[PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Amitoj Kaur Chawla]

flush_scheduled_work is scheduled for deprecation. 
Replace cancel_delayed_work and flush_scheduled_work with
cancel_delayed_work_sync instead to ensure there is no pending or
running work item.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/iio/light/tsl2563.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
index 12731d6..57b108c 100644
--- a/drivers/iio/light/tsl2563.c
+++ b/drivers/iio/light/tsl2563.c
@@ -806,8 +806,7 @@ static int tsl2563_probe(struct i2c_client *client,
 	return 0;
 
 fail:
-	cancel_delayed_work(&chip->poweroff_work);
-	flush_scheduled_work();
+	cancel_delayed_work_sync(&chip->poweroff_work);
 	return err;
 }
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Greg KH]

On Tue, Mar 15, 2016 at 08:49:51PM +0530, Amitoj Kaur Chawla wrote:
> flush_scheduled_work is scheduled for deprecation. 
> Replace cancel_delayed_work and flush_scheduled_work with
> cancel_delayed_work_sync instead to ensure there is no pending or
> running work item.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/iio/light/tsl2563.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Please only touch files in drivers/staging/ for the application process,
I can not take any patches outside of that area.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Amitoj Kaur Chawla]

On Tue, Mar 15, 2016 at 9:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>  drivers/iio/light/tsl2563.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Please only touch files in drivers/staging/ for the application process,
> I can not take any patches outside of that area.
>
> thanks,
>
> greg k-h
Actually, Tejun gave the go ahead to move on to other drivers since
the exhaustion of opportunities in staging drivers hence the patches
in drivers/net/ and drivers/iio/.

Amitoj

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Greg KH]

On Tue, Mar 15, 2016 at 10:09:58PM +0530, Amitoj Kaur Chawla wrote:
> On Tue, Mar 15, 2016 at 9:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>  drivers/iio/light/tsl2563.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Please only touch files in drivers/staging/ for the application process,
> > I can not take any patches outside of that area.
> >
> > thanks,
> >
> > greg k-h
> Actually, Tejun gave the go ahead to move on to other drivers since
> the exhaustion of opportunities in staging drivers hence the patches
> in drivers/net/ and drivers/iio/.

Ok, but note, I can't do anything with them, so you need to be
responsible for getting them to the correct mailing lists and
maintainers after Tejun acks them.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Amitoj Kaur Chawla]

On Tue, Mar 15, 2016 at 10:21 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> Ok, but note, I can't do anything with them, so you need to be
> responsible for getting them to the correct mailing lists and
> maintainers after Tejun acks them.
>
> thanks,
>
> greg k-h

Understood, thanks for the heads up.

Amitoj

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Tejun Heo]

Hello, Greg.

On Tue, Mar 15, 2016 at 09:51:32AM -0700, Greg KH wrote:
> > Actually, Tejun gave the go ahead to move on to other drivers since
> > the exhaustion of opportunities in staging drivers hence the patches
> > in drivers/net/ and drivers/iio/.
> 
> Ok, but note, I can't do anything with them, so you need to be
> responsible for getting them to the correct mailing lists and
> maintainers after Tejun acks them.

Yeah, the simple conversions under drivers/staging are all done now
and there are plenty of fairly mechanical conversions outside.  I'll
help push the patches through.

Thanks.

-- 
tejun

Re: [Outreachy kernel] [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

[Tejun Heo]

Hello, Amiotj.

On Tue, Mar 15, 2016 at 08:49:51PM +0530, Amitoj Kaur Chawla wrote:
> flush_scheduled_work is scheduled for deprecation. 
> Replace cancel_delayed_work and flush_scheduled_work with
> cancel_delayed_work_sync instead to ensure there is no pending or
> running work item.

It'd be nice to note that there are no further dependencies flushed by
flush_scheduled_work() - ie. verify and note that there are no other
instances of schedule_work() usages by the driver or if there are they
are drained properly other ways.

> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

 Acked-by: Tejun Heo <tj@kernel.org>

Can you please update the description accoringly, add the ack and
repost with the driver maintainers cc'd?

Thanks!

-- 
tejun