* [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source
@ 2016-11-21 0:26 fgao
2016-11-21 0:52 ` Feng Gao
2016-11-21 16:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: fgao @ 2016-11-21 0:26 UTC (permalink / raw)
To: davem, kaber, netdev, gfree.wind
From: Gao Feng <gfree.wind@gmail.com>
The function macvlan_forward_source_one has already checked the flag
IFF_UP, so needn't check it outside in macvlan_forward_source too.
Signed-off-by: Gao Feng <gfree.wind@gmail.com>
---
v2: Remove the IFF_UP check in macvlan_forward_source instead of macvlan_forward_source_one
v1: Initial patch
drivers/net/macvlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 13b7e0b..7ddfd2c 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -400,8 +400,7 @@ static void macvlan_forward_source(struct sk_buff *skb,
hlist_for_each_entry_rcu(entry, h, hlist) {
if (ether_addr_equal_64bits(entry->addr, addr))
- if (entry->vlan->dev->flags & IFF_UP)
- macvlan_forward_source_one(skb, entry->vlan);
+ macvlan_forward_source_one(skb, entry->vlan);
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source
2016-11-21 0:26 [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source fgao
@ 2016-11-21 0:52 ` Feng Gao
2016-11-21 16:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Feng Gao @ 2016-11-21 0:52 UTC (permalink / raw)
To: David S. Miller, Patrick McHardy,
Linux Kernel Network Developers, Feng Gao
On Mon, Nov 21, 2016 at 8:26 AM, <fgao@ikuai8.com> wrote:
> From: Gao Feng <gfree.wind@gmail.com>
>
> The function macvlan_forward_source_one has already checked the flag
> IFF_UP, so needn't check it outside in macvlan_forward_source too.
>
> Signed-off-by: Gao Feng <gfree.wind@gmail.com>
> ---
> v2: Remove the IFF_UP check in macvlan_forward_source instead of macvlan_forward_source_one
> v1: Initial patch
>
> drivers/net/macvlan.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index 13b7e0b..7ddfd2c 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -400,8 +400,7 @@ static void macvlan_forward_source(struct sk_buff *skb,
>
> hlist_for_each_entry_rcu(entry, h, hlist) {
> if (ether_addr_equal_64bits(entry->addr, addr))
> - if (entry->vlan->dev->flags & IFF_UP)
> - macvlan_forward_source_one(skb, entry->vlan);
> + macvlan_forward_source_one(skb, entry->vlan);
> }
> }
>
> --
> 1.9.1
>
>
Sorry, I forget add the "v2" in the title.
Regards
Feng
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source
2016-11-21 0:26 [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source fgao
2016-11-21 0:52 ` Feng Gao
@ 2016-11-21 16:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-21 16:59 UTC (permalink / raw)
To: fgao; +Cc: kaber, netdev, gfree.wind
From: fgao@ikuai8.com
Date: Mon, 21 Nov 2016 08:26:38 +0800
> From: Gao Feng <gfree.wind@gmail.com>
>
> The function macvlan_forward_source_one has already checked the flag
> IFF_UP, so needn't check it outside in macvlan_forward_source too.
>
> Signed-off-by: Gao Feng <gfree.wind@gmail.com>
> ---
> v2: Remove the IFF_UP check in macvlan_forward_source instead of macvlan_forward_source_one
> v1: Initial patch
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-21 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-21 0:26 [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source fgao
2016-11-21 0:52 ` Feng Gao
2016-11-21 16:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.