From: Feng Gao <gfree.wind@gmail.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc, "David S. Miller" <davem@davemloft.net>, b.a.t.m.a.n@lists.open-mesh.org, Linux Kernel Network Developers <netdev@vger.kernel.org> Subject: Re: [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully Date: Mon, 21 Nov 2016 19:01:12 +0800 [thread overview] Message-ID: <CA+6hz4qFrZpC7CYRq1OFJP8y_Zj1LG3qaFZGJNW8rNf=E__4bA@mail.gmail.com> (raw) In-Reply-To: <850ff61e-8f94-9316-ed1f-c7d3e8faf95b@cogentembedded.com> Hi Sergei, On Mon, Nov 21, 2016 at 6:44 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 11/21/2016 3:39 AM, fgao@ikuai8.com wrote: > >> From: Gao Feng <fgao@ikuai8.com> >> >> The tc could return NET_XMIT_CN as one congestion notification, but >> it does not mean the packe is lost. Other modules like ipvlan, > > > Packet. Thanks, it was typo. > >> macvlan, and others treat NET_XMIT_CN as success too. >> >> So batman-adv should add the NET_XMIT_CN check. >> >> Signed-off-by: Gao Feng <fgao@ikuai8.com> > > > [...] > >> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c >> index 7e8dc64..8edd324 100644 >> --- a/net/batman-adv/routing.c >> +++ b/net/batman-adv/routing.c >> @@ -706,7 +706,7 @@ static int batadv_route_unicast_packet(struct sk_buff >> *skb, >> goto out; >> >> /* translate transmit result into receive result */ >> - if (res == NET_XMIT_SUCCESS) { >> + if (res == NET_XMIT_SUCCESS || ret == NET_XMIT_CN) { Thanks again. I didn't find it during myself's review and compile process. > > > Not 'res == NET_XMIT_CN'? > >> /* skb was transmitted and consumed */ >> batadv_inc_counter(bat_priv, BATADV_CNT_FORWARD); >> batadv_add_counter(bat_priv, BATADV_CNT_FORWARD_BYTES, > > [...] > > MBR, Sergei > I have sent the v2 patch which corrects these two typos. Best Regards Feng
WARNING: multiple messages have this Message-ID (diff)
From: Feng Gao <gfree.wind@gmail.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: mareklindner@neomailbox.ch, Linux Kernel Network Developers <netdev@vger.kernel.org>, b.a.t.m.a.n@lists.open-mesh.org, a@unstable.cc, "David S. Miller" <davem@davemloft.net> Subject: Re: [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully Date: Mon, 21 Nov 2016 19:01:12 +0800 [thread overview] Message-ID: <CA+6hz4qFrZpC7CYRq1OFJP8y_Zj1LG3qaFZGJNW8rNf=E__4bA@mail.gmail.com> (raw) In-Reply-To: <850ff61e-8f94-9316-ed1f-c7d3e8faf95b@cogentembedded.com> Hi Sergei, On Mon, Nov 21, 2016 at 6:44 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 11/21/2016 3:39 AM, fgao@ikuai8.com wrote: > >> From: Gao Feng <fgao@ikuai8.com> >> >> The tc could return NET_XMIT_CN as one congestion notification, but >> it does not mean the packe is lost. Other modules like ipvlan, > > > Packet. Thanks, it was typo. > >> macvlan, and others treat NET_XMIT_CN as success too. >> >> So batman-adv should add the NET_XMIT_CN check. >> >> Signed-off-by: Gao Feng <fgao@ikuai8.com> > > > [...] > >> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c >> index 7e8dc64..8edd324 100644 >> --- a/net/batman-adv/routing.c >> +++ b/net/batman-adv/routing.c >> @@ -706,7 +706,7 @@ static int batadv_route_unicast_packet(struct sk_buff >> *skb, >> goto out; >> >> /* translate transmit result into receive result */ >> - if (res == NET_XMIT_SUCCESS) { >> + if (res == NET_XMIT_SUCCESS || ret == NET_XMIT_CN) { Thanks again. I didn't find it during myself's review and compile process. > > > Not 'res == NET_XMIT_CN'? > >> /* skb was transmitted and consumed */ >> batadv_inc_counter(bat_priv, BATADV_CNT_FORWARD); >> batadv_add_counter(bat_priv, BATADV_CNT_FORWARD_BYTES, > > [...] > > MBR, Sergei > I have sent the v2 patch which corrects these two typos. Best Regards Feng
next prev parent reply other threads:[~2016-11-21 11:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-21 0:39 [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully fgao 2016-11-21 0:39 ` [B.A.T.M.A.N.] " fgao 2016-11-21 8:16 ` Sven Eckelmann 2016-11-21 8:16 ` Sven Eckelmann 2016-11-21 8:21 ` Feng Gao 2016-11-21 8:21 ` Feng Gao [not found] ` <CA+6hz4rZyacN_jg74JLg8EWkno2aJEnwJSTwRaw558uE-zAaxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-11-21 8:31 ` Sven Eckelmann 2016-11-21 8:31 ` [B.A.T.M.A.N.] " Sven Eckelmann 2016-11-21 8:47 ` Feng Gao 2016-11-21 8:47 ` [B.A.T.M.A.N.] " Feng Gao [not found] ` <1479688779-1328-1-git-send-email-fgao-KlmEoCYek3zQT0dZR+AlfA@public.gmane.org> 2016-11-21 10:44 ` Sergei Shtylyov 2016-11-21 10:44 ` [B.A.T.M.A.N.] " Sergei Shtylyov 2016-11-21 11:01 ` Feng Gao [this message] 2016-11-21 11:01 ` Feng Gao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+6hz4qFrZpC7CYRq1OFJP8y_Zj1LG3qaFZGJNW8rNf=E__4bA@mail.gmail.com' \ --to=gfree.wind@gmail.com \ --cc=a@unstable.cc \ --cc=b.a.t.m.a.n@lists.open-mesh.org \ --cc=davem@davemloft.net \ --cc=mareklindner@neomailbox.ch \ --cc=netdev@vger.kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=sw@simonwunderlich.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.