From: Mathieu Malaterre <malat@debian.org> To: Christophe LEROY <christophe.leroy@c-s.fr> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Paul Mackerras <paulus@samba.org>, Jiri Slaby <jslaby@suse.com>, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH 01/21] powerpc: Remove warning on array size when empty Date: Tue, 27 Feb 2018 08:44:01 +0100 [thread overview] Message-ID: <CA+7wUsys=J8vkEOtzd26B6MGEhfTBRzaA_myuUWNzf24rMvn+A@mail.gmail.com> (raw) In-Reply-To: <603d5335-6220-73f2-d902-b92bc74bc79e@c-s.fr> On Tue, Feb 27, 2018 at 8:33 AM, Christophe LEROY <christophe.leroy@c-s.fr> wrote: > > > Le 27/02/2018 à 08:25, Mathieu Malaterre a écrit : >> >> On Mon, Feb 26, 2018 at 3:45 PM, Andy Shevchenko >> <andy.shevchenko@gmail.com> wrote: >>> >>> On Mon, Feb 26, 2018 at 4:44 PM, Andy Shevchenko >>> <andy.shevchenko@gmail.com> wrote: >>>> >>>> On Sun, Feb 25, 2018 at 7:22 PM, Mathieu Malaterre <malat@debian.org> >>>> wrote: >>> >>> >>>>> static void __init check_cpu_feature_properties(unsigned long node) >>>>> { >>>>> - unsigned long i; >>>>> struct feature_property *fp = feature_properties; >>>>> const __be32 *prop; >>>>> >>>> >>>> Much simpler is just add >>>> >>>> if (ARRAY_SIZE() == 0) >>>> return; >>>> >>>>> - for (i = 0; i < ARRAY_SIZE(feature_properties); ++i, ++fp) { >>>>> + for (; fp != feature_properties + >>>>> ARRAY_SIZE(feature_properties); ++fp) { >>> >>> >>> ...or convert to while(), which will be more readable. >> >> >> So you'd prefer something like: >> >> while (fp < feature_properties + ARRAY_SIZE(feature_properties)) { >> ... >> ++fp; >> } >> >> right ? >> > > > Why not do as suggested by Segher, ie just replace < by != in the original > form ? I can do that. > Or add in front: > if (!ARRAY_SIZE(feature_properties)) > return; (not tested) I believe the compiler still go over the for() loop and will complain about the original unsigned comparison. > Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Malaterre <malat@debian.org> To: Christophe LEROY <christophe.leroy@c-s.fr> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Paul Mackerras <paulus@samba.org>, Jiri Slaby <jslaby@suse.com>, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH 01/21] powerpc: Remove warning on array size when empty Date: Tue, 27 Feb 2018 08:44:01 +0100 [thread overview] Message-ID: <CA+7wUsys=J8vkEOtzd26B6MGEhfTBRzaA_myuUWNzf24rMvn+A@mail.gmail.com> (raw) In-Reply-To: <603d5335-6220-73f2-d902-b92bc74bc79e@c-s.fr> On Tue, Feb 27, 2018 at 8:33 AM, Christophe LEROY <christophe.leroy@c-s.fr> wrote: > > > Le 27/02/2018 =C3=A0 08:25, Mathieu Malaterre a =C3=A9crit : >> >> On Mon, Feb 26, 2018 at 3:45 PM, Andy Shevchenko >> <andy.shevchenko@gmail.com> wrote: >>> >>> On Mon, Feb 26, 2018 at 4:44 PM, Andy Shevchenko >>> <andy.shevchenko@gmail.com> wrote: >>>> >>>> On Sun, Feb 25, 2018 at 7:22 PM, Mathieu Malaterre <malat@debian.org> >>>> wrote: >>> >>> >>>>> static void __init check_cpu_feature_properties(unsigned long node) >>>>> { >>>>> - unsigned long i; >>>>> struct feature_property *fp =3D feature_properties; >>>>> const __be32 *prop; >>>>> >>>> >>>> Much simpler is just add >>>> >>>> if (ARRAY_SIZE() =3D=3D 0) >>>> return; >>>> >>>>> - for (i =3D 0; i < ARRAY_SIZE(feature_properties); ++i, ++fp) = { >>>>> + for (; fp !=3D feature_properties + >>>>> ARRAY_SIZE(feature_properties); ++fp) { >>> >>> >>> ...or convert to while(), which will be more readable. >> >> >> So you'd prefer something like: >> >> while (fp < feature_properties + ARRAY_SIZE(feature_properties)) { >> ... >> ++fp; >> } >> >> right ? >> > > > Why not do as suggested by Segher, ie just replace < by !=3D in the origi= nal > form ? I can do that. > Or add in front: > if (!ARRAY_SIZE(feature_properties)) > return; (not tested) I believe the compiler still go over the for() loop and will complain about the original unsigned comparison. > Christophe
next prev parent reply other threads:[~2018-02-27 7:44 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-25 17:22 [PATCH 00/21] powerpc/gamecube: make W=1 compilation errors free Mathieu Malaterre 2018-02-25 17:22 ` [PATCH 01/21] powerpc: Remove warning on array size when empty Mathieu Malaterre 2018-02-25 18:53 ` Segher Boessenkool 2018-02-26 14:44 ` Andy Shevchenko 2018-02-26 14:44 ` Andy Shevchenko 2018-02-26 14:45 ` Andy Shevchenko 2018-02-27 7:25 ` Mathieu Malaterre 2018-02-27 7:33 ` Christophe LEROY 2018-02-27 7:44 ` Mathieu Malaterre [this message] 2018-02-27 7:44 ` Mathieu Malaterre 2018-02-27 15:52 ` Andy Shevchenko 2018-02-27 17:25 ` Mathieu Malaterre 2018-02-27 17:25 ` Mathieu Malaterre 2018-02-27 20:42 ` Segher Boessenkool 2018-02-28 15:50 ` Andy Shevchenko 2018-03-01 2:55 ` Michael Ellerman 2018-03-01 2:55 ` Michael Ellerman 2018-03-01 7:01 ` Mathieu Malaterre 2018-03-01 7:01 ` Mathieu Malaterre 2018-03-01 9:33 ` Michael Ellerman 2018-03-01 9:33 ` Michael Ellerman 2018-03-02 19:49 ` [PATCH v2 " Mathieu Malaterre 2018-03-14 9:28 ` [v2,01/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 02/21] powerpc: Move the inline keyword at the beginning of function declaration Mathieu Malaterre 2018-03-14 9:27 ` [02/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 03/21] powerpc: Mark the variable earlycon_acpi_spcr_enable maybe_unused Mathieu Malaterre 2018-03-04 10:54 ` Michael Ellerman 2018-03-04 10:54 ` Michael Ellerman 2018-03-10 18:08 ` Mathieu Malaterre 2018-03-10 18:08 ` Mathieu Malaterre 2018-02-25 17:22 ` [PATCH 04/21] powerpc: Mark both tmp variables as unused Mathieu Malaterre 2018-03-14 9:27 ` [04/21] " Michael Ellerman 2018-03-14 10:38 ` [PATCH 04/21] " Christophe LEROY 2018-03-16 14:08 ` Michael Ellerman 2018-03-16 14:08 ` Michael Ellerman 2018-02-25 17:22 ` [PATCH 05/21] powerpc: Avoid comparison of unsigned long >= 0 in pfn_valid Mathieu Malaterre 2018-02-26 6:32 ` Christophe LEROY 2018-02-26 7:49 ` Mathieu Malaterre 2018-02-26 7:49 ` Mathieu Malaterre 2018-02-26 8:46 ` Segher Boessenkool 2018-03-02 19:54 ` Mathieu Malaterre 2018-03-02 19:54 ` Mathieu Malaterre 2018-03-03 7:45 ` christophe leroy 2018-03-04 10:55 ` Michael Ellerman 2018-03-04 10:55 ` Michael Ellerman 2018-03-04 19:46 ` christophe leroy 2018-03-07 20:34 ` [PATCH v2 " Mathieu Malaterre 2018-03-14 9:28 ` [v2, " Michael Ellerman 2018-02-25 17:22 ` [PATCH 06/21] powerpc: Avoid comparison of unsigned long >= 0 in __access_ok Mathieu Malaterre 2018-02-26 6:34 ` Christophe LEROY 2018-02-26 6:50 ` Christophe LEROY 2018-02-26 7:44 ` Mathieu Malaterre 2018-02-26 7:44 ` Mathieu Malaterre 2018-02-26 17:50 ` Mathieu Malaterre 2018-02-26 17:50 ` Mathieu Malaterre 2018-02-26 20:00 ` christophe leroy 2018-02-26 22:17 ` Segher Boessenkool 2018-03-02 19:50 ` [PATCH v2 " Mathieu Malaterre 2018-03-03 7:44 ` christophe leroy 2018-03-14 9:28 ` [v2, " Michael Ellerman 2018-02-25 17:22 ` [PATCH 07/21] powerpc: Make functions flipper_pic_init & ug_udbg_putc static Mathieu Malaterre 2018-03-14 9:27 ` [07/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 08/21] powerpc: Make function __giveup_fpu static Mathieu Malaterre 2018-03-14 9:28 ` [08/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 09/21] powerpc: Make function save_all static Mathieu Malaterre 2018-02-25 17:22 ` [PATCH 10/21] powerpc: Add missing prototype for slb_miss_bad_addr Mathieu Malaterre 2018-03-14 9:27 ` [10/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 11/21] powerpc: Add missing prototype for hdec_interrupt Mathieu Malaterre 2018-03-14 9:27 ` [11/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 12/21] powerpc: Add missing prototype for time_init Mathieu Malaterre 2018-03-14 9:27 ` [12/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 13/21] powerpc: Add missing prototype for arch_dup_task_struct Mathieu Malaterre 2018-03-14 9:27 ` [13/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 14/21] powerpc: Add missing prototype for arch_irq_work_raise Mathieu Malaterre 2018-03-14 9:27 ` [14/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 15/21] powerpc: Add missing prototype for MMU_setup Mathieu Malaterre 2018-03-04 10:54 ` Michael Ellerman 2018-03-04 10:54 ` Michael Ellerman 2018-03-07 20:32 ` [PATCH v2 15/21] powerpc: Make function MMU_setup static Mathieu Malaterre 2018-03-14 9:28 ` [v2,15/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 16/21] powerpc: Add missing prototype for init_IRQ Mathieu Malaterre 2018-03-14 9:28 ` [16/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 17/21] powerpc: Add missing prototype for sys_debug_setcontext Mathieu Malaterre 2018-03-04 10:54 ` Michael Ellerman 2018-03-04 10:54 ` Michael Ellerman 2018-03-07 20:37 ` Mathieu Malaterre 2018-03-07 20:37 ` Mathieu Malaterre 2018-03-08 10:36 ` Michael Ellerman 2018-03-08 10:36 ` Michael Ellerman 2018-03-26 18:56 ` Mathieu Malaterre 2018-03-26 18:56 ` Mathieu Malaterre 2018-03-27 8:50 ` Michael Ellerman 2018-03-27 8:50 ` Michael Ellerman 2018-03-14 9:28 ` [17/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 18/21] powerpc: Add missing prototypes for sys_sigreturn & sys_rt_sigreturn Mathieu Malaterre 2018-03-14 9:28 ` [18/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 19/21] powerpc: Add missing prototypes for hw_breakpoint_handler & arch_unregister_hw_breakpoint Mathieu Malaterre 2018-03-14 9:28 ` [19/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 20/21] powerpc: Add missing prototypes for ppc_select & ppc_fadvise64_64 Mathieu Malaterre 2018-03-14 9:28 ` [20/21] " Michael Ellerman 2018-02-25 17:22 ` [PATCH 21/21] powerpc: Add missing prototypes in setup_32.c Mathieu Malaterre 2018-03-08 11:44 ` Michael Ellerman 2018-03-14 9:28 ` [21/21] " Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+7wUsys=J8vkEOtzd26B6MGEhfTBRzaA_myuUWNzf24rMvn+A@mail.gmail.com' \ --to=malat@debian.org \ --cc=andy.shevchenko@gmail.com \ --cc=christophe.leroy@c-s.fr \ --cc=jslaby@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.