pull-request mwifiex-firmware 2017-10-30

pull-request mwifiex-firmware 2017-10-30

[Ganapathi Bhat]

The following changes since commit e0494e95192ac5329989f4d128cf95c417d618cc:

  linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-08-01 23:55:30 +0530)

are available in the git repository at:

  git://git.marvell.com/mwifiex-firmware.git

for you to fetch changes up to c5bed1294f6cf6bf6cbef612204f96361a3c2539:

  linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-10-30 19:23:05 +0530)

----------------------------------------------------------------
Ganapathi Bhat (1):
      linux-firmware: update Marvell PCIe-USB8997 firmware image

WHENCE                        |   2 +-
mrvl/pcieusb8997_combo_v4.bin | Bin 620800 -> 622532 bytes
2 files changed, 1 insertion(+), 1 deletion(-)

Re: pull-request mwifiex-firmware 2017-10-30

[Brian Norris]

On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:
> The following changes since commit e0494e95192ac5329989f4d128cf95c417d618cc:
> 
>   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-08-01 23:55:30 +0530)
> 
> are available in the git repository at:
> 
>   git://git.marvell.com/mwifiex-firmware.git
> 
> for you to fetch changes up to c5bed1294f6cf6bf6cbef612204f96361a3c2539:
> 
>   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-10-30 19:23:05 +0530)

Hooray, your git server is working again! And FWIW:

Tested-by: Brian Norris <briannorris@chromium.org>

But quoting your patch...

> --- a/WHENCE
> +++ b/WHENCE
> @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
>  Version: 16.68.1.p70
>  
>  File: mrvl/pcieusb8997_combo_v4.bin
> -Version: 16.68.1.p133
> +Version: 16.68.1.p40

This says .p40, whereas the commit message (and the version tag within the
firmware) says p140. I think you're missing a "1".

>  
>  File: mrvl/pcie8997_wlan_v4.bin
>  Version: 16.68.1.p97


Brian

> 
> ----------------------------------------------------------------
> Ganapathi Bhat (1):
>       linux-firmware: update Marvell PCIe-USB8997 firmware image
> 
> WHENCE                        |   2 +-
> mrvl/pcieusb8997_combo_v4.bin | Bin 620800 -> 622532 bytes
> 2 files changed, 1 insertion(+), 1 deletion(-)

RE: [EXT] Re: pull-request mwifiex-firmware 2017-10-30

[Ganapathi Bhat]

Hi Brian,

>
> ----------------------------------------------------------------------
> On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:
> > The following changes since commit
> e0494e95192ac5329989f4d128cf95c417d618cc:
> >
> >   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-08-01
> 23:55:30 +0530)
> >
> > are available in the git repository at:
> >
> >   git://git.marvell.com/mwifiex-firmware.git
> >
> > for you to fetch changes up to
> c5bed1294f6cf6bf6cbef612204f96361a3c2539:
> >
> >   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-10-30
> 19:23:05 +0530)
>
> Hooray, your git server is working again! And FWIW:
>
> Tested-by: Brian Norris <briannorris@chromium.org>
>
> But quoting your patch...
>
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
> >  Version: 16.68.1.p70
> >
> >  File: mrvl/pcieusb8997_combo_v4.bin
> > -Version: 16.68.1.p133
> > +Version: 16.68.1.p40
>
> This says .p40, whereas the commit message (and the version tag within the
> firmware) says p140. I think you're missing a "1".
 I did miss this.  Will it make sense to trigger another pull request with just the version change?
>
> >
> >  File: mrvl/pcie8997_wlan_v4.bin
> >  Version: 16.68.1.p97
>
>
> Brian
>
> >
> > ----------------------------------------------------------------
> > Ganapathi Bhat (1):
> >       linux-firmware: update Marvell PCIe-USB8997 firmware image
> >
> > WHENCE                        |   2 +-
> > mrvl/pcieusb8997_combo_v4.bin | Bin 620800 -> 622532 bytes
> > 2 files changed, 1 insertion(+), 1 deletion(-)

Regards,
Ganapathi

Re: [EXT] Re: pull-request mwifiex-firmware 2017-10-30

[Brian Norris]

On Mon, Oct 30, 2017 at 06:47:58PM +0000, Ganapathi Bhat wrote:
> > ----------------------------------------------------------------------
> > On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:

> > > --- a/WHENCE
> > > +++ b/WHENCE
> > > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
> > >  Version: 16.68.1.p70
> > >
> > >  File: mrvl/pcieusb8997_combo_v4.bin
> > > -Version: 16.68.1.p133
> > > +Version: 16.68.1.p40
> >
> > This says .p40, whereas the commit message (and the version tag within the
> > firmware) says p140. I think you're missing a "1".
>  I did miss this.  Will it make sense to trigger another pull request with just the version change?

Sure, why not? Email is cheap, and so is git. Either rewrite the commit
or add another on top to fix it...

RE: [EXT] Re: pull-request mwifiex-firmware 2017-10-30

[Ganapathi Bhat]

Hi Brian,

> On Mon, Oct 30, 2017 at 06:47:58PM +0000, Ganapathi Bhat wrote:
> > > --------------------------------------------------------------------
> > > -- On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:
>
> > > > --- a/WHENCE
> > > > +++ b/WHENCE
> > > > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
> > > >  Version: 16.68.1.p70
> > > >
> > > >  File: mrvl/pcieusb8997_combo_v4.bin
> > > > -Version: 16.68.1.p133
> > > > +Version: 16.68.1.p40
> > >
> > > This says .p40, whereas the commit message (and the version tag
> > > within the
> > > firmware) says p140. I think you're missing a "1".
> >  I did miss this.  Will it make sense to trigger another pull request with just
> the version change?
>
> Sure, why not? Email is cheap, and so is git. Either rewrite the commit or add
> another on top to fix it...
Ok, prepared the follow up patch.  Let me also know if we can send a merge request while previous one is pending?
If that is not the case I will send it as soon as the current request is merged.

Thanks,
Ganapathi

Re: [EXT] Re: pull-request mwifiex-firmware 2017-10-30

[Brian Norris]

On Mon, Oct 30, 2017 at 12:02 PM, Ganapathi Bhat <gbhat@marvell.com> wrote:
> Ok, prepared the follow up patch.  Let me also know if we can send a merge request while previous one is pending?
> If that is not the case I will send it as soon as the current request is merged.

That's not up to me. I'm sure the maintainer will let you know if they
need something, eventually. It's so trivial, I don't see why they
couldn't just pull it in without any more fuss.

RE: [EXT] Re: pull-request mwifiex-firmware 2017-10-30

[Ganapathi Bhat]

SGkgQnJpYW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQnJpYW4g
Tm9ycmlzIFttYWlsdG86YnJpYW5ub3JyaXNAY2hyb21pdW0ub3JnXQ0KPiBTZW50OiBUdWVzZGF5
LCBPY3RvYmVyIDMxLCAyMDE3IDE6MTggQU0NCj4gVG86IEdhbmFwYXRoaSBCaGF0DQo+IENjOiBs
aW51eC1maXJtd2FyZUBrZXJuZWwub3JnOyBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmc7
IEphbWVzIENhbzsNCj4gQ2F0aHkgTHVvOyBNYW5nZXNoIE1hbHVzYXJlOyBYaW5taW5nIEh1OyBa
aGl5dWFuIFlhbmc7IEthcnRoaWsNCj4gRG9kZGF5ZW5uZWdlcmUgQW5hbnRoYXBhZG1hbmFiaGEN
Cj4gU3ViamVjdDogUmU6IFtFWFRdIFJlOiBwdWxsLXJlcXVlc3QgbXdpZmlleC1maXJtd2FyZSAy
MDE3LTEwLTMwDQo+DQo+IE9uIE1vbiwgT2N0IDMwLCAyMDE3IGF0IDEyOjAyIFBNLCBHYW5hcGF0
aGkgQmhhdCA8Z2JoYXRAbWFydmVsbC5jb20+DQo+IHdyb3RlOg0KPiA+IE9rLCBwcmVwYXJlZCB0
aGUgZm9sbG93IHVwIHBhdGNoLiAgTGV0IG1lIGFsc28ga25vdyBpZiB3ZSBjYW4gc2VuZCBhDQo+
IG1lcmdlIHJlcXVlc3Qgd2hpbGUgcHJldmlvdXMgb25lIGlzIHBlbmRpbmc/DQo+ID4gSWYgdGhh
dCBpcyBub3QgdGhlIGNhc2UgSSB3aWxsIHNlbmQgaXQgYXMgc29vbiBhcyB0aGUgY3VycmVudCBy
ZXF1ZXN0IGlzIG1lcmdlZC4NCj4NCj4gVGhhdCdzIG5vdCB1cCB0byBtZS4gSSdtIHN1cmUgdGhl
IG1haW50YWluZXIgd2lsbCBsZXQgeW91IGtub3cgaWYgdGhleSBuZWVkDQo+IHNvbWV0aGluZywg
ZXZlbnR1YWxseS4gSXQncyBzbyB0cml2aWFsLCBJIGRvbid0IHNlZSB3aHkgdGhleSBjb3VsZG4n
dCBqdXN0IHB1bGwgaXQNCj4gaW4gd2l0aG91dCBhbnkgbW9yZSBmdXNzLg0KDQpJIGhhdmUgc2Vu
dCBhbm90aGVyIHB1bGwgcmVxdWVzdCwgd2hpY2ggaGFzIGNvcnJlY3QgdmVyc2lvbiBpbmZvLg0K
DQpJIGhlcmVieSBpbmZvcm0gbWFpbnRhaW5lcnMgdG8gaWdub3JlIHRoaXMgcGFydGljdWxhciBy
ZXF1ZXN0IGFuZCBjb25zaWRlciB0aGUgbGF0ZXN0IHB1bGwgcmVxdWVzdC4NCg0KVGhhbmtzLA0K
R2FuYXBhdGhpDQo=