* [PATCH] mwifiex: don't print error message on coex event
@ 2019-01-28 15:43 Stefan Agner
2019-01-29 18:52 ` Brian Norris
2019-02-08 15:28 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Agner @ 2019-01-28 15:43 UTC (permalink / raw)
To: amitkarwar, nishants, gbhat, huxinming820
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Stefan Agner
The BT coex event is not an error condition. Don't print an error
message in this case. The same even in sta_event.c prints a
message using the debug level already.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
index e86217a6b9ca..ca759d9c0253 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
@@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
mwifiex_11h_handle_radar_detected(priv, adapter->event_skb);
break;
case EVENT_BT_COEX_WLAN_PARA_CHANGE:
- dev_err(adapter->dev, "EVENT: BT coex wlan param update\n");
+ mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n");
mwifiex_bt_coex_wlan_param_update_event(priv,
adapter->event_skb);
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mwifiex: don't print error message on coex event
2019-01-28 15:43 [PATCH] mwifiex: don't print error message on coex event Stefan Agner
@ 2019-01-29 18:52 ` Brian Norris
2019-02-08 15:28 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2019-01-29 18:52 UTC (permalink / raw)
To: Stefan Agner
Cc: amit karwar, Nishant Sarmukadam, Ganapathi Bhat, huxinming820,
Kalle Valo, davem, linux-wireless, netdev, Linux Kernel
On Mon, Jan 28, 2019 at 7:43 AM Stefan Agner <stefan@agner.ch> wrote:
>
> The BT coex event is not an error condition. Don't print an error
> message in this case. The same even in sta_event.c prints a
> message using the debug level already.
For some reason, that one (and a handful of others) uses dev_dbg()
instead of mwifiex_dbg() with an appropriate mask (e.g., EVENT). But
mwifiex_dbg() seems preferable for consistency.
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> index e86217a6b9ca..ca759d9c0253 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> @@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
> mwifiex_11h_handle_radar_detected(priv, adapter->event_skb);
> break;
> case EVENT_BT_COEX_WLAN_PARA_CHANGE:
> - dev_err(adapter->dev, "EVENT: BT coex wlan param update\n");
> + mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n");
> mwifiex_bt_coex_wlan_param_update_event(priv,
> adapter->event_skb);
> break;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mwifiex: don't print error message on coex event
2019-01-28 15:43 [PATCH] mwifiex: don't print error message on coex event Stefan Agner
2019-01-29 18:52 ` Brian Norris
@ 2019-02-08 15:28 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-02-08 15:28 UTC (permalink / raw)
To: Stefan Agner
Cc: amitkarwar, nishants, gbhat, huxinming820, davem, linux-wireless,
netdev, linux-kernel, Stefan Agner
Stefan Agner <stefan@agner.ch> wrote:
> The BT coex event is not an error condition. Don't print an error
> message in this case. The same even in sta_event.c prints a
> message using the debug level already.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
5208fea64e4f mwifiex: don't print error message on coex event
--
https://patchwork.kernel.org/patch/10783935/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 15:43 [PATCH] mwifiex: don't print error message on coex event Stefan Agner
2019-01-29 18:52 ` Brian Norris
2019-02-08 15:28 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.