All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix build breakage in omap-usb-host.c
@ 2012-04-22  8:48 Russ Dill
  2012-04-22  8:50 ` Russ Dill
  2012-05-01  9:56 ` Samuel Ortiz
  0 siblings, 2 replies; 6+ messages in thread
From: Russ Dill @ 2012-04-22  8:48 UTC (permalink / raw)
  To: linux-omap; +Cc: Keshava Munegowda, Samuel Ortiz, Russ Dill

'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
which is required by omap-usb-host.c. Fix the build breakage by including
it directly.

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
---
 drivers/mfd/omap-usb-host.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c8aae66..7e96bb2 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -25,6 +25,7 @@
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
+#include <plat/cpu.h>
 #include <plat/usb.h>
 #include <linux/pm_runtime.h>
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build breakage in omap-usb-host.c
  2012-04-22  8:48 [PATCH] Fix build breakage in omap-usb-host.c Russ Dill
@ 2012-04-22  8:50 ` Russ Dill
  2012-04-23  6:25   ` Munegowda, Keshava
  2012-05-01  9:56 ` Samuel Ortiz
  1 sibling, 1 reply; 6+ messages in thread
From: Russ Dill @ 2012-04-22  8:50 UTC (permalink / raw)
  To: linux-omap; +Cc: Keshava Munegowda, Samuel Ortiz, Russ Dill

On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill <Russ.Dill@ti.com> wrote:
> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
> linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
> which is required by omap-usb-host.c. Fix the build breakage by including
> it directly.

(Sorry, I should add some detail, this is a build breakage in linux-next)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build breakage in omap-usb-host.c
  2012-04-22  8:50 ` Russ Dill
@ 2012-04-23  6:25   ` Munegowda, Keshava
  2012-04-23 18:49     ` Anatolij Gustschin
       [not found]     ` <87ty0452ur.fsf@ti.com>
  0 siblings, 2 replies; 6+ messages in thread
From: Munegowda, Keshava @ 2012-04-23  6:25 UTC (permalink / raw)
  To: Russ Dill, Anatolij Gustschin; +Cc: linux-omap, Samuel Ortiz

On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill <Russ.Dill@ti.com> wrote:
> On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill <Russ.Dill@ti.com> wrote:
>> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
>> linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
>> which is required by omap-usb-host.c. Fix the build breakage by including
>> it directly.
>
> (Sorry, I should add some detail, this is a build breakage in linux-next)

Russ Dill and Anatolij Gustschin

Both patches fixes the same issue; But here , I am seeing Russ Dill
has sent earlier (in my mailbox it shows 21 hours ago)
Here my ack by:

Acked-by:  Keshava Munegowda <keshava_mgowda@ti.com>

Regards
Keshava

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build breakage in omap-usb-host.c
  2012-04-23  6:25   ` Munegowda, Keshava
@ 2012-04-23 18:49     ` Anatolij Gustschin
       [not found]     ` <87ty0452ur.fsf@ti.com>
  1 sibling, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2012-04-23 18:49 UTC (permalink / raw)
  To: Munegowda, Keshava; +Cc: Russ Dill, linux-omap, Samuel Ortiz

On Mon, 23 Apr 2012 11:55:49 +0530
"Munegowda, Keshava" <keshava_mgowda@ti.com> wrote:

> On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill <Russ.Dill@ti.com> wrote:
> > On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill <Russ.Dill@ti.com> wrote:
> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
> >> linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
> >> which is required by omap-usb-host.c. Fix the build breakage by including
> >> it directly.
> >
> > (Sorry, I should add some detail, this is a build breakage in linux-next)
> 
> Russ Dill and Anatolij Gustschin
> 
> Both patches fixes the same issue; But here , I am seeing Russ Dill
> has sent earlier (in my mailbox it shows 21 hours ago)

Great! I'm not on linux-omap list and didn't see this patch unfortunately.
Sure, the patch from Russ Dill should be applied.

Thanks,
Anatolij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build breakage in omap-usb-host.c
       [not found]     ` <87ty0452ur.fsf@ti.com>
@ 2012-04-30  8:22       ` Samuel Ortiz
  0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2012-04-30  8:22 UTC (permalink / raw)
  To: Kevin Hilman
  Cc: Munegowda, Keshava, Russ Dill, Anatolij Gustschin, linux-omap

Hi Kevin,

On Fri, Apr 27, 2012 at 01:36:28PM -0700, Kevin Hilman wrote:
> Samuel,
> 
> "Munegowda, Keshava" <keshava_mgowda@ti.com> writes:
> 
> > On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill <Russ.Dill@ti.com> wrote:
> >> On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill <Russ.Dill@ti.com> wrote:
> >>> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
> >>> linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
> >>> which is required by omap-usb-host.c. Fix the build breakage by including
> >>> it directly.
> >>
> >> (Sorry, I should add some detail, this is a build breakage in linux-next)
> >
> > Russ Dill and Anatolij Gustschin
> >
> > Both patches fixes the same issue; But here , I am seeing Russ Dill
> > has sent earlier (in my mailbox it shows 21 hours ago)
> > Here my ack by:
> >
> > Acked-by:  Keshava Munegowda <keshava_mgowda@ti.com>
> 
> Acked-by: Kevin Hilman <khilman@ti.com>
> 
> Can you pick this up for v3.4-rc5?  The breakage was introduced in
> v3.4-rc4.
I will, yes.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build breakage in omap-usb-host.c
  2012-04-22  8:48 [PATCH] Fix build breakage in omap-usb-host.c Russ Dill
  2012-04-22  8:50 ` Russ Dill
@ 2012-05-01  9:56 ` Samuel Ortiz
  1 sibling, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2012-05-01  9:56 UTC (permalink / raw)
  To: Russ Dill; +Cc: linux-omap, Keshava Munegowda

Hi Russ,

On Sun, Apr 22, 2012 at 01:48:18AM -0700, Russ Dill wrote:
> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
> linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
> which is required by omap-usb-host.c. Fix the build breakage by including
> it directly.
> 
> Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Patch applied, thanks.
I'm planning to send an MFD pull request including this fix to Linus,
in time for rc6.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-01  9:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-22  8:48 [PATCH] Fix build breakage in omap-usb-host.c Russ Dill
2012-04-22  8:50 ` Russ Dill
2012-04-23  6:25   ` Munegowda, Keshava
2012-04-23 18:49     ` Anatolij Gustschin
     [not found]     ` <87ty0452ur.fsf@ti.com>
2012-04-30  8:22       ` Samuel Ortiz
2012-05-01  9:56 ` Samuel Ortiz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.