* [PATCH 01/17] drm/nouveau/core: add missing header dependencies
@ 2016-10-22 9:41 Baoyou Xie
2016-10-22 9:41 ` [PATCH 02/17] drm/nouveau/bios: mark symbols static where possible Baoyou Xie
` (16 more replies)
0 siblings, 17 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
index 34ecd4a..058ff46 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
@@ -20,6 +20,7 @@
* DEALINGS IN THE SOFTWARE.
*/
#include <core/device.h>
+#include <core/firmware.h>
/**
* nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 02/17] drm/nouveau/bios: mark symbols static where possible
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
@ 2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
` (15 subsequent siblings)
16 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c:29:1: warning: no previous prototype for 'nvbios_fan_table' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c:56:1: warning: no previous prototype for 'nvbios_fan_entry' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
index 80fed7e..e290581 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
@@ -25,7 +25,7 @@
#include <subdev/bios/bit.h>
#include <subdev/bios/fan.h>
-u16
+static u16
nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
{
struct bit_entry bit_P;
@@ -52,7 +52,7 @@ nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
return 0x0000;
}
-u16
+static u16
nvbios_fan_entry(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr,
u8 *cnt, u8 *len)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 03/17] drm/nouveau/clk: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:184:1: warning: no previous prototype for 'gt215_clk_info' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
index 056702e..96e0941 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
@@ -180,7 +180,7 @@ gt215_clk_read(struct nvkm_clk *base, enum nv_clk_src src)
return 0;
}
-int
+static int
gt215_clk_info(struct nvkm_clk *base, int idx, u32 khz,
struct gt215_clk_info *info)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 03/17] drm/nouveau/clk: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:184:1: warning: no previous prototype for 'gt215_clk_info' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
index 056702e..96e0941 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c
@@ -180,7 +180,7 @@ gt215_clk_read(struct nvkm_clk *base, enum nv_clk_src src)
return 0;
}
-int
+static int
gt215_clk_info(struct nvkm_clk *base, int idx, u32 khz,
struct gt215_clk_info *info)
{
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 04/17] drm/nouveau/fb: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c:69:1: warning: no previous prototype for 'nvkm_sddr3_calc' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c:60:1: warning: no previous prototype for 'nvkm_sddr2_calc' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
index b9f1ffd..4dcd874 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
@@ -23,6 +23,7 @@
* Ben Skeggs
*/
#include "priv.h"
+#include "ram.h"
struct ramxlat {
int id;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
index 2690033..eca8a44 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
@@ -23,6 +23,7 @@
* Roy Spliet <rspliet@eclipso.eu>
*/
#include "priv.h"
+#include "ram.h"
struct ramxlat {
int id;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 04/17] drm/nouveau/fb: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c:69:1: warning: no previous prototype for 'nvkm_sddr3_calc' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c:60:1: warning: no previous prototype for 'nvkm_sddr2_calc' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
index b9f1ffd..4dcd874 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c
@@ -23,6 +23,7 @@
* Ben Skeggs
*/
#include "priv.h"
+#include "ram.h"
struct ramxlat {
int id;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
index 2690033..eca8a44 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c
@@ -23,6 +23,7 @@
* Roy Spliet <rspliet@eclipso.eu>
*/
#include "priv.h"
+#include "ram.h"
struct ramxlat {
int id;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 05/17] drm/nouveau/fb: mark symbols static where possible
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
` (2 preceding siblings ...)
2016-10-22 9:41 ` Baoyou Xie
@ 2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
` (12 subsequent siblings)
16 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 4 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c:99:1: warning: no previous prototype for 'gt215_link_train_calc' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c:153:1: warning: no previous prototype for 'gt215_link_train' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c:271:1: warning: no previous prototype for 'gt215_link_train_init' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c:337:1: warning: no previous prototype for 'gt215_link_train_fini' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
index d15ea88..f106643 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
@@ -95,7 +95,7 @@ struct gt215_ram {
struct gt215_ltrain ltrain;
};
-void
+static void
gt215_link_train_calc(u32 *vals, struct gt215_ltrain *train)
{
int i, lo, hi;
@@ -149,7 +149,7 @@ gt215_link_train_calc(u32 *vals, struct gt215_ltrain *train)
/*
* Link training for (at least) DDR3
*/
-int
+static int
gt215_link_train(struct gt215_ram *ram)
{
struct gt215_ltrain *train = &ram->ltrain;
@@ -267,7 +267,7 @@ gt215_link_train(struct gt215_ram *ram)
return ret;
}
-int
+static int
gt215_link_train_init(struct gt215_ram *ram)
{
static const u32 pattern[16] = {
@@ -333,7 +333,7 @@ gt215_link_train_init(struct gt215_ram *ram)
return 0;
}
-void
+static void
gt215_link_train_fini(struct gt215_ram *ram)
{
if (ram->ltrain.mem)
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 06/17] drm/nouveau/gpio: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c:41:1: warning: no previous prototype for 'gk104_gpio_intr_mask' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
index 3f45afd1..2ead515 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
@@ -37,7 +37,7 @@ gk104_gpio_intr_stat(struct nvkm_gpio *gpio, u32 *hi, u32 *lo)
nvkm_wr32(device, 0x00dc80, intr1);
}
-void
+static void
gk104_gpio_intr_mask(struct nvkm_gpio *gpio, u32 type, u32 mask, u32 data)
{
struct nvkm_device *device = gpio->subdev.device;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 06/17] drm/nouveau/gpio: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c:41:1: warning: no previous prototype for 'gk104_gpio_intr_mask' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
index 3f45afd1..2ead515 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c
@@ -37,7 +37,7 @@ gk104_gpio_intr_stat(struct nvkm_gpio *gpio, u32 *hi, u32 *lo)
nvkm_wr32(device, 0x00dc80, intr1);
}
-void
+static void
gk104_gpio_intr_mask(struct nvkm_gpio *gpio, u32 type, u32 mask, u32 data)
{
struct nvkm_device *device = gpio->subdev.device;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 07/17] drm/nouveau/secboot: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c:1368:1: warning: no previous prototype for 'gm200_secboot_fini' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
index f1e2dc9..ec48e4a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
@@ -1364,7 +1364,7 @@ gm200_secboot_init(struct nvkm_secboot *sb)
return 0;
}
-int
+static int
gm200_secboot_fini(struct nvkm_secboot *sb, bool suspend)
{
struct gm200_secboot *gsb = gm200_secboot(sb);
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 07/17] drm/nouveau/secboot: mark symbol static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c:1368:1: warning: no previous prototype for 'gm200_secboot_fini' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
index f1e2dc9..ec48e4a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c
@@ -1364,7 +1364,7 @@ gm200_secboot_init(struct nvkm_secboot *sb)
return 0;
}
-int
+static int
gm200_secboot_fini(struct nvkm_secboot *sb, bool suspend)
{
struct gm200_secboot *gsb = gm200_secboot(sb);
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 08/17] drm/nouveau/volt: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 3 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:35:1: warning: no previous prototype for 'nvkm_voltgpio_get' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:54:1: warning: no previous prototype for 'nvkm_voltgpio_set' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:71:1: warning: no previous prototype for 'nvkm_voltgpio_init' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/subdev/volt/priv.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
index d2bac1d..443c031 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
@@ -25,6 +25,7 @@
#include <subdev/bios.h>
#include <subdev/bios/gpio.h>
#include <subdev/gpio.h>
+#include "priv.h"
static const u8 tags[] = {
DCB_GPIO_VID0, DCB_GPIO_VID1, DCB_GPIO_VID2, DCB_GPIO_VID3,
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 08/17] drm/nouveau/volt: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 3 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:35:1: warning: no previous prototype for 'nvkm_voltgpio_get' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:54:1: warning: no previous prototype for 'nvkm_voltgpio_set' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:71:1: warning: no previous prototype for 'nvkm_voltgpio_init' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/subdev/volt/priv.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
index d2bac1d..443c031 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c
@@ -25,6 +25,7 @@
#include <subdev/bios.h>
#include <subdev/bios/gpio.h>
#include <subdev/gpio.h>
+#include "priv.h"
static const u8 tags[] = {
DCB_GPIO_VID0, DCB_GPIO_VID1, DCB_GPIO_VID2, DCB_GPIO_VID3,
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 09/17] drm/nouveau/volt: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c:38:1: warning: no previous prototype for 'gk104_volt_get' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c:51:1: warning: no previous prototype for 'gk104_volt_set' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index 420bd84..1527d12 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -34,7 +34,7 @@ struct gk104_volt {
struct nvbios_volt bios;
};
-int
+static int
gk104_volt_get(struct nvkm_volt *base)
{
struct nvbios_volt *bios = &gk104_volt(base)->bios;
@@ -47,7 +47,7 @@ gk104_volt_get(struct nvkm_volt *base)
return bios->base + bios->pwm_range * duty / div;
}
-int
+static int
gk104_volt_set(struct nvkm_volt *base, u32 uv)
{
struct nvbios_volt *bios = &gk104_volt(base)->bios;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 09/17] drm/nouveau/volt: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c:38:1: warning: no previous prototype for 'gk104_volt_get' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c:51:1: warning: no previous prototype for 'gk104_volt_set' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index 420bd84..1527d12 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -34,7 +34,7 @@ struct gk104_volt {
struct nvbios_volt bios;
};
-int
+static int
gk104_volt_get(struct nvkm_volt *base)
{
struct nvbios_volt *bios = &gk104_volt(base)->bios;
@@ -47,7 +47,7 @@ gk104_volt_get(struct nvkm_volt *base)
return bios->base + bios->pwm_range * duty / div;
}
-int
+static int
gk104_volt_set(struct nvkm_volt *base, u32 uv)
{
struct nvbios_volt *bios = &gk104_volt(base)->bios;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 10/17] drm/nouveau/device: mark symbol static where possible
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
` (7 preceding siblings ...)
2016-10-22 9:41 ` Baoyou Xie
@ 2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 11/17] drm/nouveau/disp: mark symbols " Baoyou Xie
` (7 subsequent siblings)
16 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/device/user.c:330:1: warning: no previous prototype for 'nvkm_udevice_new' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/device/user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
index 79a8f71..513ee6b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
@@ -326,7 +326,7 @@ nvkm_udevice = {
.sclass = nvkm_udevice_child_get,
};
-int
+static int
nvkm_udevice_new(const struct nvkm_oclass *oclass, void *data, u32 size,
struct nvkm_object **pobject)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 11/17] drm/nouveau/disp: mark symbols static where possible
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
` (8 preceding siblings ...)
2016-10-22 9:41 ` [PATCH 10/17] drm/nouveau/device: mark symbol " Baoyou Xie
@ 2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
` (6 subsequent siblings)
16 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 5 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c:70:1: warning: no previous prototype for 'nv50_disp_root_mthd_' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:157:1: warning: no previous prototype for 'nv50_disp_chan_rd32' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:167:1: warning: no previous prototype for 'nv50_disp_chan_wr32' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:177:1: warning: no previous prototype for 'nv50_disp_chan_ntfy' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:193:1: warning: no previous prototype for 'nv50_disp_chan_map' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c | 8 ++++----
drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
index dd2953b..26990d4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
@@ -153,7 +153,7 @@ nv50_disp_chan_uevent = {
.fini = nv50_disp_chan_uevent_fini,
};
-int
+static int
nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr, u32 *data)
{
struct nv50_disp_chan *chan = nv50_disp_chan(object);
@@ -163,7 +163,7 @@ nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr, u32 *data)
return 0;
}
-int
+static int
nv50_disp_chan_wr32(struct nvkm_object *object, u64 addr, u32 data)
{
struct nv50_disp_chan *chan = nv50_disp_chan(object);
@@ -173,7 +173,7 @@ nv50_disp_chan_wr32(struct nvkm_object *object, u64 addr, u32 data)
return 0;
}
-int
+static int
nv50_disp_chan_ntfy(struct nvkm_object *object, u32 type,
struct nvkm_event **pevent)
{
@@ -189,7 +189,7 @@ nv50_disp_chan_ntfy(struct nvkm_object *object, u32 type,
return -EINVAL;
}
-int
+static int
nv50_disp_chan_map(struct nvkm_object *object, u64 *addr, u32 *size)
{
struct nv50_disp_chan *chan = nv50_disp_chan(object);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
index 2f9cecd..6424b39 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c
@@ -66,7 +66,7 @@ nv50_disp_root_scanoutpos(NV50_DISP_MTHD_V0)
return 0;
}
-int
+static int
nv50_disp_root_mthd_(struct nvkm_object *object, u32 mthd, void *data, u32 size)
{
union {
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 12/17] drm/nouveau/fifo: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:133:1: warning: no previous prototype for 'g84_fifo_chan_engine_init' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:174:1: warning: no previous prototype for 'g84_fifo_chan_object_ctor' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
index aeb3387..15a992b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
@@ -129,7 +129,7 @@ g84_fifo_chan_engine_fini(struct nvkm_fifo_chan *base,
}
-int
+static int
g84_fifo_chan_engine_init(struct nvkm_fifo_chan *base,
struct nvkm_engine *engine)
{
@@ -170,7 +170,7 @@ g84_fifo_chan_engine_ctor(struct nvkm_fifo_chan *base,
return nvkm_object_bind(object, NULL, 0, &chan->engn[engn]);
}
-int
+static int
g84_fifo_chan_object_ctor(struct nvkm_fifo_chan *base,
struct nvkm_object *object)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 12/17] drm/nouveau/fifo: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:133:1: warning: no previous prototype for 'g84_fifo_chan_engine_init' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:174:1: warning: no previous prototype for 'g84_fifo_chan_object_ctor' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
index aeb3387..15a992b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
@@ -129,7 +129,7 @@ g84_fifo_chan_engine_fini(struct nvkm_fifo_chan *base,
}
-int
+static int
g84_fifo_chan_engine_init(struct nvkm_fifo_chan *base,
struct nvkm_engine *engine)
{
@@ -170,7 +170,7 @@ g84_fifo_chan_engine_ctor(struct nvkm_fifo_chan *base,
return nvkm_object_bind(object, NULL, 0, &chan->engn[engn]);
}
-int
+static int
g84_fifo_chan_object_ctor(struct nvkm_fifo_chan *base,
struct nvkm_object *object)
{
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 13/17] drm/nouveau/gr: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no previous prototype for 'nv50_grctx_init' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/engine/gr/nv50.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
index 1e13278..c8bb919 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
@@ -106,6 +106,7 @@
#define CP_SEEK_2 0x00c800ff
#include "ctxnv40.h"
+#include "nv50.h"
#include <subdev/fb.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 13/17] drm/nouveau/gr: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no previous prototype for 'nv50_grctx_init' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/nouveau/nvkm/engine/gr/nv50.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
index 1e13278..c8bb919 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c
@@ -106,6 +106,7 @@
#define CP_SEEK_2 0x00c800ff
#include "ctxnv40.h"
+#include "nv50.h"
#include <subdev/fb.h>
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 14/17] drm/nouveau/gr: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 5 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1388:1: warning: no previous prototype for 'gf100_gr_init_fw' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1705:1: warning: no previous prototype for 'gf100_gr_init_' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c:312:1: warning: no previous prototype for 'gm107_gr_init' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
index c925ade..74a64e3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
@@ -218,7 +218,7 @@ gf117_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gf117_grctx_generate_main(struct gf100_gr *gr, struct gf100_grctx *info)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c501..4c4b5ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gm107_grctx_generate_tpcid(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 157919c..eccdee0 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1384,7 +1384,7 @@ gf100_gr_intr(struct nvkm_gr *base)
nvkm_fifo_chan_put(device->fifo, flags, &chan);
}
-void
+static void
gf100_gr_init_fw(struct gf100_gr *gr, u32 fuc_base,
struct gf100_gr_fuc *code, struct gf100_gr_fuc *data)
{
@@ -1701,7 +1701,7 @@ gf100_gr_oneinit(struct nvkm_gr *base)
return 0;
}
-int
+static int
gf100_gr_init_(struct nvkm_gr *base)
{
struct gf100_gr *gr = gf100_gr(base);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
index 45f965f..2c67fac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
@@ -308,7 +308,7 @@ gm107_gr_init_bios(struct gf100_gr *gr)
}
}
-int
+static int
gm107_gr_init(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 14/17] drm/nouveau/gr: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 5 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1388:1: warning: no previous prototype for 'gf100_gr_init_fw' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1705:1: warning: no previous prototype for 'gf100_gr_init_' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c:312:1: warning: no previous prototype for 'gm107_gr_init' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
index c925ade..74a64e3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
@@ -218,7 +218,7 @@ gf117_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gf117_grctx_generate_main(struct gf100_gr *gr, struct gf100_grctx *info)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c501..4c4b5ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gm107_grctx_generate_tpcid(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 157919c..eccdee0 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1384,7 +1384,7 @@ gf100_gr_intr(struct nvkm_gr *base)
nvkm_fifo_chan_put(device->fifo, flags, &chan);
}
-void
+static void
gf100_gr_init_fw(struct gf100_gr *gr, u32 fuc_base,
struct gf100_gr_fuc *code, struct gf100_gr_fuc *data)
{
@@ -1701,7 +1701,7 @@ gf100_gr_oneinit(struct nvkm_gr *base)
return 0;
}
-int
+static int
gf100_gr_init_(struct nvkm_gr *base)
{
struct gf100_gr *gr = gf100_gr(base);
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
index 45f965f..2c67fac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
@@ -308,7 +308,7 @@ gm107_gr_init_bios(struct gf100_gr *gr)
}
}
-int
+static int
gm107_gr_init(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 15/17] drm/nouveau/pm: mark symbols static where possible
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
` (12 preceding siblings ...)
2016-10-22 9:41 ` Baoyou Xie
@ 2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
` (2 subsequent siblings)
16 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
index 8616636..dde89a4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
@@ -71,7 +71,7 @@ nvkm_perfdom_find(struct nvkm_pm *pm, int di)
return NULL;
}
-struct nvkm_perfsig *
+static struct nvkm_perfsig *
nvkm_perfsig_find(struct nvkm_pm *pm, u8 di, u8 si, struct nvkm_perfdom **pdom)
{
struct nvkm_perfdom *dom = *pdom;
@@ -699,7 +699,7 @@ nvkm_pm_oclass_get(struct nvkm_oclass *oclass, int index,
return 1;
}
-int
+static int
nvkm_perfsrc_new(struct nvkm_pm *pm, struct nvkm_perfsig *sig,
const struct nvkm_specsrc *spec)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 16/17] drm/nouveau/dispnv04: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
In fact, this function is declared in
drivers/gpu/drm/nouveau/dispnv04/disp.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 16/17] drm/nouveau/dispnv04: add missing header dependencies
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
In fact, this function is declared in
drivers/gpu/drm/nouveau/dispnv04/disp.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 17/17] drm/nouveau: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs, airlied, acourbot, imirkin, Julia.Lawall, martin.peres,
rspliet, nouveau
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou,
han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for 'nv10_fence_context_new' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
drivers/gpu/drm/nouveau/nv10_fence.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index afbf557..b60ee21 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line)
return line;
}
-int
+static int
nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime)
{
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c
index 4e3de34..619f79d 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.c
+++ b/drivers/gpu/drm/nouveau/nv10_fence.c
@@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan)
nouveau_fence_context_free(&fctx->base);
}
-int
+static int
nv10_fence_context_new(struct nouveau_channel *chan)
{
struct nv10_fence_chan *fctx;
--
2.7.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 17/17] drm/nouveau: mark symbols static where possible
@ 2016-10-22 9:41 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:41 UTC (permalink / raw)
To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA, airlied-cv59FeDIM0c,
acourbot-DDmLM1+adcrQT0dZR+AlfA, imirkin-FrUbXkNCsVf2fBVCVOL8/A,
Julia.Lawall-L2FTfq7BK8M, martin.peres-GANU6spQydw,
rspliet-pPYjZ15w/Xhulxpn9UvDqw, nouveau-lIBOoy2+GI7scQ4cX5LuPg
Cc: arnd-r2nGTMty4D4, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
han.fei-Th6q7B73Y6EnDS1+zs4M5A,
baoyou.xie-QSEj5FYQhm4dnm+yROfE0A
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for 'nv10_fence_context_new' [-Wmissing-prototypes]
In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
drivers/gpu/drm/nouveau/nv10_fence.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index afbf557..b60ee21 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line)
return line;
}
-int
+static int
nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime)
{
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c
index 4e3de34..619f79d 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.c
+++ b/drivers/gpu/drm/nouveau/nv10_fence.c
@@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan)
nouveau_fence_context_free(&fctx->base);
}
-int
+static int
nv10_fence_context_new(struct nouveau_channel *chan)
{
struct nv10_fence_chan *fctx;
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies
@ 2016-10-22 17:32 ` Karol Herbst
0 siblings, 0 replies; 33+ messages in thread
From: Karol Herbst @ 2016-10-22 17:32 UTC (permalink / raw)
To: Baoyou Xie
Cc: Ben Skeggs, David Airlie, Alexandre Courbot, Ilia Mirkin,
Julia.Lawall, Martin Peres, rspliet, Karol Herbst, arnd,
ML nouveau, tang.qiang007, xie.baoyou, Linux Kernel Mailing List,
dri-devel, han.fei
I think it would be better to squash those commits:
1. for the includes
2. for static declerations
2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> index 34ecd4a..058ff46 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -20,6 +20,7 @@
> * DEALINGS IN THE SOFTWARE.
> */
> #include <core/device.h>
> +#include <core/firmware.h>
>
> /**
> * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
> --
> 2.7.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 01/17] drm/nouveau/core: add missing header dependencies
@ 2016-10-22 17:32 ` Karol Herbst
0 siblings, 0 replies; 33+ messages in thread
From: Karol Herbst @ 2016-10-22 17:32 UTC (permalink / raw)
To: Baoyou Xie
Cc: rspliet-pPYjZ15w/Xhulxpn9UvDqw, Karol Herbst, arnd-r2nGTMty4D4,
David Airlie, ML nouveau, tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A, Linux Kernel Mailing List,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Julia.Lawall-L2FTfq7BK8M, Ben Skeggs,
han.fei-Th6q7B73Y6EnDS1+zs4M5A
I think it would be better to squash those commits:
1. for the includes
2. for static declerations
2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> index 34ecd4a..058ff46 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -20,6 +20,7 @@
> * DEALINGS IN THE SOFTWARE.
> */
> #include <core/device.h>
> +#include <core/firmware.h>
>
> /**
> * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
> --
> 2.7.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 01/17] drm/nouveau/core: add missing header dependencies
[not found] ` <CAEXux-ZYknEnU=D4qA_xv162vXF4UpVG-W9eNk68ahQoPP0ozQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-10-24 7:13 ` Baoyou Xie
2016-10-24 15:43 ` [Nouveau] " Karol Herbst
0 siblings, 1 reply; 33+ messages in thread
From: Baoyou Xie @ 2016-10-24 7:13 UTC (permalink / raw)
To: Karol Herbst
Cc: rspliet-pPYjZ15w/Xhulxpn9UvDqw, Karol Herbst, Arnd Bergmann,
David Airlie, ML nouveau, tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A, Linux Kernel Mailing List,
dri-devel, Julia Lawall, Ben Skeggs,
han.fei-Th6q7B73Y6EnDS1+zs4M5A
[-- Attachment #1.1: Type: text/plain, Size: 1738 bytes --]
On 23 October 2016 at 01:32, Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> I think it would be better to squash those commits:
> 1. for the includes
> 2. for static declerations
>
> OK, I have resent new patch that squash those commits.
> 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
> > We get 2 warnings when building kernel with W=1:
> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous
> prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous
> prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
> >
> > In fact, these functions are declared in
> > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> > So this patch adds missing header dependencies.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> > index 34ecd4a..058ff46 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> > @@ -20,6 +20,7 @@
> > * DEALINGS IN THE SOFTWARE.
> > */
> > #include <core/device.h>
> > +#include <core/firmware.h>
> >
> > /**
> > * nvkm_firmware_get - load firmware from the official nvidia/chip/
> directory
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Nouveau mailing list
> > Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> > https://lists.freedesktop.org/mailman/listinfo/nouveau
>
[-- Attachment #1.2: Type: text/html, Size: 2912 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies
2016-10-24 7:13 ` Baoyou Xie
@ 2016-10-24 15:43 ` Karol Herbst
[not found] ` <CAEXux-Y+MXCawYsWm3gNgjA+7y6iVqqJN0n_cLNqR2U33GRWrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 33+ messages in thread
From: Karol Herbst @ 2016-10-24 15:43 UTC (permalink / raw)
To: Baoyou Xie
Cc: Ben Skeggs, David Airlie, Alexandre Courbot, Ilia Mirkin,
Julia Lawall, Martin Peres, rspliet, Karol Herbst, Arnd Bergmann,
ML nouveau, tang.qiang007, xie.baoyou, Linux Kernel Mailing List,
dri-devel, han.fei
2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>:
>
>
> On 23 October 2016 at 01:32, Karol Herbst <karolherbst@gmail.com> wrote:
>>
>> I think it would be better to squash those commits:
>> 1. for the includes
>> 2. for static declerations
>>
> OK, I have resent new patch that squash those commits.
>
thanks, this is much easier to review and keeps the git history clean :)
Will try to make a test with those patches over the next days, but it
looks fine as it is already.
>>
>> 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>:
>> > We get 2 warnings when building kernel with W=1:
>> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous
>> > prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
>> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous
>> > prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
>> >
>> > In fact, these functions are declared in
>> > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
>> > So this patch adds missing header dependencies.
>> >
>> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> > ---
>> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> > b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> > index 34ecd4a..058ff46 100644
>> > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> > @@ -20,6 +20,7 @@
>> > * DEALINGS IN THE SOFTWARE.
>> > */
>> > #include <core/device.h>
>> > +#include <core/firmware.h>
>> >
>> > /**
>> > * nvkm_firmware_get - load firmware from the official nvidia/chip/
>> > directory
>> > --
>> > 2.7.4
>> >
>> > _______________________________________________
>> > Nouveau mailing list
>> > Nouveau@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/nouveau
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 01/17] drm/nouveau/core: add missing header dependencies
[not found] ` <CAEXux-Y+MXCawYsWm3gNgjA+7y6iVqqJN0n_cLNqR2U33GRWrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-10-25 0:23 ` Baoyou Xie
0 siblings, 0 replies; 33+ messages in thread
From: Baoyou Xie @ 2016-10-25 0:23 UTC (permalink / raw)
To: Karol Herbst
Cc: rspliet-pPYjZ15w/Xhulxpn9UvDqw, Karol Herbst, Arnd Bergmann,
David Airlie, ML nouveau, tang.qiang007-Th6q7B73Y6EnDS1+zs4M5A,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A, Linux Kernel Mailing List,
dri-devel, Julia Lawall, Ben Skeggs,
han.fei-Th6q7B73Y6EnDS1+zs4M5A
[-- Attachment #1.1: Type: text/plain, Size: 2325 bytes --]
On 24 October 2016 at 23:43, Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
> >
> >
> > On 23 October 2016 at 01:32, Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >>
> >> I think it would be better to squash those commits:
> >> 1. for the includes
> >> 2. for static declerations
> >>
> > OK, I have resent new patch that squash those commits.
> >
>
> thanks, this is much easier to review and keeps the git history clean :)
> Will try to make a test with those patches over the next days, but it
> looks fine as it is already.
>
>
I worked them out on next-20161021.
> >>
> >> 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
> >> > We get 2 warnings when building kernel with W=1:
> >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no
> previous
> >> > prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no
> previous
> >> > prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
> >> >
> >> > In fact, these functions are declared in
> >> > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> >> > So this patch adds missing header dependencies.
> >> >
> >> > Signed-off-by: Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >> > ---
> >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> >> > b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> >> > index 34ecd4a..058ff46 100644
> >> > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> >> > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> >> > @@ -20,6 +20,7 @@
> >> > * DEALINGS IN THE SOFTWARE.
> >> > */
> >> > #include <core/device.h>
> >> > +#include <core/firmware.h>
> >> >
> >> > /**
> >> > * nvkm_firmware_get - load firmware from the official nvidia/chip/
> >> > directory
> >> > --
> >> > 2.7.4
> >> >
> >> > _______________________________________________
> >> > Nouveau mailing list
> >> > Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> >> > https://lists.freedesktop.org/mailman/listinfo/nouveau
> >
> >
>
[-- Attachment #1.2: Type: text/html, Size: 4070 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2016-10-25 0:23 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 02/17] drm/nouveau/bios: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 03/17] drm/nouveau/clk: mark symbol " Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 04/17] drm/nouveau/fb: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 05/17] drm/nouveau/fb: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 06/17] drm/nouveau/gpio: mark symbol " Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 07/17] drm/nouveau/secboot: " Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 08/17] drm/nouveau/volt: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 09/17] drm/nouveau/volt: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 10/17] drm/nouveau/device: mark symbol " Baoyou Xie
2016-10-22 9:41 ` [PATCH 11/17] drm/nouveau/disp: mark symbols " Baoyou Xie
2016-10-22 9:41 ` [PATCH 12/17] drm/nouveau/fifo: " Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 13/17] drm/nouveau/gr: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 14/17] drm/nouveau/gr: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 15/17] drm/nouveau/pm: " Baoyou Xie
2016-10-22 9:41 ` [PATCH 16/17] drm/nouveau/dispnv04: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 9:41 ` [PATCH 17/17] drm/nouveau: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` Baoyou Xie
2016-10-22 17:32 ` [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies Karol Herbst
2016-10-22 17:32 ` Karol Herbst
[not found] ` <CAEXux-ZYknEnU=D4qA_xv162vXF4UpVG-W9eNk68ahQoPP0ozQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-24 7:13 ` Baoyou Xie
2016-10-24 15:43 ` [Nouveau] " Karol Herbst
[not found] ` <CAEXux-Y+MXCawYsWm3gNgjA+7y6iVqqJN0n_cLNqR2U33GRWrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-25 0:23 ` Baoyou Xie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.