Re: [LTP] [PATCH] lib: memutils: don't pollute entire system memory to avoid OoM

From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: memutils: don't pollute entire system memory to avoid OoM
Date: Wed, 8 Sep 2021 16:19:08 +0200	[thread overview]
Message-ID: <CA+Eumj53j-AucdNdJ91-wHO6CN=jNg=kpNpxNwnRwqvbxsWMkw@mail.gmail.com> (raw)
Message-ID: <20210908141908.gsL0di-KGJBtpncwJBA0X2bO985IchTzmBCgtMy8utw@z> (raw)
In-Reply-To: <YTjGCeaaA0Nv56hn@yuki>

On Wed, 8 Sept 2021 at 16:17, Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > > I guess that this is another bug that should be fixed before the
> > > release. I still think that the memory pollution is a best effort
> > > operation and that we should be more conservative with the reserve. I
> > > would go for a few percents of the free memory just to be extra sure
> > > that we do not cause memory pressure.
> > >
> > > If we go for 2% we will add following;
> > >
> > > safety = MAX(safety, info.freeram / 50);
> > >
> > > Also it looks like info.freeram is the same as MemFree: from
> > > /proc/meminfo, I guess that this is not wrong, since memory that have
> > > been used in buffers is dirty enough for our case.
> >
> > I'd recommend dividing by a power of 2 (either 32 or 64) but other than
> > that, I completely agree.
>
> Sounds good.
>
> Krzysztof unless you disagree I will push your patch but change the
> division factor from 200 to 64.

Sounds good. In such case please also update the % mentioned at the
end of commit msg (0.5% -> 1.5%).

Best regards,
Krzysztof

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp