All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: wangyunjian <wangyunjian@huawei.com>
Cc: Network Development <netdev@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	virtualization@lists.linux-foundation.org,
	"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
	chenchanghu <chenchanghu@huawei.com>,
	xudingke <xudingke@huawei.com>,
	"huangbin (J)" <brian.huangbin@huawei.com>
Subject: Re: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails
Date: Mon, 14 Dec 2020 21:45:45 -0500	[thread overview]
Message-ID: <CA+FuTSeH-+p_7i9UdEy0UL2y2EoprO4sE-BYNe2Vt8ThxaCLcA@mail.gmail.com> (raw)
In-Reply-To: <5e2ecf3d0f07b864d307b9f0425b7b7fe8bf4d2c.1608024547.git.wangyunjian@huawei.com>

On Mon, Dec 14, 2020 at 8:59 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Currently the vhost_zerocopy_callback() maybe be called to decrease
> the refcount when sendmsg fails in tun. The error handling in vhost
> handle_tx_zerocopy() will try to decrease the same refcount again.
> This is wrong. To fix this issue, we only call vhost_net_ubuf_put()
> when vq->heads[nvq->desc].len == VHOST_DMA_IN_PROGRESS.
>
> Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
> Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Patch looks good to me. Thanks.

But I think the right Fixes tag would be

Fixes: 0690899b4d45 ("tun: experimental zero copy tx support")

WARNING: multiple messages have this Message-ID (diff)
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: wangyunjian <wangyunjian@huawei.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Network Development <netdev@vger.kernel.org>,
	"Lilijun \(Jerry\)" <jerry.lilijun@huawei.com>,
	virtualization@lists.linux-foundation.org,
	xudingke <xudingke@huawei.com>,
	"huangbin \(J\)" <brian.huangbin@huawei.com>,
	chenchanghu <chenchanghu@huawei.com>
Subject: Re: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails
Date: Mon, 14 Dec 2020 21:45:45 -0500	[thread overview]
Message-ID: <CA+FuTSeH-+p_7i9UdEy0UL2y2EoprO4sE-BYNe2Vt8ThxaCLcA@mail.gmail.com> (raw)
In-Reply-To: <5e2ecf3d0f07b864d307b9f0425b7b7fe8bf4d2c.1608024547.git.wangyunjian@huawei.com>

On Mon, Dec 14, 2020 at 8:59 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Currently the vhost_zerocopy_callback() maybe be called to decrease
> the refcount when sendmsg fails in tun. The error handling in vhost
> handle_tx_zerocopy() will try to decrease the same refcount again.
> This is wrong. To fix this issue, we only call vhost_net_ubuf_put()
> when vq->heads[nvq->desc].len == VHOST_DMA_IN_PROGRESS.
>
> Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
> Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Patch looks good to me. Thanks.

But I think the right Fixes tag would be

Fixes: 0690899b4d45 ("tun: experimental zero copy tx support")
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2020-12-15  2:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15  1:48 [PATCH net 0/2] fixes for vhost_net wangyunjian
2020-12-15  1:48 ` [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails wangyunjian
2020-12-15  2:45   ` Willem de Bruijn [this message]
2020-12-15  2:45     ` Willem de Bruijn
2020-12-15  7:51     ` wangyunjian
2020-12-15  1:48 ` [PATCH net 2/2] vhost_net: fix high cpu load " wangyunjian
2020-12-15  4:09   ` Jason Wang
2020-12-15  4:09     ` Jason Wang
2020-12-15  8:03     ` wangyunjian
2020-12-16  5:56       ` Jason Wang
2020-12-16  5:56         ` Jason Wang
2020-12-16  7:43         ` wangyunjian
2020-12-16  7:47           ` Jason Wang
2020-12-16  7:47             ` Jason Wang
2020-12-16  8:20 ` [PATCH net v2 0/2] fixes for vhost_net wangyunjian
2020-12-16  8:20   ` [PATCH net v2 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails wangyunjian
2020-12-16 14:17     ` Willem de Bruijn
2020-12-16 14:17       ` Willem de Bruijn
2020-12-16 20:56     ` Michael S. Tsirkin
2020-12-16 20:56       ` Michael S. Tsirkin
2020-12-16  8:20   ` [PATCH net v2 2/2] vhost_net: fix high cpu load " wangyunjian
2020-12-16  9:23     ` Michael S. Tsirkin
2020-12-16  9:23       ` Michael S. Tsirkin
2020-12-17  2:38       ` wangyunjian
2020-12-17  3:19       ` Jason Wang
2020-12-17  3:19         ` Jason Wang
2020-12-21 23:07     ` Willem de Bruijn
2020-12-21 23:07       ` Willem de Bruijn
2020-12-22  4:41       ` Jason Wang
2020-12-22  4:41         ` Jason Wang
2020-12-22 14:24         ` Willem de Bruijn
2020-12-22 14:24           ` Willem de Bruijn
2020-12-23  2:53           ` Jason Wang
2020-12-23  2:53             ` Jason Wang
2020-12-23 13:21             ` wangyunjian
2020-12-23 13:48               ` Willem de Bruijn
2020-12-23 13:48                 ` Willem de Bruijn
2020-12-23  2:46         ` wangyunjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+FuTSeH-+p_7i9UdEy0UL2y2EoprO4sE-BYNe2Vt8ThxaCLcA@mail.gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=brian.huangbin@huawei.com \
    --cc=chenchanghu@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.