[PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

[PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

[Robin Murphy]

The PLDA root complex on Juno relies on an address-based lookup table to
generate AXI attributes for inbound PCI transactions, and as such will
not pass any transaction not matching any programmed address range. The
standard firmware configuration programs 3 entries covering the GICv2m
MSI doorbell and the 2 DRAM regions, so add a "dma-ranges" property to
describe those usable inbound windows.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index f6c55877fbd9..b48a76b100b1 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -544,6 +544,10 @@
 		ranges = <0x01000000 0x00 0x00000000 0x00 0x5f800000 0x0 0x00800000>,
 			 <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
 			 <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
+		/* Standard AXI Translation entries as programmed by EDK2 */
+		dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
+			     <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
+			     <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
 		#interrupt-cells = <1>;
 		interrupt-map-mask = <0 0 0 7>;
 		interrupt-map = <0 0 0 1 &gic 0 GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Robin Murphy]

Now that PCI inbound window restrictions are handled generically between
the of_pci resource parsing and the IOMMU layer, and described in the
Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
mappings inadvertently allocating unusable addresses.

Similarly, the relevant support for IOMMU mappings for peripheral
transfers has been hooked up in the pl330 driver for ages, so we can
happily enable the DMA SMMU without that breaking anything either.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 1 -
 arch/arm64/boot/dts/arm/juno-r1.dts    | 4 ++++
 arch/arm64/boot/dts/arm/juno-r2.dts    | 4 ++++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index b48a76b100b1..1cc7fdcec51b 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -644,7 +644,6 @@
 		#iommu-cells = <1>;
 		#global-interrupts = <1>;
 		dma-coherent;
-		status = "disabled";
 	};
 
 	smmu_hdlcd1: iommu@7fb10000 {
diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
index 5f290090b0cf..0e24e29eb9b1 100644
--- a/arch/arm64/boot/dts/arm/juno-r1.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1.dts
@@ -230,6 +230,10 @@
 	status = "okay";
 };
 
+&smmu_pcie {
+	status = "okay";
+};
+
 &etm0 {
 	cpu = <&A57_0>;
 };
diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
index 305300dd521c..e609420ce3e4 100644
--- a/arch/arm64/boot/dts/arm/juno-r2.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2.dts
@@ -236,6 +236,10 @@
 	status = "okay";
 };
 
+&smmu_pcie {
+	status = "okay";
+};
+
 &etm0 {
 	cpu = <&A72_0>;
 };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Robin Murphy]

On 2021-07-30 12:35, Anders Roxell wrote:
> From: Robin Murphy <robin.murphy@arm.com>
> 
>> Now that PCI inbound window restrictions are handled generically between
>> the of_pci resource parsing and the IOMMU layer, and described in the
>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
>> mappings inadvertently allocating unusable addresses.
>>
>> Similarly, the relevant support for IOMMU mappings for peripheral
>> transfers has been hooked up in the pl330 driver for ages, so we can
>> happily enable the DMA SMMU without that breaking anything either.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> When we build a kernel with 64k page size and run the ltp syscalls we
> sporadically see a kernel crash while doing a mkfs on a connected SATA
> drive.  This is happening every third test run on any juno-r2 device in
> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> with gcc-11.

Hmm, I guess 64K pages might make a difference in that we'll chew 
through IOVA space a lot faster with small mappings...

I'll have to try to reproduce this locally, since the interesting thing 
would be knowing what DMA address it was trying to use that went wrong, 
but IOMMU tracepoints and/or dma-debug are going to generate an crazy 
amount of data to sift through and try to correlate - having done it 
before it's not something I'd readily ask someone else to do for me :)

On a hunch, though, does it make any difference if you remove the first 
entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?

Robin.

> Here is a snippet of the boot log [1]:
> 
> + mkfs -t ext4 /dev/disk/by-id/ata-SanDisk_SDSSDA120G_165192443611
> mke2fs 1.43.8 (1-Jan-2018)
> Discarding device blocks:     4096/29305200
> [   55.344291] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6
> frozen
> [   55.351423] ata1.00: irq_stat 0x00020002, failed to transmit command
> FIS
> [   55.358205] ata1.00: failed command: DATA SET MANAGEMENT
> [   55.363561] ata1.00: cmd 06/01:01:00:00:00/00:00:00:00:00/a0 tag 12
> dma 512 out
> [   55.363561]          res ec/ff:00:00:00:00/00:00:00:00:ec/00 Emask
> 0x12 (ATA bus error)
> [   55.378955] ata1.00: status: { Busy }
> [   55.382658] ata1.00: error: { ICRC UNC AMNF IDNF ABRT }
> [   55.387947] ata1: hard resetting link
> [   55.391653] ata1: controller in dubious state, performing PORT_RST
> [   57.588447] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
> [   57.613471] ata1.00: configured for UDMA/100
> [   57.617866] ata1.00: device reported invalid CHS sector 0
> [   57.623397] ata1: EH complete
> 
> 
> When we revert this patch we don't see any issue.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Cheers,
> Anders
> [1]
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.13.y/build/v5.13.5-225-g692072e7b7fa/testrun/5279599/suite/ltp-syscalls-tests/test/copy_file_range01/log
> 

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Robin Murphy]

On 2021-07-30 12:35, Anders Roxell wrote:
> From: Robin Murphy <robin.murphy@arm.com>
> 
>> Now that PCI inbound window restrictions are handled generically between
>> the of_pci resource parsing and the IOMMU layer, and described in the
>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
>> mappings inadvertently allocating unusable addresses.
>>
>> Similarly, the relevant support for IOMMU mappings for peripheral
>> transfers has been hooked up in the pl330 driver for ages, so we can
>> happily enable the DMA SMMU without that breaking anything either.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> When we build a kernel with 64k page size and run the ltp syscalls we
> sporadically see a kernel crash while doing a mkfs on a connected SATA
> drive.  This is happening every third test run on any juno-r2 device in
> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> with gcc-11.

Hmm, I guess 64K pages might make a difference in that we'll chew 
through IOVA space a lot faster with small mappings...

I'll have to try to reproduce this locally, since the interesting thing 
would be knowing what DMA address it was trying to use that went wrong, 
but IOMMU tracepoints and/or dma-debug are going to generate an crazy 
amount of data to sift through and try to correlate - having done it 
before it's not something I'd readily ask someone else to do for me :)

On a hunch, though, does it make any difference if you remove the first 
entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?

Robin.

> Here is a snippet of the boot log [1]:
> 
> + mkfs -t ext4 /dev/disk/by-id/ata-SanDisk_SDSSDA120G_165192443611
> mke2fs 1.43.8 (1-Jan-2018)
> Discarding device blocks:     4096/29305200
> [   55.344291] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6
> frozen
> [   55.351423] ata1.00: irq_stat 0x00020002, failed to transmit command
> FIS
> [   55.358205] ata1.00: failed command: DATA SET MANAGEMENT
> [   55.363561] ata1.00: cmd 06/01:01:00:00:00/00:00:00:00:00/a0 tag 12
> dma 512 out
> [   55.363561]          res ec/ff:00:00:00:00/00:00:00:00:ec/00 Emask
> 0x12 (ATA bus error)
> [   55.378955] ata1.00: status: { Busy }
> [   55.382658] ata1.00: error: { ICRC UNC AMNF IDNF ABRT }
> [   55.387947] ata1: hard resetting link
> [   55.391653] ata1: controller in dubious state, performing PORT_RST
> [   57.588447] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
> [   57.613471] ata1.00: configured for UDMA/100
> [   57.617866] ata1.00: device reported invalid CHS sector 0
> [   57.623397] ata1: EH complete
> 
> 
> When we revert this patch we don't see any issue.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Cheers,
> Anders
> [1]
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.13.y/build/v5.13.5-225-g692072e7b7fa/testrun/5279599/suite/ltp-syscalls-tests/test/copy_file_range01/log
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On 2021-07-30 13:17, Robin Murphy wrote:
> On 2021-07-30 12:35, Anders Roxell wrote:
> > From: Robin Murphy <robin.murphy@arm.com>
> > 
> > > Now that PCI inbound window restrictions are handled generically between
> > > the of_pci resource parsing and the IOMMU layer, and described in the
> > > Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> > > mappings inadvertently allocating unusable addresses.
> > > 
> > > Similarly, the relevant support for IOMMU mappings for peripheral
> > > transfers has been hooked up in the pl330 driver for ages, so we can
> > > happily enable the DMA SMMU without that breaking anything either.
> > > 
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > 
> > When we build a kernel with 64k page size and run the ltp syscalls we
> > sporadically see a kernel crash while doing a mkfs on a connected SATA
> > drive.  This is happening every third test run on any juno-r2 device in
> > the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> > with gcc-11.
> 
> Hmm, I guess 64K pages might make a difference in that we'll chew through
> IOVA space a lot faster with small mappings...
> 
> I'll have to try to reproduce this locally, since the interesting thing
> would be knowing what DMA address it was trying to use that went wrong, but
> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> data to sift through and try to correlate - having done it before it's not
> something I'd readily ask someone else to do for me :)
> 
> On a hunch, though, does it make any difference if you remove the first
> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?

I did this change, and run the job 7 times and could not reproduce the
issue.

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 8e7a66943b01..d3148730e951 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
                         <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
                         <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
                /* Standard AXI Translation entries as programmed by EDK2 */
-               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
-                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
+               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
                             <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
                #interrupt-cells = <1>;
                interrupt-map-mask = <0 0 0 7>;


Cheers,
Anders

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On 2021-07-30 13:17, Robin Murphy wrote:
> On 2021-07-30 12:35, Anders Roxell wrote:
> > From: Robin Murphy <robin.murphy@arm.com>
> > 
> > > Now that PCI inbound window restrictions are handled generically between
> > > the of_pci resource parsing and the IOMMU layer, and described in the
> > > Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> > > mappings inadvertently allocating unusable addresses.
> > > 
> > > Similarly, the relevant support for IOMMU mappings for peripheral
> > > transfers has been hooked up in the pl330 driver for ages, so we can
> > > happily enable the DMA SMMU without that breaking anything either.
> > > 
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > 
> > When we build a kernel with 64k page size and run the ltp syscalls we
> > sporadically see a kernel crash while doing a mkfs on a connected SATA
> > drive.  This is happening every third test run on any juno-r2 device in
> > the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> > with gcc-11.
> 
> Hmm, I guess 64K pages might make a difference in that we'll chew through
> IOVA space a lot faster with small mappings...
> 
> I'll have to try to reproduce this locally, since the interesting thing
> would be knowing what DMA address it was trying to use that went wrong, but
> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> data to sift through and try to correlate - having done it before it's not
> something I'd readily ask someone else to do for me :)
> 
> On a hunch, though, does it make any difference if you remove the first
> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?

I did this change, and run the job 7 times and could not reproduce the
issue.

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 8e7a66943b01..d3148730e951 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
                         <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
                         <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
                /* Standard AXI Translation entries as programmed by EDK2 */
-               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
-                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
+               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
                             <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
                #interrupt-cells = <1>;
                interrupt-map-mask = <0 0 0 7>;


Cheers,
Anders

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Robin Murphy]

On 2021-07-30 15:34, Anders Roxell wrote:
> On 2021-07-30 13:17, Robin Murphy wrote:
>> On 2021-07-30 12:35, Anders Roxell wrote:
>>> From: Robin Murphy <robin.murphy@arm.com>
>>>
>>>> Now that PCI inbound window restrictions are handled generically between
>>>> the of_pci resource parsing and the IOMMU layer, and described in the
>>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
>>>> mappings inadvertently allocating unusable addresses.
>>>>
>>>> Similarly, the relevant support for IOMMU mappings for peripheral
>>>> transfers has been hooked up in the pl330 driver for ages, so we can
>>>> happily enable the DMA SMMU without that breaking anything either.
>>>>
>>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>>>
>>> When we build a kernel with 64k page size and run the ltp syscalls we
>>> sporadically see a kernel crash while doing a mkfs on a connected SATA
>>> drive.  This is happening every third test run on any juno-r2 device in
>>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
>>> with gcc-11.
>>
>> Hmm, I guess 64K pages might make a difference in that we'll chew through
>> IOVA space a lot faster with small mappings...
>>
>> I'll have to try to reproduce this locally, since the interesting thing
>> would be knowing what DMA address it was trying to use that went wrong, but
>> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
>> data to sift through and try to correlate - having done it before it's not
>> something I'd readily ask someone else to do for me :)
>>
>> On a hunch, though, does it make any difference if you remove the first
>> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> 
> I did this change, and run the job 7 times and could not reproduce the
> issue.

Thanks! And hold that thought; if it works then I suspect it probably is 
the best fix, but I'll double-check and write it up properly next week.

Cheers,
Robin.

> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 8e7a66943b01..d3148730e951 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
>                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
>                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
>                  /* Standard AXI Translation entries as programmed by EDK2 */
> -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
>                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
>                  #interrupt-cells = <1>;
>                  interrupt-map-mask = <0 0 0 7>;
> 
> 
> Cheers,
> Anders
> 

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Robin Murphy]

On 2021-07-30 15:34, Anders Roxell wrote:
> On 2021-07-30 13:17, Robin Murphy wrote:
>> On 2021-07-30 12:35, Anders Roxell wrote:
>>> From: Robin Murphy <robin.murphy@arm.com>
>>>
>>>> Now that PCI inbound window restrictions are handled generically between
>>>> the of_pci resource parsing and the IOMMU layer, and described in the
>>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
>>>> mappings inadvertently allocating unusable addresses.
>>>>
>>>> Similarly, the relevant support for IOMMU mappings for peripheral
>>>> transfers has been hooked up in the pl330 driver for ages, so we can
>>>> happily enable the DMA SMMU without that breaking anything either.
>>>>
>>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>>>
>>> When we build a kernel with 64k page size and run the ltp syscalls we
>>> sporadically see a kernel crash while doing a mkfs on a connected SATA
>>> drive.  This is happening every third test run on any juno-r2 device in
>>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
>>> with gcc-11.
>>
>> Hmm, I guess 64K pages might make a difference in that we'll chew through
>> IOVA space a lot faster with small mappings...
>>
>> I'll have to try to reproduce this locally, since the interesting thing
>> would be knowing what DMA address it was trying to use that went wrong, but
>> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
>> data to sift through and try to correlate - having done it before it's not
>> something I'd readily ask someone else to do for me :)
>>
>> On a hunch, though, does it make any difference if you remove the first
>> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> 
> I did this change, and run the job 7 times and could not reproduce the
> issue.

Thanks! And hold that thought; if it works then I suspect it probably is 
the best fix, but I'll double-check and write it up properly next week.

Cheers,
Robin.

> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 8e7a66943b01..d3148730e951 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
>                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
>                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
>                  /* Standard AXI Translation entries as programmed by EDK2 */
> -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
>                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
>                  #interrupt-cells = <1>;
>                  interrupt-map-mask = <0 0 0 7>;
> 
> 
> Cheers,
> Anders
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On Fri, 30 Jul 2021 at 16:44, Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2021-07-30 15:34, Anders Roxell wrote:
> > On 2021-07-30 13:17, Robin Murphy wrote:
> >> On 2021-07-30 12:35, Anders Roxell wrote:
> >>> From: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>>> Now that PCI inbound window restrictions are handled generically between
> >>>> the of_pci resource parsing and the IOMMU layer, and described in the
> >>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> >>>> mappings inadvertently allocating unusable addresses.
> >>>>
> >>>> Similarly, the relevant support for IOMMU mappings for peripheral
> >>>> transfers has been hooked up in the pl330 driver for ages, so we can
> >>>> happily enable the DMA SMMU without that breaking anything either.
> >>>>
> >>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>> When we build a kernel with 64k page size and run the ltp syscalls we
> >>> sporadically see a kernel crash while doing a mkfs on a connected SATA
> >>> drive.  This is happening every third test run on any juno-r2 device in
> >>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> >>> with gcc-11.
> >>
> >> Hmm, I guess 64K pages might make a difference in that we'll chew through
> >> IOVA space a lot faster with small mappings...
> >>
> >> I'll have to try to reproduce this locally, since the interesting thing
> >> would be knowing what DMA address it was trying to use that went wrong, but
> >> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> >> data to sift through and try to correlate - having done it before it's not
> >> something I'd readily ask someone else to do for me :)
> >>
> >> On a hunch, though, does it make any difference if you remove the first
> >> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> >
> > I did this change, and run the job 7 times and could not reproduce the
> > issue.
>
> Thanks! And hold that thought; if it works then I suspect it probably is
> the best fix, but I'll double-check and write it up properly next week.

Thank you Robin.

Cheers,
Anders

>
> Cheers,
> Robin.
>
> > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > index 8e7a66943b01..d3148730e951 100644
> > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> >                  #interrupt-cells = <1>;
> >                  interrupt-map-mask = <0 0 0 7>;
> >
> >
> > Cheers,
> > Anders
> >

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On Fri, 30 Jul 2021 at 16:44, Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2021-07-30 15:34, Anders Roxell wrote:
> > On 2021-07-30 13:17, Robin Murphy wrote:
> >> On 2021-07-30 12:35, Anders Roxell wrote:
> >>> From: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>>> Now that PCI inbound window restrictions are handled generically between
> >>>> the of_pci resource parsing and the IOMMU layer, and described in the
> >>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> >>>> mappings inadvertently allocating unusable addresses.
> >>>>
> >>>> Similarly, the relevant support for IOMMU mappings for peripheral
> >>>> transfers has been hooked up in the pl330 driver for ages, so we can
> >>>> happily enable the DMA SMMU without that breaking anything either.
> >>>>
> >>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>> When we build a kernel with 64k page size and run the ltp syscalls we
> >>> sporadically see a kernel crash while doing a mkfs on a connected SATA
> >>> drive.  This is happening every third test run on any juno-r2 device in
> >>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> >>> with gcc-11.
> >>
> >> Hmm, I guess 64K pages might make a difference in that we'll chew through
> >> IOVA space a lot faster with small mappings...
> >>
> >> I'll have to try to reproduce this locally, since the interesting thing
> >> would be knowing what DMA address it was trying to use that went wrong, but
> >> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> >> data to sift through and try to correlate - having done it before it's not
> >> something I'd readily ask someone else to do for me :)
> >>
> >> On a hunch, though, does it make any difference if you remove the first
> >> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> >
> > I did this change, and run the job 7 times and could not reproduce the
> > issue.
>
> Thanks! And hold that thought; if it works then I suspect it probably is
> the best fix, but I'll double-check and write it up properly next week.

Thank you Robin.

Cheers,
Anders

>
> Cheers,
> Robin.
>
> > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > index 8e7a66943b01..d3148730e951 100644
> > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> >                  #interrupt-cells = <1>;
> >                  interrupt-map-mask = <0 0 0 7>;
> >
> >
> > Cheers,
> > Anders
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On Fri, 30 Jul 2021 at 16:44, Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2021-07-30 15:34, Anders Roxell wrote:
> > On 2021-07-30 13:17, Robin Murphy wrote:
> >> On 2021-07-30 12:35, Anders Roxell wrote:
> >>> From: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>>> Now that PCI inbound window restrictions are handled generically between
> >>>> the of_pci resource parsing and the IOMMU layer, and described in the
> >>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> >>>> mappings inadvertently allocating unusable addresses.
> >>>>
> >>>> Similarly, the relevant support for IOMMU mappings for peripheral
> >>>> transfers has been hooked up in the pl330 driver for ages, so we can
> >>>> happily enable the DMA SMMU without that breaking anything either.
> >>>>
> >>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>> When we build a kernel with 64k page size and run the ltp syscalls we
> >>> sporadically see a kernel crash while doing a mkfs on a connected SATA
> >>> drive.  This is happening every third test run on any juno-r2 device in
> >>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> >>> with gcc-11.
> >>
> >> Hmm, I guess 64K pages might make a difference in that we'll chew through
> >> IOVA space a lot faster with small mappings...
> >>
> >> I'll have to try to reproduce this locally, since the interesting thing
> >> would be knowing what DMA address it was trying to use that went wrong, but
> >> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> >> data to sift through and try to correlate - having done it before it's not
> >> something I'd readily ask someone else to do for me :)
> >>
> >> On a hunch, though, does it make any difference if you remove the first
> >> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> >
> > I did this change, and run the job 7 times and could not reproduce the
> > issue.
>
> Thanks! And hold that thought; if it works then I suspect it probably is
> the best fix, but I'll double-check and write it up properly next week.

I just want to send a friendly reminder to this issue, since I haven't
seen a patch for this.
We still see the issue on v5.13.y and above.

Or have I missed anything?

Cheers,
Anders

>
> Cheers,
> Robin.
>
> > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > index 8e7a66943b01..d3148730e951 100644
> > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> >                  #interrupt-cells = <1>;
> >                  interrupt-map-mask = <0 0 0 7>;
> >
> >
> > Cheers,
> > Anders
> >

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Anders Roxell]

On Fri, 30 Jul 2021 at 16:44, Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2021-07-30 15:34, Anders Roxell wrote:
> > On 2021-07-30 13:17, Robin Murphy wrote:
> >> On 2021-07-30 12:35, Anders Roxell wrote:
> >>> From: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>>> Now that PCI inbound window restrictions are handled generically between
> >>>> the of_pci resource parsing and the IOMMU layer, and described in the
> >>>> Juno DT, we can finally enable the PCIe SMMU without the risk of DMA
> >>>> mappings inadvertently allocating unusable addresses.
> >>>>
> >>>> Similarly, the relevant support for IOMMU mappings for peripheral
> >>>> transfers has been hooked up in the pl330 driver for ages, so we can
> >>>> happily enable the DMA SMMU without that breaking anything either.
> >>>>
> >>>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >>>
> >>> When we build a kernel with 64k page size and run the ltp syscalls we
> >>> sporadically see a kernel crash while doing a mkfs on a connected SATA
> >>> drive.  This is happening every third test run on any juno-r2 device in
> >>> the lab with the same kernel image (stable-rc 5.13.y, mainline and next)
> >>> with gcc-11.
> >>
> >> Hmm, I guess 64K pages might make a difference in that we'll chew through
> >> IOVA space a lot faster with small mappings...
> >>
> >> I'll have to try to reproduce this locally, since the interesting thing
> >> would be knowing what DMA address it was trying to use that went wrong, but
> >> IOMMU tracepoints and/or dma-debug are going to generate an crazy amount of
> >> data to sift through and try to correlate - having done it before it's not
> >> something I'd readily ask someone else to do for me :)
> >>
> >> On a hunch, though, does it make any difference if you remove the first
> >> entry from the PCIe "dma-ranges" (the 0x2c1c0000 one)?
> >
> > I did this change, and run the job 7 times and could not reproduce the
> > issue.
>
> Thanks! And hold that thought; if it works then I suspect it probably is
> the best fix, but I'll double-check and write it up properly next week.

I just want to send a friendly reminder to this issue, since I haven't
seen a patch for this.
We still see the issue on v5.13.y and above.

Or have I missed anything?

Cheers,
Anders

>
> Cheers,
> Robin.
>
> > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > index 8e7a66943b01..d3148730e951 100644
> > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> >                  #interrupt-cells = <1>;
> >                  interrupt-map-mask = <0 0 0 7>;
> >
> >
> > Cheers,
> > Anders
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

Hi Robin,

Since we did not get a reply on this email thread.
and those intermittent failures are causing a lot of noise in reports summary.
We will wait one more week and stop running 64k page size testing on
Juno-r2 devices.

> > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > index 8e7a66943b01..d3148730e951 100644
> > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > >                  #interrupt-cells = <1>;
> > >                  interrupt-map-mask = <0 0 0 7>;
> > >

Reference email thread,
https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/

- Naresh

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

Hi Robin,

Since we did not get a reply on this email thread.
and those intermittent failures are causing a lot of noise in reports summary.
We will wait one more week and stop running 64k page size testing on
Juno-r2 devices.

> > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > index 8e7a66943b01..d3148730e951 100644
> > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > >                  #interrupt-cells = <1>;
> > >                  interrupt-map-mask = <0 0 0 7>;
> > >

Reference email thread,
https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/

- Naresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Sudeep Holla]

On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> Hi Robin,
> 
> Since we did not get a reply on this email thread.
> and those intermittent failures are causing a lot of noise in reports summary.
> We will wait one more week and stop running 64k page size testing on
> Juno-r2 devices.
> 
> > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > index 8e7a66943b01..d3148730e951 100644
> > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > >                  #interrupt-cells = <1>;
> > > >                  interrupt-map-mask = <0 0 0 7>;
> > > >
> 
> Reference email thread,
> https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> 

I was about to tag the fix for this and was just reading this thread. I will
send the pull request soon. Sorry for the delay, it is in next for some time
now. Are you seeing the issue even in linux-next ?

-- 
Regards,
Sudeep

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Sudeep Holla]

On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> Hi Robin,
> 
> Since we did not get a reply on this email thread.
> and those intermittent failures are causing a lot of noise in reports summary.
> We will wait one more week and stop running 64k page size testing on
> Juno-r2 devices.
> 
> > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > index 8e7a66943b01..d3148730e951 100644
> > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > >                  #interrupt-cells = <1>;
> > > >                  interrupt-map-mask = <0 0 0 7>;
> > > >
> 
> Reference email thread,
> https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> 

I was about to tag the fix for this and was just reading this thread. I will
send the pull request soon. Sorry for the delay, it is in next for some time
now. Are you seeing the issue even in linux-next ?

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > Hi Robin,
> >
> > Since we did not get a reply on this email thread.
> > and those intermittent failures are causing a lot of noise in reports summary.
> > We will wait one more week and stop running 64k page size testing on
> > Juno-r2 devices.
> >
> > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > >                  #interrupt-cells = <1>;
> > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > >
> >
> > Reference email thread,
> > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> >
>
> I was about to tag the fix for this and was just reading this thread. I will
> send the pull request soon. Sorry for the delay, it is in next for some time
> now. Are you seeing the issue even in linux-next ?

Due to load balance / test queue maintenance on Juno-r2 devices,
We have stopped running 64k page testing on mainline and next instead
running on stable-rc builds.

Allow me a day to test Linux next 64k page size build testing on
Juno-r2 and get back to you.

- Naresh

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > Hi Robin,
> >
> > Since we did not get a reply on this email thread.
> > and those intermittent failures are causing a lot of noise in reports summary.
> > We will wait one more week and stop running 64k page size testing on
> > Juno-r2 devices.
> >
> > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > >                  #interrupt-cells = <1>;
> > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > >
> >
> > Reference email thread,
> > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> >
>
> I was about to tag the fix for this and was just reading this thread. I will
> send the pull request soon. Sorry for the delay, it is in next for some time
> now. Are you seeing the issue even in linux-next ?

Due to load balance / test queue maintenance on Juno-r2 devices,
We have stopped running 64k page testing on mainline and next instead
running on stable-rc builds.

Allow me a day to test Linux next 64k page size build testing on
Juno-r2 and get back to you.

- Naresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

Hi Sudeep,

On Mon, 14 Feb 2022 at 20:41, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > > Hi Robin,
> > >
> > > Since we did not get a reply on this email thread.
> > > and those intermittent failures are causing a lot of noise in reports summary.
> > > We will wait one more week and stop running 64k page size testing on
> > > Juno-r2 devices.
> > >
> > > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > > >                  #interrupt-cells = <1>;
> > > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > > >
> > >
> > > Reference email thread,
> > > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> > >
> >
> > I was about to tag the fix for this and was just reading this thread. I will
> > send the pull request soon. Sorry for the delay, it is in next for some time
> > now. Are you seeing the issue even in linux-next ?

I have tested Linux next arm64 64k page size builds on Juno-r2 and confirm that
the reported issue is fixed now.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

- Naresh Kamboju

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Naresh Kamboju]

Hi Sudeep,

On Mon, 14 Feb 2022 at 20:41, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > > Hi Robin,
> > >
> > > Since we did not get a reply on this email thread.
> > > and those intermittent failures are causing a lot of noise in reports summary.
> > > We will wait one more week and stop running 64k page size testing on
> > > Juno-r2 devices.
> > >
> > > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > > >                  #interrupt-cells = <1>;
> > > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > > >
> > >
> > > Reference email thread,
> > > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> > >
> >
> > I was about to tag the fix for this and was just reading this thread. I will
> > send the pull request soon. Sorry for the delay, it is in next for some time
> > now. Are you seeing the issue even in linux-next ?

I have tested Linux next arm64 64k page size builds on Juno-r2 and confirm that
the reported issue is fixed now.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

- Naresh Kamboju

--
Linaro LKFT
https://lkft.linaro.org

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Sudeep Holla]

On Wed, Feb 16, 2022 at 05:02:53PM +0530, Naresh Kamboju wrote:
> Hi Sudeep,
> 
> On Mon, 14 Feb 2022 at 20:41, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
> > >
> > > On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > > > Hi Robin,
> > > >
> > > > Since we did not get a reply on this email thread.
> > > > and those intermittent failures are causing a lot of noise in reports summary.
> > > > We will wait one more week and stop running 64k page size testing on
> > > > Juno-r2 devices.
> > > >
> > > > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > > > >                  #interrupt-cells = <1>;
> > > > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > > > >
> > > >
> > > > Reference email thread,
> > > > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> > > >
> > >
> > > I was about to tag the fix for this and was just reading this thread. I will
> > > send the pull request soon. Sorry for the delay, it is in next for some time
> > > now. Are you seeing the issue even in linux-next ?
> 
> I have tested Linux next arm64 64k page size builds on Juno-r2 and confirm that
> the reported issue is fixed now.
> 
> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

Thanks for testing. I have already sent the pull request to Arnd yesterday.

-- 
Regards,
Sudeep

Re: [PATCH 2/2] arm64: dts: juno: Enable more SMMUs

[Sudeep Holla]

On Wed, Feb 16, 2022 at 05:02:53PM +0530, Naresh Kamboju wrote:
> Hi Sudeep,
> 
> On Mon, 14 Feb 2022 at 20:41, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Mon, 14 Feb 2022 at 19:43, Sudeep Holla <sudeep.holla@arm.com> wrote:
> > >
> > > On Mon, Feb 14, 2022 at 07:36:00PM +0530, Naresh Kamboju wrote:
> > > > Hi Robin,
> > > >
> > > > Since we did not get a reply on this email thread.
> > > > and those intermittent failures are causing a lot of noise in reports summary.
> > > > We will wait one more week and stop running 64k page size testing on
> > > > Juno-r2 devices.
> > > >
> > > > > > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > index 8e7a66943b01..d3148730e951 100644
> > > > > > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > > > > > @@ -545,8 +545,7 @@ pcie_ctlr: pcie@40000000 {
> > > > > > >                           <0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000>,
> > > > > > >                           <0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > > > > > >                  /* Standard AXI Translation entries as programmed by EDK2 */
> > > > > > > -               dma-ranges = <0x02000000 0x0 0x2c1c0000 0x0 0x2c1c0000 0x0 0x00040000>,
> > > > > > > -                            <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > > +               dma-ranges = <0x02000000 0x0 0x80000000 0x0 0x80000000 0x0 0x80000000>,
> > > > > > >                               <0x43000000 0x8 0x00000000 0x8 0x00000000 0x2 0x00000000>;
> > > > > > >                  #interrupt-cells = <1>;
> > > > > > >                  interrupt-map-mask = <0 0 0 7>;
> > > > > > >
> > > >
> > > > Reference email thread,
> > > > https://lore.kernel.org/stable/0a1d437d-9ea0-de83-3c19-e07f560ad37c@arm.com/
> > > >
> > >
> > > I was about to tag the fix for this and was just reading this thread. I will
> > > send the pull request soon. Sorry for the delay, it is in next for some time
> > > now. Are you seeing the issue even in linux-next ?
> 
> I have tested Linux next arm64 64k page size builds on Juno-r2 and confirm that
> the reported issue is fixed now.
> 
> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

Thanks for testing. I have already sent the pull request to Arnd yesterday.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

[Sudeep Holla]

On Fri, 5 Mar 2021 17:33:17 +0000, Robin Murphy wrote:
> The PLDA root complex on Juno relies on an address-based lookup table to
> generate AXI attributes for inbound PCI transactions, and as such will
> not pass any transaction not matching any programmed address range. The
> standard firmware configuration programs 3 entries covering the GICv2m
> MSI doorbell and the 2 DRAM regions, so add a "dma-ranges" property to
> describe those usable inbound windows.


Applied to sudeep.holla/linux (master), thanks!

[1/2] arm64: dts: juno: Describe PCI dma-ranges
      https://git.kernel.org/sudeep.holla/c/7c93556605
[2/2] arm64: dts: juno: Enable more SMMUs
      https://git.kernel.org/sudeep.holla/c/68a28da891

--

Regards,
Sudeep


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

[Sudeep Holla]

On Fri, 5 Mar 2021 17:33:17 +0000, Robin Murphy wrote:
> The PLDA root complex on Juno relies on an address-based lookup table to
> generate AXI attributes for inbound PCI transactions, and as such will
> not pass any transaction not matching any programmed address range. The
> standard firmware configuration programs 3 entries covering the GICv2m
> MSI doorbell and the 2 DRAM regions, so add a "dma-ranges" property to
> describe those usable inbound windows.


(New commit info after rebase to v5.12-rc2 for obvious reasons)
Applied to sudeep.holla/linux (for-next/juno), thanks!

[1/2] arm64: dts: juno: Describe PCI dma-ranges
https://git.kernel.org/sudeep.holla/c/4ac4d146cb
[2/2] arm64: dts: juno: Enable more SMMUs
https://git.kernel.org/sudeep.holla/c/d9df28ba58

--
Regards,
Sudeep

Re: [PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

[Sudeep Holla]

On Fri, 5 Mar 2021 17:33:17 +0000, Robin Murphy wrote:
> The PLDA root complex on Juno relies on an address-based lookup table to
> generate AXI attributes for inbound PCI transactions, and as such will
> not pass any transaction not matching any programmed address range. The
> standard firmware configuration programs 3 entries covering the GICv2m
> MSI doorbell and the 2 DRAM regions, so add a "dma-ranges" property to
> describe those usable inbound windows.


(New commit info after rebase to v5.12-rc2 for obvious reasons)
Applied to sudeep.holla/linux (for-next/juno), thanks!

[1/2] arm64: dts: juno: Describe PCI dma-ranges
https://git.kernel.org/sudeep.holla/c/4ac4d146cb
[2/2] arm64: dts: juno: Enable more SMMUs
https://git.kernel.org/sudeep.holla/c/d9df28ba58

--
Regards,
Sudeep


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel