[Qemu-devel] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

[Qemu-devel] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

[Ján Veselý]

Device communication errors need to be reported to driver.
Add a debug message while at it.

Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
---
 hw/usb/hcd-ohci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
struct ohci_ed *ed)
             switch (ret) {
             case USB_RET_IOERROR:
             case USB_RET_NODEV:
+                DPRINTF("usb-ohci: got DEV ERROR\n");
                 OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
+                break;
             case USB_RET_NAK:
                 DPRINTF("usb-ohci: got NAK\n");
                 return 1;
-- 
1.8.1.5

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

[Michael Tokarev]

22.09.2013 00:26, Ján Veselý wrote:
> Device communication errors need to be reported to driver.
> Add a debug message while at it.
>
> Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
> ---
>   hw/usb/hcd-ohci.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 35f0878..0396e33 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
> struct ohci_ed *ed)
>               switch (ret) {
>               case USB_RET_IOERROR:
>               case USB_RET_NODEV:
> +                DPRINTF("usb-ohci: got DEV ERROR\n");

why is this "DEV ERROR" ?  Note it is about 2 case statements, not one.

>                   OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
> +                break;
>               case USB_RET_NAK:
>                   DPRINTF("usb-ohci: got NAK\n");
>                   return 1;

While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this.  If he's okay
I'll pick it up.

Thanks,

/mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

[Gerd Hoffmann]

  Hi,

> While the actual interesting change (adding break) looks
> correct, and the whole thing is trivial indeed, this area
> has a maintainer, -- Cc'ing Gerd for this.  If he's okay
> I'll pick it up.

Patch is fine.

Acked-by: Gerd Hoffmann <kraxel@gmail.com>

cheers,
  Gerd

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

[Michael Tokarev]

30.09.2013 10:32, Gerd Hoffmann wrote:
>    Hi,
>
>> While the actual interesting change (adding break) looks
>> correct, and the whole thing is trivial indeed, this area
>> has a maintainer, -- Cc'ing Gerd for this.  If he's okay
>> I'll pick it up.
>
> Patch is fine.

No, I didn't ask whenever the patch is fine, I wanted to
ensure you wont blame me for accepting a trivial patch
for an area which has an active maintainer... ;)

Thanks, queued up for trivial-patches!

/mjt