From: Tomasz Figa <tomasz.figa@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH v2] clk: samsung: Remove useless check for return value of samsung_clk_init
Date: Sat, 18 Jun 2016 23:35:15 +0900 [thread overview]
Message-ID: <CA+Ln22GCD+DeeaB0J_S8ZE7UXWPjFghSHjG_Q4FLA9EoqdDp2w@mail.gmail.com> (raw)
In-Reply-To: <1462815151-14396-1-git-send-email-krzk@kernel.org>
Hi,
2016-05-10 2:32 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
> The samsung_clk_init() cannot return NULL. Either it returns allocated
> memory or it panics.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes since v1:
> 1. Remove the check from most of other Samsung clock drivers (suggested
> by Javier).
> ---
> drivers/clk/samsung/clk-exynos4.c | 2 --
> drivers/clk/samsung/clk-exynos5250.c | 3 +--
> drivers/clk/samsung/clk-exynos5420.c | 2 --
> drivers/clk/samsung/clk-exynos5440.c | 2 --
> drivers/clk/samsung/clk-s3c2410.c | 2 --
> drivers/clk/samsung/clk-s3c2412.c | 2 --
> drivers/clk/samsung/clk-s3c2443.c | 2 --
> drivers/clk/samsung/clk-s3c64xx.c | 2 --
> drivers/clk/samsung/clk-s5pv210.c | 2 --
> 9 files changed, 1 insertion(+), 18 deletions(-)
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: samsung: Remove useless check for return value of samsung_clk_init
Date: Sat, 18 Jun 2016 23:35:15 +0900 [thread overview]
Message-ID: <CA+Ln22GCD+DeeaB0J_S8ZE7UXWPjFghSHjG_Q4FLA9EoqdDp2w@mail.gmail.com> (raw)
In-Reply-To: <1462815151-14396-1-git-send-email-krzk@kernel.org>
Hi,
2016-05-10 2:32 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
> The samsung_clk_init() cannot return NULL. Either it returns allocated
> memory or it panics.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes since v1:
> 1. Remove the check from most of other Samsung clock drivers (suggested
> by Javier).
> ---
> drivers/clk/samsung/clk-exynos4.c | 2 --
> drivers/clk/samsung/clk-exynos5250.c | 3 +--
> drivers/clk/samsung/clk-exynos5420.c | 2 --
> drivers/clk/samsung/clk-exynos5440.c | 2 --
> drivers/clk/samsung/clk-s3c2410.c | 2 --
> drivers/clk/samsung/clk-s3c2412.c | 2 --
> drivers/clk/samsung/clk-s3c2443.c | 2 --
> drivers/clk/samsung/clk-s3c64xx.c | 2 --
> drivers/clk/samsung/clk-s5pv210.c | 2 --
> 9 files changed, 1 insertion(+), 18 deletions(-)
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2016-06-18 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 17:32 [PATCH v2] clk: samsung: Remove useless check for return value of samsung_clk_init Krzysztof Kozlowski
2016-05-09 17:32 ` Krzysztof Kozlowski
2016-06-18 14:35 ` Tomasz Figa [this message]
2016-06-18 14:35 ` Tomasz Figa
2016-06-18 14:35 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Ln22GCD+DeeaB0J_S8ZE7UXWPjFghSHjG_Q4FLA9EoqdDp2w@mail.gmail.com \
--to=tomasz.figa@gmail.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.