[PATCH V12 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

[PATCH V12 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

[Leela Krishna Amudala]

This patchset does the following things
	- Adds pmusysreg device node to exynos5.dtsi file
	- Adds watchdog DT nodes to Exynos5250 and 5420
	- Uses syscon regmap interface to configure pmu registers
	  to mask/unmask enable/disable of watchdog.
	
This patch set is rebased on Kgene's for-next branch and tested on SMDK5420

changes since V11:
	- Added EXYNOS5 prefix to REG_OFFSET defines (suggested by Tomasz)
	- NEEDS_PMU_CONFIG => HAS_PMU_CONFIG (suggested by Olof, Guenter)
	- Move QUIRK_HAS_PMU_CONFIG check to s3c2410wdt_mask_and_disable_reset (suggested by Guenter)

changes since V10:
	- followed coding style rules
	- removed duplicate error message suggested by Guenter Roeck <linux@roeck-us.net>

changes since V9:
	- added descriptions to s3c2410_wdt_variant structure fields
	- moved calling s3c2410wdt_mask_and_disable_reset() function above s3c2410wdt_start() call in probe
	- put dev_err message back to s3c2410wdt_mask_and_disable_reset() function
	  (suggested by Doug Anderson <dianders@chromium.org>)

changes since V8:
	- modified the patch description for the below patch
	  "watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register"
	- removed MODULE_ALIAS in watchdog driver
	- changed dev_warn to dev_err in one failure case handling (suggested by Guenter Roeck <linux@roeck-us.net>)
	- renamed variable name from pmu_config to drv_data
	- changed the compatible field description in documentation file
	  (suggested by Tomasz Figa <t.figa@samsung.com>)

changes since V7:
	- re-ordered the patches in the series
	- moved pmu_config_s3c2410 structure out of ifdef CONFIG_OF
	  and limited only this structure to platform match table
	- renamed structure name from s3c_wdt_driver_ids to s3c2410_wdt_ids
	- removed exynos variants from platform match table
	  (suggested by Tomasz Figa <t.figa@samsung.com>)

changes since V6:
	- added SoC-specific compatible value to syscon node and documented it
	- given more patch description for below patch
	  ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
	- added platform_device_id array for watchdog devices
	- selected MFD_SYSCON in Kconfig entry for watchdog

Changes since V5:
	- removed status property in DT nodes
	- changed the return type for the function s3c2410wdt_mask_and_disable_reset()
	  and handled error cases
	- Handled to get driver data in non-DT cases
	- Addressed comments given by Tomasz Figa <t.figa@samsung.com>

Changes since V4:
	- changed the node name from pmusysreg to syscon and node label from pmu_sys_reg to pmu_syscon
	- changed the property name from samsung,pmusysreg to samsung,syscon-phandle
	- used regmap_update_bits instead of remap_read/regmap_write
	- Addressed other comments given by Tomasz Figa <t.figa@samsung.com>

Changes since V3:
	- changed the compatible strings for watchdog node
	- splitted up adding pmusysreg node and made it separate patch
	- Addressed comments given by Sachin Kamat <sachin.kamat@linaro.org>

Changes since V2:
	- used syscon regmap interface to configure pmu registers in WDT driver
	  (suggested by Tomasz Figa <t.figa@samsung.com>)

Changes since V1:
        - Added new compatible string for Exynos5 SoCs
        - Introduced quirk mechanism to program PMU registers
        - Addressed comments given by Tomasz Figa <t.figa@samsung.com>

Leela Krishna Amudala (3):
  ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
  watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
    register
  ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

 .../devicetree/bindings/arm/samsung/pmu.txt        |   15 ++
 .../devicetree/bindings/watchdog/samsung-wdt.txt   |   21 ++-
 arch/arm/boot/dts/exynos5.dtsi                     |    7 -
 arch/arm/boot/dts/exynos5250.dtsi                  |   11 +-
 arch/arm/boot/dts/exynos5420.dtsi                  |   14 ++
 drivers/watchdog/Kconfig                           |    1 +
 drivers/watchdog/s3c2410_wdt.c                     |  154 ++++++++++++++++++--
 7 files changed, 205 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt

-- 
1.7.10.4

[PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Leela Krishna Amudala]

This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
handle PMU register accesses in a centralized way using syscon driver

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
---
 Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
 arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
 3 files changed, 25 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
new file mode 100644
index 0000000..f1f1552
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
@@ -0,0 +1,15 @@
+SAMSUNG Exynos SoC series PMU Registers
+
+Properties:
+ - compatible : should contain two values. First value must be one from following list:
+		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
+		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+		second value must be always "syscon".
+
+ - reg : offset and length of the register set.
+
+Example :
+pmu_system_controller: system-controller@10040000 {
+	compatible = "samsung,exynos5250-pmu", "syscon";
+	reg = <0x10040000 0x5000>;
+};
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index b98ffc3..62f9e36 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -163,6 +163,11 @@
 		interrupts = <0 47 0>;
 	};
 
+	pmu_system_controller: system-controller@10040000 {
+		compatible = "samsung,exynos5250-pmu", "syscon";
+		reg = <0x10040000 0x5000>;
+	};
+
 	watchdog {
 		clocks = <&clock 336>;
 		clock-names = "watchdog";
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b1fa334..cd47db0 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -402,4 +402,9 @@
 		clock-names = "gscl";
 		samsung,power-domain = <&gsc_pd>;
 	};
+
+	pmu_system_controller: system-controller@10040000 {
+		compatible = "samsung,exynos5420-pmu", "syscon";
+		reg = <0x10040000 0x5000>;
+	};
 };
-- 
1.7.10.4

[PATCH V12 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

[Leela Krishna Amudala]

Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap interface
to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers of PMU
to mask/unmask enable/disable of watchdog in probe and s2r scenarios.

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 .../devicetree/bindings/watchdog/samsung-wdt.txt   |   21 ++-
 drivers/watchdog/Kconfig                           |    1 +
 drivers/watchdog/s3c2410_wdt.c                     |  154 ++++++++++++++++++--
 3 files changed, 166 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
index 2aa486c..cfff375 100644
--- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
@@ -5,10 +5,29 @@ after a preset amount of time during which the WDT reset event has not
 occurred.
 
 Required properties:
-- compatible : should be "samsung,s3c2410-wdt"
+- compatible : should be one among the following
+	(a) "samsung,s3c2410-wdt" for Exynos4 and previous SoCs
+	(b) "samsung,exynos5250-wdt" for Exynos5250
+	(c) "samsung,exynos5420-wdt" for Exynos5420
+
 - reg : base physical address of the controller and length of memory mapped
 	region.
 - interrupts : interrupt number to the cpu.
+- samsung,syscon-phandle : reference to syscon node (This property required only
+	in case of compatible being "samsung,exynos5250-wdt" or "samsung,exynos5420-wdt".
+	In case of Exynos5250 and 5420 this property points to syscon node holding the PMU
+	base address)
 
 Optional properties:
 - timeout-sec : contains the watchdog timeout in seconds.
+
+Example:
+
+watchdog@101D0000 {
+	compatible = "samsung,exynos5250-wdt";
+	reg = <0x101D0000 0x100>;
+	interrupts = <0 42 0>;
+	clocks = <&clock 336>;
+	clock-names = "watchdog";
+	samsung,syscon-phandle = <&pmu_syscon>;
+};
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 5be6e91..24738c0 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -188,6 +188,7 @@ config S3C2410_WATCHDOG
 	tristate "S3C2410 Watchdog"
 	depends on HAVE_S3C2410_WATCHDOG
 	select WATCHDOG_CORE
+	select MFD_SYSCON if ARCH_EXYNOS5
 	help
 	  Watchdog timer block in the Samsung SoCs. This will reboot
 	  the system when the timer expires with the watchdog enabled.
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index 7d8fd04..e1b1a75 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -40,6 +40,8 @@
 #include <linux/slab.h>
 #include <linux/err.h>
 #include <linux/of.h>
+#include <linux/mfd/syscon.h>
+#include <linux/regmap.h>
 
 #define S3C2410_WTCON		0x00
 #define S3C2410_WTDAT		0x04
@@ -60,6 +62,10 @@
 #define CONFIG_S3C2410_WATCHDOG_ATBOOT		(0)
 #define CONFIG_S3C2410_WATCHDOG_DEFAULT_TIME	(15)
 
+#define EXYNOS5_WDT_DISABLE_REG_OFFSET		0x0408
+#define EXYNOS5_WDT_MASK_RESET_REG_OFFSET	0x040c
+#define QUIRK_HAS_PMU_CONFIG			(1 << 0)
+
 static bool nowayout	= WATCHDOG_NOWAYOUT;
 static int tmr_margin;
 static int tmr_atboot	= CONFIG_S3C2410_WATCHDOG_ATBOOT;
@@ -83,6 +89,25 @@ MODULE_PARM_DESC(soft_noboot, "Watchdog action, set to 1 to ignore reboots, "
 			"0 to reboot (default 0)");
 MODULE_PARM_DESC(debug, "Watchdog debug, set to >1 for debug (default 0)");
 
+/**
+ * struct s3c2410_wdt_variant - Per-variant config data
+ *
+ * @disable_reg: Offset in pmureg for the register that disables the watchdog
+ * timer reset functionality.
+ * @mask_reset_reg: Offset in pmureg for the register that masks the watchdog
+ * timer reset functionality.
+ * @mask_bit: Bit number for the watchdog timer in the disable register and the
+ * mask reset register.
+ * @quirks: A bitfield of quirks.
+ */
+
+struct s3c2410_wdt_variant {
+	int disable_reg;
+	int mask_reset_reg;
+	int mask_bit;
+	u32 quirks;
+};
+
 struct s3c2410_wdt {
 	struct device		*dev;
 	struct clk		*clock;
@@ -93,7 +118,49 @@ struct s3c2410_wdt {
 	unsigned long		wtdat_save;
 	struct watchdog_device	wdt_device;
 	struct notifier_block	freq_transition;
+	struct s3c2410_wdt_variant *drv_data;
+	struct regmap *pmureg;
+};
+
+static const struct s3c2410_wdt_variant drv_data_s3c2410 = {
+	.quirks = 0
+};
+
+#ifdef CONFIG_OF
+static const struct s3c2410_wdt_variant drv_data_exynos5250  = {
+	.disable_reg = EXYNOS5_WDT_DISABLE_REG_OFFSET,
+	.mask_reset_reg = EXYNOS5_WDT_MASK_RESET_REG_OFFSET,
+	.mask_bit = 20,
+	.quirks = QUIRK_HAS_PMU_CONFIG
+};
+
+static const struct s3c2410_wdt_variant drv_data_exynos5420 = {
+	.disable_reg = EXYNOS5_WDT_DISABLE_REG_OFFSET,
+	.mask_reset_reg = EXYNOS5_WDT_MASK_RESET_REG_OFFSET,
+	.mask_bit = 0,
+	.quirks = QUIRK_HAS_PMU_CONFIG
+};
+
+static const struct of_device_id s3c2410_wdt_match[] = {
+	{ .compatible = "samsung,s3c2410-wdt",
+	  .data = &drv_data_s3c2410 },
+	{ .compatible = "samsung,exynos5250-wdt",
+	  .data = &drv_data_exynos5250 },
+	{ .compatible = "samsung,exynos5420-wdt",
+	  .data = &drv_data_exynos5420 },
+	{},
 };
+MODULE_DEVICE_TABLE(of, s3c2410_wdt_match);
+#endif
+
+static const struct platform_device_id s3c2410_wdt_ids[] = {
+	{
+		.name = "s3c2410-wdt",
+		.driver_data = (unsigned long)&drv_data_s3c2410,
+	},
+	{}
+};
+MODULE_DEVICE_TABLE(platform, s3c2410_wdt_ids);
 
 /* watchdog control routines */
 
@@ -110,6 +177,35 @@ static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb)
 	return container_of(nb, struct s3c2410_wdt, freq_transition);
 }
 
+static int s3c2410wdt_mask_and_disable_reset(struct s3c2410_wdt *wdt, bool mask)
+{
+	int ret;
+	u32 mask_val = 1 << wdt->drv_data->mask_bit;
+	u32 val = 0;
+
+	/* No need to do anything if no PMU CONFIG needed */
+	if (!(wdt->drv_data->quirks & QUIRK_HAS_PMU_CONFIG))
+		return 0;
+
+	if (mask)
+		val = mask_val;
+
+	ret = regmap_update_bits(wdt->pmureg,
+			wdt->drv_data->disable_reg,
+			mask_val, val);
+	if (ret < 0)
+		goto error;
+
+	ret = regmap_update_bits(wdt->pmureg,
+			wdt->drv_data->mask_reset_reg,
+			mask_val, val);
+ error:
+	if (ret < 0)
+		dev_err(wdt->dev, "failed to update reg(%d)\n", ret);
+
+	return ret;
+}
+
 static int s3c2410wdt_keepalive(struct watchdog_device *wdd)
 {
 	struct s3c2410_wdt *wdt = watchdog_get_drvdata(wdd);
@@ -331,6 +427,20 @@ static inline void s3c2410wdt_cpufreq_deregister(struct s3c2410_wdt *wdt)
 }
 #endif
 
+/* s3c2410_get_wdt_driver_data */
+static inline struct s3c2410_wdt_variant *
+get_wdt_drv_data(struct platform_device *pdev)
+{
+	if (pdev->dev.of_node) {
+		const struct of_device_id *match;
+		match = of_match_node(s3c2410_wdt_match, pdev->dev.of_node);
+		return (struct s3c2410_wdt_variant *)match->data;
+	} else {
+		return (struct s3c2410_wdt_variant *)
+			platform_get_device_id(pdev)->driver_data;
+	}
+}
+
 static int s3c2410wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev;
@@ -353,6 +463,16 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
 	spin_lock_init(&wdt->lock);
 	wdt->wdt_device = s3c2410_wdd;
 
+	wdt->drv_data = get_wdt_drv_data(pdev);
+	if (wdt->drv_data->quirks & QUIRK_HAS_PMU_CONFIG) {
+		wdt->pmureg = syscon_regmap_lookup_by_phandle(dev->of_node,
+						"samsung,syscon-phandle");
+		if (IS_ERR(wdt->pmureg)) {
+			dev_err(dev, "syscon regmap lookup failed.\n");
+			return PTR_ERR(wdt->pmureg);
+		}
+	}
+
 	wdt_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	if (wdt_irq == NULL) {
 		dev_err(dev, "no irq resource specified\n");
@@ -421,6 +541,10 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
 		goto err_cpufreq;
 	}
 
+	ret = s3c2410wdt_mask_and_disable_reset(wdt, false);
+	if (ret < 0)
+		goto err_unregister;
+
 	if (tmr_atboot && started == 0) {
 		dev_info(dev, "starting watchdog timer\n");
 		s3c2410wdt_start(&wdt->wdt_device);
@@ -445,6 +569,9 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
 
 	return 0;
 
+ err_unregister:
+	watchdog_unregister_device(&wdt->wdt_device);
+
  err_cpufreq:
 	s3c2410wdt_cpufreq_deregister(wdt);
 
@@ -458,8 +585,13 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
 
 static int s3c2410wdt_remove(struct platform_device *dev)
 {
+	int ret;
 	struct s3c2410_wdt *wdt = platform_get_drvdata(dev);
 
+	ret = s3c2410wdt_mask_and_disable_reset(wdt, true);
+	if (ret < 0)
+		return ret;
+
 	watchdog_unregister_device(&wdt->wdt_device);
 
 	s3c2410wdt_cpufreq_deregister(wdt);
@@ -474,6 +606,8 @@ static void s3c2410wdt_shutdown(struct platform_device *dev)
 {
 	struct s3c2410_wdt *wdt = platform_get_drvdata(dev);
 
+	s3c2410wdt_mask_and_disable_reset(wdt, true);
+
 	s3c2410wdt_stop(&wdt->wdt_device);
 }
 
@@ -481,12 +615,17 @@ static void s3c2410wdt_shutdown(struct platform_device *dev)
 
 static int s3c2410wdt_suspend(struct device *dev)
 {
+	int ret;
 	struct s3c2410_wdt *wdt = dev_get_drvdata(dev);
 
 	/* Save watchdog state, and turn it off. */
 	wdt->wtcon_save = readl(wdt->reg_base + S3C2410_WTCON);
 	wdt->wtdat_save = readl(wdt->reg_base + S3C2410_WTDAT);
 
+	ret = s3c2410wdt_mask_and_disable_reset(wdt, true);
+	if (ret < 0)
+		return ret;
+
 	/* Note that WTCNT doesn't need to be saved. */
 	s3c2410wdt_stop(&wdt->wdt_device);
 
@@ -495,6 +634,7 @@ static int s3c2410wdt_suspend(struct device *dev)
 
 static int s3c2410wdt_resume(struct device *dev)
 {
+	int ret;
 	struct s3c2410_wdt *wdt = dev_get_drvdata(dev);
 
 	/* Restore watchdog state. */
@@ -502,6 +642,10 @@ static int s3c2410wdt_resume(struct device *dev)
 	writel(wdt->wtdat_save, wdt->reg_base + S3C2410_WTCNT);/* Reset count */
 	writel(wdt->wtcon_save, wdt->reg_base + S3C2410_WTCON);
 
+	ret = s3c2410wdt_mask_and_disable_reset(wdt, false);
+	if (ret < 0)
+		return ret;
+
 	dev_info(dev, "watchdog %sabled\n",
 		(wdt->wtcon_save & S3C2410_WTCON_ENABLE) ? "en" : "dis");
 
@@ -512,18 +656,11 @@ static int s3c2410wdt_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(s3c2410wdt_pm_ops, s3c2410wdt_suspend,
 			s3c2410wdt_resume);
 
-#ifdef CONFIG_OF
-static const struct of_device_id s3c2410_wdt_match[] = {
-	{ .compatible = "samsung,s3c2410-wdt" },
-	{},
-};
-MODULE_DEVICE_TABLE(of, s3c2410_wdt_match);
-#endif
-
 static struct platform_driver s3c2410wdt_driver = {
 	.probe		= s3c2410wdt_probe,
 	.remove		= s3c2410wdt_remove,
 	.shutdown	= s3c2410wdt_shutdown,
+	.id_table	= s3c2410_wdt_ids,
 	.driver		= {
 		.owner	= THIS_MODULE,
 		.name	= "s3c2410-wdt",
@@ -538,4 +675,3 @@ MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>, "
 	      "Dimitry Andric <dimitry.andric@tomtom.com>");
 MODULE_DESCRIPTION("S3C2410 Watchdog Device Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:s3c2410-wdt");
-- 
1.7.10.4

[PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

[Leela Krishna Amudala]

In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
watchdog timer which is not the case with s3c series SoCs so, there is a
need to have different compatible names for watchdog to handle these pmu
registers access.

Hence this patch removes watchdog node from Exynos5.dtsi common file and
make it separate by updating existing node in Exynos5250 and adding new node
to Exynos5420. This patch also makes the watchdog node enabled by default

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
---
 arch/arm/boot/dts/exynos5.dtsi    |    7 -------
 arch/arm/boot/dts/exynos5250.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5420.dtsi |    9 +++++++++
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index e52b038..f1fea28 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -81,13 +81,6 @@
 		status = "disabled";
 	};
 
-	watchdog {
-		compatible = "samsung,s3c2410-wdt";
-		reg = <0x101D0000 0x100>;
-		interrupts = <0 42 0>;
-		status = "disabled";
-	};
-
 	fimd@14400000 {
 		compatible = "samsung,exynos5250-fimd";
 		interrupt-parent = <&combiner>;
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 62f9e36..d440a9a 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -168,9 +168,13 @@
 		reg = <0x10040000 0x5000>;
 	};
 
-	watchdog {
+	watchdog@101D0000 {
+		compatible = "samsung,exynos5250-wdt";
+		reg = <0x101D0000 0x100>;
+		interrupts = <0 42 0>;
 		clocks = <&clock 336>;
 		clock-names = "watchdog";
+		samsung,syscon-phandle = <&pmu_system_controller>;
 	};
 
 	g2d@10850000 {
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index cd47db0..167480c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -407,4 +407,13 @@
 		compatible = "samsung,exynos5420-pmu", "syscon";
 		reg = <0x10040000 0x5000>;
 	};
+
+        watchdog@101D0000 {
+		compatible = "samsung,exynos5420-wdt";
+		reg = <0x101D0000 0x100>;
+		interrupts = <0 42 0>;
+		clocks = <&clock 316>;
+		clock-names = "watchdog";
+		samsung,syscon-phandle = <&pmu_system_controller>;
+        };
 };
-- 
1.7.10.4

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Doug Anderson]

Leela Krishna,

On Thu, Dec 5, 2013 at 9:47 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
> handle PMU register accesses in a centralized way using syscon driver
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
> ---
>  Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
>  arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>  arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> new file mode 100644
> index 0000000..f1f1552
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> @@ -0,0 +1,15 @@
> +SAMSUNG Exynos SoC series PMU Registers
> +
> +Properties:
> + - compatible : should contain two values. First value must be one from following list:
> +                  - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
> +                  - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
> +               second value must be always "syscon".
> +
> + - reg : offset and length of the register set.
> +
> +Example :
> +pmu_system_controller: system-controller@10040000 {
> +       compatible = "samsung,exynos5250-pmu", "syscon";
> +       reg = <0x10040000 0x5000>;
> +};

This looks right to me based on previous discussion.  Hopefully Olof
and/or Tomasz can indicate that they're happy with it now.

-Doug

Re: [PATCH V12 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

[Doug Anderson]

Leela Krishna,

On Thu, Dec 5, 2013 at 9:47 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap interface
> to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers of PMU
> to mask/unmask enable/disable of watchdog in probe and s2r scenarios.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  .../devicetree/bindings/watchdog/samsung-wdt.txt   |   21 ++-
>  drivers/watchdog/Kconfig                           |    1 +
>  drivers/watchdog/s3c2410_wdt.c                     |  154 ++++++++++++++++++--
>  3 files changed, 166 insertions(+), 10 deletions(-)

Thank you for incorporating the fixups.

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Sylwester Nawrocki]

Hi,

Just a few minor comments...

On 12/06/2013 06:47 AM, Leela Krishna Amudala wrote:
> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to

s/pmusysreg/PMU sysreg ? Similarly I would capitalize it in the subject
line as well.

> handle PMU register accesses in a centralized way using syscon driver
>
> Signed-off-by: Leela Krishna Amudala<l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Tomasz Figa<t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Doug Anderson<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Doug Anderson<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
>   Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
>   arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>   arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>   3 files changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> new file mode 100644
> index 0000000..f1f1552
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt

I might be easy to confuse this with ARM Performance Monitoring Unit.
So perhaps we should rename this file to, e.g. power-management-unit.txt ?

> @@ -0,0 +1,15 @@
> +SAMSUNG Exynos SoC series PMU Registers

s/PMU/Power Management Unit ?

> +
> +Properties:
> + - compatible : should contain two values. First value must be one from following list:
> +		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
> +		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.

s/./; ?

> +		second value must be always "syscon".

It might be more safe to specify it as the last value, so something along
the lines of:

	The last value should be "syscon".

> +
> + - reg : offset and length of the register set.
> +
> +Example :
> +pmu_system_controller: system-controller@10040000 {

Might be more sensible to use 'power_management_unit' for the label.

> +	compatible = "samsung,exynos5250-pmu", "syscon";
> +	reg =<0x10040000 0x5000>;
> +};
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index b98ffc3..62f9e36 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -163,6 +163,11 @@
>   		interrupts =<0 47 0>;
>   	};
>
> +	pmu_system_controller: system-controller@10040000 {

s/pmu_system_controller/power_management_unit ? So it describes the 
subsystem
better in terms used in the SoCs User Manual ?

> +		compatible = "samsung,exynos5250-pmu", "syscon";
> +		reg =<0x10040000 0x5000>;
> +	};
> +
>   	watchdog {
>   		clocks =<&clock 336>;
>   		clock-names = "watchdog";
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index b1fa334..cd47db0 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -402,4 +402,9 @@
>   		clock-names = "gscl";
>   		samsung,power-domain =<&gsc_pd>;
>   	};
> +
> +	pmu_system_controller: system-controller@10040000 {

s/pmu_system_controller/power_management_unit ?

> +		compatible = "samsung,exynos5420-pmu", "syscon";
> +		reg =<0x10040000 0x5000>;
> +	};
>   };

Otherwise looks good.

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Sylwester Nawrocki]

Hi,

Just a few minor comments...

On 12/06/2013 06:47 AM, Leela Krishna Amudala wrote:
> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to

s/pmusysreg/PMU sysreg ? Similarly I would capitalize it in the subject
line as well.

> handle PMU register accesses in a centralized way using syscon driver
>
> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
> Reviewed-by: Doug Anderson<dianders@chromium.org>
> Tested-by: Doug Anderson<dianders@chromium.org>
> ---
>   Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
>   arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>   arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>   3 files changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> new file mode 100644
> index 0000000..f1f1552
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt

I might be easy to confuse this with ARM Performance Monitoring Unit.
So perhaps we should rename this file to, e.g. power-management-unit.txt ?

> @@ -0,0 +1,15 @@
> +SAMSUNG Exynos SoC series PMU Registers

s/PMU/Power Management Unit ?

> +
> +Properties:
> + - compatible : should contain two values. First value must be one from following list:
> +		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
> +		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.

s/./; ?

> +		second value must be always "syscon".

It might be more safe to specify it as the last value, so something along
the lines of:

	The last value should be "syscon".

> +
> + - reg : offset and length of the register set.
> +
> +Example :
> +pmu_system_controller: system-controller@10040000 {

Might be more sensible to use 'power_management_unit' for the label.

> +	compatible = "samsung,exynos5250-pmu", "syscon";
> +	reg =<0x10040000 0x5000>;
> +};
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index b98ffc3..62f9e36 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -163,6 +163,11 @@
>   		interrupts =<0 47 0>;
>   	};
>
> +	pmu_system_controller: system-controller@10040000 {

s/pmu_system_controller/power_management_unit ? So it describes the 
subsystem
better in terms used in the SoCs User Manual ?

> +		compatible = "samsung,exynos5250-pmu", "syscon";
> +		reg =<0x10040000 0x5000>;
> +	};
> +
>   	watchdog {
>   		clocks =<&clock 336>;
>   		clock-names = "watchdog";
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index b1fa334..cd47db0 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -402,4 +402,9 @@
>   		clock-names = "gscl";
>   		samsung,power-domain =<&gsc_pd>;
>   	};
> +
> +	pmu_system_controller: system-controller@10040000 {

s/pmu_system_controller/power_management_unit ?

> +		compatible = "samsung,exynos5420-pmu", "syscon";
> +		reg =<0x10040000 0x5000>;
> +	};
>   };

Otherwise looks good.

Thanks,
Sylwester

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Guenter Roeck]

On Fri, Dec 06, 2013 at 11:17:46AM +0530, Leela Krishna Amudala wrote:
> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
> handle PMU register accesses in a centralized way using syscon driver
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH V12 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

[Guenter Roeck]

On Fri, Dec 06, 2013 at 11:17:47AM +0530, Leela Krishna Amudala wrote:
> Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap interface
> to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers of PMU
> to mask/unmask enable/disable of watchdog in probe and s2r scenarios.
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

[Guenter Roeck]

On Fri, Dec 06, 2013 at 11:17:48AM +0530, Leela Krishna Amudala wrote:
> In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
> watchdog timer which is not the case with s3c series SoCs so, there is a
> need to have different compatible names for watchdog to handle these pmu
> registers access.
> 
> Hence this patch removes watchdog node from Exynos5.dtsi common file and
> make it separate by updating existing node in Exynos5250 and adding new node
> to Exynos5420. This patch also makes the watchdog node enabled by default
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Doug Anderson]

Guenter,

On Fri, Dec 6, 2013 at 11:47 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Dec 06, 2013 at 11:17:46AM +0530, Leela Krishna Amudala wrote:
>> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
>> handle PMU register accesses in a centralized way using syscon driver
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>

I'm curious of your opinion of Sylwester's requests, since your Ack
came in after his requests.  Would you like to see a respin of this,
or do you think it's gone through enough spinning and are thinking it
would go in as-is?

-Doug

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Guenter Roeck]

On Fri, Dec 06, 2013 at 03:01:23PM -0800, Doug Anderson wrote:
> Guenter,
> 
> On Fri, Dec 6, 2013 at 11:47 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Fri, Dec 06, 2013 at 11:17:46AM +0530, Leela Krishna Amudala wrote:
> >> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
> >> handle PMU register accesses in a centralized way using syscon driver
> >>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> >> Reviewed-by: Doug Anderson <dianders@chromium.org>
> >> Tested-by: Doug Anderson <dianders@chromium.org>
> >
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> I'm curious of your opinion of Sylwester's requests, since your Ack
> came in after his requests.  Would you like to see a respin of this,
> or do you think it's gone through enough spinning and are thinking it
> would go in as-is?
> 

My Ack means "I am ok with this patch without further changes".
My reaction to the new comments was along the line of "sigh".
Whoever comments now had more than 10 chances to comment earlier,
which should have been way enough, and thus deserves to be ignored.
Sorry if that statement happens to offend any listener, but I am not
really known for my patience.

Guenter

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Tomasz Figa]

Hi Sylwester,

On Friday 06 of December 2013 18:22:32 Sylwester Nawrocki wrote:
> Hi,
> 
> Just a few minor comments...

I wouldn't really nitpick on such things, but if we end up needing another
respin, here's what I think.

> 
> On 12/06/2013 06:47 AM, Leela Krishna Amudala wrote:
> > This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
> 
> s/pmusysreg/PMU sysreg ? Similarly I would capitalize it in the subject
> line as well.

Well, since this is supposed to be a human readable description, I would
go even further and write "...device tree node of Power Management Unit
 to...".

> 
> > handle PMU register accesses in a centralized way using syscon driver
> >
> > Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
> > Reviewed-by: Tomasz Figa<t.figa@samsung.com>
> > Reviewed-by: Doug Anderson<dianders@chromium.org>
> > Tested-by: Doug Anderson<dianders@chromium.org>
> > ---
> >   Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
> >   arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
> >   arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
> >   3 files changed, 25 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
> >
> > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> > new file mode 100644
> > index 0000000..f1f1552
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> 
> I might be easy to confuse this with ARM Performance Monitoring Unit.
> So perhaps we should rename this file to, e.g. power-management-unit.txt ?

Considering location of this file, which is arm/samsung, I think this
name is pretty much clear. ARM PMU is a generic thing, so it couldn't
be placed here.

> 
> > @@ -0,0 +1,15 @@
> > +SAMSUNG Exynos SoC series PMU Registers
> 
> s/PMU/Power Management Unit ?

s/PMU Registers/Power Management Unit/

> 
> > +
> > +Properties:
> > + - compatible : should contain two values. First value must be one from following list:
> > +		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
> > +		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
> 
> s/./; ?
> 
> > +		second value must be always "syscon".
> 
> It might be more safe to specify it as the last value, so something along
> the lines of:
> 
> 	The last value should be "syscon".
> 
> > +
> > + - reg : offset and length of the register set.
> > +
> > +Example :
> > +pmu_system_controller: system-controller@10040000 {
> 
> Might be more sensible to use 'power_management_unit' for the label.

That's quite a lot of text for a label. pmu_syscon as in previous version
of this patch would look more sensible to me.

> 
> > +	compatible = "samsung,exynos5250-pmu", "syscon";
> > +	reg =<0x10040000 0x5000>;
> > +};
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > index b98ffc3..62f9e36 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -163,6 +163,11 @@
> >   		interrupts =<0 47 0>;
> >   	};
> >
> > +	pmu_system_controller: system-controller@10040000 {
> 
> s/pmu_system_controller/power_management_unit ? So it describes the 
> subsystem
> better in terms used in the SoCs User Manual ?

See above.

> 
> > +		compatible = "samsung,exynos5250-pmu", "syscon";
> > +		reg =<0x10040000 0x5000>;
> > +	};
> > +
> >   	watchdog {
> >   		clocks =<&clock 336>;
> >   		clock-names = "watchdog";
> > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> > index b1fa334..cd47db0 100644
> > --- a/arch/arm/boot/dts/exynos5420.dtsi
> > +++ b/arch/arm/boot/dts/exynos5420.dtsi
> > @@ -402,4 +402,9 @@
> >   		clock-names = "gscl";
> >   		samsung,power-domain =<&gsc_pd>;
> >   	};
> > +
> > +	pmu_system_controller: system-controller@10040000 {
> 
> s/pmu_system_controller/power_management_unit ?

See above.

Best regards,
Tomasz

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Sylwester Nawrocki]

Hi Tomasz,

On 12/07/2013 01:57 AM, Tomasz Figa wrote:
> On Friday 06 of December 2013 18:22:32 Sylwester Nawrocki wrote:
[...]
> I wouldn't really nitpick on such things, but if we end up needing another
> respin, here's what I think.

Yeah, I didn't really realize the iteration index for this series was 
already
a 2 digit number and some people could have already gotten upset or 
seriously
impatient. Started to regret I even bothered with posting any comments 
to that.
:) Anyway, I didn't request any corrections, just pointed out what could be
improved. People are free to accept it or ignore as they see fit. And having
seen patch series that got merged after periods like 2.5 year V12 is not
something unusual anyway. :)

>> On 12/06/2013 06:47 AM, Leela Krishna Amudala wrote:
>>> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
>>
>> s/pmusysreg/PMU sysreg ? Similarly I would capitalize it in the subject
>> line as well.
>
> Well, since this is supposed to be a human readable description, I would
> go even further and write "...device tree node of Power Management Unit
>   to...".

Agreed, it sounds better.

>>> handle PMU register accesses in a centralized way using syscon driver
>>>
>>> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
>>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>>> Reviewed-by: Doug Anderson<dianders@chromium.org>
>>> Tested-by: Doug Anderson<dianders@chromium.org>
>>> ---
>>>    Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15 +++++++++++++++
>>>    arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>>>    arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>>>    3 files changed, 25 insertions(+)
>>>    create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>> new file mode 100644
>>> index 0000000..f1f1552
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>
>> I might be easy to confuse this with ARM Performance Monitoring Unit.
>> So perhaps we should rename this file to, e.g. power-management-unit.txt ?
>
> Considering location of this file, which is arm/samsung, I think this
> name is pretty much clear. ARM PMU is a generic thing, so it couldn't
> be placed here.

It's up to the patch author if they want to change it or not, I still think
it's better to not use short acronyms like this, if we can easily make it
unambiguous.

>>> @@ -0,0 +1,15 @@
>>> +SAMSUNG Exynos SoC series PMU Registers
>>
>> s/PMU/Power Management Unit ?
>
> s/PMU Registers/Power Management Unit/

Yeah, that's more accurate.

>>> +Properties:
>>> + - compatible : should contain two values. First value must be one from following list:
>>> +		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>>> +		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>>
>> s/./; ?
>>
>>> +		second value must be always "syscon".
>>
>> It might be more safe to specify it as the last value, so something along
>> the lines of:
>>
>> 	The last value should be "syscon".
>>
>>> +
>>> + - reg : offset and length of the register set.
>>> +
>>> +Example :
>>> +pmu_system_controller: system-controller@10040000 {
>>
>> Might be more sensible to use 'power_management_unit' for the label.
>
> That's quite a lot of text for a label. pmu_syscon as in previous version
> of this patch would look more sensible to me.

I don't think it hurts to have this long labels, what I proposed is exactly
of same length as the original one. Anyway pmu_syscon sounds good to me too.

>>> +	compatible = "samsung,exynos5250-pmu", "syscon";
>>> +	reg =<0x10040000 0x5000>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>>> index b98ffc3..62f9e36 100644
>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>> @@ -163,6 +163,11 @@
>>>    		interrupts =<0 47 0>;
>>>    	};
>>>
>>> +	pmu_system_controller: system-controller@10040000 {
>>
>> s/pmu_system_controller/power_management_unit ? So it describes the
>> subsystem better in terms used in the SoCs User Manual ?
>
> See above.

I can't see anything wrong in such long labels, but this discussion is 
really
just a bike-shedding, so let's end it right now not to risk annoying 
even more
people! :)

--
Regards,
Sylwester

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Leela Krishna Amudala]

Hi,

As I was in travel not accessed my mails.

I'll try to post next version of this series tomorrow addressing
Sylwester's comments.

Best Wishes,
Leela Krishna.

On Sun, Dec 8, 2013 at 7:20 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> Hi Tomasz,
>
>
> On 12/07/2013 01:57 AM, Tomasz Figa wrote:
>>
>> On Friday 06 of December 2013 18:22:32 Sylwester Nawrocki wrote:
>
> [...]
>
>> I wouldn't really nitpick on such things, but if we end up needing another
>> respin, here's what I think.
>
>
> Yeah, I didn't really realize the iteration index for this series was
> already
> a 2 digit number and some people could have already gotten upset or
> seriously
> impatient. Started to regret I even bothered with posting any comments to
> that.
> :) Anyway, I didn't request any corrections, just pointed out what could be
> improved. People are free to accept it or ignore as they see fit. And having
> seen patch series that got merged after periods like 2.5 year V12 is not
> something unusual anyway. :)
>
>
>>> On 12/06/2013 06:47 AM, Leela Krishna Amudala wrote:
>>>>
>>>> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files
>>>> to
>>>
>>>
>>> s/pmusysreg/PMU sysreg ? Similarly I would capitalize it in the subject
>>> line as well.
>>
>>
>> Well, since this is supposed to be a human readable description, I would
>> go even further and write "...device tree node of Power Management Unit
>>   to...".
>
>
> Agreed, it sounds better.
>
>
>>>> handle PMU register accesses in a centralized way using syscon driver
>>>>
>>>> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
>>>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>>>> Reviewed-by: Doug Anderson<dianders@chromium.org>
>>>> Tested-by: Doug Anderson<dianders@chromium.org>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/samsung/pmu.txt |   15
>>>> +++++++++++++++
>>>>    arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>>>>    arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>>>>    3 files changed, 25 insertions(+)
>>>>    create mode 100644
>>>> Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>>> b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>>> new file mode 100644
>>>> index 0000000..f1f1552
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>>
>>>
>>> I might be easy to confuse this with ARM Performance Monitoring Unit.
>>> So perhaps we should rename this file to, e.g. power-management-unit.txt
>>> ?
>>
>>
>> Considering location of this file, which is arm/samsung, I think this
>> name is pretty much clear. ARM PMU is a generic thing, so it couldn't
>> be placed here.
>
>
> It's up to the patch author if they want to change it or not, I still think
> it's better to not use short acronyms like this, if we can easily make it
> unambiguous.
>
>
>>>> @@ -0,0 +1,15 @@
>>>> +SAMSUNG Exynos SoC series PMU Registers
>>>
>>>
>>> s/PMU/Power Management Unit ?
>>
>>
>> s/PMU Registers/Power Management Unit/
>
>
> Yeah, that's more accurate.
>
>
>>>> +Properties:
>>>> + - compatible : should contain two values. First value must be one from
>>>> following list:
>>>> +                  - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>>>> +                  - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>>>
>>>
>>> s/./; ?
>>>
>>>> +               second value must be always "syscon".
>>>
>>>
>>> It might be more safe to specify it as the last value, so something along
>>> the lines of:
>>>
>>>         The last value should be "syscon".
>>>
>>>> +
>>>> + - reg : offset and length of the register set.
>>>> +
>>>> +Example :
>>>> +pmu_system_controller: system-controller@10040000 {
>>>
>>>
>>> Might be more sensible to use 'power_management_unit' for the label.
>>
>>
>> That's quite a lot of text for a label. pmu_syscon as in previous version
>> of this patch would look more sensible to me.
>
>
> I don't think it hurts to have this long labels, what I proposed is exactly
> of same length as the original one. Anyway pmu_syscon sounds good to me too.
>
>
>>>> +       compatible = "samsung,exynos5250-pmu", "syscon";
>>>> +       reg =<0x10040000 0x5000>;
>>>> +};
>>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>>>> b/arch/arm/boot/dts/exynos5250.dtsi
>>>> index b98ffc3..62f9e36 100644
>>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>>> @@ -163,6 +163,11 @@
>>>>                 interrupts =<0 47 0>;
>>>>         };
>>>>
>>>> +       pmu_system_controller: system-controller@10040000 {
>>>
>>>
>>> s/pmu_system_controller/power_management_unit ? So it describes the
>>> subsystem better in terms used in the SoCs User Manual ?
>>
>>
>> See above.
>
>
> I can't see anything wrong in such long labels, but this discussion is
> really
> just a bike-shedding, so let's end it right now not to risk annoying even
> more
> people! :)
>
> --
> Regards,
> Sylwester
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Doug Anderson]

Leela Krishna,

On Wed, Dec 11, 2013 at 4:22 AM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> Hi,
>
> As I was in travel not accessed my mails.
>
> I'll try to post next version of this series tomorrow addressing
> Sylwester's comments.

It's completely up to you (and Wim), of course.  ...but if it were me
I wouldn't spin the patch at this point.  Your existing version has
Guenter's Ack and his indication that he thinks that v12 is good
enough to land without future spins.  You could spin with Tomasz /
Sylwester's suggestions but remember that it is not mandatory.

-Doug

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Tomasz Figa]

2013/12/11 Doug Anderson <dianders@chromium.org>:
> Leela Krishna,
>
> On Wed, Dec 11, 2013 at 4:22 AM, Leela Krishna Amudala
> <l.krishna@samsung.com> wrote:
>> Hi,
>>
>> As I was in travel not accessed my mails.
>>
>> I'll try to post next version of this series tomorrow addressing
>> Sylwester's comments.
>
> It's completely up to you (and Wim), of course.  ...but if it were me
> I wouldn't spin the patch at this point.  Your existing version has
> Guenter's Ack and his indication that he thinks that v12 is good
> enough to land without future spins.  You could spin with Tomasz /
> Sylwester's suggestions but remember that it is not mandatory.

As I said, at this point the comments are just nitpicks that it would be
nice to have them addressed, but this might be done as well in incremental
patch(es).

So if it's not a problem for you and you can find time for it, a re-spin would
be nice, but it's not a necessity (unless Wim decides otherwise).

Best regards,
Tomasz

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Leela Krishna Amudala]

Hi,

On Thu, Dec 12, 2013 at 8:57 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> 2013/12/11 Doug Anderson <dianders@chromium.org>:
>> Leela Krishna,
>>
>> On Wed, Dec 11, 2013 at 4:22 AM, Leela Krishna Amudala
>> <l.krishna@samsung.com> wrote:
>>> Hi,
>>>
>>> As I was in travel not accessed my mails.
>>>
>>> I'll try to post next version of this series tomorrow addressing
>>> Sylwester's comments.
>>
>> It's completely up to you (and Wim), of course.  ...but if it were me
>> I wouldn't spin the patch at this point.  Your existing version has
>> Guenter's Ack and his indication that he thinks that v12 is good
>> enough to land without future spins.  You could spin with Tomasz /
>> Sylwester's suggestions but remember that it is not mandatory.
>
> As I said, at this point the comments are just nitpicks that it would be
> nice to have them addressed, but this might be done as well in incremental
> patch(es).
>
> So if it's not a problem for you and you can find time for it, a re-spin would
> be nice, but it's not a necessity (unless Wim decides otherwise).
>

Okay, Then I'll drop my plan to post next version of this series.
Anyways I don't have code repository and hardware with me now to
re-base and test.

Hello Wim,
Can you kindly look into this series and take necessary action..?

Best Wishes,
Leela Krishna.


> Best regards,
> Tomasz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V12 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

[Leela Krishna Amudala]

Hello Wim Van Sebroeck,

Can you kindly look into this series and take necessary action..?

Best Wishes,
Leela Krishna.


On Fri, Dec 6, 2013 at 2:47 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> This patchset does the following things
>         - Adds pmusysreg device node to exynos5.dtsi file
>         - Adds watchdog DT nodes to Exynos5250 and 5420
>         - Uses syscon regmap interface to configure pmu registers
>           to mask/unmask enable/disable of watchdog.
>
> This patch set is rebased on Kgene's for-next branch and tested on SMDK5420
>
> changes since V11:
>         - Added EXYNOS5 prefix to REG_OFFSET defines (suggested by Tomasz)
>         - NEEDS_PMU_CONFIG => HAS_PMU_CONFIG (suggested by Olof, Guenter)
>         - Move QUIRK_HAS_PMU_CONFIG check to s3c2410wdt_mask_and_disable_reset (suggested by Guenter)
>
> changes since V10:
>         - followed coding style rules
>         - removed duplicate error message suggested by Guenter Roeck <linux@roeck-us.net>
>
> changes since V9:
>         - added descriptions to s3c2410_wdt_variant structure fields
>         - moved calling s3c2410wdt_mask_and_disable_reset() function above s3c2410wdt_start() call in probe
>         - put dev_err message back to s3c2410wdt_mask_and_disable_reset() function
>           (suggested by Doug Anderson <dianders@chromium.org>)
>
> changes since V8:
>         - modified the patch description for the below patch
>           "watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register"
>         - removed MODULE_ALIAS in watchdog driver
>         - changed dev_warn to dev_err in one failure case handling (suggested by Guenter Roeck <linux@roeck-us.net>)
>         - renamed variable name from pmu_config to drv_data
>         - changed the compatible field description in documentation file
>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>
> changes since V7:
>         - re-ordered the patches in the series
>         - moved pmu_config_s3c2410 structure out of ifdef CONFIG_OF
>           and limited only this structure to platform match table
>         - renamed structure name from s3c_wdt_driver_ids to s3c2410_wdt_ids
>         - removed exynos variants from platform match table
>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>
> changes since V6:
>         - added SoC-specific compatible value to syscon node and documented it
>         - given more patch description for below patch
>           ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
>         - added platform_device_id array for watchdog devices
>         - selected MFD_SYSCON in Kconfig entry for watchdog
>
> Changes since V5:
>         - removed status property in DT nodes
>         - changed the return type for the function s3c2410wdt_mask_and_disable_reset()
>           and handled error cases
>         - Handled to get driver data in non-DT cases
>         - Addressed comments given by Tomasz Figa <t.figa@samsung.com>
>
> Changes since V4:
>         - changed the node name from pmusysreg to syscon and node label from pmu_sys_reg to pmu_syscon
>         - changed the property name from samsung,pmusysreg to samsung,syscon-phandle
>         - used regmap_update_bits instead of remap_read/regmap_write
>         - Addressed other comments given by Tomasz Figa <t.figa@samsung.com>
>
> Changes since V3:
>         - changed the compatible strings for watchdog node
>         - splitted up adding pmusysreg node and made it separate patch
>         - Addressed comments given by Sachin Kamat <sachin.kamat@linaro.org>
>
> Changes since V2:
>         - used syscon regmap interface to configure pmu registers in WDT driver
>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>
> Changes since V1:
>         - Added new compatible string for Exynos5 SoCs
>         - Introduced quirk mechanism to program PMU registers
>         - Addressed comments given by Tomasz Figa <t.figa@samsung.com>
>
> Leela Krishna Amudala (3):
>   ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
>   watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
>     register
>   ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
>
>  .../devicetree/bindings/arm/samsung/pmu.txt        |   15 ++
>  .../devicetree/bindings/watchdog/samsung-wdt.txt   |   21 ++-
>  arch/arm/boot/dts/exynos5.dtsi                     |    7 -
>  arch/arm/boot/dts/exynos5250.dtsi                  |   11 +-
>  arch/arm/boot/dts/exynos5420.dtsi                  |   14 ++
>  drivers/watchdog/Kconfig                           |    1 +
>  drivers/watchdog/s3c2410_wdt.c                     |  154 ++++++++++++++++++--
>  7 files changed, 205 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V12 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

[Leela Krishna Amudala]

Hello Wim Van Sebroeck,

I believe that I addressed all the comments given by reviewers.
So can you look into this series and take necessary action..?

Best Wishes,
Leela Krishna.

On Wed, Dec 18, 2013 at 9:01 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> Hello Wim Van Sebroeck,
>
> Can you kindly look into this series and take necessary action..?
>
> Best Wishes,
> Leela Krishna.
>
>
> On Fri, Dec 6, 2013 at 2:47 PM, Leela Krishna Amudala
> <l.krishna@samsung.com> wrote:
>> This patchset does the following things
>>         - Adds pmusysreg device node to exynos5.dtsi file
>>         - Adds watchdog DT nodes to Exynos5250 and 5420
>>         - Uses syscon regmap interface to configure pmu registers
>>           to mask/unmask enable/disable of watchdog.
>>
>> This patch set is rebased on Kgene's for-next branch and tested on SMDK5420
>>
>> changes since V11:
>>         - Added EXYNOS5 prefix to REG_OFFSET defines (suggested by Tomasz)
>>         - NEEDS_PMU_CONFIG => HAS_PMU_CONFIG (suggested by Olof, Guenter)
>>         - Move QUIRK_HAS_PMU_CONFIG check to s3c2410wdt_mask_and_disable_reset (suggested by Guenter)
>>
>> changes since V10:
>>         - followed coding style rules
>>         - removed duplicate error message suggested by Guenter Roeck <linux@roeck-us.net>
>>
>> changes since V9:
>>         - added descriptions to s3c2410_wdt_variant structure fields
>>         - moved calling s3c2410wdt_mask_and_disable_reset() function above s3c2410wdt_start() call in probe
>>         - put dev_err message back to s3c2410wdt_mask_and_disable_reset() function
>>           (suggested by Doug Anderson <dianders@chromium.org>)
>>
>> changes since V8:
>>         - modified the patch description for the below patch
>>           "watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register"
>>         - removed MODULE_ALIAS in watchdog driver
>>         - changed dev_warn to dev_err in one failure case handling (suggested by Guenter Roeck <linux@roeck-us.net>)
>>         - renamed variable name from pmu_config to drv_data
>>         - changed the compatible field description in documentation file
>>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>>
>> changes since V7:
>>         - re-ordered the patches in the series
>>         - moved pmu_config_s3c2410 structure out of ifdef CONFIG_OF
>>           and limited only this structure to platform match table
>>         - renamed structure name from s3c_wdt_driver_ids to s3c2410_wdt_ids
>>         - removed exynos variants from platform match table
>>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>>
>> changes since V6:
>>         - added SoC-specific compatible value to syscon node and documented it
>>         - given more patch description for below patch
>>           ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
>>         - added platform_device_id array for watchdog devices
>>         - selected MFD_SYSCON in Kconfig entry for watchdog
>>
>> Changes since V5:
>>         - removed status property in DT nodes
>>         - changed the return type for the function s3c2410wdt_mask_and_disable_reset()
>>           and handled error cases
>>         - Handled to get driver data in non-DT cases
>>         - Addressed comments given by Tomasz Figa <t.figa@samsung.com>
>>
>> Changes since V4:
>>         - changed the node name from pmusysreg to syscon and node label from pmu_sys_reg to pmu_syscon
>>         - changed the property name from samsung,pmusysreg to samsung,syscon-phandle
>>         - used regmap_update_bits instead of remap_read/regmap_write
>>         - Addressed other comments given by Tomasz Figa <t.figa@samsung.com>
>>
>> Changes since V3:
>>         - changed the compatible strings for watchdog node
>>         - splitted up adding pmusysreg node and made it separate patch
>>         - Addressed comments given by Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Changes since V2:
>>         - used syscon regmap interface to configure pmu registers in WDT driver
>>           (suggested by Tomasz Figa <t.figa@samsung.com>)
>>
>> Changes since V1:
>>         - Added new compatible string for Exynos5 SoCs
>>         - Introduced quirk mechanism to program PMU registers
>>         - Addressed comments given by Tomasz Figa <t.figa@samsung.com>
>>
>> Leela Krishna Amudala (3):
>>   ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
>>   watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
>>     register
>>   ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
>>
>>  .../devicetree/bindings/arm/samsung/pmu.txt        |   15 ++
>>  .../devicetree/bindings/watchdog/samsung-wdt.txt   |   21 ++-
>>  arch/arm/boot/dts/exynos5.dtsi                     |    7 -
>>  arch/arm/boot/dts/exynos5250.dtsi                  |   11 +-
>>  arch/arm/boot/dts/exynos5420.dtsi                  |   14 ++
>>  drivers/watchdog/Kconfig                           |    1 +
>>  drivers/watchdog/s3c2410_wdt.c                     |  154 ++++++++++++++++++--
>>  7 files changed, 205 insertions(+), 18 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V12 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

[Wim Van Sebroeck]

Hi Leela

> Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap interface
> to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers of PMU
> to mask/unmask enable/disable of watchdog in probe and s2r scenarios.
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Wim Van Sebroeck]

Hi Leela,

> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
> handle PMU register accesses in a centralized way using syscon driver
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
> ---
...
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index b1fa334..cd47db0 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -402,4 +402,9 @@
>  		clock-names = "gscl";
>  		samsung,power-domain = <&gsc_pd>;
>  	};

I can't add this patch since there is no "gscl" in the current linux-tree.
Is this depending on another patch or are we going to fix this in another way?

Kind regards,
Wim.

Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Leela Krishna Amudala]

On 1/10/14, Wim Van Sebroeck <wim@iguana.be> wrote:
> Hi Leela,
>
>> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
>> handle PMU register accesses in a centralized way using syscon driver
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>> ---
> ...
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi
>> index b1fa334..cd47db0 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -402,4 +402,9 @@
>>  		clock-names = "gscl";
>>  		samsung,power-domain = <&gsc_pd>;
>>  	};
>
> I can't add this patch since there is no "gscl" in the current linux-tree.
> Is this depending on another patch or are we going to fix this in another
> way?
>

Hi Kgene,

Driver changes has been merged to Wim's tree, so can you please pick
this patch into your tree.

Best Wishes,
Leela krishna.

> Kind regards,
> Wim.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

[Leela Krishna Amudala]

On 12/7/13, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Dec 06, 2013 at 11:17:48AM +0530, Leela Krishna Amudala wrote:
>> In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
>> watchdog timer which is not the case with s3c series SoCs so, there is a
>> need to have different compatible names for watchdog to handle these pmu
>> registers access.
>>
>> Hence this patch removes watchdog node from Exynos5.dtsi common file and
>> make it separate by updating existing node in Exynos5250 and adding new
>> node
>> to Exynos5420. This patch also makes the watchdog node enabled by default
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>

Hi Kgene,

Driver changes has been merged to Wim's tree, so can you please pick
this patch into your tree.

Best Wishes,
Leela krishna.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

RE: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[kgene]

Leela Krishna Amudala wrote:
> 
> On 1/10/14, Wim Van Sebroeck <wim@iguana.be> wrote:
> > Hi Leela,
> >
> >> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files
> to
> >> handle PMU register accesses in a centralized way using syscon driver
> >>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> >> Reviewed-by: Doug Anderson <dianders@chromium.org>
> >> Tested-by: Doug Anderson <dianders@chromium.org>
> >> ---
> > ...
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >> b/arch/arm/boot/dts/exynos5420.dtsi
> >> index b1fa334..cd47db0 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -402,4 +402,9 @@
> >>  		clock-names = "gscl";
> >>  		samsung,power-domain = <&gsc_pd>;
> >>  	};
> >
> > I can't add this patch since there is no "gscl" in the current linux-
> tree.
> > Is this depending on another patch or are we going to fix this in
> another
> > way?
> >
> 
> Hi Kgene,
> 
Hi Leela,

> Driver changes has been merged to Wim's tree, so can you please pick
> this patch into your tree.
> 
OK, let me take this and 3rd patch into Samsung tree for next time.

Thanks,
Kukjin