Re: [RFC PATCH] ARM: s3c: mark as deprecated and schedule removal after 2022

[Tomasz Figa <tomasz.figa@gmail.com>]

2021年11月2日(火) 20:05 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>:
>
> The Samsung S3C24xx and S3C64xx platforms are very old designs. S3C2416
> was introduced in 2008 and S3C6410 in 2009/2010.  They are not widely
> available anymore - out-of-stock on FriendlyArm (one of manufacturers of

FWIW, I still see mini6410 and (compatible) tiny6410 available on
AliExpress, although it's not a good enough reason to keep a platform
without active users.
(and I also have one, but haven't made any use of it for 7 years or so
and don't see myself finding time to invest into it)

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz

> boards) and only few specialist stores still offer them for quite a high
> price.
>
> The community around these platforms was not very active, so I suspect
> no one really uses them anymore. Maintenance takes precious time so
> there is little sense in keeping them alive if there are no real users.
>
> Let's mark all S3C24xx and S3C64xx platforms as deprecated and mention
> possible removal in one year (after 2022).  The deprecation message will
> be as text in Kconfig, build message (not a warning though) and runtime
> print error.
>
> If there are any users, they might respond and postpone the removal.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm/Kconfig                  | 7 ++++++-
>  arch/arm/mach-s3c/Kconfig.s3c64xx | 7 ++++++-
>  arch/arm/mach-s3c/cpu.c           | 1 +
>  arch/arm/mach-s3c/init.c          | 2 ++
>  arch/arm/mach-s3c/s3c24xx.c       | 5 +++++
>  arch/arm/mach-s3c/s3c64xx.c       | 5 +++++
>  6 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f0f9e8bec83a..bd8237c7e7f1 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -473,7 +473,7 @@ config ARCH_SA1100
>           Support for StrongARM 11x0 based boards.
>
>  config ARCH_S3C24XX
> -       bool "Samsung S3C24XX SoCs"
> +       bool "Samsung S3C24XX SoCs (deprecated, see help)"
>         select ATAGS
>         select CLKSRC_SAMSUNG_PWM
>         select GPIO_SAMSUNG
> @@ -491,6 +491,11 @@ config ARCH_S3C24XX
>           (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or the
>           Samsung SMDK2410 development board (and derivatives).
>
> +         The platform is deprecated and scheduled in removal. Please reach to
> +         the maintainers of the platform and linux-samsung-soc@vger.kernel.org if
> +         you still use it.
> +         Without such feedback, the platform will be removed after 2022.
> +
>  config ARCH_OMAP1
>         bool "TI OMAP1"
>         depends on MMU
> diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
> index f3fcb570edf5..3b090ae72bbd 100644
> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx
> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
> @@ -4,7 +4,7 @@
>  #      Simtec Electronics, Ben Dooks <ben@simtec.co.uk>
>
>  menuconfig ARCH_S3C64XX
> -       bool "Samsung S3C64XX"
> +       bool "Samsung S3C64XX (deprecated, see help)"
>         depends on ARCH_MULTI_V6
>         select ARM_AMBA
>         select ARM_VIC
> @@ -25,6 +25,11 @@ menuconfig ARCH_S3C64XX
>         help
>           Samsung S3C64XX series based systems
>
> +         The platform is deprecated and scheduled in removal. Please reach to
> +         the maintainers of the platform and linux-samsung-soc@vger.kernel.org if
> +         you still use it.
> +         Without such feedback, the platform will be removed after 2022.
> +
>  if ARCH_S3C64XX
>
>  # Configuration options for the S3C6410 CPU
> diff --git a/arch/arm/mach-s3c/cpu.c b/arch/arm/mach-s3c/cpu.c
> index 6e9772555f0d..3b16cf42910f 100644
> --- a/arch/arm/mach-s3c/cpu.c
> +++ b/arch/arm/mach-s3c/cpu.c
> @@ -28,4 +28,5 @@ void __init s3c64xx_init_cpu(void)
>         }
>
>         pr_info("Samsung CPU ID: 0x%08lx\n", samsung_cpu_id);
> +       pr_err("The platform is deprecated and scheduled in removal. Please reach to the maintainers of the platform and linux-samsung-soc@vger.kernel.org if you still use it.  Without such feedback, the platform will be removed after 2022.\n");
>  }
> diff --git a/arch/arm/mach-s3c/init.c b/arch/arm/mach-s3c/init.c
> index 9d92f03e9bc1..5db7dc54340c 100644
> --- a/arch/arm/mach-s3c/init.c
> +++ b/arch/arm/mach-s3c/init.c
> @@ -59,6 +59,8 @@ void __init s3c_init_cpu(unsigned long idcode,
>
>         if (cpu->map_io)
>                 cpu->map_io();
> +
> +       pr_err("The platform is deprecated and scheduled in removal. Please reach to the maintainers of the platform and linux-samsung-soc@vger.kernel.org if you still use it.  Without such feedback, the platform will be removed after 2022.\n");
>  }
>
>  /* s3c24xx_init_clocks
> diff --git a/arch/arm/mach-s3c/s3c24xx.c b/arch/arm/mach-s3c/s3c24xx.c
> index ccfed48c98aa..2ea1cb21dfbc 100644
> --- a/arch/arm/mach-s3c/s3c24xx.c
> +++ b/arch/arm/mach-s3c/s3c24xx.c
> @@ -678,3 +678,8 @@ struct platform_device s3c2410_device_dclk = {
>         },
>  };
>  #endif
> +
> +#pragma message "The platform is deprecated and scheduled in removal (see platform help). " \
> +               "Please reach to the maintainers of the platform " \
> +               "and linux-samsung-soc@vger.kernel.org if you still use it." \
> +               "Without such feedback, the platform will be removed after 2022."
> diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c
> index 4dfb648142f2..3e248f0e96a2 100644
> --- a/arch/arm/mach-s3c/s3c64xx.c
> +++ b/arch/arm/mach-s3c/s3c64xx.c
> @@ -425,3 +425,8 @@ static int __init s3c64xx_init_irq_eint(void)
>         return 0;
>  }
>  arch_initcall(s3c64xx_init_irq_eint);
> +
> +#pragma message "The platform is deprecated and scheduled in removal (see platform help). " \
> +               "Please reach to the maintainers of the platform " \
> +               "and linux-samsung-soc@vger.kernel.org if you still use it." \
> +               "Without such feedback, the platform will be removed after 2022."
> --
> 2.32.0
>