* [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-01 7:24 ` Yannick Fertré
0 siblings, 0 replies; 9+ messages in thread
From: Yannick Fertré @ 2019-04-01 7:24 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
Plane updates must be synchronized on vblank with the shadow register mechanism
to avoid partial refresh on screen.
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index b1741a9..c2d0800 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
/* Enable IRQ */
reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
- /* Immediately commit the planes */
- reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
+ /* Commit shadow registers = update planes at next vblank */
+ reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
/* Enable LTDC */
reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-01 7:24 ` Yannick Fertré
0 siblings, 0 replies; 9+ messages in thread
From: Yannick Fertré @ 2019-04-01 7:24 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
Plane updates must be synchronized on vblank with the shadow register mechanism
to avoid partial refresh on screen.
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index b1741a9..c2d0800 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
/* Enable IRQ */
reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
- /* Immediately commit the planes */
- reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
+ /* Commit shadow registers = update planes at next vblank */
+ reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
/* Enable LTDC */
reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-01 7:24 ` Yannick Fertré
0 siblings, 0 replies; 9+ messages in thread
From: Yannick Fertré @ 2019-04-01 7:24 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
Plane updates must be synchronized on vblank with the shadow register mechanism
to avoid partial refresh on screen.
Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index b1741a9..c2d0800 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
/* Enable IRQ */
reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
- /* Immediately commit the planes */
- reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
+ /* Commit shadow registers = update planes at next vblank */
+ reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
/* Enable LTDC */
reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
2019-04-01 7:24 ` Yannick Fertré
(?)
@ 2019-04-01 9:22 ` Philippe CORNU
-1 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2019-04-01 9:22 UTC (permalink / raw)
To: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Dear Yannick,
Thank you for your patch, works fine,
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 4/1/19 9:24 AM, Yannick Fertré wrote:
> Plane updates must be synchronized on vblank with the shadow register mechanism
> to avoid partial refresh on screen.
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..c2d0800 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> /* Enable IRQ */
> reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
>
> - /* Immediately commit the planes */
> - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> + /* Commit shadow registers = update planes at next vblank */
> + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
>
> /* Enable LTDC */
> reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-01 9:22 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2019-04-01 9:22 UTC (permalink / raw)
To: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Dear Yannick,
Thank you for your patch, works fine,
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 4/1/19 9:24 AM, Yannick Fertré wrote:
> Plane updates must be synchronized on vblank with the shadow register mechanism
> to avoid partial refresh on screen.
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..c2d0800 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> /* Enable IRQ */
> reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
>
> - /* Immediately commit the planes */
> - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> + /* Commit shadow registers = update planes at next vblank */
> + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
>
> /* Enable LTDC */
> reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-01 9:22 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2019-04-01 9:22 UTC (permalink / raw)
To: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Dear Yannick,
Thank you for your patch, works fine,
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 4/1/19 9:24 AM, Yannick Fertré wrote:
> Plane updates must be synchronized on vblank with the shadow register mechanism
> to avoid partial refresh on screen.
>
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..c2d0800 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> /* Enable IRQ */
> reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
>
> - /* Immediately commit the planes */
> - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> + /* Commit shadow registers = update planes at next vblank */
> + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
>
> /* Enable LTDC */
> reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
2019-04-01 9:22 ` Philippe CORNU
(?)
@ 2019-04-24 12:25 ` Benjamin Gaignard
-1 siblings, 0 replies; 9+ messages in thread
From: Benjamin Gaignard @ 2019-04-24 12:25 UTC (permalink / raw)
To: Philippe CORNU
Cc: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Le lun. 1 avr. 2019 à 11:22, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
> Dear Yannick,
> Thank you for your patch, works fine,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
Applied on drm-misc-next,
Thanks,
Benjamin
> Philippe :-)
>
> On 4/1/19 9:24 AM, Yannick Fertré wrote:
> > Plane updates must be synchronized on vblank with the shadow register mechanism
> > to avoid partial refresh on screen.
> >
> > Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..c2d0800 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> > /* Enable IRQ */
> > reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
> >
> > - /* Immediately commit the planes */
> > - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> > + /* Commit shadow registers = update planes at next vblank */
> > + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
> >
> > /* Enable LTDC */
> > reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-24 12:25 ` Benjamin Gaignard
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin Gaignard @ 2019-04-24 12:25 UTC (permalink / raw)
To: Philippe CORNU
Cc: Daniel Vetter, David Airlie, linux-kernel, dri-devel,
Yannick FERTRE, Maxime Coquelin, Vincent ABRIOU, linux-stm32,
linux-arm-kernel, Alexandre TORGUE
Le lun. 1 avr. 2019 à 11:22, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
> Dear Yannick,
> Thank you for your patch, works fine,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
Applied on drm-misc-next,
Thanks,
Benjamin
> Philippe :-)
>
> On 4/1/19 9:24 AM, Yannick Fertré wrote:
> > Plane updates must be synchronized on vblank with the shadow register mechanism
> > to avoid partial refresh on screen.
> >
> > Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..c2d0800 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> > /* Enable IRQ */
> > reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
> >
> > - /* Immediately commit the planes */
> > - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> > + /* Commit shadow registers = update planes at next vblank */
> > + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
> >
> > /* Enable LTDC */
> > reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh
@ 2019-04-24 12:25 ` Benjamin Gaignard
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin Gaignard @ 2019-04-24 12:25 UTC (permalink / raw)
To: Philippe CORNU
Cc: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Le lun. 1 avr. 2019 à 11:22, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
> Dear Yannick,
> Thank you for your patch, works fine,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
Applied on drm-misc-next,
Thanks,
Benjamin
> Philippe :-)
>
> On 4/1/19 9:24 AM, Yannick Fertré wrote:
> > Plane updates must be synchronized on vblank with the shadow register mechanism
> > to avoid partial refresh on screen.
> >
> > Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..c2d0800 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
> > /* Enable IRQ */
> > reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
> >
> > - /* Immediately commit the planes */
> > - reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> > + /* Commit shadow registers = update planes at next vblank */
> > + reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
> >
> > /* Enable LTDC */
> > reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-24 12:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 7:24 [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh Yannick Fertré
2019-04-01 7:24 ` Yannick Fertré
2019-04-01 7:24 ` Yannick Fertré
2019-04-01 9:22 ` Philippe CORNU
2019-04-01 9:22 ` Philippe CORNU
2019-04-01 9:22 ` Philippe CORNU
2019-04-24 12:25 ` Benjamin Gaignard
2019-04-24 12:25 ` Benjamin Gaignard
2019-04-24 12:25 ` Benjamin Gaignard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.