All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: David Airlie <airlied@linux.ie>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Vincent Abriou <vincent.abriou@st.com>
Subject: Re: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put after calling of_parse_phandle
Date: Tue, 12 Jul 2016 14:59:23 +0200	[thread overview]
Message-ID: <CA+M3ks7Q4CJ3OskRoEXZM9SY7dMMxMotkdGP_w=n=67NGnGwLA@mail.gmail.com> (raw)
In-Reply-To: <1467684294-20111-3-git-send-email-peter.chen@nxp.com>

Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  drivers/gpu/drm/sti/sti_compositor.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c
> index 3d2fa3a..064de14 100644
> --- a/drivers/gpu/drm/sti/sti_compositor.c
> +++ b/drivers/gpu/drm/sti/sti_compositor.c
> @@ -247,10 +247,12 @@ static int sti_compositor_probe(struct platform_device *pdev)
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0);
>         if (vtg_np)
>                 compo->vtg_main = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 1);
>         if (vtg_np)
>                 compo->vtg_aux = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         platform_set_drvdata(pdev, compo);
>
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: Vincent Abriou <vincent.abriou@st.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put after calling of_parse_phandle
Date: Tue, 12 Jul 2016 14:59:23 +0200	[thread overview]
Message-ID: <CA+M3ks7Q4CJ3OskRoEXZM9SY7dMMxMotkdGP_w=n=67NGnGwLA@mail.gmail.com> (raw)
In-Reply-To: <1467684294-20111-3-git-send-email-peter.chen@nxp.com>

Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  drivers/gpu/drm/sti/sti_compositor.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c
> index 3d2fa3a..064de14 100644
> --- a/drivers/gpu/drm/sti/sti_compositor.c
> +++ b/drivers/gpu/drm/sti/sti_compositor.c
> @@ -247,10 +247,12 @@ static int sti_compositor_probe(struct platform_device *pdev)
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0);
>         if (vtg_np)
>                 compo->vtg_main = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 1);
>         if (vtg_np)
>                 compo->vtg_aux = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         platform_set_drvdata(pdev, compo);
>
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-07-12 12:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  2:04 [PATCH 0/7] gpu: drm: remaining missing of_node_put issue fixes Peter Chen
2016-07-05  2:04 ` Peter Chen
2016-07-05  2:04 ` [PATCH 1/7] gpu: drm: rockchip_drm_drv: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-05  2:04 ` [PATCH 2/7] gpu: drm: sti_compositor: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-12 12:59   ` Benjamin Gaignard [this message]
2016-07-12 12:59     ` Benjamin Gaignard
2016-07-05  2:04 ` [PATCH 3/7] gpu: drm: sti_vdo: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-12 12:59   ` Benjamin Gaignard
2016-07-12 12:59     ` Benjamin Gaignard
2016-07-05  2:04 ` [PATCH 4/7] gpu: drm: sti_hqvdp: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-12 12:59   ` Benjamin Gaignard
2016-07-12 12:59     ` Benjamin Gaignard
2016-07-05  2:04 ` [PATCH 5/7] gpu: drm: sti_vtg: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-12 12:59   ` Benjamin Gaignard
2016-07-12 12:59     ` Benjamin Gaignard
2016-07-05  2:04 ` [PATCH 6/7] gpu: drm: sun4i_drv: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-05  7:20   ` Maxime Ripard
2016-07-05  7:20     ` Maxime Ripard
2016-07-05  2:04 ` [PATCH 7/7] gpu: drm: vc4_hdmi: " Peter Chen
2016-07-05  2:04   ` Peter Chen
2016-07-05 16:23   ` Eric Anholt
2016-07-05 16:23     ` Eric Anholt
2016-07-12 13:47     ` Daniel Vetter
2016-07-08  1:46   ` Eric Anholt
2016-07-08  1:46     ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+M3ks7Q4CJ3OskRoEXZM9SY7dMMxMotkdGP_w=n=67NGnGwLA@mail.gmail.com' \
    --to=benjamin.gaignard@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.