From: Tzung-Bi Shih <tzungbi@google.com>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
"Jiaxin Yu (俞家鑫)" <Jiaxin.Yu@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] ASoC: mediatek: mt8192-mt6359: fix device_node leak
Date: Fri, 24 Dec 2021 14:21:33 +0800 [thread overview]
Message-ID: <CA+Px+wV5HydJdxmoEF7HkkBcAE_jbmtyBeAE62yuKMUJM=jGLA@mail.gmail.com> (raw)
In-Reply-To: <20211214040028.2992627-1-tzungbi@google.com>
On Tue, Dec 14, 2021 at 12:00 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Option 1. Machine driver makes sure the object is valid until registered
>
> This patch adopts the option. It needs snd_soc_register_card() to call
> of_node_get() somewhere to hold the reference count of of_node. However,
> I failed to find similar logic in soc-core.c.
>
> Option 2. Machine driver borrows the reference count
>
> This is what [1] adopts. Decreasing the reference count in device's
> remove() to make sure the object is valid for whole sound card's lifecycle.
>
> [1]: https://elixir.bootlin.com/linux/v5.16-rc5/source/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c#L1065
I guess I have found the answer to my original questions. The of_node
in snd_soc_dai_link_component in snd_soc_dai_link is mainly for
matching the component[4]. snd_soc_component itself should hold the
reference count.
[4]: https://elixir.bootlin.com/linux/v5.16-rc6/source/sound/soc/soc-core.c#L749
In summary:
- ASoC doesn't need to hold the device_node reference counts.
- Device nodes can be released after components have bound.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Jiaxin Yu (俞家鑫)" <Jiaxin.Yu@mediatek.com>
Subject: Re: [RFC PATCH] ASoC: mediatek: mt8192-mt6359: fix device_node leak
Date: Fri, 24 Dec 2021 14:21:33 +0800 [thread overview]
Message-ID: <CA+Px+wV5HydJdxmoEF7HkkBcAE_jbmtyBeAE62yuKMUJM=jGLA@mail.gmail.com> (raw)
In-Reply-To: <20211214040028.2992627-1-tzungbi@google.com>
On Tue, Dec 14, 2021 at 12:00 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Option 1. Machine driver makes sure the object is valid until registered
>
> This patch adopts the option. It needs snd_soc_register_card() to call
> of_node_get() somewhere to hold the reference count of of_node. However,
> I failed to find similar logic in soc-core.c.
>
> Option 2. Machine driver borrows the reference count
>
> This is what [1] adopts. Decreasing the reference count in device's
> remove() to make sure the object is valid for whole sound card's lifecycle.
>
> [1]: https://elixir.bootlin.com/linux/v5.16-rc5/source/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c#L1065
I guess I have found the answer to my original questions. The of_node
in snd_soc_dai_link_component in snd_soc_dai_link is mainly for
matching the component[4]. snd_soc_component itself should hold the
reference count.
[4]: https://elixir.bootlin.com/linux/v5.16-rc6/source/sound/soc/soc-core.c#L749
In summary:
- ASoC doesn't need to hold the device_node reference counts.
- Device nodes can be released after components have bound.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Jiaxin Yu (俞家鑫)" <Jiaxin.Yu@mediatek.com>
Subject: Re: [RFC PATCH] ASoC: mediatek: mt8192-mt6359: fix device_node leak
Date: Fri, 24 Dec 2021 14:21:33 +0800 [thread overview]
Message-ID: <CA+Px+wV5HydJdxmoEF7HkkBcAE_jbmtyBeAE62yuKMUJM=jGLA@mail.gmail.com> (raw)
In-Reply-To: <20211214040028.2992627-1-tzungbi@google.com>
On Tue, Dec 14, 2021 at 12:00 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> Option 1. Machine driver makes sure the object is valid until registered
>
> This patch adopts the option. It needs snd_soc_register_card() to call
> of_node_get() somewhere to hold the reference count of of_node. However,
> I failed to find similar logic in soc-core.c.
>
> Option 2. Machine driver borrows the reference count
>
> This is what [1] adopts. Decreasing the reference count in device's
> remove() to make sure the object is valid for whole sound card's lifecycle.
>
> [1]: https://elixir.bootlin.com/linux/v5.16-rc5/source/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c#L1065
I guess I have found the answer to my original questions. The of_node
in snd_soc_dai_link_component in snd_soc_dai_link is mainly for
matching the component[4]. snd_soc_component itself should hold the
reference count.
[4]: https://elixir.bootlin.com/linux/v5.16-rc6/source/sound/soc/soc-core.c#L749
In summary:
- ASoC doesn't need to hold the device_node reference counts.
- Device nodes can be released after components have bound.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-24 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 4:00 [RFC PATCH] ASoC: mediatek: mt8192-mt6359: fix device_node leak Tzung-Bi Shih
2021-12-14 4:00 ` Tzung-Bi Shih
2021-12-14 4:00 ` Tzung-Bi Shih
2021-12-23 19:39 ` Mark Brown
2021-12-23 19:39 ` Mark Brown
2021-12-23 19:39 ` Mark Brown
2021-12-24 6:21 ` Tzung-Bi Shih [this message]
2021-12-24 6:21 ` Tzung-Bi Shih
2021-12-24 6:21 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Px+wV5HydJdxmoEF7HkkBcAE_jbmtyBeAE62yuKMUJM=jGLA@mail.gmail.com' \
--to=tzungbi@google.com \
--cc=Jiaxin.Yu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.