All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] cukinia: new package
@ 2017-04-25 13:58 Alexandre Leblanc
  2017-05-01  8:51 ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Leblanc @ 2017-04-25 13:58 UTC (permalink / raw)
  To: buildroot

Cukinia is designed to help Linux-based embedded firmware developers
run simple validation tests on their firmware. For basic usage it
requires no dependencies other than busybox.

Cukinia can run tests at boot time which is why we are using SZZcukinia
since it would possibly be the last script to be executed in 'init.d'.

Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>
---
 package/Config.in            |  1 +
 package/cukinia/Config.in    | 12 ++++++++++++
 package/cukinia/SZZcukinia   |  7 +++++++
 package/cukinia/cukinia.conf |  1 +
 package/cukinia/cukinia.mk   | 26 ++++++++++++++++++++++++++
 5 files changed, 47 insertions(+)
 create mode 100644 package/cukinia/Config.in
 create mode 100644 package/cukinia/SZZcukinia
 create mode 100644 package/cukinia/cukinia.conf
 create mode 100644 package/cukinia/cukinia.mk

diff --git a/package/Config.in b/package/Config.in
index 4eaa95b..e3f8ce4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -73,6 +73,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/blktrace/Config.in"
 	source "package/bonnie/Config.in"
 	source "package/cache-calibrator/Config.in"
+	source "package/cukinia/Config.in"
 	source "package/dhrystone/Config.in"
 	source "package/dieharder/Config.in"
 	source "package/dmalloc/Config.in"
diff --git a/package/cukinia/Config.in b/package/cukinia/Config.in
new file mode 100644
index 0000000..2588bb6
--- /dev/null
+++ b/package/cukinia/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_CUKINIA
+	bool "cukinia"
+	help
+	  Cukinia is designed to help Linux-based embedded firmware
+	  developers run simple validation tests on their firmware.
+
+	  https://github.com/savoirfairelinux/cukinia
+
+config BR2_PACKAGE_CUKINIA_BOOT
+	bool "run at boot time"
+	depends on BR2_PACKAGE_CUKINIA && (BR2_INIT_SYSV || BR2_INIT_BUSYBOX)
+
diff --git a/package/cukinia/SZZcukinia b/package/cukinia/SZZcukinia
new file mode 100644
index 0000000..d9dc144
--- /dev/null
+++ b/package/cukinia/SZZcukinia
@@ -0,0 +1,7 @@
+#!/bin/sh
+#
+# Run cukinia
+#
+
+[ "$1" == "start"] || exit 0
+/usr/bin/cukinia
diff --git a/package/cukinia/cukinia.conf b/package/cukinia/cukinia.conf
new file mode 100644
index 0000000..0593662
--- /dev/null
+++ b/package/cukinia/cukinia.conf
@@ -0,0 +1 @@
+cukinia_user root
diff --git a/package/cukinia/cukinia.mk b/package/cukinia/cukinia.mk
new file mode 100644
index 0000000..d507e33
--- /dev/null
+++ b/package/cukinia/cukinia.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# cukinia
+#
+################################################################################
+
+CUKINIA_VERSION = 152d4965dd1024a3f345a9ee1df6cf663a5775ed
+CUKINIA_SITE = $(call github,savoirfairelinux,cukinia,$(CUKINIA_VERSION))
+CUKINIA_LICENSE = Apache-2.0 or GPLv3
+
+define CUKINIA_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/cukinia \
+		$(TARGET_DIR)/usr/bin/cukinia
+
+	$(INSTALL) -D -m 0644 $(CUKINIA_PKGDIR)/cukinia.conf \
+		$(TARGET_DIR)/etc/cukinia/cukinia.conf
+endef
+
+ifeq ($(BR2_PACKAGE_CUKINIA_BOOT),y)
+define CUKINIA_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 $(CUKINIA_PKGDIR)/SZZcukinia \
+		$(TARGET_DIR)/etc/init.d/SZZcukinia
+endef
+endif
+
+$(eval $(generic-package))
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] cukinia: new package
  2017-04-25 13:58 [Buildroot] [PATCH] cukinia: new package Alexandre Leblanc
@ 2017-05-01  8:51 ` Thomas Petazzoni
  2017-05-01 14:48   ` Alexandre Leblanc
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-05-01  8:51 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 25 Apr 2017 09:58:14 -0400, Alexandre Leblanc wrote:
> Cukinia is designed to help Linux-based embedded firmware developers
> run simple validation tests on their firmware. For basic usage it
> requires no dependencies other than busybox.
> 
> Cukinia can run tests at boot time which is why we are using SZZcukinia
> since it would possibly be the last script to be executed in 'init.d'.
> 
> Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>

As much as I like adding new package in Buildroot, this project feels
like your own project, very recently started, with no outside
contributions. In the end it's just a single shell script providing a
few functions. Could be useful, but I'm not sure we want to add this as
a Buildroot package that quickly.

Perhaps we need to see if there is some interest/adoption first?

>  package/cukinia/Config.in    | 12 ++++++++++++
>  package/cukinia/SZZcukinia   |  7 +++++++

I'm not sure I like this idea of SZZcukinia, though indeed S99 wouldn't
work because a few other Buildroot services are started at S99, and you
want to be after those services. Maybe other developers will have some
ideas?

> +CUKINIA_LICENSE = Apache-2.0 or GPLv3

GPLv3 should be GPL-3.0.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] cukinia: new package
  2017-05-01  8:51 ` Thomas Petazzoni
@ 2017-05-01 14:48   ` Alexandre Leblanc
  2017-05-04  9:16     ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Leblanc @ 2017-05-01 14:48 UTC (permalink / raw)
  To: buildroot


Thank you for your reply.
I'm quite new to the world of project up-streaming. 
Knowing This might be a hard question to answer, would you be able to quantify how many outside contribution would be reasonably acceptable ? 

Thank you again 

Alexandre Leblanc 


----- Original Message -----
From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
To: "Alexandre Leblanc" <alexandre.leblanc@savoirfairelinux.com>
Cc: buildroot at busybox.net
Sent: Monday, May 1, 2017 4:51:18 AM
Subject: Re: [Buildroot] [PATCH] cukinia: new package

Hello,

On Tue, 25 Apr 2017 09:58:14 -0400, Alexandre Leblanc wrote:
> Cukinia is designed to help Linux-based embedded firmware developers
> run simple validation tests on their firmware. For basic usage it
> requires no dependencies other than busybox.
> 
> Cukinia can run tests at boot time which is why we are using SZZcukinia
> since it would possibly be the last script to be executed in 'init.d'.
> 
> Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>

As much as I like adding new package in Buildroot, this project feels
like your own project, very recently started, with no outside
contributions. In the end it's just a single shell script providing a
few functions. Could be useful, but I'm not sure we want to add this as
a Buildroot package that quickly.

Perhaps we need to see if there is some interest/adoption first?

>  package/cukinia/Config.in    | 12 ++++++++++++
>  package/cukinia/SZZcukinia   |  7 +++++++

I'm not sure I like this idea of SZZcukinia, though indeed S99 wouldn't
work because a few other Buildroot services are started at S99, and you
want to be after those services. Maybe other developers will have some
ideas?

> +CUKINIA_LICENSE = Apache-2.0 or GPLv3

GPLv3 should be GPL-3.0.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] cukinia: new package
  2017-05-01 14:48   ` Alexandre Leblanc
@ 2017-05-04  9:16     ` Thomas Petazzoni
  2020-04-26 19:56       ` Angelo Compagnucci
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-05-04  9:16 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:

> I'm quite new to the world of project up-streaming. 
> Knowing This might be a hard question to answer, would you be able to quantify how many outside contribution would be reasonably acceptable ? 

There is no exact quantity, it's just a feeling about the project
activity/spread/usefulness.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] cukinia: new package
  2017-05-04  9:16     ` Thomas Petazzoni
@ 2020-04-26 19:56       ` Angelo Compagnucci
  2020-04-27  8:08         ` Shyam Saini
  0 siblings, 1 reply; 6+ messages in thread
From: Angelo Compagnucci @ 2020-04-26 19:56 UTC (permalink / raw)
  To: buildroot

Il giorno gio 4 mag 2017 alle ore 11:16 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> ha scritto:

> Hello,
>
> On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:
>
> > I'm quite new to the world of project up-streaming.
> > Knowing This might be a hard question to answer, would you be able to
> quantify how many outside contribution would be reasonably acceptable ?
>
> There is no exact quantity, it's just a feeling about the project
> activity/spread/usefulness.
>

Could you resend an updated patch? I'm interested in the project and I
would like to have a buildroot package.

Thanks!


> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Profile: http://it.linkedin.com/in/compagnucciangelo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200426/b2724957/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] cukinia: new package
  2020-04-26 19:56       ` Angelo Compagnucci
@ 2020-04-27  8:08         ` Shyam Saini
  0 siblings, 0 replies; 6+ messages in thread
From: Shyam Saini @ 2020-04-27  8:08 UTC (permalink / raw)
  To: buildroot

Thank you for your interest Angelo,

I have just sent an updated patch.


On Mon, Apr 27, 2020 at 1:27 AM Angelo Compagnucci <
angelo.compagnucci@gmail.com> wrote:

>
>
> Il giorno gio 4 mag 2017 alle ore 11:16 Thomas Petazzoni <
> thomas.petazzoni at free-electrons.com> ha scritto:
>
>> Hello,
>>
>> On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:
>>
>> > I'm quite new to the world of project up-streaming.
>> > Knowing This might be a hard question to answer, would you be able to
>> quantify how many outside contribution would be reasonably acceptable ?
>>
>> There is no exact quantity, it's just a feeling about the project
>> activity/spread/usefulness.
>>
>
> Could you resend an updated patch? I'm interested in the project and I
> would like to have a buildroot package.
>
> Thanks!
>
>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Free Electrons
>> Embedded Linux and Kernel engineering
>> http://free-electrons.com
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>
>
> --
> Profile: http://it.linkedin.com/in/compagnucciangelo
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200427/65a90f13/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-27  8:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 13:58 [Buildroot] [PATCH] cukinia: new package Alexandre Leblanc
2017-05-01  8:51 ` Thomas Petazzoni
2017-05-01 14:48   ` Alexandre Leblanc
2017-05-04  9:16     ` Thomas Petazzoni
2020-04-26 19:56       ` Angelo Compagnucci
2020-04-27  8:08         ` Shyam Saini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.