* [Buildroot] [PATCH v8] package/sysdig: New package
@ 2015-03-25 10:53 Angelo Compagnucci
2015-03-25 10:56 ` Yegor Yefremov
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Angelo Compagnucci @ 2015-03-25 10:53 UTC (permalink / raw)
To: buildroot
Sysdig is open source, system-level exploration:
capture system state and activity from a running Linux
instance, then save, filter and analyze.
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
Changes v7 -> v8:
- sysdig now alphabetically ordered in Config.in
Changes v6 -> v7:
- Fixing a nasty mistake in Config.in
Changes v5 -> v6:
- Patching kernel module makefile to be compatible with buildroot.
- Patching cmakefile to remove unneed installation of DKMS infrastructure.
- Removing of unneeded post installation script.
- Added -DUSE_BUNDLED_JSONCPP = NO
- Package is now at the bare minimum.
Changes v4 -> v5:
- Adjusted to 80 columns for sysdig.mk header
Changes v3 -> v4:
- Changed "depends on" to "select" and fixed selected packages
dependencies.
- moved "comment" section to the bottom
Changes v2 -> v3:
- Changed "depends on" and "select" to simplify package
Changes v1 -> v2:
- Changed "depends on" with "select" for dependencies (suggested by Baruch)
- Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
- Upgreded to recently released 0.1.99
package/Config.in | 1 +
.../0001-makefile-driver-compile-options.patch | 23 ++++++++++++++++
.../sysdig/0002-remove-dkms-module-updater.patch | 32 ++++++++++++++++++++++
package/sysdig/Config.in | 21 ++++++++++++++
package/sysdig/sysdig.mk | 16 +++++++++++
5 files changed, 93 insertions(+)
create mode 100644 package/sysdig/0001-makefile-driver-compile-options.patch
create mode 100644 package/sysdig/0002-remove-dkms-module-updater.patch
create mode 100644 package/sysdig/Config.in
create mode 100644 package/sysdig/sysdig.mk
diff --git a/package/Config.in b/package/Config.in
index e4ee95d..aaf12ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -94,6 +94,7 @@ endif
source "package/spidev_test/Config.in"
source "package/strace/Config.in"
source "package/stress/Config.in"
+ source "package/sysdig/Config.in"
source "package/sysprof/Config.in"
source "package/tinymembench/Config.in"
source "package/trace-cmd/Config.in"
diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
new file mode 100644
index 0000000..b3444ad
--- /dev/null
+++ b/package/sysdig/0001-makefile-driver-compile-options.patch
@@ -0,0 +1,23 @@
+Updated Makefile compile options
+
+This patch updates linux kernel module (driver) of sysdig to be
+compatible with buildroot compile flags.
+
+Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
+
+--- a/driver/Makefile.in
++++ b/driver/Makefile.in
+@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
+
+ TOP := $(shell pwd)
+ all:
+- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
+
+ clean:
+- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
+
+ install: all
+- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
diff --git a/package/sysdig/0002-remove-dkms-module-updater.patch b/package/sysdig/0002-remove-dkms-module-updater.patch
new file mode 100644
index 0000000..66fe3dd
--- /dev/null
+++ b/package/sysdig/0002-remove-dkms-module-updater.patch
@@ -0,0 +1,32 @@
+Remove DKMS module updater
+
+This patch disables the in target installation of DKMS module updater
+mechanism unneeded in buildroot.
+
+Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
+
+--- a/driver/CMakeLists.txt
++++ b/driver/CMakeLists.txt
+@@ -38,22 +38,3 @@ add_custom_target(install_driver
+ DEPENDS driver
+ WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
+ VERBATIM)
+-
+-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Makefile.dkms
+- RENAME Makefile
+- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
+-
+-install(FILES
+- ${CMAKE_CURRENT_BINARY_DIR}/dkms.conf
+- dynamic_params_table.c
+- event_table.c
+- flags_table.c
+- main.c
+- ppm.h
+- ppm_events.c
+- ppm_events.h
+- ppm_events_public.h
+- ppm_fillers.c
+- ppm_ringbuffer.h
+- syscall_table.c
+- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
new file mode 100644
index 0000000..caf7ef8
--- /dev/null
+++ b/package/sysdig/Config.in
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_SYSDIG
+ bool "sysdig"
+ select BR2_PACKAGE_ZLIB
+ select BR2_PACKAGE_LUAJIT
+ select BR2_PACKAGE_JSONCPP
+ depends on BR2_LINUX_KERNEL
+ depends on BR2_INSTALL_LIBSTDCPP # libjson
+ depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
+ help
+ Sysdig is open source, system-level exploration:
+ capture system state and activity from a running Linux instance,
+ then save, filter and analyze.
+ Think of it as strace + tcpdump + lsof + awesome sauce.
+ With a little Lua cherry on top.
+
+ http://sysdig.org
+
+comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL
+ depends on !BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
new file mode 100644
index 0000000..769cfe2
--- /dev/null
+++ b/package/sysdig/sysdig.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# sysdig
+#
+################################################################################
+
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
+ -DUSE_BUNDLED_JSONCPP=OFF
+SYSDIG_DEPENDENCIES = zlib luajit libjson linux
+SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
+
+$(eval $(cmake-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 10:53 [Buildroot] [PATCH v8] package/sysdig: New package Angelo Compagnucci
@ 2015-03-25 10:56 ` Yegor Yefremov
2015-03-25 18:05 ` Ryan Barnett
2015-03-25 21:56 ` Ryan Barnett
2 siblings, 0 replies; 9+ messages in thread
From: Yegor Yefremov @ 2015-03-25 10:56 UTC (permalink / raw)
To: buildroot
On Wed, Mar 25, 2015 at 11:53 AM, Angelo Compagnucci
<angelo.compagnucci@gmail.com> wrote:
> Sysdig is open source, system-level exploration:
> capture system state and activity from a running Linux
> instance, then save, filter and analyze.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes v7 -> v8:
> - sysdig now alphabetically ordered in Config.in
>
> Changes v6 -> v7:
> - Fixing a nasty mistake in Config.in
>
> Changes v5 -> v6:
> - Patching kernel module makefile to be compatible with buildroot.
> - Patching cmakefile to remove unneed installation of DKMS infrastructure.
> - Removing of unneeded post installation script.
> - Added -DUSE_BUNDLED_JSONCPP = NO
> - Package is now at the bare minimum.
>
> Changes v4 -> v5:
> - Adjusted to 80 columns for sysdig.mk header
>
> Changes v3 -> v4:
> - Changed "depends on" to "select" and fixed selected packages
> dependencies.
> - moved "comment" section to the bottom
>
> Changes v2 -> v3:
> - Changed "depends on" and "select" to simplify package
>
> Changes v1 -> v2:
> - Changed "depends on" with "select" for dependencies (suggested by Baruch)
> - Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
> - Upgreded to recently released 0.1.99
>
> package/Config.in | 1 +
> .../0001-makefile-driver-compile-options.patch | 23 ++++++++++++++++
> .../sysdig/0002-remove-dkms-module-updater.patch | 32 ++++++++++++++++++++++
> package/sysdig/Config.in | 21 ++++++++++++++
> package/sysdig/sysdig.mk | 16 +++++++++++
> 5 files changed, 93 insertions(+)
> create mode 100644 package/sysdig/0001-makefile-driver-compile-options.patch
> create mode 100644 package/sysdig/0002-remove-dkms-module-updater.patch
> create mode 100644 package/sysdig/Config.in
> create mode 100644 package/sysdig/sysdig.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e4ee95d..aaf12ec 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -94,6 +94,7 @@ endif
> source "package/spidev_test/Config.in"
> source "package/strace/Config.in"
> source "package/stress/Config.in"
> + source "package/sysdig/Config.in"
> source "package/sysprof/Config.in"
> source "package/tinymembench/Config.in"
> source "package/trace-cmd/Config.in"
> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
> new file mode 100644
> index 0000000..b3444ad
> --- /dev/null
> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
> @@ -0,0 +1,23 @@
> +Updated Makefile compile options
> +
> +This patch updates linux kernel module (driver) of sysdig to be
> +compatible with buildroot compile flags.
> +
> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> +
> +--- a/driver/Makefile.in
> ++++ b/driver/Makefile.in
> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
> +
> + TOP := $(shell pwd)
> + all:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
> +
> + clean:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
> +
> + install: all
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
> diff --git a/package/sysdig/0002-remove-dkms-module-updater.patch b/package/sysdig/0002-remove-dkms-module-updater.patch
> new file mode 100644
> index 0000000..66fe3dd
> --- /dev/null
> +++ b/package/sysdig/0002-remove-dkms-module-updater.patch
> @@ -0,0 +1,32 @@
> +Remove DKMS module updater
> +
> +This patch disables the in target installation of DKMS module updater
> +mechanism unneeded in buildroot.
> +
> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> +
> +--- a/driver/CMakeLists.txt
> ++++ b/driver/CMakeLists.txt
> +@@ -38,22 +38,3 @@ add_custom_target(install_driver
> + DEPENDS driver
> + WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
> + VERBATIM)
> +-
> +-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Makefile.dkms
> +- RENAME Makefile
> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
> +-
> +-install(FILES
> +- ${CMAKE_CURRENT_BINARY_DIR}/dkms.conf
> +- dynamic_params_table.c
> +- event_table.c
> +- flags_table.c
> +- main.c
> +- ppm.h
> +- ppm_events.c
> +- ppm_events.h
> +- ppm_events_public.h
> +- ppm_fillers.c
> +- ppm_ringbuffer.h
> +- syscall_table.c
> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> new file mode 100644
> index 0000000..caf7ef8
> --- /dev/null
> +++ b/package/sysdig/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_SYSDIG
> + bool "sysdig"
> + select BR2_PACKAGE_ZLIB
> + select BR2_PACKAGE_LUAJIT
> + select BR2_PACKAGE_JSONCPP
> + depends on BR2_LINUX_KERNEL
> + depends on BR2_INSTALL_LIBSTDCPP # libjson
> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> + help
> + Sysdig is open source, system-level exploration:
> + capture system state and activity from a running Linux instance,
> + then save, filter and analyze.
> + Think of it as strace + tcpdump + lsof + awesome sauce.
> + With a little Lua cherry on top.
> +
> + http://sysdig.org
> +
> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> + depends on !BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> new file mode 100644
> index 0000000..769cfe2
> --- /dev/null
> +++ b/package/sysdig/sysdig.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# sysdig
> +#
> +################################################################################
> +
> +SYSDIG_VERSION = 0.1.99
> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> +SYSDIG_LICENSE = GPLv2
> +SYSDIG_LICENSE_FILES = COPYING
> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
> + -DUSE_BUNDLED_JSONCPP=OFF
> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +$(eval $(cmake-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 10:53 [Buildroot] [PATCH v8] package/sysdig: New package Angelo Compagnucci
2015-03-25 10:56 ` Yegor Yefremov
@ 2015-03-25 18:05 ` Ryan Barnett
2015-03-25 18:29 ` Ryan Barnett
2015-03-25 21:50 ` Angelo Compagnucci
2015-03-25 21:56 ` Ryan Barnett
2 siblings, 2 replies; 9+ messages in thread
From: Ryan Barnett @ 2015-03-25 18:05 UTC (permalink / raw)
To: buildroot
Angelo,
On Wed, Mar 25, 2015 at 5:53 AM, Angelo Compagnucci
<angelo.compagnucci@gmail.com> wrote:
[...]
> package/Config.in | 1 +
> .../0001-makefile-driver-compile-options.patch | 23 ++++++++++++++++
> .../sysdig/0002-remove-dkms-module-updater.patch | 32 ++++++++++++++++++++++
> package/sysdig/Config.in | 21 ++++++++++++++
> package/sysdig/sysdig.mk | 16 +++++++++++
> 5 files changed, 93 insertions(+)
> create mode 100644 package/sysdig/0001-makefile-driver-compile-options.patch
Have you submitted this sysdig patch upstream via a github pull request?
Giving it a quick look at 0001 looks like something that could be
upstreamable since
> create mode 100644 package/sysdig/0002-remove-dkms-module-updater.patch
> create mode 100644 package/sysdig/Config.in
> create mode 100644 package/sysdig/sysdig.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e4ee95d..aaf12ec 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -94,6 +94,7 @@ endif
> source "package/spidev_test/Config.in"
> source "package/strace/Config.in"
> source "package/stress/Config.in"
> + source "package/sysdig/Config.in"
> source "package/sysprof/Config.in"
> source "package/tinymembench/Config.in"
> source "package/trace-cmd/Config.in"
> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
> new file mode 100644
> index 0000000..b3444ad
> --- /dev/null
> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
> @@ -0,0 +1,23 @@
> +Updated Makefile compile options
> +
> +This patch updates linux kernel module (driver) of sysdig to be
> +compatible with buildroot compile flags.
> +
> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> +
> +--- a/driver/Makefile.in
> ++++ b/driver/Makefile.in
> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
> +
> + TOP := $(shell pwd)
> + all:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
> +
> + clean:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
> +
> + install: all
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
> diff --git a/package/sysdig/0002-remove-dkms-module-updater.patch b/package/sysdig/0002-remove-dkms-module-updater.patch
> new file mode 100644
> index 0000000..66fe3dd
> --- /dev/null
> +++ b/package/sysdig/0002-remove-dkms-module-updater.patch
> @@ -0,0 +1,32 @@
> +Remove DKMS module updater
> +
> +This patch disables the in target installation of DKMS module updater
> +mechanism unneeded in buildroot.
> +
> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> +
> +--- a/driver/CMakeLists.txt
> ++++ b/driver/CMakeLists.txt
> +@@ -38,22 +38,3 @@ add_custom_target(install_driver
> + DEPENDS driver
> + WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
> + VERBATIM)
> +-
> +-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Makefile.dkms
> +- RENAME Makefile
> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
> +-
> +-install(FILES
> +- ${CMAKE_CURRENT_BINARY_DIR}/dkms.conf
> +- dynamic_params_table.c
> +- event_table.c
> +- flags_table.c
> +- main.c
> +- ppm.h
> +- ppm_events.c
> +- ppm_events.h
> +- ppm_events_public.h
> +- ppm_fillers.c
> +- ppm_ringbuffer.h
> +- syscall_table.c
> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> new file mode 100644
> index 0000000..caf7ef8
> --- /dev/null
> +++ b/package/sysdig/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_SYSDIG
> + bool "sysdig"
> + select BR2_PACKAGE_ZLIB
> + select BR2_PACKAGE_LUAJIT
> + select BR2_PACKAGE_JSONCPP
> + depends on BR2_LINUX_KERNEL
> + depends on BR2_INSTALL_LIBSTDCPP # libjson
> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> + help
> + Sysdig is open source, system-level exploration:
> + capture system state and activity from a running Linux instance,
> + then save, filter and analyze.
> + Think of it as strace + tcpdump + lsof + awesome sauce.
> + With a little Lua cherry on top.
> +
> + http://sysdig.org
> +
> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> + depends on !BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> new file mode 100644
> index 0000000..769cfe2
> --- /dev/null
> +++ b/package/sysdig/sysdig.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# sysdig
> +#
> +################################################################################
> +
> +SYSDIG_VERSION = 0.1.99
> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> +SYSDIG_LICENSE = GPLv2
> +SYSDIG_LICENSE_FILES = COPYING
> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
> + -DUSE_BUNDLED_JSONCPP=OFF
> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
In your previous email you gave a link to saying why luajit is required:
[1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/
However, from reading the documentation it says that you can use the
bundled luajit. Quoting from the site you provided:
> +$(eval $(cmake-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 18:05 ` Ryan Barnett
@ 2015-03-25 18:29 ` Ryan Barnett
2015-03-25 18:47 ` Thomas Petazzoni
2015-03-25 21:50 ` Angelo Compagnucci
1 sibling, 1 reply; 9+ messages in thread
From: Ryan Barnett @ 2015-03-25 18:29 UTC (permalink / raw)
To: buildroot
Angelo,
I apologies as I accidentally pressed a keyboard shortcut that sent
the email prematurely.
On Wed, Mar 25, 2015 at 1:05 PM, Ryan Barnett
<ryan.barnett@rockwellcollins.com> wrote:
> Angelo,
>
> On Wed, Mar 25, 2015 at 5:53 AM, Angelo Compagnucci
> <angelo.compagnucci@gmail.com> wrote:
>
> [...]
>
>> package/Config.in | 1 +
>> .../0001-makefile-driver-compile-options.patch | 23 ++++++++++++++++
>> .../sysdig/0002-remove-dkms-module-updater.patch | 32 ++++++++++++++++++++++
>> package/sysdig/Config.in | 21 ++++++++++++++
>> package/sysdig/sysdig.mk | 16 +++++++++++
>> 5 files changed, 93 insertions(+)
>> create mode 100644 package/sysdig/0001-makefile-driver-compile-options.patch
>
> Have you submitted this sysdig patch upstream via a github pull request?
>
> Giving it a quick look at 0001 looks like something that could be
> upstreamable since
So upon further review of your 0001 patch I have some questions which
you can see below.
>
>> create mode 100644 package/sysdig/0002-remove-dkms-module-updater.patch
>> create mode 100644 package/sysdig/Config.in
>> create mode 100644 package/sysdig/sysdig.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index e4ee95d..aaf12ec 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -94,6 +94,7 @@ endif
>> source "package/spidev_test/Config.in"
>> source "package/strace/Config.in"
>> source "package/stress/Config.in"
>> + source "package/sysdig/Config.in"
>> source "package/sysprof/Config.in"
>> source "package/tinymembench/Config.in"
>> source "package/trace-cmd/Config.in"
>> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
>> new file mode 100644
>> index 0000000..b3444ad
>> --- /dev/null
>> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
>> @@ -0,0 +1,23 @@
>> +Updated Makefile compile options
>> +
>> +This patch updates linux kernel module (driver) of sysdig to be
>> +compatible with buildroot compile flags.
>> +
>> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> +
>> +--- a/driver/Makefile.in
>> ++++ b/driver/Makefile.in
>> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
>> +
>> + TOP := $(shell pwd)
>> + all:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
How is LINUX_MAKE_FLAGS available in your environment when you are
attempting to run these commands? Buildroot doesn't export this
variable to the environment and I don't see how these are available
you cmake is executing this makefile.
>> + clean:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
>> +
>> + install: all
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
>> diff --git a/package/sysdig/0002-remove-dkms-module-updater.patch b/package/sysdig/0002-remove-dkms-module-updater.patch
>> new file mode 100644
>> index 0000000..66fe3dd
>> --- /dev/null
>> +++ b/package/sysdig/0002-remove-dkms-module-updater.patch
>> @@ -0,0 +1,32 @@
>> +Remove DKMS module updater
>> +
>> +This patch disables the in target installation of DKMS module updater
>> +mechanism unneeded in buildroot.
>> +
>> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> +
>> +--- a/driver/CMakeLists.txt
>> ++++ b/driver/CMakeLists.txt
>> +@@ -38,22 +38,3 @@ add_custom_target(install_driver
>> + DEPENDS driver
>> + WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
>> + VERBATIM)
>> +-
>> +-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Makefile.dkms
>> +- RENAME Makefile
>> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
>> +-
>> +-install(FILES
>> +- ${CMAKE_CURRENT_BINARY_DIR}/dkms.conf
>> +- dynamic_params_table.c
>> +- event_table.c
>> +- flags_table.c
>> +- main.c
>> +- ppm.h
>> +- ppm_events.c
>> +- ppm_events.h
>> +- ppm_events_public.h
>> +- ppm_fillers.c
>> +- ppm_ringbuffer.h
>> +- syscall_table.c
>> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
>> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
>> new file mode 100644
>> index 0000000..caf7ef8
>> --- /dev/null
>> +++ b/package/sysdig/Config.in
>> @@ -0,0 +1,21 @@
>> +config BR2_PACKAGE_SYSDIG
>> + bool "sysdig"
>> + select BR2_PACKAGE_ZLIB
>> + select BR2_PACKAGE_LUAJIT
>> + select BR2_PACKAGE_JSONCPP
>> + depends on BR2_LINUX_KERNEL
>> + depends on BR2_INSTALL_LIBSTDCPP # libjson
>> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>> + help
>> + Sysdig is open source, system-level exploration:
>> + capture system state and activity from a running Linux instance,
>> + then save, filter and analyze.
>> + Think of it as strace + tcpdump + lsof + awesome sauce.
>> + With a little Lua cherry on top.
>> +
>> + http://sysdig.org
>> +
>> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
>> + depends on !BR2_LINUX_KERNEL
>> + depends on !BR2_INSTALL_LIBSTDCPP
>> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
>> new file mode 100644
>> index 0000000..769cfe2
>> --- /dev/null
>> +++ b/package/sysdig/sysdig.mk
>> @@ -0,0 +1,16 @@
>> +################################################################################
>> +#
>> +# sysdig
>> +#
>> +################################################################################
>> +
>> +SYSDIG_VERSION = 0.1.99
>> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
>> +SYSDIG_LICENSE = GPLv2
>> +SYSDIG_LICENSE_FILES = COPYING
>> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
>> + -DUSE_BUNDLED_JSONCPP=OFF
>> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
>> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
>
In your previous email you gave a link to saying why luajit is required:
[1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/
However, from reading the documentation it says that you can use the
bundled luajit. Quoting from the site you provided:
---
By default the bundled version of LuaJIT will be built and linked
statically. If you prefer to use the system one, then you can do:
cmake -DUSE_BUNDLED_LUAJIT=OFF ..
---
This would imply that we can make an optional dependency on luajit by
doing something like this:
ifeq ($(BR2_PACKAGE_LUAJIT),y)
SYSDIG_CONF_OPTS += DUSE_BUNDLED_LUAJIT=OFF
SYSDIG_DEPENDENCIES += luajit
endif
I don't think it make sense to have an else case here since it doesn't
mention having to define BUNDLED_LUAJIT as on.
It appears that you can the same for zlib and jsoncpp as well. I have
not tried this yet but from reading the documentation it appears that
this all possible.
Thanks,
-Ryan
--
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 18:29 ` Ryan Barnett
@ 2015-03-25 18:47 ` Thomas Petazzoni
2015-03-25 21:20 ` Ryan Barnett
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2015-03-25 18:47 UTC (permalink / raw)
To: buildroot
Dear Ryan Barnett,
On Wed, 25 Mar 2015 13:29:56 -0500, Ryan Barnett wrote:
> In your previous email you gave a link to saying why luajit is required:
>
> [1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/
>
> However, from reading the documentation it says that you can use the
> bundled luajit. Quoting from the site you provided:
>
> ---
> By default the bundled version of LuaJIT will be built and linked
> statically. If you prefer to use the system one, then you can do:
>
> cmake -DUSE_BUNDLED_LUAJIT=OFF ..
> ---
>
> This would imply that we can make an optional dependency on luajit by
> doing something like this:
>
> ifeq ($(BR2_PACKAGE_LUAJIT),y)
> SYSDIG_CONF_OPTS += DUSE_BUNDLED_LUAJIT=OFF
> SYSDIG_DEPENDENCIES += luajit
> endif
>
> I don't think it make sense to have an else case here since it doesn't
> mention having to define BUNDLED_LUAJIT as on.
>
> It appears that you can the same for zlib and jsoncpp as well. I have
> not tried this yet but from reading the documentation it appears that
> this all possible.
Well, it depends. If those dependencies are indeed mandatory (i.e
sysdig always needs LuaJIT, be it a bundled version or a
system-provided version), I believe we generally prefer to always use
the system-generated version. Using bundling version is not really nice
to make sure that the latest versions of LuaJit/zlib/jsoncpp are used.
So, in general, I think we prefer to use system-provided versions,
unless using the bundled version is absolutely necessary (tight version
dependency, specific hacks done, etc.).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 18:47 ` Thomas Petazzoni
@ 2015-03-25 21:20 ` Ryan Barnett
0 siblings, 0 replies; 9+ messages in thread
From: Ryan Barnett @ 2015-03-25 21:20 UTC (permalink / raw)
To: buildroot
Thomas,
On Wed, Mar 25, 2015 at 1:47 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> Well, it depends. If those dependencies are indeed mandatory (i.e
> sysdig always needs LuaJIT, be it a bundled version or a
> system-provided version), I believe we generally prefer to always use
> the system-generated version. Using bundling version is not really nice
> to make sure that the latest versions of LuaJit/zlib/jsoncpp are used.
>
> So, in general, I think we prefer to use system-provided versions,
> unless using the bundled version is absolutely necessary (tight version
> dependency, specific hacks done, etc.).
Thank you for the clarification! So he is correct in forcing
luajit/zlib/jsoncpp to be build in your target.
Thanks,
-Ryan
--
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 18:05 ` Ryan Barnett
2015-03-25 18:29 ` Ryan Barnett
@ 2015-03-25 21:50 ` Angelo Compagnucci
1 sibling, 0 replies; 9+ messages in thread
From: Angelo Compagnucci @ 2015-03-25 21:50 UTC (permalink / raw)
To: buildroot
Dear Ryan Barnett,
2015-03-25 19:05 GMT+01:00 Ryan Barnett <ryan.barnett@rockwellcollins.com>:
> Angelo,
>
> On Wed, Mar 25, 2015 at 5:53 AM, Angelo Compagnucci
> <angelo.compagnucci@gmail.com> wrote:
>
> [...]
>
>> package/Config.in | 1 +
>> .../0001-makefile-driver-compile-options.patch | 23 ++++++++++++++++
>> .../sysdig/0002-remove-dkms-module-updater.patch | 32 ++++++++++++++++++++++
>> package/sysdig/Config.in | 21 ++++++++++++++
>> package/sysdig/sysdig.mk | 16 +++++++++++
>> 5 files changed, 93 insertions(+)
>> create mode 100644 package/sysdig/0001-makefile-driver-compile-options.patch
>
> Have you submitted this sysdig patch upstream via a github pull request?
I don't think they will be interested cause the patch is strictly
releated to buildroot, $(LINUX_MAKE_FLAGS) is indeed a buildroot
defined variable not applicable in other contexts.
> Giving it a quick look at 0001 looks like something that could be
> upstreamable since
>
>> create mode 100644 package/sysdig/0002-remove-dkms-module-updater.patch
>> create mode 100644 package/sysdig/Config.in
>> create mode 100644 package/sysdig/sysdig.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index e4ee95d..aaf12ec 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -94,6 +94,7 @@ endif
>> source "package/spidev_test/Config.in"
>> source "package/strace/Config.in"
>> source "package/stress/Config.in"
>> + source "package/sysdig/Config.in"
>> source "package/sysprof/Config.in"
>> source "package/tinymembench/Config.in"
>> source "package/trace-cmd/Config.in"
>> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
>> new file mode 100644
>> index 0000000..b3444ad
>> --- /dev/null
>> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
>> @@ -0,0 +1,23 @@
>> +Updated Makefile compile options
>> +
>> +This patch updates linux kernel module (driver) of sysdig to be
>> +compatible with buildroot compile flags.
>> +
>> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> +
>> +--- a/driver/Makefile.in
>> ++++ b/driver/Makefile.in
>> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
>> +
>> + TOP := $(shell pwd)
>> + all:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
>> +
>> + clean:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
>> +
>> + install: all
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
>> diff --git a/package/sysdig/0002-remove-dkms-module-updater.patch b/package/sysdig/0002-remove-dkms-module-updater.patch
>> new file mode 100644
>> index 0000000..66fe3dd
>> --- /dev/null
>> +++ b/package/sysdig/0002-remove-dkms-module-updater.patch
>> @@ -0,0 +1,32 @@
>> +Remove DKMS module updater
>> +
>> +This patch disables the in target installation of DKMS module updater
>> +mechanism unneeded in buildroot.
>> +
>> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> +
>> +--- a/driver/CMakeLists.txt
>> ++++ b/driver/CMakeLists.txt
>> +@@ -38,22 +38,3 @@ add_custom_target(install_driver
>> + DEPENDS driver
>> + WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
>> + VERBATIM)
>> +-
>> +-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Makefile.dkms
>> +- RENAME Makefile
>> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
>> +-
>> +-install(FILES
>> +- ${CMAKE_CURRENT_BINARY_DIR}/dkms.conf
>> +- dynamic_params_table.c
>> +- event_table.c
>> +- flags_table.c
>> +- main.c
>> +- ppm.h
>> +- ppm_events.c
>> +- ppm_events.h
>> +- ppm_events_public.h
>> +- ppm_fillers.c
>> +- ppm_ringbuffer.h
>> +- syscall_table.c
>> +- DESTINATION "src/sysdig-${SYSDIG_VERSION}")
>> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
>> new file mode 100644
>> index 0000000..caf7ef8
>> --- /dev/null
>> +++ b/package/sysdig/Config.in
>> @@ -0,0 +1,21 @@
>> +config BR2_PACKAGE_SYSDIG
>> + bool "sysdig"
>> + select BR2_PACKAGE_ZLIB
>> + select BR2_PACKAGE_LUAJIT
>> + select BR2_PACKAGE_JSONCPP
>> + depends on BR2_LINUX_KERNEL
>> + depends on BR2_INSTALL_LIBSTDCPP # libjson
>> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>> + help
>> + Sysdig is open source, system-level exploration:
>> + capture system state and activity from a running Linux instance,
>> + then save, filter and analyze.
>> + Think of it as strace + tcpdump + lsof + awesome sauce.
>> + With a little Lua cherry on top.
>> +
>> + http://sysdig.org
>> +
>> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
>> + depends on !BR2_LINUX_KERNEL
>> + depends on !BR2_INSTALL_LIBSTDCPP
>> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
>> new file mode 100644
>> index 0000000..769cfe2
>> --- /dev/null
>> +++ b/package/sysdig/sysdig.mk
>> @@ -0,0 +1,16 @@
>> +################################################################################
>> +#
>> +# sysdig
>> +#
>> +################################################################################
>> +
>> +SYSDIG_VERSION = 0.1.99
>> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
>> +SYSDIG_LICENSE = GPLv2
>> +SYSDIG_LICENSE_FILES = COPYING
>> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
>> + -DUSE_BUNDLED_JSONCPP=OFF
>> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
>> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
>
> In your previous email you gave a link to saying why luajit is required:
>
> [1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/
>
> However, from reading the documentation it says that you can use the
> bundled luajit. Quoting from the site you provided:
I think that deduplication is really important here. Having only a
system wide library installed is more appropriated for an embedded
system where resources is limited, instead of having several libraries
with similar functionality installed.
Sincerely, Angelo
>
>
>> +$(eval $(cmake-package))
>> --
>> 1.9.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
>
> --
> Ryan Barnett / Sr Software Engineer
> Airborne Information Systems / Security Systems and Software
> MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
> ryan.barnett at rockwellcollins.com
> www.rockwellcollins.com
--
Profile: http://it.linkedin.com/in/compagnucciangelo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 10:53 [Buildroot] [PATCH v8] package/sysdig: New package Angelo Compagnucci
2015-03-25 10:56 ` Yegor Yefremov
2015-03-25 18:05 ` Ryan Barnett
@ 2015-03-25 21:56 ` Ryan Barnett
2015-03-26 15:17 ` Angelo Compagnucci
2 siblings, 1 reply; 9+ messages in thread
From: Ryan Barnett @ 2015-03-25 21:56 UTC (permalink / raw)
To: buildroot
Angelo,
Sorry for the noise before I have now had a change to actually
download and try your patch out. Please see the issues that I have had
when just doing a build with 'make sysdig'
On Wed, Mar 25, 2015 at 5:53 AM, Angelo Compagnucci
<angelo.compagnucci@gmail.com> wrote:
>
> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
> new file mode 100644
> index 0000000..b3444ad
> --- /dev/null
> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
> @@ -0,0 +1,23 @@
> +Updated Makefile compile options
> +
> +This patch updates linux kernel module (driver) of sysdig to be
> +compatible with buildroot compile flags.
> +
> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> +
> +--- a/driver/Makefile.in
> ++++ b/driver/Makefile.in
> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
> +
> + TOP := $(shell pwd)
> + all:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
This doesn't work because when I do a build and run file on the .ko I
get the following:
$ file build/sysdig-0.1.99/buildroot-build/driver/sysdig-probe.ko
build/sysdig-0.1.99/buildroot-build/driver/sysdig-probe.ko: ELF 64-bit
LSB relocatable, x86-64, version 1 (SYSV),
BuildID[sha1]=0ea061af98e9fd2b5ba04d2be1c309833a20217a, not stripped
My target was a Cortex-A5 (arm 32-bit LE). So this patch isn't working
because I think KERNELDIR is being set by above to /lib/modules$(shell
uname -r)/build
So in order to use this patch with buildroot we need to modify the
sysdig.mk in order to make this work.
> +
> + clean:
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
> +
> + install: all
> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
[...]
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> new file mode 100644
> index 0000000..769cfe2
> --- /dev/null
> +++ b/package/sysdig/sysdig.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# sysdig
> +#
> +################################################################################
> +
> +SYSDIG_VERSION = 0.1.99
> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> +SYSDIG_LICENSE = GPLv2
> +SYSDIG_LICENSE_FILES = COPYING
> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
> + -DUSE_BUNDLED_JSONCPP=OFF
In order to make sure the kernel driver is actually cross compiling
with buildroot's kernel I had to add the following:
SYSDIG_MAKE_ENV = KERNELDIR="$(LINUX_SRCDIR)" \
LINUX_MAKE_FLAGS='$(LINUX_MAKE_FLAGS)'
(Note: spacing should be a tab).
> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
I think your dependancy should be on 'jsoncpp' instead of libjson. I
was unable to detect jsoncpp in the configure step when just running:
'make sysdig'
> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +$(eval $(cmake-package))
Thanks,
-Ryan
--
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v8] package/sysdig: New package
2015-03-25 21:56 ` Ryan Barnett
@ 2015-03-26 15:17 ` Angelo Compagnucci
0 siblings, 0 replies; 9+ messages in thread
From: Angelo Compagnucci @ 2015-03-26 15:17 UTC (permalink / raw)
To: buildroot
Dear Ryan Barnett,
2015-03-25 22:56 GMT+01:00 Ryan Barnett <ryan.barnett@rockwellcollins.com>:
> Angelo,
>
> Sorry for the noise before I have now had a change to actually
> download and try your patch out. Please see the issues that I have had
> when just doing a build with 'make sysdig'
>
> On Wed, Mar 25, 2015 at 5:53 AM, Angelo Compagnucci
> <angelo.compagnucci@gmail.com> wrote:
>>
>> diff --git a/package/sysdig/0001-makefile-driver-compile-options.patch b/package/sysdig/0001-makefile-driver-compile-options.patch
>> new file mode 100644
>> index 0000000..b3444ad
>> --- /dev/null
>> +++ b/package/sysdig/0001-makefile-driver-compile-options.patch
>> @@ -0,0 +1,23 @@
>> +Updated Makefile compile options
>> +
>> +This patch updates linux kernel module (driver) of sysdig to be
>> +compatible with buildroot compile flags.
>> +
>> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> +
>> +--- a/driver/Makefile.in
>> ++++ b/driver/Makefile.in
>> +@@ -6,10 +6,10 @@ KERNELDIR ?= /lib/modules/$(shell uname -r)/build
>> +
>> + TOP := $(shell pwd)
>> + all:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules
>
> This doesn't work because when I do a build and run file on the .ko I
> get the following:
>
> $ file build/sysdig-0.1.99/buildroot-build/driver/sysdig-probe.ko
> build/sysdig-0.1.99/buildroot-build/driver/sysdig-probe.ko: ELF 64-bit
> LSB relocatable, x86-64, version 1 (SYSV),
> BuildID[sha1]=0ea061af98e9fd2b5ba04d2be1c309833a20217a, not stripped
>
> My target was a Cortex-A5 (arm 32-bit LE). So this patch isn't working
> because I think KERNELDIR is being set by above to /lib/modules$(shell
> uname -r)/build
>
> So in order to use this patch with buildroot we need to modify the
> sysdig.mk in order to make this work.
>
>> +
>> + clean:
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) clean
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) clean
>> +
>> + install: all
>> +- $(MAKE) -C $(KERNELDIR) M=$(TOP) modules_install
>> ++ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(KERNELDIR) M=$(TOP) modules_install
>
> [...]
>
>> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
>> new file mode 100644
>> index 0000000..769cfe2
>> --- /dev/null
>> +++ b/package/sysdig/sysdig.mk
>> @@ -0,0 +1,16 @@
>> +################################################################################
>> +#
>> +# sysdig
>> +#
>> +################################################################################
>> +
>> +SYSDIG_VERSION = 0.1.99
>> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
>> +SYSDIG_LICENSE = GPLv2
>> +SYSDIG_LICENSE_FILES = COPYING
>> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \
>> + -DUSE_BUNDLED_JSONCPP=OFF
>
> In order to make sure the kernel driver is actually cross compiling
> with buildroot's kernel I had to add the following:
>
> SYSDIG_MAKE_ENV = KERNELDIR="$(LINUX_SRCDIR)" \
> LINUX_MAKE_FLAGS='$(LINUX_MAKE_FLAGS)'
>
> (Note: spacing should be a tab).
>
>
>> +SYSDIG_DEPENDENCIES = zlib luajit libjson linux
>
> I think your dependancy should be on 'jsoncpp' instead of libjson. I
> was unable to detect jsoncpp in the configure step when just running:
>
> 'make sysdig'
I submitted and updated patch addressing these issues. I tested the
patch several time and now it should work like expected.
>
>> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
>> +
>> +$(eval $(cmake-package))
>
> Thanks,
> -Ryan
>
> --
> Ryan Barnett / Sr Software Engineer
> Airborne Information Systems / Security Systems and Software
> MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
> ryan.barnett at rockwellcollins.com
> www.rockwellcollins.com
--
Profile: http://it.linkedin.com/in/compagnucciangelo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-03-26 15:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 10:53 [Buildroot] [PATCH v8] package/sysdig: New package Angelo Compagnucci
2015-03-25 10:56 ` Yegor Yefremov
2015-03-25 18:05 ` Ryan Barnett
2015-03-25 18:29 ` Ryan Barnett
2015-03-25 18:47 ` Thomas Petazzoni
2015-03-25 21:20 ` Ryan Barnett
2015-03-25 21:50 ` Angelo Compagnucci
2015-03-25 21:56 ` Ryan Barnett
2015-03-26 15:17 ` Angelo Compagnucci
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.