Re: [Buildroot] [PATCH 4/4] package/busybox: add service to load kernel modules at boot

* Re: [Buildroot] [PATCH 4/4] package/busybox: add service to load kernel modules at boot
       [not found] <mailman.2285.1655818273.17960.buildroot@buildroot.org>
@ 2022-06-25  5:02 ` Andreas Ziegler
  2022-06-28  7:56   ` Angelo Compagnucci
  2022-06-25  5:32 ` [Buildroot] [PATCH 1/4] system: adding options for configuring wifi Andreas Ziegler
  1 sibling, 1 reply; 11+ messages in thread
From: Andreas Ziegler @ 2022-06-25  5:02 UTC (permalink / raw)
  To: Angelo Compagnucci; +Cc: Buildroot

Hi Angelo,

On 2022-06-21 13:31, Angelo Compagnucci <angelo@amarulasolutions.com> 
wrote:

>> 
>> 
>> On 20/06/2022 23:40, Angelo Compagnucci wrote:
>> > In cases where no hotplug is available (by choice or by the lack of a
>> > proper hotplug method for a device), this service can be used to load
>> > kernel module drivers by reading the /etc/modules file.
>> 
>>   Do you have a concrete example of something that needs this? It's 
>> kind
>> of a
>> hack for e.g. a device connected to a serial port that isn't described 
>> in
>> DT
>> (e.g. on an x86 platform), right?
>> 
> 
> Wifi card connected on SDIO with an out of tree kernel module.
> 
> 
>>   I'm not altogether sure if it is worth making an init script for 
>> that.
>> 
> 
> Most distros out there have the /etc/modules loaded at boot time.
> 
> 
>>   Also, this would belong to the initscripts package because it would 
>> also
>> be
>> needed if busybox isn't used at all (it would of course require kmod).
>> 
> 
> Right, I'll fix it
> 
> 
>> 
>> 
>> >
>> > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>> > ---
>> >   package/busybox/S02modules | 56 ++++++++++++++++++++++++++++++++++++++
>> >   package/busybox/busybox.mk |  2 ++
>> >   2 files changed, 58 insertions(+)
>> >   create mode 100644 package/busybox/S02modules
>> >
>> > diff --git a/package/busybox/S02modules b/package/busybox/S02modules

S02 is a bit early, [mu]dev use S10.

>> > new file mode 100644
>> > index 0000000000..f25712e1ca
>> > --- /dev/null
>> > +++ b/package/busybox/S02modules
>> > @@ -0,0 +1,56 @@
>> > +#!/bin/sh
>> > +
>> > +MODULES="modules"
>> > +
>> > +load_unload() {
>> > +     [ ! -f /etc/${MODULES} ] && echo ' OK' && exit 0
>> > +
>> > +     while read module args; do
>> > +
>> > +             case "$module" in
>> > +                     ""|"#"*) continue ;;
>> > +             esac
>> > +
>> > +             if [ "$1" = "load" ]; then
>> > +                     modprobe -q ${module} ${args} >/dev/null && \
>> > +                             printf ' %s success,' "$module" ||
>> > +                             printf ' %s failed,' "$module"
>> > +             else
>> > +                     rmmod ${module} >/dev/null
>> > +             fi
>> > +
>> > +     done < /etc/${MODULES}
>> > +}
>> > +
>> > +start() {
>> > +     printf 'Starting %s:' "$MODULES"
>> > +
>> > +     load_unload load
>> > +
>> > +     echo ' OK'
>> > +}
>> > +
>> > +stop() {
>> > +     printf 'Stopping %s: ' "$MODULES"
>> > +
>> > +     load_unload unload
>> > +
>> > +     echo 'OK'
>> > +}
>> > +
>> > +restart() {
>> > +     stop
>> > +     sleep 1
>> > +     start
>> > +}
>> > +
>> > +case "$1" in
>> > +     start|stop|restart)
>> > +             "$1";;
>> > +     reload)
>> > +             # Restart, since there is no true "reload" feature.
>> > +             restart;;
>> > +     *)
>> > +             echo "Usage: $0 {start|stop|restart|reload}"
>> > +             exit 1
>> > +esac
>> > diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
>> > index 3e49de0a84..40490e866a 100644
>> > --- a/package/busybox/busybox.mk
>> > +++ b/package/busybox/busybox.mk
>> > @@ -382,6 +382,8 @@ define BUSYBOX_INSTALL_TARGET_CMDS
>> >       $(BUSYBOX_INSTALL_UDHCPC_SCRIPT)
>> >       $(BUSYBOX_INSTALL_ZCIP_SCRIPT)
>> >       $(BUSYBOX_INSTALL_MDEV_CONF)
>> > +     $(INSTALL) -m 0755 -D package/busybox/S02modules \
>> > +                     $(TARGET_DIR)/etc/init.d/S02modules;

Since this is intended for systems without dynamic device handling, you 
might use an optional script, similar to BUSYBOX_INSTALL_*_SCRIPT:

# Copy S22modules to /etc/init.d if no dynamic device handling is used
ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
define BUSYBOX_INSTALL_MODULES_SCRIPT
	$(INSTALL) -m 0755 -D package/busybox/S22modules \
		$(TARGET_DIR)/etc/init.d/S22modules;
endef # BUSYBOX_INSTALL_MODULES_SCRIPT

Probably a default /etc/modules could also be installed.

Kind regards,
Andreas

>> 
>>   This is a sysvinit script, so it should be installed in
>> BUSYBOX_INSTALL_INIT_SYSV.
>> 
>> 
>> 
>>   Regards,
>>   Arnout
>> 
>> >   endef
>> >
>> >   # Install the sysvinit scripts, for the moment, but not those that
>> already
>> 
> 
> 
> --
> 
> Angelo Compagnucci
> 
> Software Engineer
> 
> angelo@amarulasolutions.com
> __________________________________
> Amarula Solutions SRL
> 
> Via le Canevare 30, 31100 Treviso, Veneto, IT
> 
> T. +39 (0)42 243 5310
> info@amarulasolutions.com
> 
> www.amarulasolutions.com
> [`as] https://www.amarulasolutions.com|
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 11+ messages in thread