All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage
Date: Wed, 30 Sep 2020 11:46:06 +0300	[thread overview]
Message-ID: <CA+U=DsofSvQKwSQEye9ONYMJkKiL9er6sH2FTLH-5SgmmnPqOA@mail.gmail.com> (raw)
In-Reply-To: <20200930074728.GD2804081@piout.net>

On Wed, Sep 30, 2020 at 10:48 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> Hi,
>
> On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote:
> > Since the driver should be allowed to build without OF support, the
> > of_match_ptr() is redundant.
> >
>
> This can probably be squashed with the previous commit.
>
> Also, I think that you should really make the driver DT only else, the
> driver will carry dead code and there will be no reminder that a cleanup
> is needed.
>
> I can take care of that if you feel that this is more work than what you
> wanted to spend on this driver.

Ah, you're saying remove the old pdata?
I can do that while waiting for other of my patches to go in.

>
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> >  drivers/iio/adc/at91_adc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> > index 7d846a2852a5..473bffe84fbd 100644
> > --- a/drivers/iio/adc/at91_adc.c
> > +++ b/drivers/iio/adc/at91_adc.c
> > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = {
> >       .id_table = at91_adc_ids,
> >       .driver = {
> >                  .name = DRIVER_NAME,
> > -                .of_match_table = of_match_ptr(at91_adc_dt_ids),
> > +                .of_match_table = at91_adc_dt_ids,
> >                  .pm = &at91_adc_pm_ops,
> >       },
> >  };
> > --
> > 2.17.1
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-arm-kernel@lists.infradead.org,
	Alexandru Ardelean <alexandru.ardelean@analog.com>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage
Date: Wed, 30 Sep 2020 11:46:06 +0300	[thread overview]
Message-ID: <CA+U=DsofSvQKwSQEye9ONYMJkKiL9er6sH2FTLH-5SgmmnPqOA@mail.gmail.com> (raw)
In-Reply-To: <20200930074728.GD2804081@piout.net>

On Wed, Sep 30, 2020 at 10:48 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> Hi,
>
> On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote:
> > Since the driver should be allowed to build without OF support, the
> > of_match_ptr() is redundant.
> >
>
> This can probably be squashed with the previous commit.
>
> Also, I think that you should really make the driver DT only else, the
> driver will carry dead code and there will be no reminder that a cleanup
> is needed.
>
> I can take care of that if you feel that this is more work than what you
> wanted to spend on this driver.

Ah, you're saying remove the old pdata?
I can do that while waiting for other of my patches to go in.

>
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> >  drivers/iio/adc/at91_adc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> > index 7d846a2852a5..473bffe84fbd 100644
> > --- a/drivers/iio/adc/at91_adc.c
> > +++ b/drivers/iio/adc/at91_adc.c
> > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = {
> >       .id_table = at91_adc_ids,
> >       .driver = {
> >                  .name = DRIVER_NAME,
> > -                .of_match_table = of_match_ptr(at91_adc_dt_ids),
> > +                .of_match_table = at91_adc_dt_ids,
> >                  .pm = &at91_adc_pm_ops,
> >       },
> >  };
> > --
> > 2.17.1
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-30  8:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  6:00 [PATCH v2 0/4] iio: adc: at91: misc driver cleanups Alexandru Ardelean
2020-09-30  6:00 ` Alexandru Ardelean
2020-09-30  6:00 ` [PATCH v2 1/4] iio: adc: at91_adc: use of_device_get_match_data() helper Alexandru Ardelean
2020-09-30  6:00   ` Alexandru Ardelean
2020-09-30  7:30   ` Alexandre Belloni
2020-09-30  7:30     ` Alexandre Belloni
2020-09-30  6:00 ` [PATCH v2 2/4] iio: adc: at91_adc: const-ify some driver data Alexandru Ardelean
2020-09-30  6:00   ` Alexandru Ardelean
2020-09-30  7:32   ` Alexandre Belloni
2020-09-30  7:32     ` Alexandre Belloni
2020-09-30  6:00 ` [PATCH v2 3/4] iio: adc: at91_adc: add Kconfig dependency on the OF symbol Alexandru Ardelean
2020-09-30  6:00   ` Alexandru Ardelean
2020-09-30  7:37   ` Alexandre Belloni
2020-09-30  7:37     ` Alexandre Belloni
2020-09-30  8:47     ` Alexandru Ardelean
2020-09-30  8:47       ` Alexandru Ardelean
2020-09-30  6:00 ` [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage Alexandru Ardelean
2020-09-30  6:00   ` Alexandru Ardelean
2020-09-30  7:47   ` Alexandre Belloni
2020-09-30  7:47     ` Alexandre Belloni
2020-09-30  8:46     ` Alexandru Ardelean [this message]
2020-09-30  8:46       ` Alexandru Ardelean
2020-09-30  9:14       ` Alexandre Belloni
2020-09-30  9:14         ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+U=DsofSvQKwSQEye9ONYMJkKiL9er6sH2FTLH-5SgmmnPqOA@mail.gmail.com' \
    --to=ardeleanalex@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.