* [PATCH] drivers: iio: adc: fix unmet dependency on OF
@ 2021-03-28 3:51 Julian Braha
2021-03-29 6:42 ` Alexandru Ardelean
0 siblings, 1 reply; 4+ messages in thread
From: Julian Braha @ 2021-03-28 3:51 UTC (permalink / raw)
To: jic23; +Cc: fazilyildiran, linux-iio, linux-kernel
When AD9467 is enabled, and OF is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for ADI_AXI_ADC
Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
Selected by [y]:
- AD9467 [=y] && IIO [=y] && SPI [=y]
This is because AD9467 selects ADI_AXI_ADC
without selecting or depending on OF,
despite ADI_AXI_ADC depending on OF.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/iio/adc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index e0667c4b3c08..7606c9b1630e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -248,7 +248,7 @@ config AD799X
config AD9467
tristate "Analog Devices AD9467 High Speed ADC driver"
- depends on SPI
+ depends on SPI && OF
select ADI_AXI_ADC
help
Say yes here to build support for Analog Devices:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF
2021-03-28 3:51 [PATCH] drivers: iio: adc: fix unmet dependency on OF Julian Braha
@ 2021-03-29 6:42 ` Alexandru Ardelean
2021-03-29 11:18 ` Andy Shevchenko
2021-03-29 16:18 ` Julian Braha
0 siblings, 2 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2021-03-29 6:42 UTC (permalink / raw)
To: Julian Braha; +Cc: Jonathan Cameron, fazilyildiran, linux-iio, LKML
On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
>
> When AD9467 is enabled, and OF is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> Selected by [y]:
> - AD9467 [=y] && IIO [=y] && SPI [=y]
>
> This is because AD9467 selects ADI_AXI_ADC
> without selecting or depending on OF,
> despite ADI_AXI_ADC depending on OF.
>
Hey,
Thanks for the patch.
This should have been fixed a bit differently with patch:
https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
Can you check if this fixes your setup?
Thanks
Alex
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> drivers/iio/adc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index e0667c4b3c08..7606c9b1630e 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -248,7 +248,7 @@ config AD799X
>
> config AD9467
> tristate "Analog Devices AD9467 High Speed ADC driver"
> - depends on SPI
> + depends on SPI && OF
> select ADI_AXI_ADC
> help
> Say yes here to build support for Analog Devices:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF
2021-03-29 6:42 ` Alexandru Ardelean
@ 2021-03-29 11:18 ` Andy Shevchenko
2021-03-29 16:18 ` Julian Braha
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-03-29 11:18 UTC (permalink / raw)
To: Alexandru Ardelean
Cc: Julian Braha, Jonathan Cameron, Necip Fazil Yildiran, linux-iio, LKML
On Mon, Mar 29, 2021 at 9:43 AM Alexandru Ardelean
<ardeleanalex@gmail.com> wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> > Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> > Selected by [y]:
> > - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.
> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
>
> Can you check if this fixes your setup?
I have to add for sake of the clarification that we are trying really
hard to make drivers agnostic to the device tree provider. In such a
case the same driver can work for all existing providers (ACPI, DT,
and board files with use of software nodes).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF
2021-03-29 6:42 ` Alexandru Ardelean
2021-03-29 11:18 ` Andy Shevchenko
@ 2021-03-29 16:18 ` Julian Braha
1 sibling, 0 replies; 4+ messages in thread
From: Julian Braha @ 2021-03-29 16:18 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-kernel
On Monday, March 29, 2021 2:42:12 AM EDT you wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> > Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> > Selected by [y]:
> > - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.
> >
>
> Hey,
>
> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
>
> Can you check if this fixes your setup?
>
> Thanks
> Alex
>
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> > ---
> > drivers/iio/adc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index e0667c4b3c08..7606c9b1630e 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -248,7 +248,7 @@ config AD799X
> >
> > config AD9467
> > tristate "Analog Devices AD9467 High Speed ADC driver"
> > - depends on SPI
> > + depends on SPI && OF
> > select ADI_AXI_ADC
> > help
> > Say yes here to build support for Analog Devices:
> > --
> > 2.25.1
> >
>
Hi Alex,
I can confirm that this works for me. (https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/)
- Julian Braha
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-29 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-28 3:51 [PATCH] drivers: iio: adc: fix unmet dependency on OF Julian Braha
2021-03-29 6:42 ` Alexandru Ardelean
2021-03-29 11:18 ` Andy Shevchenko
2021-03-29 16:18 ` Julian Braha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.