From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Sam Ravnborg <sam@ravnborg.org> Cc: Rob Herring <robh@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Chris Paterson <Chris.Paterson2@renesas.com>, dri-devel@lists.freedesktop.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: Re: [RESEND PATCH v7] dt-bindings: display: Add idk-2121wr binding Date: Mon, 9 Mar 2020 22:28:26 +0000 [thread overview] Message-ID: <CA+V-a8uRD2Vi05rPw2fw6SQO66EHWG=Z+ZAL23xR_9QSVz7WBw@mail.gmail.com> (raw) In-Reply-To: <20200309214739.GA11495@ravnborg.org> Hi Sam, On Mon, Mar 9, 2020 at 9:47 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Prabhakar > > On Mon, Mar 09, 2020 at 09:23:24PM +0000, Lad, Prabhakar wrote: > > Hi Rob, > > > > On Mon, Mar 9, 2020 at 8:32 PM Rob Herring <robh@kernel.org> wrote: > > > > > > On Fri, 6 Mar 2020 15:20:31 +0000, Lad Prabhakar wrote: > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > Add binding for the idk-2121wr LVDS panel from Advantech. > > > > > > > > Some panel-specific documentation can be found here: > > > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > --- > > > > Apologies for flooding in I missed to add the ML email-ids for the earlier > > > > version so resending it. > > > > > > > > Hi All, > > > > > > > > This patch is part of series [1] ("Add dual-LVDS panel support to EK874), > > > > all the patches have been accepted from it except this one. I have fixed > > > > Rob's comments in this version of the patch. > > > > > > > > [1] https://patchwork.kernel.org/cover/11297589/ > > > > > > > > v6->7 > > > > * Added reference to lvds.yaml > > > > * Changed maintainer to myself > > > > * Switched to dual license > > > > * Dropped required properties except for ports as rest are already listed > > > > in lvds.panel > > > > * Dropped Reviewed-by tag of Laurent, due to the changes made it might not > > > > be valid. > > > > > > > > v5->v6: > > > > * No change > > > > > > > > v4->v5: > > > > * No change > > > > > > > > v3->v4: > > > > * Absorbed patch "dt-bindings: display: Add bindings for LVDS > > > > bus-timings" > > > > * Big restructuring after Rob's and Laurent's comments > > > > > > > > v2->v3: > > > > * New patch > > > > > > > > .../display/panel/advantech,idk-2121wr.yaml | 120 +++++++++++++++++++++ > > > > 1 file changed, 120 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > > > > This panel is a dual channel LVDS, as a result the root port is called as > > ports instead of port and the child node port@0 and port@1 are used for > > even and odd pixels, hence binding has required property as ports instead > > of port. > > What goes wrong is that you have a ref to lvds.yaml - and thus you get > also required from that file. > Agreed. > So basically - I think this binding should not have a ref to lvds.yaml - > as the binding needs to be different. > Yes makes sense, will post a v8 dropping the reference to lvds.yaml Cheers, --Prabhakar > Sam
WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Sam Ravnborg <sam@ravnborg.org> Cc: Mark Rutland <mark.rutland@arm.com>, Chris Paterson <Chris.Paterson2@renesas.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Thierry Reding <thierry.reding@gmail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: Re: [RESEND PATCH v7] dt-bindings: display: Add idk-2121wr binding Date: Mon, 9 Mar 2020 22:28:26 +0000 [thread overview] Message-ID: <CA+V-a8uRD2Vi05rPw2fw6SQO66EHWG=Z+ZAL23xR_9QSVz7WBw@mail.gmail.com> (raw) In-Reply-To: <20200309214739.GA11495@ravnborg.org> Hi Sam, On Mon, Mar 9, 2020 at 9:47 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Prabhakar > > On Mon, Mar 09, 2020 at 09:23:24PM +0000, Lad, Prabhakar wrote: > > Hi Rob, > > > > On Mon, Mar 9, 2020 at 8:32 PM Rob Herring <robh@kernel.org> wrote: > > > > > > On Fri, 6 Mar 2020 15:20:31 +0000, Lad Prabhakar wrote: > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > Add binding for the idk-2121wr LVDS panel from Advantech. > > > > > > > > Some panel-specific documentation can be found here: > > > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > --- > > > > Apologies for flooding in I missed to add the ML email-ids for the earlier > > > > version so resending it. > > > > > > > > Hi All, > > > > > > > > This patch is part of series [1] ("Add dual-LVDS panel support to EK874), > > > > all the patches have been accepted from it except this one. I have fixed > > > > Rob's comments in this version of the patch. > > > > > > > > [1] https://patchwork.kernel.org/cover/11297589/ > > > > > > > > v6->7 > > > > * Added reference to lvds.yaml > > > > * Changed maintainer to myself > > > > * Switched to dual license > > > > * Dropped required properties except for ports as rest are already listed > > > > in lvds.panel > > > > * Dropped Reviewed-by tag of Laurent, due to the changes made it might not > > > > be valid. > > > > > > > > v5->v6: > > > > * No change > > > > > > > > v4->v5: > > > > * No change > > > > > > > > v3->v4: > > > > * Absorbed patch "dt-bindings: display: Add bindings for LVDS > > > > bus-timings" > > > > * Big restructuring after Rob's and Laurent's comments > > > > > > > > v2->v3: > > > > * New patch > > > > > > > > .../display/panel/advantech,idk-2121wr.yaml | 120 +++++++++++++++++++++ > > > > 1 file changed, 120 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > > > > This panel is a dual channel LVDS, as a result the root port is called as > > ports instead of port and the child node port@0 and port@1 are used for > > even and odd pixels, hence binding has required property as ports instead > > of port. > > What goes wrong is that you have a ref to lvds.yaml - and thus you get > also required from that file. > Agreed. > So basically - I think this binding should not have a ref to lvds.yaml - > as the binding needs to be different. > Yes makes sense, will post a v8 dropping the reference to lvds.yaml Cheers, --Prabhakar > Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-09 22:28 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-06 15:20 [RESEND PATCH v7] dt-bindings: display: Add idk-2121wr binding Lad Prabhakar 2020-03-06 15:20 ` Lad Prabhakar 2020-03-09 20:32 ` Rob Herring 2020-03-09 20:32 ` Rob Herring 2020-03-09 21:23 ` Lad, Prabhakar 2020-03-09 21:23 ` Lad, Prabhakar 2020-03-09 21:47 ` Sam Ravnborg 2020-03-09 21:47 ` Sam Ravnborg 2020-03-09 22:28 ` Lad, Prabhakar [this message] 2020-03-09 22:28 ` Lad, Prabhakar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+V-a8uRD2Vi05rPw2fw6SQO66EHWG=Z+ZAL23xR_9QSVz7WBw@mail.gmail.com' \ --to=prabhakar.csengg@gmail.com \ --cc=Chris.Paterson2@renesas.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.