From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, Hans Verkuil <hverkuil@xs4all.nl>, Shawn Tu <shawnx.tu@intel.com>, Jacopo Mondi <jacopo@jmondi.org>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: Re: [PATCH v3 6/9] media: i2c: ov5645: Use runtime PM Date: Thu, 27 Oct 2022 10:48:51 +0100 [thread overview] Message-ID: <CA+V-a8uqPenMqbhixzefspsffLH=P7i7DJ53C7hfv0hMcgGutQ@mail.gmail.com> (raw) In-Reply-To: <Y1pN0oksKeauTpBA@paasikivi.fi.intel.com> Hi Sakari, On Thu, Oct 27, 2022 at 10:22 AM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Prabhakar, > > Thanks for the update. > > On Wed, Oct 26, 2022 at 02:06:55PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Switch to using runtime PM for power management. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > v2->v3 > > * Jumped to err_pm_runtime label in case of sd register failure > > * Now calling pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend() > > call > > * Now calling pm_runtime_put_sync() in case s_stream(1) fails > > * In s_stream(0) no calling pm_runtime_mark_last_busy() and > > pm_runtime_put_autosuspend() > > * Included RB tag from Laurent. > > > > v1->v2 > > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > > --- > > drivers/media/i2c/Kconfig | 2 +- > > drivers/media/i2c/ov5645.c | 141 +++++++++++++++++++------------------ > > 2 files changed, 73 insertions(+), 70 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 7806d4b81716..c0edd1017fe8 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -459,7 +459,7 @@ config VIDEO_OV5640 > > config VIDEO_OV5645 > > tristate "OmniVision OV5645 sensor support" > > depends on OF > > - depends on I2C && VIDEO_DEV > > + depends on I2C && PM && VIDEO_DEV > > I think you can drop the PM dependency --- the driver will work fine > without CONFIG_PM. > Agreed, I'll send a new version dropping this and fixing the comments on patch #5 and patch #8. > Although one could question why do we have CONFIG_PM. Some systems won't > boot without it and who would want to consume more power than necessary? > > Could this be removed altogether? Or perhaps we could add CONFIG_PM > dependency to V4L2 and DVB? :-) > Or rather this option should be selected by the platform itself rather than subsystem? Cheers, Prabhakar
WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> To: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, Hans Verkuil <hverkuil@xs4all.nl>, Shawn Tu <shawnx.tu@intel.com>, Jacopo Mondi <jacopo@jmondi.org>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: Re: [PATCH v3 6/9] media: i2c: ov5645: Use runtime PM Date: Thu, 27 Oct 2022 10:48:51 +0100 [thread overview] Message-ID: <CA+V-a8uqPenMqbhixzefspsffLH=P7i7DJ53C7hfv0hMcgGutQ@mail.gmail.com> (raw) In-Reply-To: <Y1pN0oksKeauTpBA@paasikivi.fi.intel.com> Hi Sakari, On Thu, Oct 27, 2022 at 10:22 AM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Prabhakar, > > Thanks for the update. > > On Wed, Oct 26, 2022 at 02:06:55PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Switch to using runtime PM for power management. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > v2->v3 > > * Jumped to err_pm_runtime label in case of sd register failure > > * Now calling pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend() > > call > > * Now calling pm_runtime_put_sync() in case s_stream(1) fails > > * In s_stream(0) no calling pm_runtime_mark_last_busy() and > > pm_runtime_put_autosuspend() > > * Included RB tag from Laurent. > > > > v1->v2 > > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > > --- > > drivers/media/i2c/Kconfig | 2 +- > > drivers/media/i2c/ov5645.c | 141 +++++++++++++++++++------------------ > > 2 files changed, 73 insertions(+), 70 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 7806d4b81716..c0edd1017fe8 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -459,7 +459,7 @@ config VIDEO_OV5640 > > config VIDEO_OV5645 > > tristate "OmniVision OV5645 sensor support" > > depends on OF > > - depends on I2C && VIDEO_DEV > > + depends on I2C && PM && VIDEO_DEV > > I think you can drop the PM dependency --- the driver will work fine > without CONFIG_PM. > Agreed, I'll send a new version dropping this and fixing the comments on patch #5 and patch #8. > Although one could question why do we have CONFIG_PM. Some systems won't > boot without it and who would want to consume more power than necessary? > > Could this be removed altogether? Or perhaps we could add CONFIG_PM > dependency to V4L2 and DVB? :-) > Or rather this option should be selected by the platform itself rather than subsystem? Cheers, Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-27 9:49 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-26 13:06 [PATCH v3 0/9] media: i2c: ov5645 driver enhancements Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 13:06 ` [PATCH v3 1/9] media: i2c: ov5645: Drop fetching the clk reference by name Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 13:06 ` [PATCH v3 2/9] ARM: dts: imx6qdl-pico: Drop clock-names property Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 13:06 ` [PATCH v3 3/9] ARM: dts: imx6qdl-wandboard: " Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 13:06 ` [PATCH v3 4/9] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: " Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-27 13:14 ` Geert Uytterhoeven 2022-10-27 13:14 ` Geert Uytterhoeven 2022-10-26 13:06 ` [PATCH v3 5/9] media: dt-bindings: ov5645: Convert OV5645 binding to a schema Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 20:10 ` Krzysztof Kozlowski 2022-10-26 20:10 ` Krzysztof Kozlowski 2022-10-26 13:06 ` [PATCH v3 6/9] media: i2c: ov5645: Use runtime PM Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-27 9:22 ` Sakari Ailus 2022-10-27 9:22 ` Sakari Ailus 2022-10-27 9:48 ` Lad, Prabhakar [this message] 2022-10-27 9:48 ` Lad, Prabhakar 2022-10-26 13:06 ` [PATCH v3 7/9] media: i2c: ov5645: Drop empty comment Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 13:06 ` [PATCH v3 8/9] media: i2c: ov5645: Don't return early on failures for s_stream(0) Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-26 17:17 ` Marco Felsch 2022-10-26 17:17 ` Marco Felsch 2022-10-26 17:26 ` Lad, Prabhakar 2022-10-26 17:26 ` Lad, Prabhakar 2022-10-26 17:35 ` Marco Felsch 2022-10-26 17:35 ` Marco Felsch 2022-10-26 18:26 ` Lad, Prabhakar 2022-10-26 18:26 ` Lad, Prabhakar 2022-10-26 13:06 ` [PATCH v3 9/9] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev Prabhakar 2022-10-26 13:06 ` Prabhakar 2022-10-27 9:32 ` [PATCH v3 0/9] media: i2c: ov5645 driver enhancements Sakari Ailus 2022-10-27 9:32 ` Sakari Ailus 2022-10-29 12:54 ` Shawn Guo 2022-10-29 12:54 ` Shawn Guo 2022-10-31 9:56 ` Sakari Ailus 2022-10-31 9:56 ` Sakari Ailus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+V-a8uqPenMqbhixzefspsffLH=P7i7DJ53C7hfv0hMcgGutQ@mail.gmail.com' \ --to=prabhakar.csengg@gmail.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=hverkuil@xs4all.nl \ --cc=jacopo@jmondi.org \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mchehab@kernel.org \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sakari.ailus@linux.intel.com \ --cc=shawnguo@kernel.org \ --cc=shawnx.tu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.