From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Pavel Machek <pavel@denx.de>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
Date: Mon, 10 Jan 2022 20:16:08 +0000 [thread overview]
Message-ID: <CA+V-a8vJzSPxpy0Te1XUiT_zkt4wd=NvFJGvwGkgwcNnibjbhQ@mail.gmail.com> (raw)
In-Reply-To: <f69a0650-174f-1b0d-ba29-7fe04c7cf211@intel.com>
On Mon, Jan 10, 2022 at 5:48 PM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> On 2022-01-10 5:03 PM, Lad, Prabhakar wrote:
> > Hi Cezary,
> >
> > Thank you for the review.
> >
>
> ...
>
> >> Recursion and loops are means for doing something repeatedly. Could you
> >> specify _why_ such change was made i.e. the conversion from one method
> >> into the other? I bet the code is not being changed for the sake of
> >> changing it, the reason is simply missing in the commit message.
> >>
> > I had feedback from Pavel "recursion is unwelcome in kernel due to
> > limited stack use." which I did agree with as a result I have come up
> > with this patch. Also to add this driver will later be used on Renesas
> > RZ/A2 SoC's which runs with limited memory.
>
> Adding that reasoning to the commits message will prevent questions
> (such as mine) in the future. Thank you for a quick reply and a
> transparent answer.
>
My bad! I'll update the commit message.
CHeers,
Prabhakar
WARNING: multiple messages have this Message-ID (diff)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>, Pavel Machek <pavel@denx.de>,
Takashi Iwai <tiwai@suse.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
Date: Mon, 10 Jan 2022 20:16:08 +0000 [thread overview]
Message-ID: <CA+V-a8vJzSPxpy0Te1XUiT_zkt4wd=NvFJGvwGkgwcNnibjbhQ@mail.gmail.com> (raw)
In-Reply-To: <f69a0650-174f-1b0d-ba29-7fe04c7cf211@intel.com>
On Mon, Jan 10, 2022 at 5:48 PM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> On 2022-01-10 5:03 PM, Lad, Prabhakar wrote:
> > Hi Cezary,
> >
> > Thank you for the review.
> >
>
> ...
>
> >> Recursion and loops are means for doing something repeatedly. Could you
> >> specify _why_ such change was made i.e. the conversion from one method
> >> into the other? I bet the code is not being changed for the sake of
> >> changing it, the reason is simply missing in the commit message.
> >>
> > I had feedback from Pavel "recursion is unwelcome in kernel due to
> > limited stack use." which I did agree with as a result I have come up
> > with this patch. Also to add this driver will later be used on Renesas
> > RZ/A2 SoC's which runs with limited memory.
>
> Adding that reasoning to the commits message will prevent questions
> (such as mine) in the future. Thank you for a quick reply and a
> transparent answer.
>
My bad! I'll update the commit message.
CHeers,
Prabhakar
next prev parent reply other threads:[~2022-01-10 20:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 9:47 [PATCH 0/5] ASoC: sh: rz-ssi: Code cleanup and fixes Lad Prabhakar
2022-01-10 9:47 ` [PATCH 1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively Lad Prabhakar
2022-01-10 9:47 ` Lad Prabhakar
2022-01-10 15:48 ` Cezary Rojewski
2022-01-10 15:48 ` Cezary Rojewski
2022-01-10 16:03 ` Lad, Prabhakar
2022-01-10 16:03 ` Lad, Prabhakar
2022-01-10 17:48 ` Cezary Rojewski
2022-01-10 17:48 ` Cezary Rojewski
2022-01-10 20:16 ` Lad, Prabhakar [this message]
2022-01-10 20:16 ` Lad, Prabhakar
2022-01-10 18:44 ` Pavel Machek
2022-01-10 18:44 ` Pavel Machek
2022-01-10 18:58 ` Cezary Rojewski
2022-01-10 18:58 ` Cezary Rojewski
2022-01-10 9:47 ` [PATCH 2/5] ASoC: sh: rz-ssi: Make the data structures available before registering the handlers Lad Prabhakar
2022-01-10 9:47 ` Lad Prabhakar
2022-01-10 9:47 ` [PATCH 3/5] ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() Lad Prabhakar
2022-01-10 9:47 ` Lad Prabhakar
2022-01-10 9:47 ` [PATCH 4/5] ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool Lad Prabhakar
2022-01-10 9:47 ` Lad Prabhakar
2022-01-10 9:47 ` [PATCH 5/5] ASoC: sh: rz-ssi: Add functions to get/set substream pointer Lad Prabhakar
2022-01-10 9:47 ` Lad Prabhakar
2022-01-10 15:10 ` Mark Brown
2022-01-10 15:10 ` Mark Brown
2022-01-10 16:14 ` Lad, Prabhakar
2022-01-10 16:14 ` Lad, Prabhakar
2022-01-25 10:20 ` (subset) [PATCH 0/5] ASoC: sh: rz-ssi: Code cleanup and fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8vJzSPxpy0Te1XUiT_zkt4wd=NvFJGvwGkgwcNnibjbhQ@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=pavel@denx.de \
--cc=perex@perex.cz \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.