[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] mptcp: create subflow for newly added address and testcases

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] mptcp: create subflow for newly added address and testcases

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

Hi Paolo,

Paolo Abeni <pabeni(a)redhat.com> 于2020年12月22日周二 下午5:48写道：
>
> On Fri, 2020-12-18 at 14:33 -0800, Mat Martineau wrote:
> > On Fri, 18 Dec 2020, Geliang Tang wrote:
> >
> > > v2:
> > > - drop the unused addr parameter in mptcp_nl_add_subflow_or_signal_addr
> > > - use the pernet *_max values in mptcp_pm_create_subflow_or_signal_addr
> > > instead of the per-msk values.
> > >
> >
> > Paolo, do you think the per-msk add_addr_signal_max and local_addr_max are
> > still needed? It's not clear to me what having pernet and per-msk copies
> > of those values will help accomplish.
>
> Well, that was likely overdesign on my side. I thought it would be
> easier and/or faster have the limit avail in each msk. It looks like
> it's not really the case. I think the same consideration applies to '
> local_addr_max' and 'subflows_max' so I guess we can drop all the
> 'pm.*max' fields.
>
> (in a separate patch)
>

Thanks for your suggestion, I'll write a new patch to drop those *max fields.

-Geliang

> Thanks!
>
> Paolo
>

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] mptcp: create subflow for newly added address and testcases

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Fri, 2020-12-18 at 14:33 -0800, Mat Martineau wrote:
> On Fri, 18 Dec 2020, Geliang Tang wrote:
> 
> > v2:
> > - drop the unused addr parameter in mptcp_nl_add_subflow_or_signal_addr
> > - use the pernet *_max values in mptcp_pm_create_subflow_or_signal_addr
> > instead of the per-msk values.
> > 
> 
> Paolo, do you think the per-msk add_addr_signal_max and local_addr_max are 
> still needed? It's not clear to me what having pernet and per-msk copies 
> of those values will help accomplish.

Well, that was likely overdesign on my side. I thought it would be
easier and/or faster have the limit avail in each msk. It looks like
it's not really the case. I think the same consideration applies to '
local_addr_max' and 'subflows_max' so I guess we can drop all the
'pm.*max' fields.

(in a separate patch)

Thanks!

Paolo

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 0/3] mptcp: create subflow for newly added address and testcases

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]


On Fri, 18 Dec 2020, Geliang Tang wrote:

> v2:
> - drop the unused addr parameter in mptcp_nl_add_subflow_or_signal_addr
> - use the pernet *_max values in mptcp_pm_create_subflow_or_signal_addr
> instead of the per-msk values.
>

Paolo, do you think the per-msk add_addr_signal_max and local_addr_max are 
still needed? It's not clear to me what having pernet and per-msk copies 
of those values will help accomplish.

> Address issue 19 "let PM netlink update live sockets on local addresses
> list change". The removed addresses part of this issue is done, this
> patchset only implemented the added addresses part.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/19
>
> Geliang Tang (3):
>  mptcp: create subflow or signal addr for newly added address
>  selftests: mptcp: use minus value for removing address numbers
>  selftests: mptcp: add testcases for newly added addresses
>
> net/mptcp/pm_netlink.c                        |  43 ++++++--
> .../testing/selftests/net/mptcp/mptcp_join.sh | 101 +++++++++++++++---
> 2 files changed, 123 insertions(+), 21 deletions(-)
>
> -- 
> 2.29.2

--
Mat Martineau
Intel