[MPTCP] Re: [MPTCP][PATCH v9 mptcp-next 0/9] ADD_ADDR: ports support

[MPTCP] Re: [MPTCP][PATCH v9 mptcp-next 0/9] ADD_ADDR: ports support

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Hi Mat,

Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2021年1月9日周六 上午7:19写道：
>
>
> On Tue, 5 Jan 2021, Geliang Tang wrote:
>
> > v9:
> > - use queue_rcu_work to release the listening socket.
> > - squash v8's patch 2 with patch 3.
> > - add two new patches, "mptcp: drop unused skb in
> > subflow_token_join_request" and "mptcp: add a new helper
> > subflow_req_create_thmac"
> >
>
> Hi Geliang -
>
> I'd like to make a request to make review easier: Please include in the
> cover letter the base commit where the patches apply successfully, or a
> reference to a public git repo showing the full commit history. It took
> some trial and error to figure out that this patch set only applied on top
> of the export branch with the "add-IPv4-mapped address support v4" patch
> set applied too.
>
> For example, referencing the export tag from the mptcp_net-next repo (like
> export/20201217T083536) and the patch set name and revision for any
> prerequisite patch sets would really help.

Sorry for the trouble, I just sent my commit log to you.

Thanks.

-Geliang

>
> Thanks!
>
> --
> Mat Martineau
> Intel

[MPTCP] Re: [MPTCP][PATCH v9 mptcp-next 0/9] ADD_ADDR: ports support

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]


On Tue, 5 Jan 2021, Geliang Tang wrote:

> v9:
> - use queue_rcu_work to release the listening socket.
> - squash v8's patch 2 with patch 3.
> - add two new patches, "mptcp: drop unused skb in
> subflow_token_join_request" and "mptcp: add a new helper
> subflow_req_create_thmac"
>

Hi Geliang -

I'd like to make a request to make review easier: Please include in the 
cover letter the base commit where the patches apply successfully, or a 
reference to a public git repo showing the full commit history. It took 
some trial and error to figure out that this patch set only applied on top 
of the export branch with the "add-IPv4-mapped address support v4" patch 
set applied too.

For example, referencing the export tag from the mptcp_net-next repo (like 
export/20201217T083536) and the patch set name and revision for any 
prerequisite patch sets would really help.

Thanks!

--
Mat Martineau
Intel