[MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: drop *_max fields in mptcp_pm_data"

[MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: drop *_max fields in mptcp_pm_data"

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi Matt,

Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2021年1月16日周六 下午7:49写道：
>
> Hi
>
> On 16/01/2021 12:36, Matthieu Baerts wrote:
> > We need to export these functions that are also used in mptcp_diag.c
> > which can be part of a separated module.
> >
> > We can then avoid these errors:
> >
> >    ERROR: modpost: "mptcp_pm_get_add_addr_accept_max" [net/mptcp/mptcp_diag.ko] undefined!
> >    ERROR: modpost: "mptcp_pm_get_add_addr_signal_max" [net/mptcp/mptcp_diag.ko] undefined!
> >    ERROR: modpost: "mptcp_pm_get_subflows_max" [net/mptcp/mptcp_diag.ko] undefined!
>
> This is now applied in our git repo.
>

Thanks for this fix.

-Geliang

> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org

[MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: drop *_max fields in mptcp_pm_data"

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Hi

On 16/01/2021 12:36, Matthieu Baerts wrote:
> We need to export these functions that are also used in mptcp_diag.c
> which can be part of a separated module.
> 
> We can then avoid these errors:
> 
>    ERROR: modpost: "mptcp_pm_get_add_addr_accept_max" [net/mptcp/mptcp_diag.ko] undefined!
>    ERROR: modpost: "mptcp_pm_get_add_addr_signal_max" [net/mptcp/mptcp_diag.ko] undefined!
>    ERROR: modpost: "mptcp_pm_get_subflows_max" [net/mptcp/mptcp_diag.ko] undefined!

This is now applied in our git repo.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net