* [PATCH] drivers: net: xen-netfront: remove unused arrays
@ 2014-04-15 17:39 Vincenzo Maffione
2014-04-15 17:54 ` David Vrabel
2014-04-15 17:54 ` David Vrabel
0 siblings, 2 replies; 8+ messages in thread
From: Vincenzo Maffione @ 2014-04-15 17:39 UTC (permalink / raw)
To: konrad.wilk
Cc: boris.ostrovsky, david.vrabel, xen-devel, netdev, linux-kernel,
Vincenzo Maffione
This patch removes some unused arrays from the netfront
private data structure.
Also removes an unused address variable.
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
Hello,
I don't see the point in having those unused arrays in the private
structure.
Sorry if I'm missing something.
Cheers,
Vincenzo
drivers/net/xen-netfront.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 158b5e6..1403ac7 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -137,10 +137,6 @@ struct netfront_info {
grant_ref_t gref_rx_head;
grant_ref_t grant_rx_ref[NET_RX_RING_SIZE];
- unsigned long rx_pfn_array[NET_RX_RING_SIZE];
- struct multicall_entry rx_mcl[NET_RX_RING_SIZE+1];
- struct mmu_update rx_mmu[NET_RX_RING_SIZE];
-
/* Statistics */
struct netfront_stats __percpu *stats;
@@ -252,7 +248,6 @@ static void xennet_alloc_rx_buffers(struct net_device *dev)
RING_IDX req_prod = np->rx.req_prod_pvt;
grant_ref_t ref;
unsigned long pfn;
- void *vaddr;
struct xen_netif_rx_request *req;
if (unlikely(!netif_carrier_ok(dev)))
@@ -322,7 +317,6 @@ no_skb:
np->grant_rx_ref[id] = ref;
pfn = page_to_pfn(skb_frag_page(&skb_shinfo(skb)->frags[0]));
- vaddr = page_address(skb_frag_page(&skb_shinfo(skb)->frags[0]));
req = RING_GET_REQUEST(&np->rx, req_prod + i);
gnttab_grant_foreign_access_ref(ref,
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:39 [PATCH] drivers: net: xen-netfront: remove unused arrays Vincenzo Maffione
@ 2014-04-15 17:54 ` David Vrabel
2014-04-15 17:54 ` David Vrabel
1 sibling, 0 replies; 8+ messages in thread
From: David Vrabel @ 2014-04-15 17:54 UTC (permalink / raw)
To: Vincenzo Maffione; +Cc: xen-devel, boris.ostrovsky, netdev, linux-kernel
On 15/04/14 18:39, Vincenzo Maffione wrote:
> This patch removes some unused arrays from the netfront
> private data structure.
> Also removes an unused address variable.
>
> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
Huh. I wonder what they were for.
Acked-by: David Vrabel <david.vrabel@citrix.com>
For net related patches please say whether they're for the net (current
RCs) or net-next branch. e.g.,
[PATCH net-next] xen-netfront: removed unused arrays.
Thanks.
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:39 [PATCH] drivers: net: xen-netfront: remove unused arrays Vincenzo Maffione
2014-04-15 17:54 ` David Vrabel
@ 2014-04-15 17:54 ` David Vrabel
2014-04-15 18:46 ` Vincenzo Maffione
` (3 more replies)
1 sibling, 4 replies; 8+ messages in thread
From: David Vrabel @ 2014-04-15 17:54 UTC (permalink / raw)
To: Vincenzo Maffione
Cc: konrad.wilk, boris.ostrovsky, xen-devel, netdev, linux-kernel
On 15/04/14 18:39, Vincenzo Maffione wrote:
> This patch removes some unused arrays from the netfront
> private data structure.
> Also removes an unused address variable.
>
> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
Huh. I wonder what they were for.
Acked-by: David Vrabel <david.vrabel@citrix.com>
For net related patches please say whether they're for the net (current
RCs) or net-next branch. e.g.,
[PATCH net-next] xen-netfront: removed unused arrays.
Thanks.
David
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:54 ` David Vrabel
@ 2014-04-15 18:46 ` Vincenzo Maffione
2014-04-15 18:46 ` Vincenzo Maffione
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Vincenzo Maffione @ 2014-04-15 18:46 UTC (permalink / raw)
To: David Vrabel; +Cc: xen-devel, boris.ostrovsky, netdev, linux-kernel
2014-04-15 19:54 GMT+02:00 David Vrabel <david.vrabel@citrix.com>:
> On 15/04/14 18:39, Vincenzo Maffione wrote:
>> This patch removes some unused arrays from the netfront
>> private data structure.
>> Also removes an unused address variable.
>>
>> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>
> Huh. I wonder what they were for.
>
> Acked-by: David Vrabel <david.vrabel@citrix.com>
>
> For net related patches please say whether they're for the net (current
> RCs) or net-next branch. e.g.,
>
> [PATCH net-next] xen-netfront: removed unused arrays.
>
Ok, thanks.
I used linux-next
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
but I don't really know what is the most appropriate.
(I guess git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git is "net"?)
Vincenzo
> Thanks.
>
> David
--
Vincenzo Maffione
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:54 ` David Vrabel
2014-04-15 18:46 ` Vincenzo Maffione
@ 2014-04-15 18:46 ` Vincenzo Maffione
2014-04-16 8:26 ` [Xen-devel] " Ian Campbell
2014-04-16 8:26 ` Ian Campbell
3 siblings, 0 replies; 8+ messages in thread
From: Vincenzo Maffione @ 2014-04-15 18:46 UTC (permalink / raw)
To: David Vrabel
Cc: konrad.wilk, boris.ostrovsky, xen-devel, netdev, linux-kernel
2014-04-15 19:54 GMT+02:00 David Vrabel <david.vrabel@citrix.com>:
> On 15/04/14 18:39, Vincenzo Maffione wrote:
>> This patch removes some unused arrays from the netfront
>> private data structure.
>> Also removes an unused address variable.
>>
>> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>
> Huh. I wonder what they were for.
>
> Acked-by: David Vrabel <david.vrabel@citrix.com>
>
> For net related patches please say whether they're for the net (current
> RCs) or net-next branch. e.g.,
>
> [PATCH net-next] xen-netfront: removed unused arrays.
>
Ok, thanks.
I used linux-next
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
but I don't really know what is the most appropriate.
(I guess git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git is "net"?)
Vincenzo
> Thanks.
>
> David
--
Vincenzo Maffione
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:54 ` David Vrabel
2014-04-15 18:46 ` Vincenzo Maffione
2014-04-15 18:46 ` Vincenzo Maffione
@ 2014-04-16 8:26 ` Ian Campbell
2014-04-16 8:26 ` Ian Campbell
3 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2014-04-16 8:26 UTC (permalink / raw)
To: David Vrabel
Cc: Vincenzo Maffione, xen-devel, boris.ostrovsky, netdev, linux-kernel
On Tue, 2014-04-15 at 18:54 +0100, David Vrabel wrote:
> On 15/04/14 18:39, Vincenzo Maffione wrote:
> > This patch removes some unused arrays from the netfront
> > private data structure.
> > Also removes an unused address variable.
> >
> > Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>
> Huh. I wonder what they were for.
Looks like they were leftovers from the old flipping mode of operation.
Which was removed with:
commit 5dcddfae63bd26da0f11a8e40f0ae555b5ac624e
Author: Jeremy Fitzhardinge <jeremy@goop.org>
Date: Tue Aug 7 14:56:42 2007 -0700
xen-netfront: remove dead code
Which missed these bits.
Ian.
> Acked-by: David Vrabel <david.vrabel@citrix.com>
>
> For net related patches please say whether they're for the net (current
> RCs) or net-next branch. e.g.,
>
> [PATCH net-next] xen-netfront: removed unused arrays.
>
> Thanks.
>
> David
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drivers: net: xen-netfront: remove unused arrays
2014-04-15 17:54 ` David Vrabel
` (2 preceding siblings ...)
2014-04-16 8:26 ` [Xen-devel] " Ian Campbell
@ 2014-04-16 8:26 ` Ian Campbell
3 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2014-04-16 8:26 UTC (permalink / raw)
To: David Vrabel
Cc: xen-devel, boris.ostrovsky, linux-kernel, Vincenzo Maffione, netdev
On Tue, 2014-04-15 at 18:54 +0100, David Vrabel wrote:
> On 15/04/14 18:39, Vincenzo Maffione wrote:
> > This patch removes some unused arrays from the netfront
> > private data structure.
> > Also removes an unused address variable.
> >
> > Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>
> Huh. I wonder what they were for.
Looks like they were leftovers from the old flipping mode of operation.
Which was removed with:
commit 5dcddfae63bd26da0f11a8e40f0ae555b5ac624e
Author: Jeremy Fitzhardinge <jeremy@goop.org>
Date: Tue Aug 7 14:56:42 2007 -0700
xen-netfront: remove dead code
Which missed these bits.
Ian.
> Acked-by: David Vrabel <david.vrabel@citrix.com>
>
> For net related patches please say whether they're for the net (current
> RCs) or net-next branch. e.g.,
>
> [PATCH net-next] xen-netfront: removed unused arrays.
>
> Thanks.
>
> David
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drivers: net: xen-netfront: remove unused arrays
@ 2014-04-15 17:39 Vincenzo Maffione
0 siblings, 0 replies; 8+ messages in thread
From: Vincenzo Maffione @ 2014-04-15 17:39 UTC (permalink / raw)
To: konrad.wilk
Cc: netdev, linux-kernel, Vincenzo Maffione, david.vrabel, xen-devel,
boris.ostrovsky
This patch removes some unused arrays from the netfront
private data structure.
Also removes an unused address variable.
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
Hello,
I don't see the point in having those unused arrays in the private
structure.
Sorry if I'm missing something.
Cheers,
Vincenzo
drivers/net/xen-netfront.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 158b5e6..1403ac7 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -137,10 +137,6 @@ struct netfront_info {
grant_ref_t gref_rx_head;
grant_ref_t grant_rx_ref[NET_RX_RING_SIZE];
- unsigned long rx_pfn_array[NET_RX_RING_SIZE];
- struct multicall_entry rx_mcl[NET_RX_RING_SIZE+1];
- struct mmu_update rx_mmu[NET_RX_RING_SIZE];
-
/* Statistics */
struct netfront_stats __percpu *stats;
@@ -252,7 +248,6 @@ static void xennet_alloc_rx_buffers(struct net_device *dev)
RING_IDX req_prod = np->rx.req_prod_pvt;
grant_ref_t ref;
unsigned long pfn;
- void *vaddr;
struct xen_netif_rx_request *req;
if (unlikely(!netif_carrier_ok(dev)))
@@ -322,7 +317,6 @@ no_skb:
np->grant_rx_ref[id] = ref;
pfn = page_to_pfn(skb_frag_page(&skb_shinfo(skb)->frags[0]));
- vaddr = page_address(skb_frag_page(&skb_shinfo(skb)->frags[0]));
req = RING_GET_REQUEST(&np->rx, req_prod + i);
gnttab_grant_foreign_access_ref(ref,
--
1.9.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-16 8:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15 17:39 [PATCH] drivers: net: xen-netfront: remove unused arrays Vincenzo Maffione
2014-04-15 17:54 ` David Vrabel
2014-04-15 17:54 ` David Vrabel
2014-04-15 18:46 ` Vincenzo Maffione
2014-04-15 18:46 ` Vincenzo Maffione
2014-04-16 8:26 ` [Xen-devel] " Ian Campbell
2014-04-16 8:26 ` Ian Campbell
2014-04-15 17:39 Vincenzo Maffione
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.