All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincenzo Maffione <v.maffione@gmail.com>
To: Luigi Rizzo <rizzo@iet.unipi.it>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] net: Adding netmap network backend
Date: Fri, 14 Feb 2014 14:41:24 +0100	[thread overview]
Message-ID: <CA+_eA9isf2Caf_-2QUCNUcoHSYd93emq=J+wB=9tseLAVq7hhg@mail.gmail.com> (raw)
In-Reply-To: <CA+hQ2+gKh_6SqrofFvUdUDWJPFc-gcubrguRWzwR669+wY4i=A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Stefan,
  It is ok for you if I prepare a patch (touching configure and
net/netmap.c) that makes sure the host kernel has the minimum netmap
version required for QEMU to work (and if not just --disable-netmap)?

Cheers,
  Vincenzo


2014-02-14 11:24 GMT+01:00 Luigi Rizzo <rizzo@iet.unipi.it>:

>
>
>
> On Fri, Feb 14, 2014 at 2:20 AM, Vincenzo Maffione <v.maffione@gmail.com>wrote:
>
>> Yes, for sure we need to do a check.
>>
>> However, this would involve - I think - some non-trivial modifications to
>> net/netmap.c, because without NS_MOREFRAG you cannot split a packet over
>> more "netmap slots/descriptors" (both tx and rx side)
>>
>> Therefore I would ask (manly Luigi, since netmap is in-tree in FreeBSD):
>> Wouldn't it be better to force --disable-netmap when we realize that
>> NETMAP_API (version number for the netmap API) is less than the value
>> required by QEMU? This can be done in ./configure. In this way we keep the
>> QEMU code cleaner.
>>
>
> yes we should do exactly what vincenzo suggests.
>
> cheers
> luigi
>



-- 
Vincenzo Maffione

[-- Attachment #2: Type: text/html, Size: 2300 bytes --]

  reply	other threads:[~2014-02-14 13:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 18:01 [Qemu-devel] net: Adding netmap network backend Michael Tokarev
2014-02-14  9:52 ` Stefan Hajnoczi
2014-02-14 10:20   ` Vincenzo Maffione
2014-02-14 10:24     ` Luigi Rizzo
2014-02-14 13:41       ` Vincenzo Maffione [this message]
2014-02-14 15:40         ` Stefan Hajnoczi
2014-02-14 15:43           ` Vincenzo Maffione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+_eA9isf2Caf_-2QUCNUcoHSYd93emq=J+wB=9tseLAVq7hhg@mail.gmail.com' \
    --to=v.maffione@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.