Re: [oe-commits] [meta-openembedded] 44/47: tsocks: Add -lssp_nonshared to LIBS explicitly on musl

* Re: [oe-commits] [meta-openembedded] 44/47: tsocks: Add -lssp_nonshared to LIBS explicitly on musl
       [not found] ` <20180925161843.DFECE234E18@git.openembedded.org>
@ 2018-09-27 17:41   ` Martin Jansa
  2018-09-27 17:44     ` [meta-networking][PATCH] tsocks: use -lssp_nonshared also for glibc Martin Jansa
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2018-09-27 17:41 UTC (permalink / raw)
  To: openembedded-devel, Khem Raj; +Cc: openembedded-commits

Is this really musl specific? I'm seeing the same failure with glibc
qemux86 build with security_flags included:

| tsocks.c:954: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:842: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:339: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:522: error: undefined reference to '__stack_chk_fail_local'
| collect2: error: ld returned 1 exit status
| Makefile:53: recipe for target 'libtsocks.so.1.8' failed
| make: *** [libtsocks.so.1.8] Error 1

On Tue, Sep 25, 2018 at 6:19 PM <git@git.openembedded.org> wrote:

> This is an automated email from the git hooks/post-receive script.
>
> khem pushed a commit to branch master-next
> in repository meta-openembedded.
>
> commit 4a0e53cb229f97e9cc3dd925b8db334e07b85768
> Author: Khem Raj <raj.khem@gmail.com>
> AuthorDate: Mon Sep 24 10:57:13 2018 -0700
>
>     tsocks: Add -lssp_nonshared to LIBS explicitly on musl
>
>     tsocks uses -nostdlib while linking shared library, which is not ideal
>     but instead of chasing that and assuming there is a reason for that, we
>     add -lssp_noshared to linker command at the end so it can build when
>     security flags are enabled
>
>     Fixes
>     tsocks.c:954: undefined reference to `__stack_chk_fail_local'
>
>     Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb
> b/meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb
> index b2757f6..7291357 100644
> --- a/meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb
> +++ b/meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb
> @@ -18,11 +18,13 @@ SRC_URI[sha256sum] =
> "849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863
>
>  inherit autotools-brokensep
>
> +LIBS_append_libc-musl = " -lssp_nonshared"
> +
>  S = "${WORKDIR}/tsocks-1.8"
>
>  FILES_${PN} = "${libdir}/* ${bindir}/tsocks"
>  FILES_${PN}-dev = ""
>  INSANE_SKIP_${PN} = "dev-so"
>
> -EXTRA_OEMAKE = "SHCC='${CC} -fPIC ${LDFLAGS}'"
> +EXTRA_OEMAKE = "SHCC='${CC} -fPIC ${LDFLAGS}' LIBS='${LIBS}'"
>
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>

^ permalink raw reply	[flat|nested] 4+ messages in thread