All of lore.kernel.org
 help / color / mirror / Atom feed
* [gastesgarth][PATCH 01/12] gstreamer1.0: Fix reproducibility issue around libcap
@ 2020-11-01  0:43 Martin Jansa
  2020-11-01  0:43 ` [gastesgarth][PATCH 02/12] gstreamer1.0: Update 1.16.2 -> Update 1.16.3 Martin Jansa
                   ` (11 more replies)
  0 siblings, 12 replies; 16+ messages in thread
From: Martin Jansa @ 2020-11-01  0:43 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jose Quaresma

From: Jose Quaresma <quaresma.jose@gmail.com>

Currently gstreamer configuration depends libcap and on whether
setcap is found on the host system.

Removing libcap from DEPENDS and only use it when the 'setcap' is enabled.

    * 0004-capfix.patch
      Removed as the same goals can be achieved only with the PACKAGECONFIG 'setcap'

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0/capfix.patch       | 37 -------------------
 .../gstreamer/gstreamer1.0_1.16.2.bb          |  5 +--
 2 files changed, 2 insertions(+), 40 deletions(-)
 delete mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0/capfix.patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0/capfix.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0/capfix.patch
deleted file mode 100644
index 7ca3d5ad4a..0000000000
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0/capfix.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-Currently gstreamer configuration depends on whether setcap is found on the host
-system. Turn this into a configure option to make builds deterinistic.
-
-RP 2020/2/19
-Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-Upstream-Status: Pending
-
-Index: gstreamer-1.16.1/libs/gst/helpers/meson.build
-===================================================================
---- gstreamer-1.16.1.orig/libs/gst/helpers/meson.build
-+++ gstreamer-1.16.1/libs/gst/helpers/meson.build
-@@ -73,7 +73,12 @@ if have_ptp
-     endif
-   endif
- 
--  setcap = find_program('setcap', '/usr/sbin/setcap', '/sbin/setcap', required : false)
-+  setcap_feature = get_option('setcap')
-+  if setcap_feature.disabled()
-+    setcap = find_program('dontexist', required : false)
-+  else
-+    setcap = find_program('setcap', '/usr/sbin/setcap', '/sbin/setcap', required : false)
-+  endif
- 
-   # user/group to change to in gst-ptp-helper
-   ptp_helper_setuid_user = get_option('ptp-helper-setuid-user')
-Index: gstreamer-1.16.1/meson_options.txt
-===================================================================
---- gstreamer-1.16.1.orig/meson_options.txt
-+++ gstreamer-1.16.1/meson_options.txt
-@@ -26,6 +26,7 @@ option('libunwind', type : 'feature', va
- option('libdw', type : 'feature', value : 'auto', description : 'Use libdw to generate better backtraces from libunwind')
- option('dbghelp', type : 'feature', value : 'auto', description : 'Use dbghelp to generate backtraces')
- option('bash-completion', type : 'feature', value : 'auto', description : 'Install bash completion files')
-+option('setcap', type : 'feature', value : 'auto', description : 'Use setcap')
- 
- # Common feature options
- option('examples', type : 'feature', value : 'auto', yield : true)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.2.bb
index 50a872e292..9d92fe1439 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.2.bb
@@ -6,7 +6,7 @@ BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer"
 SECTION = "multimedia"
 LICENSE = "LGPLv2+"
 
-DEPENDS = "glib-2.0 glib-2.0-native libcap libxml2 bison-native flex-native"
+DEPENDS = "glib-2.0 glib-2.0-native libxml2 bison-native flex-native"
 
 inherit meson pkgconfig gettext upstream-version-is-even gobject-introspection gtk-doc
 
@@ -21,7 +21,6 @@ SRC_URI = " \
     file://0002-meson-build-gir-even-when-cross-compiling-if-introsp.patch \
     file://0003-meson-Add-valgrind-feature.patch \
     file://0004-meson-Add-option-for-installed-tests.patch \
-    file://capfix.patch \
 "
 SRC_URI[md5sum] = "0e661ed5bdf1d8996e430228d022628e"
 SRC_URI[sha256sum] = "e3f044246783fd685439647373fa13ba14f7ab0b346eadd06437092f8419e94e"
@@ -40,7 +39,7 @@ PACKAGECONFIG[unwind] = "-Dlibunwind=enabled,-Dlibunwind=disabled,libunwind"
 PACKAGECONFIG[dw] = "-Dlibdw=enabled,-Dlibdw=disabled,elfutils"
 PACKAGECONFIG[bash-completion] = "-Dbash-completion=enabled,-Dbash-completion=disabled,bash-completion"
 PACKAGECONFIG[tools] = "-Dtools=enabled,-Dtools=disabled"
-PACKAGECONFIG[setcap] = "-Dsetcap=enabled,-Dsetcap=disabled,libcap libcap-native"
+PACKAGECONFIG[setcap] = ",,libcap libcap-native"
 
 # TODO: put this in a gettext.bbclass patch
 def gettext_oemeson(d):
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-11-05  9:52 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01  0:43 [gastesgarth][PATCH 01/12] gstreamer1.0: Fix reproducibility issue around libcap Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 02/12] gstreamer1.0: Update 1.16.2 -> Update 1.16.3 Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 03/12] gstreamer1.0-plugins-base: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 04/12] gstreamer1.0-plugins-good: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 05/12] gstreamer1.0-plugins-bad: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 06/12] gstreamer1.0-plugins-ugly: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 07/12] gstreamer1.0-libav: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 08/12] gstreamer1.0-vaapi: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 09/12] gstreamer1.0-rtsp-server: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 10/12] gstreamer1.0-omx: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 11/12] gstreamer1.0-python: " Martin Jansa
2020-11-01  0:43 ` [gastesgarth][PATCH 12/12] gst-validate: " Martin Jansa
2020-11-02  9:57 ` [gastesgarth][PATCH 01/12] gstreamer1.0: Fix reproducibility issue around libcap Jose Quaresma
2020-11-02 11:16   ` [OE-core] " Richard Purdie
2020-11-02 11:47     ` Martin Jansa
2020-11-05  9:51       ` Jose Quaresma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.