All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] weston: Split out machine specific configuration
@ 2018-10-24 20:25 Mark Hatle
  2018-10-24 21:36 ` Martin Jansa
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Hatle @ 2018-10-24 20:25 UTC (permalink / raw)
  To: openembedded-core

Weston needs to be configured to load the fbdev driver when run on a QEMU system.
Other MACHINEs may want to also provider their own configuration as well..

Adding a new RRECOMMEND configuration package will allow this, but avoid
installing empty packages/files in the majority case where it is not needed.

Add maintainer entry as well.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
 meta/conf/distro/include/maintainers.inc      |  1 +
 meta/recipes-graphics/wayland/weston-cfg.bb   | 34 +++++++++++++++++++++++++++
 meta/recipes-graphics/wayland/weston_5.0.0.bb |  8 +------
 3 files changed, 36 insertions(+), 7 deletions(-)
 create mode 100644 meta/recipes-graphics/wayland/weston-cfg.bb

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index d32e07d899..5b68336184 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -678,6 +678,7 @@ RECIPE_MAINTAINER_pn-wayland = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-wayland-protocols = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-webkitgtk = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER_pn-weston = "Denys Dmytriyenko <denys@ti.com>"
+RECIPE_MAINTAINER_pn-weston-cfg = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-weston-init = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-wget = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER_pn-which = "Ross Burton <ross.burton@intel.com>"
diff --git a/meta/recipes-graphics/wayland/weston-cfg.bb b/meta/recipes-graphics/wayland/weston-cfg.bb
new file mode 100644
index 0000000000..6a5cdbf915
--- /dev/null
+++ b/meta/recipes-graphics/wayland/weston-cfg.bb
@@ -0,0 +1,34 @@
+SUMMARY = "Weston, a Wayland compositor, configuration files"
+HOMEPAGE = "http://wayland.freedesktop.org"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+CONFFILES_${PN} = "${sysconfdir}/xdg/weston/weston.ini"
+
+FILES_${PN} = "${sysconfdir}/xdg/weston/weston.ini"
+
+PACKAGES = "${PN}"
+
+do_compile[noexec] = '1'
+
+do_install() {
+	:
+}
+
+do_install_qemux86() {
+	mkdir -p ${D}/${sysconfdir}/xdg/weston
+	cat << EOF > ${D}/${sysconfdir}/xdg/weston/weston.ini
+[core]
+backend=fbdev-backend.so
+EOF
+}
+
+do_install_qemux86-64() {
+	mkdir -p ${D}/${sysconfdir}/xdg/weston
+	cat << EOF > ${D}/${sysconfdir}/xdg/weston/weston.ini
+[core]
+backend=fbdev-backend.so
+EOF
+}
diff --git a/meta/recipes-graphics/wayland/weston_5.0.0.bb b/meta/recipes-graphics/wayland/weston_5.0.0.bb
index 299408b201..b87524ece5 100644
--- a/meta/recipes-graphics/wayland/weston_5.0.0.bb
+++ b/meta/recipes-graphics/wayland/weston_5.0.0.bb
@@ -29,12 +29,6 @@ WESTON_MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:1])}"
 EXTRA_OECONF = "--enable-setuid-install \
                 --disable-rdp-compositor \
                 "
-EXTRA_OECONF_append_qemux86 = "\
-		WESTON_NATIVE_BACKEND=fbdev-backend.so \
-		"
-EXTRA_OECONF_append_qemux86-64 = "\
-		WESTON_NATIVE_BACKEND=fbdev-backend.so \
-		"
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms fbdev wayland egl', '', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 'xwayland', '', d)} \
                    ${@bb.utils.filter('DISTRO_FEATURES', 'pam systemd x11', d)} \
@@ -107,7 +101,7 @@ FILES_${PN}-xwayland = "${libdir}/libweston-${WESTON_MAJOR_VERSION}/xwayland.so"
 RDEPENDS_${PN}-xwayland += "xserver-xorg-xwayland"
 
 RDEPENDS_${PN} += "xkeyboard-config"
-RRECOMMENDS_${PN} = "liberation-fonts"
+RRECOMMENDS_${PN} = "weston-cfg liberation-fonts"
 RRECOMMENDS_${PN}-dev += "wayland-protocols"
 
 USERADD_PACKAGES = "${PN}"
-- 
2.16.0.rc2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] weston: Split out machine specific configuration
  2018-10-24 20:25 [PATCH v2] weston: Split out machine specific configuration Mark Hatle
@ 2018-10-24 21:36 ` Martin Jansa
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Jansa @ 2018-10-24 21:36 UTC (permalink / raw)
  To: Mark Hatle; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 4690 bytes --]

You need to add weston-cfg to SIGGEN_EXCLUDERECIPES_ABISAFE otherwise
weston will still be effectively MACHINE_ARCH because of the do_package
signature depending on weston-cfg signature.

On Wed, Oct 24, 2018 at 10:25 PM Mark Hatle <mark.hatle@windriver.com>
wrote:

> Weston needs to be configured to load the fbdev driver when run on a QEMU
> system.
> Other MACHINEs may want to also provider their own configuration as well..
>
> Adding a new RRECOMMEND configuration package will allow this, but avoid
> installing empty packages/files in the majority case where it is not
> needed.
>
> Add maintainer entry as well.
>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  meta/conf/distro/include/maintainers.inc      |  1 +
>  meta/recipes-graphics/wayland/weston-cfg.bb   | 34
> +++++++++++++++++++++++++++
>  meta/recipes-graphics/wayland/weston_5.0.0.bb |  8 +------
>  3 files changed, 36 insertions(+), 7 deletions(-)
>  create mode 100644 meta/recipes-graphics/wayland/weston-cfg.bb
>
> diff --git a/meta/conf/distro/include/maintainers.inc
> b/meta/conf/distro/include/maintainers.inc
> index d32e07d899..5b68336184 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -678,6 +678,7 @@ RECIPE_MAINTAINER_pn-wayland = "Denys Dmytriyenko <
> denys@ti.com>"
>  RECIPE_MAINTAINER_pn-wayland-protocols = "Denys Dmytriyenko <denys@ti.com
> >"
>  RECIPE_MAINTAINER_pn-webkitgtk = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER_pn-weston = "Denys Dmytriyenko <denys@ti.com>"
> +RECIPE_MAINTAINER_pn-weston-cfg = "Denys Dmytriyenko <denys@ti.com>"
>  RECIPE_MAINTAINER_pn-weston-init = "Denys Dmytriyenko <denys@ti.com>"
>  RECIPE_MAINTAINER_pn-wget = "Yi Zhao <yi.zhao@windriver.com>"
>  RECIPE_MAINTAINER_pn-which = "Ross Burton <ross.burton@intel.com>"
> diff --git a/meta/recipes-graphics/wayland/weston-cfg.bb
> b/meta/recipes-graphics/wayland/weston-cfg.bb
> new file mode 100644
> index 0000000000..6a5cdbf915
> --- /dev/null
> +++ b/meta/recipes-graphics/wayland/weston-cfg.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "Weston, a Wayland compositor, configuration files"
> +HOMEPAGE = "http://wayland.freedesktop.org"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +CONFFILES_${PN} = "${sysconfdir}/xdg/weston/weston.ini"
> +
> +FILES_${PN} = "${sysconfdir}/xdg/weston/weston.ini"
> +
> +PACKAGES = "${PN}"
> +
> +do_compile[noexec] = '1'
> +
> +do_install() {
> +       :
> +}
> +
> +do_install_qemux86() {
> +       mkdir -p ${D}/${sysconfdir}/xdg/weston
> +       cat << EOF > ${D}/${sysconfdir}/xdg/weston/weston.ini
> +[core]
> +backend=fbdev-backend.so
> +EOF
> +}
> +
> +do_install_qemux86-64() {
> +       mkdir -p ${D}/${sysconfdir}/xdg/weston
> +       cat << EOF > ${D}/${sysconfdir}/xdg/weston/weston.ini
> +[core]
> +backend=fbdev-backend.so
> +EOF
> +}
> diff --git a/meta/recipes-graphics/wayland/weston_5.0.0.bb
> b/meta/recipes-graphics/wayland/weston_5.0.0.bb
> index 299408b201..b87524ece5 100644
> --- a/meta/recipes-graphics/wayland/weston_5.0.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_5.0.0.bb
> @@ -29,12 +29,6 @@ WESTON_MAJOR_VERSION =
> "${@'.'.join(d.getVar('PV').split('.')[0:1])}"
>  EXTRA_OECONF = "--enable-setuid-install \
>                  --disable-rdp-compositor \
>                  "
> -EXTRA_OECONF_append_qemux86 = "\
> -               WESTON_NATIVE_BACKEND=fbdev-backend.so \
> -               "
> -EXTRA_OECONF_append_qemux86-64 = "\
> -               WESTON_NATIVE_BACKEND=fbdev-backend.so \
> -               "
>  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland',
> 'kms fbdev wayland egl', '', d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland',
> 'xwayland', '', d)} \
>                     ${@bb.utils.filter('DISTRO_FEATURES', 'pam systemd
> x11', d)} \
> @@ -107,7 +101,7 @@ FILES_${PN}-xwayland =
> "${libdir}/libweston-${WESTON_MAJOR_VERSION}/xwayland.so"
>  RDEPENDS_${PN}-xwayland += "xserver-xorg-xwayland"
>
>  RDEPENDS_${PN} += "xkeyboard-config"
> -RRECOMMENDS_${PN} = "liberation-fonts"
> +RRECOMMENDS_${PN} = "weston-cfg liberation-fonts"
>  RRECOMMENDS_${PN}-dev += "wayland-protocols"
>
>  USERADD_PACKAGES = "${PN}"
> --
> 2.16.0.rc2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 7134 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-24 21:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 20:25 [PATCH v2] weston: Split out machine specific configuration Mark Hatle
2018-10-24 21:36 ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.