[meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

[meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

[Richard Leitner]

Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
directly binding a user DN to an LDAP server.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
Changes v2:
  + assign DEPENDS (instead of appending to it)
  + add downloadfilename to SRC_URI
  + append to FILES (instead of assigning it)
---
 .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb

diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
new file mode 100644
index 000000000..c59a259fc
--- /dev/null
+++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
@@ -0,0 +1,23 @@
+SUMMARY = "PAM searchless LDAP authentication module"
+HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb"
+BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues"
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
+
+DEPENDS = "libpam openldap"
+
+inherit distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
+
+SRC_URI = "https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;downloadfilename=${BP}.tar.gz"
+SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
+SRC_URI[sha256sum] = "8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
+
+S = "${WORKDIR}/pam_ldapdb-${PV}"
+
+do_install () {
+    oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
+}
+
+FILES_${PN} += "${base_libdir}/security/pam_ldapdb.so"
-- 
2.11.0

Re: [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

[Martin Jansa]

Don't use github archives which are regenerated from time to time with
different checksums (read older discussions for more details).

On Wed, May 23, 2018 at 10:42 AM Richard Leitner <
richard.leitner@skidata.com> wrote:

> Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
> directly binding a user DN to an LDAP server.
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
> Changes v2:
>   + assign DEPENDS (instead of appending to it)
>   + add downloadfilename to SRC_URI
>   + append to FILES (instead of assigning it)
> ---
>  .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23
> ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>
> diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> new file mode 100644
> index 000000000..c59a259fc
> --- /dev/null
> +++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> @@ -0,0 +1,23 @@
> +SUMMARY = "PAM searchless LDAP authentication module"
> +HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb"
> +BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues"
> +SECTION = "libs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
> +
> +DEPENDS = "libpam openldap"
> +
> +inherit distro_features_check
> +REQUIRED_DISTRO_FEATURES = "pam"
> +
> +SRC_URI = "
> https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;downloadfilename=${BP}.tar.gz
> "
> +SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
> +SRC_URI[sha256sum] =
> "8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
> +
> +S = "${WORKDIR}/pam_ldapdb-${PV}"
> +
> +do_install () {
> +    oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
> +}
> +
> +FILES_${PN} += "${base_libdir}/security/pam_ldapdb.so"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

[Richard Leitner]

On 05/23/2018 10:54 AM, Martin Jansa wrote:
> Don't use github archives which are regenerated from time to time with different checksums (read older discussions for more details).

What should we use instead?
git clone?
My comments on that from the last patch version:

> Why should we change to git clones instead of archives? What's the advantage?

.. ok that's clear with the "different checksums" statement

> IMHO it only causes more traffic and uses more disk space.
> Furthermore if we rely on tags these may be changed without our notice...
> And if they are unsigned (like here) we also don't know if something got modified unintentionally...
> Or should we use revision hashes?

If these points were already settled please give me a pointer to that discussion.

thanks & regards;Richard.L

Re: [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

[Richard Leitner]

Any updates/suggestions on how I should proceed with this patch?

On 05/23/2018 11:03 AM, Richard Leitner wrote:
> 
> On 05/23/2018 10:54 AM, Martin Jansa wrote:
>> Don't use github archives which are regenerated from time to time with different checksums (read older discussions for more details).
> 
> What should we use instead?
> git clone?
> My comments on that from the last patch version:
> 
>> Why should we change to git clones instead of archives? What's the advantage?
> 
> .. ok that's clear with the "different checksums" statement
> 
>> IMHO it only causes more traffic and uses more disk space.
>> Furthermore if we rely on tags these may be changed without our notice...
>> And if they are unsigned (like here) we also don't know if something got modified unintentionally...
>> Or should we use revision hashes?
> 
> If these points were already settled please give me a pointer to that discussion.
> 
> thanks & regards;Richard.L
>