[PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Andreas Müller]

|   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least
|   version "3.0.1")

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \
-- 
2.31.1

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Richard Purdie]

On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
> >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least
> >   version "3.0.1")
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb b/meta/recipes-
> sato/webkit/webkitgtk_2.34.0.bb
> index 25e1d422cc..a8e067147c 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
>  
>  DEPENDS = " \
>            ruby-native \
> +          gperf-native \
>            cairo \
>            harfbuzz \
>            jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

Cheers,

Richard

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Andreas Müller]

On Sun, Oct 17, 2021 at 2:03 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
> > >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least
> > >   version "3.0.1")
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > ---
> >  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb b/meta/recipes-
> > sato/webkit/webkitgtk_2.34.0.bb
> > index 25e1d422cc..a8e067147c 100644
> > --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
> >
> >  DEPENDS = " \
> >            ruby-native \
> > +          gperf-native \
> >            cairo \
> >            harfbuzz \
> >            jpeg \
>
> Out of interest, why are you seeing that and the automated testing isn't?
>
Asked myself same but did not find an answer. My build should use
default PACKAGECONFIGs. Was off for a while so now pulled master
(meta-openembedded master-next for mozjs upgrade) and started a build.
Not helpful exactly - sorry...

Andreas

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

On Sun, Oct 17, 2021 at 2:03 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
> > >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at
> least
> > >   version "3.0.1")
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > ---
> >  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> b/meta/recipes-
> > sato/webkit/webkitgtk_2.34.0.bb
> > index 25e1d422cc..a8e067147c 100644
> > --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
> >
> >  DEPENDS = " \
> >            ruby-native \
> > +          gperf-native \
> >            cairo \
> >            harfbuzz \
> >            jpeg \
>
> Out of interest, why are you seeing that and the automated testing isn't?
>

FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it
isn't because of gperf, but:

| CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
|   Either GLX or EGL is needed.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:220 (include)
|   CMakeLists.txt:20 (include)

possibly because the default setup in oe-core doesn't have opengl in
DISTRO_FEATUES while all builds on autobuilder have opengl enabled with
poky?

[-- Attachment #2: Type: text/html, Size: 2493 bytes --]

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3341 bytes --]

On Sun, Oct 17, 2021 at 2:45 PM Martin Jansa via lists.openembedded.org
<Martin.Jansa=gmail.com@lists.openembedded.org> wrote:

> On Sun, Oct 17, 2021 at 2:03 PM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
>
>> On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
>> > >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at
>> least
>> > >   version "3.0.1")
>> >
>> > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
>> > ---
>> >  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
>> b/meta/recipes-
>> > sato/webkit/webkitgtk_2.34.0.bb
>> > index 25e1d422cc..a8e067147c 100644
>> > --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
>> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
>> > @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
>> >
>> >  DEPENDS = " \
>> >            ruby-native \
>> > +          gperf-native \
>> >            cairo \
>> >            harfbuzz \
>> >            jpeg \
>>
>> Out of interest, why are you seeing that and the automated testing isn't?
>>
>
> FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it
> isn't because of gperf, but:
>
> | CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
> |   Either GLX or EGL is needed.
> | Call Stack (most recent call first):
> |   Source/cmake/WebKitCommon.cmake:220 (include)
> |   CMakeLists.txt:20 (include)
>
> possibly because the default setup in oe-core doesn't have opengl in
> DISTRO_FEATUES while all builds on autobuilder have opengl enabled with
> poky?
>

I've sent a fix for build for default oe-core setup (without opengl in
DISTRO_FEATURES).

In my build gperf-native was found in older 2.32.3 from native sysroot:

CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot-native/usr/bin
/gperf
CMakeCache.txt.2.32.3-r0://Details about finding Gperf
CMakeCache.txt.2.32.3-r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2-foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys
root-native/usr/bin/gperf][v(3.0.1)]
CMakeCache.txt.2.32.3-r0://ADVANCED property for variable: GPERF_EXECUTABLE
CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1

and it's found there through as transitive dependency from:

"fontconfig.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
"glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
"libcap-native.do_prepare_recipe_sysroot" ->
"gperf-native.do_populate_sysroot"
"libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
"systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"

with some other combination of DISTRO_FEATURES it might be missing as in
Andreas case and as it's direct dependency of webkitgtk I think removing it
in:
https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2
wasn't correct, maybe other dependencies removed here have similar issue
and successful pass on autobuilder tests only very limited set of
combinations (understandably).

Regards,

[-- Attachment #2: Type: text/html, Size: 5111 bytes --]

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Richard Purdie]

On Mon, 2021-10-18 at 15:56 +0200, Martin Jansa wrote:
> On Sun, Oct 17, 2021 at 2:45 PM Martin Jansa via lists.openembedded.org
> <Martin.Jansa=gmail.com@lists.openembedded.org> wrote:
> > On Sun, Oct 17, 2021 at 2:03 PM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
> > > > >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at
> > > > > least
> > > > >   version "3.0.1")
> > > > 
> > > > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > > > ---
> > > >  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > b/meta/recipes-
> > > > sato/webkit/webkitgtk_2.34.0.bb
> > > > index 25e1d422cc..a8e067147c 100644
> > > > --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
> > > >  
> > > >  DEPENDS = " \
> > > >            ruby-native \
> > > > +          gperf-native \
> > > >            cairo \
> > > >            harfbuzz \
> > > >            jpeg \
> > > 
> > > Out of interest, why are you seeing that and the automated testing isn't?
> > > 
> > 
> > 
> > FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it
> > isn't because of gperf, but:
> > 
> > | CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
> > |   Either GLX or EGL is needed.
> > | Call Stack (most recent call first):
> > |   Source/cmake/WebKitCommon.cmake:220 (include)
> > |   CMakeLists.txt:20 (include)
> > 
> > possibly because the default setup in oe-core doesn't have opengl in
> > DISTRO_FEATUES while all builds on autobuilder have opengl enabled with
> > poky?
> > 
> 
> 
> I've sent a fix for build for default oe-core setup (without opengl in
> DISTRO_FEATURES).
> 
> In my build gperf-native was found in older 2.32.3 from native sysroot:
> 
> CMakeCache.txt.2.32.3-
> r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy-
> kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot-
> native/usr/bin
> /gperf
> CMakeCache.txt.2.32.3-r0://Details about finding Gperf
> CMakeCache.txt.2.32.3-
> r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2
> -foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys
> root-native/usr/bin/gperf][v(3.0.1)]
> CMakeCache.txt.2.32.3-r0://ADVANCED property for variable: GPERF_EXECUTABLE
> CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1
> 
> and it's found there through as transitive dependency from:
> 
> "fontconfig.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> "glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> "libcap-native.do_prepare_recipe_sysroot" -> "gperf-
> native.do_populate_sysroot"
> "libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> "systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> 
> with some other combination of DISTRO_FEATURES it might be missing as in
> Andreas case and as it's direct dependency of webkitgtk I think removing it
> in:
> https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2
> wasn't correct, maybe other dependencies removed here have similar issue and
> successful pass on autobuilder tests only very limited set of combinations
> (understandably).

We could put gperf-native into the same class of dependencies as pkgconfig-
native which should expose all the missing dependencies at the risk of causing
work in needing to correctly mark up the recipes.

I'm at least happier now I understand why this was being masked.

Cheers,

Richard

Re: [OE-core] [PATCH] webkitgtk: add gperf-native to DEPENDS to fix build

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 4726 bytes --]

But I still don't understand this. How can this be reproduced?

Alex

On Mon, 18 Oct 2021 at 16:07, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2021-10-18 at 15:56 +0200, Martin Jansa wrote:
> > On Sun, Oct 17, 2021 at 2:45 PM Martin Jansa via lists.openembedded.org
> > <Martin.Jansa=gmail.com@lists.openembedded.org> wrote:
> > > On Sun, Oct 17, 2021 at 2:03 PM Richard Purdie
> > > <richard.purdie@linuxfoundation.org> wrote:
> > > > On Sun, 2021-10-17 at 13:57 +0200, Andreas Müller wrote:
> > > > > >   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is
> at
> > > > > > least
> > > > > >   version "3.0.1")
> > > > >
> > > > > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > > > > ---
> > > > >  meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > > b/meta/recipes-
> > > > > sato/webkit/webkitgtk_2.34.0.bb
> > > > > index 25e1d422cc..a8e067147c 100644
> > > > > --- a/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.34.0.bb
> > > > > @@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
> > > > >
> > > > >  DEPENDS = " \
> > > > >            ruby-native \
> > > > > +          gperf-native \
> > > > >            cairo \
> > > > >            harfbuzz \
> > > > >            jpeg \
> > > >
> > > > Out of interest, why are you seeing that and the automated testing
> isn't?
> > > >
> > >
> > >
> > > FWIW: I'm also seeing webkitgtk failures since last upgrade, but for
> me it
> > > isn't because of gperf, but:
> > >
> > > | CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
> > > |   Either GLX or EGL is needed.
> > > | Call Stack (most recent call first):
> > > |   Source/cmake/WebKitCommon.cmake:220 (include)
> > > |   CMakeLists.txt:20 (include)
> > >
> > > possibly because the default setup in oe-core doesn't have opengl in
> > > DISTRO_FEATUES while all builds on autobuilder have opengl enabled with
> > > poky?
> > >
> >
> >
> > I've sent a fix for build for default oe-core setup (without opengl in
> > DISTRO_FEATURES).
> >
> > In my build gperf-native was found in older 2.32.3 from native sysroot:
> >
> > CMakeCache.txt.2.32.3-
> > r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy-
> > kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot-
> > native/usr/bin
> > /gperf
> > CMakeCache.txt.2.32.3-r0://Details about finding Gperf
> > CMakeCache.txt.2.32.3-
> >
> r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2
> > -foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys
> > root-native/usr/bin/gperf][v(3.0.1)]
> > CMakeCache.txt.2.32.3-r0://ADVANCED property for variable:
> GPERF_EXECUTABLE
> > CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1
> >
> > and it's found there through as transitive dependency from:
> >
> > "fontconfig.do_prepare_recipe_sysroot" ->
> "gperf-native.do_populate_sysroot"
> > "glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> > "libcap-native.do_prepare_recipe_sysroot" -> "gperf-
> > native.do_populate_sysroot"
> > "libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> > "systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"
> >
> > with some other combination of DISTRO_FEATURES it might be missing as in
> > Andreas case and as it's direct dependency of webkitgtk I think removing
> it
> > in:
> >
> https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2
> > wasn't correct, maybe other dependencies removed here have similar issue
> and
> > successful pass on autobuilder tests only very limited set of
> combinations
> > (understandably).
>
> We could put gperf-native into the same class of dependencies as pkgconfig-
> native which should expose all the missing dependencies at the risk of
> causing
> work in needing to correctly mark up the recipes.
>
> I'm at least happier now I understand why this was being masked.
>
> Cheers,
>
> Richard
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157063):
> https://lists.openembedded.org/g/openembedded-core/message/157063
> Mute This Topic: https://lists.openembedded.org/mt/86389188/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 7291 bytes --]