[PATCH] jack: allow empty jack package to satisfy jack-dev dependency

[PATCH] jack: allow empty jack package to satisfy jack-dev dependency

[Florian Wickert]

jack-dev depends on jack, which does not exist before this patch.
The empty package satisfies this dependency.

Signed-off-by: Florian Wickert <fw@javox-solutions.com>
---
 meta-oe/recipes-multimedia/jack/jack_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-multimedia/jack/jack_git.bb b/meta-oe/recipes-multimedia/jack/jack_git.bb
index be5f7bb..61064f4 100644
--- a/meta-oe/recipes-multimedia/jack/jack_git.bb
+++ b/meta-oe/recipes-multimedia/jack/jack_git.bb
@@ -32,6 +32,8 @@ PACKAGECONFIG[opus] = "--opus=yes,--opus=no,libopus"
 # portaudio is for windows builds only
 EXTRA_OECONF = "--portaudio=no"
 
+ALLOW_EMPTY_${PN} = "1"
+
 PACKAGES =+ "libjack jack-server jack-utils"
 
 FILES_libjack = "${libdir}/*.so.* ${libdir}/jack/*.so"
-- 
2.1.4

Re: [PATCH] jack: allow empty jack package to satisfy jack-dev dependency

[Martin Jansa]

NAK, no more useless empty packages, see ML it's discussed every few weeks.

On Thu, Apr 6, 2017 at 4:16 PM, Florian Wickert <fw@javox-solutions.com>
wrote:

> jack-dev depends on jack, which does not exist before this patch.
> The empty package satisfies this dependency.
>
> Signed-off-by: Florian Wickert <fw@javox-solutions.com>
> ---
>  meta-oe/recipes-multimedia/jack/jack_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-multimedia/jack/jack_git.bb
> b/meta-oe/recipes-multimedia/jack/jack_git.bb
> index be5f7bb..61064f4 100644
> --- a/meta-oe/recipes-multimedia/jack/jack_git.bb
> +++ b/meta-oe/recipes-multimedia/jack/jack_git.bb
> @@ -32,6 +32,8 @@ PACKAGECONFIG[opus] = "--opus=yes,--opus=no,libopus"
>  # portaudio is for windows builds only
>  EXTRA_OECONF = "--portaudio=no"
>
> +ALLOW_EMPTY_${PN} = "1"
> +
>  PACKAGES =+ "libjack jack-server jack-utils"
>
>  FILES_libjack = "${libdir}/*.so.* ${libdir}/jack/*.so"
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] jack: allow empty jack package to satisfy jack-dev dependency

[Florian Wickert]

You are right, empty packages are not a good solution. I made a new 
patch and fixed the dependency instead.


On 04/06/2017 06:12 PM, Martin Jansa wrote:
> NAK, no more useless empty packages, see ML it's discussed every few 
> weeks.
>
> On Thu, Apr 6, 2017 at 4:16 PM, Florian Wickert 
> <fw@javox-solutions.com <mailto:fw@javox-solutions.com>> wrote:
>
>     jack-dev depends on jack, which does not exist before this patch.
>     The empty package satisfies this dependency.
>
>     Signed-off-by: Florian Wickert <fw@javox-solutions.com
>     <mailto:fw@javox-solutions.com>>
>     ---
>      meta-oe/recipes-multimedia/jack/jack_git.bb <http://jack_git.bb>
>     | 2 ++
>      1 file changed, 2 insertions(+)
>
>     diff --git a/meta-oe/recipes-multimedia/jack/jack_git.bb
>     <http://jack_git.bb> b/meta-oe/recipes-multimedia/jack/jack_git.bb
>     <http://jack_git.bb>
>     index be5f7bb..61064f4 100644
>     --- a/meta-oe/recipes-multimedia/jack/jack_git.bb <http://jack_git.bb>
>     +++ b/meta-oe/recipes-multimedia/jack/jack_git.bb <http://jack_git.bb>
>     @@ -32,6 +32,8 @@ PACKAGECONFIG[opus] = "--opus=yes,--opus=no,libopus"
>      # portaudio is for windows builds only
>      EXTRA_OECONF = "--portaudio=no"
>
>     +ALLOW_EMPTY_${PN} = "1"
>     +
>      PACKAGES =+ "libjack jack-server jack-utils"
>
>      FILES_libjack = "${libdir}/*.so.* ${libdir}/jack/*.so"
>     --
>     2.1.4
>
>     --
>     _______________________________________________
>     Openembedded-devel mailing list
>     Openembedded-devel@lists.openembedded.org
>     <mailto:Openembedded-devel@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>
>
>