All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tcmode-default: Do not define LLVMVERSION
@ 2024-02-11 16:25 Khem Raj
  2024-02-11 22:10 ` [OE-core] " Martin Jansa
  0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2024-02-11 16:25 UTC (permalink / raw)
  To: openembedded-core; +Cc: Khem Raj, Ross Burton

There is a single version of llvm in core these days, furthermore the
version is no longer asked for by recipes such as mesa, which would use
llvm-config tool according to version of llvm found.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Ross Burton <ross.burton@arm.com>
---
 meta/conf/distro/include/tcmode-default.inc | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index e0319394f02..192a4e0bb2b 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -24,7 +24,6 @@ GLIBCVERSION ?= "2.39%"
 LINUXLIBCVERSION ?= "6.6%"
 QEMUVERSION ?= "8.2%"
 GOVERSION ?= "1.20%"
-LLVMVERSION ?= "17.%"
 RUSTVERSION ?= "1.74%"
 
 PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
@@ -77,10 +76,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
 
-PREFERRED_VERSION_llvm = "${LLVMVERSION}"
-PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
-PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
-
 # Rust toolchain preferred versions:
 
 PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core] [PATCH] tcmode-default: Do not define LLVMVERSION
  2024-02-11 16:25 [PATCH] tcmode-default: Do not define LLVMVERSION Khem Raj
@ 2024-02-11 22:10 ` Martin Jansa
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Jansa @ 2024-02-11 22:10 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-core, Ross Burton

[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]

There are some recipes in meta-intel which would need to be adjusted and
llvm version check in meta-browser, but I agree this is better than current
situation.

Acked-by: Martin Jansa <martin.jansa@gmail.com>

On Sun, Feb 11, 2024 at 5:25 PM Khem Raj <raj.khem@gmail.com> wrote:

> There is a single version of llvm in core these days, furthermore the
> version is no longer asked for by recipes such as mesa, which would use
> llvm-config tool according to version of llvm found.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Ross Burton <ross.burton@arm.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> index e0319394f02..192a4e0bb2b 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -24,7 +24,6 @@ GLIBCVERSION ?= "2.39%"
>  LINUXLIBCVERSION ?= "6.6%"
>  QEMUVERSION ?= "8.2%"
>  GOVERSION ?= "1.20%"
> -LLVMVERSION ?= "17.%"
>  RUSTVERSION ?= "1.74%"
>
>  PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
> @@ -77,10 +76,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
>
> -PREFERRED_VERSION_llvm = "${LLVMVERSION}"
> -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
> -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
> -
>  # Rust toolchain preferred versions:
>
>  PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#195295):
> https://lists.openembedded.org/g/openembedded-core/message/195295
> Mute This Topic: https://lists.openembedded.org/mt/104296141/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3254 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-11 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-11 16:25 [PATCH] tcmode-default: Do not define LLVMVERSION Khem Raj
2024-02-11 22:10 ` [OE-core] " Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.