From: Martin Jansa <martin.jansa@gmail.com>
To: fabien.lahoudere@collabora.com
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH] evince: Drop x11 requirement
Date: Tue, 20 Nov 2018 17:36:10 +0100 [thread overview]
Message-ID: <CA+chaQfN9Y+0TwfdcUc0mCzibX-U94SS9gR4NKGvF-FpCR5ekg@mail.gmail.com> (raw)
In-Reply-To: <1542730446-30253-1-git-send-email-fabien.lahoudere@collabora.com>
This was already removed once in:
commit 33c822a7c11df08f35dda18a44aae730f93c6130
Author: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
Date: Wed Sep 6 18:53:07 2017 +0200
evince: Remove X dependency
gnome-desktop is the only X dependency for evince.
In order to build evince for Wayland based system without X support,
gnome-desktop is added to DEPENDS only if x11 exists in DISTRO_FEATURES.
So x11 is dropped from REQUIRED_DISTRO_FEATURES.
Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
and then returned here:
commit 62376d673aa86b5f8ffb26c8a74046ee87ef4f66
Author: Armin Kuster <akuster808@gmail.com>
Date: Wed Mar 7 08:08:57 2018 -0800
evince: only include when x11 in DISTRO_FEATURES
Signed-off-by: Armin Kuster <akuster808@gmail.com>
What's going on? But if everybody agrees on removing it, then you should
remove the distro_features_check inherit as well.
On Tue, Nov 20, 2018 at 5:24 PM Fabien Lahoudere <
fabien.lahoudere@collabora.com> wrote:
> evince works fine in a wayland only distribution.
> x11 requirement is not needed.
>
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.com>
> ---
> meta-gnome/recipes-gnome/evince/evince_3.28.2.bb | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> index 8bf8a04..01f581a 100644
> --- a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> +++ b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> @@ -6,8 +6,6 @@ DEPENDS = "gtk+3 libsecret
> ${@bb.utils.contains('DISTRO_FEATURES','x11','gnome-d
>
> inherit gnome pkgconfig gtk-icon-cache gsettings gobject-introspection
> distro_features_check systemd
>
> -REQUIRED_DISTRO_FEATURES = "x11"
> -
> SRC_URI =
> "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive
> \
> file://0001-help-remove-YELP-macro.patch \
> file://0001-Add-format-attribute-to-_synctex_malloc.patch \
> --
> 1.8.3.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
next prev parent reply other threads:[~2018-11-20 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 16:14 [PATCH] evince: Drop x11 requirement Fabien Lahoudere
2018-11-20 16:36 ` Martin Jansa [this message]
2018-11-20 17:01 ` akuster808
2018-11-21 9:45 ` Fabien Lahoudere
2018-11-20 18:22 ` Andreas Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+chaQfN9Y+0TwfdcUc0mCzibX-U94SS9gR4NKGvF-FpCR5ekg@mail.gmail.com \
--to=martin.jansa@gmail.com \
--cc=fabien.lahoudere@collabora.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.