All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Müller" <schnitzeltony@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH] evince: Drop x11 requirement
Date: Tue, 20 Nov 2018 19:22:45 +0100	[thread overview]
Message-ID: <CALbNGRQ_q=+GYLc5x8Fh3=wnTTnTPci+zbJOgvYApEJSQQMTpA@mail.gmail.com> (raw)
In-Reply-To: <CA+chaQfN9Y+0TwfdcUc0mCzibX-U94SS9gR4NKGvF-FpCR5ekg@mail.gmail.com>

On Tue, Nov 20, 2018 at 5:36 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> This was already removed once in:
>
> commit 33c822a7c11df08f35dda18a44aae730f93c6130
> Author: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> Date:   Wed Sep 6 18:53:07 2017 +0200
>
>     evince: Remove X dependency
>
>     gnome-desktop is the only X dependency for evince.
>     In order to build evince for Wayland based system without X support,
>     gnome-desktop is added to DEPENDS only if x11 exists in DISTRO_FEATURES.
>     So x11 is dropped from REQUIRED_DISTRO_FEATURES.
>
>     Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
>     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>
> and then returned here:
> commit 62376d673aa86b5f8ffb26c8a74046ee87ef4f66
> Author: Armin Kuster <akuster808@gmail.com>
> Date:   Wed Mar 7 08:08:57 2018 -0800
>
>     evince: only include when x11 in DISTRO_FEATURES
>
>     Signed-off-by: Armin Kuster <akuster808@gmail.com>
>
> What's going on?
The magic yocto-layer-script is going on :)
> But if everybody agrees on removing it, then you should
> remove the distro_features_check inherit as well.

Andreas


      parent reply	other threads:[~2018-11-20 18:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 16:14 [PATCH] evince: Drop x11 requirement Fabien Lahoudere
2018-11-20 16:36 ` Martin Jansa
2018-11-20 17:01   ` akuster808
2018-11-21  9:45     ` Fabien Lahoudere
2018-11-20 18:22   ` Andreas Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALbNGRQ_q=+GYLc5x8Fh3=wnTTnTPci+zbJOgvYApEJSQQMTpA@mail.gmail.com' \
    --to=schnitzeltony@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.