Re: [OE-core] [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4278 bytes --]

FWIW: I've fixed some bigger layers where pkgconfig was causing quite a few
build failures,

e.g. meta-webosose needed it in around 30 recipes (included in
https://github.com/shr-project/meta-webosose/commits/dunfell)
meta-ros layers I'm still working on, sofar over 50 recipes (
https://github.com/ros/meta-ros/pull/939)

One interesting case I wanted to mention here was collada-dom in meta-ros:
https://github.com/ros/meta-ros/pull/939/commits/4e790a7de5e740eae3084a925a8a23f575ddf410

including this layer.conf change caused collada-dom not to fail with
reasonable error about missing pkgconfig-native, but triggered textrel QA
issue and it was actually caused by pkgconfig not being available where
do_configure "silently" failed to find system bzip2 and minizip due to
missing pkgconfig and built own version instead which lead to this textrel
QA issue.

There might be many more recipes like this, which build something
differently without pkgconfig available, without triggering any QA check
like in this case. It might be useful to compare at least buildhistory
results with and without the layer.conf change to see what else was changed
unexpectedly.

Cheers,

On Tue, Sep 21, 2021 at 6:21 AM Khem Raj <raj.khem@gmail.com> wrote:

> On Mon, Sep 20, 2021 at 6:34 AM Joshua Watt <JPEWhacker@gmail.com> wrote:
> >
> >
> > On 9/20/21 7:48 AM, Richard Purdie wrote:
> >
> > On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via
> lists.openembedded.org
> > wrote:
> >
> > There are several dependencies which recipes have which are not needed
> > at runtime, only at build time. Extend the list of these from bison to
> > include quilt, patch, meson, autoconf, automake and ninja which should
> > reduce the amount of data being included in native sysroots.
> >
> > This speeds up and reduces the sstate needed for image builds for
> example.
> >
> > If this change breaks recipes, it probably means they're missing an
> explicit
> > DEPENDS on something in this list which is a bug in the recipe.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/conf/layer.conf | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> > index 307ad7e2237..b3cc8a249e9 100644
> > --- a/meta/conf/layer.conf
> > +++ b/meta/conf/layer.conf
> > @@ -48,6 +48,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
> >  "
> >
> >  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
> > +  *->patch-native \
> >    *->quilt-native \
> >    *->subversion-native \
> >    *->git-native \
> > @@ -90,7 +91,16 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
> >  # (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
> >  # dependency incidentally. This improves determinism and avoids build
> >  # failures when people switch to external toolchains.
> > -SSTATE_EXCLUDEDEPS_SYSROOT += ".*->bison-native"
> > +SSTATE_EXCLUDEDEPS_SYSROOT += "\
> > +    .*->autoconf-native \
> > +    .*->automake-native \
> > +    .*->bison-native \
> > +    .*->meson-native \
> > +    .*->ninja-native \
> > +    .*->patch-native \
> > +    .*->pkgconfig-native \
> > +    .*->quilt-native \
> > +"
> >
> > I've marked this one as an RFC since it caused a fair bit of pain even
> in OE-
> > core due to recipes having pkgconfig class inherits missing.
> >
> > We do really want to do this and correctly mark up the recipe
> dependencies, the
> > question is whether it is too late for 3.4 or not. We could go for a
> smaller
> > list for now too but I wanted to hear opinions.
> >
> >
> > It looks like a great change! I'd say it's too late for 3.4 and we
> should do it for 3.5 instead.
> >
>
> right see the failed recipes which would need fixing
> https://errors.yoctoproject.org/Errors/Build/130779/
>
> > Cheers,
> >
> > Richard
> >
> >
> >
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156200):
> https://lists.openembedded.org/g/openembedded-core/message/156200
> Mute This Topic: https://lists.openembedded.org/mt/85739636/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 6311 bytes --]