[PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Gianfranco Costamagna]

From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
---
 meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
index e06ff7f..7a8ba60 100644
--- a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
+++ b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
@@ -3,10 +3,10 @@ SUMMARY = "Library for IPv6 Neighbor Discovery Protocol"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
-SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
+SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
            file://0001-include-sys-select.h-for-fd_-definitions.patch \
            "
-SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
-SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
+
+S = "${WORKDIR}/git"
 
 inherit autotools
-- 
2.7.4

[meta-oe][PATCH] libndp: Update patch with upstream version.

[Gianfranco Costamagna]

From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
---
 ...-include-sys-select.h-for-fd_-definitions.patch | 32 +++++++++++-----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libndp/libndp/0001-include-sys-select.h-for-fd_-definitions.patch b/meta-oe/recipes-connectivity/libndp/libndp/0001-include-sys-select.h-for-fd_-definitions.patch
index bafd916..15aa94e 100644
--- a/meta-oe/recipes-connectivity/libndp/libndp/0001-include-sys-select.h-for-fd_-definitions.patch
+++ b/meta-oe/recipes-connectivity/libndp/libndp/0001-include-sys-select.h-for-fd_-definitions.patch
@@ -1,25 +1,25 @@
-From 33150de2d77ffb645da1a043933b12ddc0143cea Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.khem@gmail.com>
-Date: Tue, 21 Mar 2017 18:59:03 -0700
-Subject: [PATCH] include sys/select.h for fd_* definitions
+From 94e9a082d76414f82794b0c9817d0c24e3868275 Mon Sep 17 00:00:00 2001
+From: Kylie McClain <somasis@exherbo.org>
+Date: Sat, 21 May 2016 21:24:36 -0400
+Subject: [PATCH] ndptool: Fix compilation on musl libc
 
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
+FD_ZERO, fd_set, etc are defined within sys/select.h on musl.
+
+Signed-off-by: Kylie McClain <somasis@exherbo.org>
+Signed-off-by: Jiri Pirko <jiri@mellanox.com>
 ---
  utils/ndptool.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/utils/ndptool.c b/utils/ndptool.c
-index 1d96f4c..0fd4c4d 100644
+index 1d96f4c..96479fa 100644
 --- a/utils/ndptool.c
 +++ b/utils/ndptool.c
-@@ -23,6 +23,7 @@
- #include <string.h>
- #include <signal.h>
- #include <getopt.h>
-+#include <sys/select.h>
- #include <net/if.h>
- #include <netinet/in.h>
+@@ -28,6 +28,7 @@
  #include <arpa/inet.h>
--- 
-2.12.0
-
+ #include <errno.h>
+ #include <ndp.h>
++#include <sys/select.h>
+ 
+ enum verbosity_level {
+ 	VERB1,
-- 
2.7.4

Re: [PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Martin Jansa]

;branch=master is default and you can drop it.

Don't use tag names (bitbake will have to reach the git repository to
convert the name to fixed SRCREV every time it parses the recipe), use
fixed SRCREV which is matching the tag.

On Thu, May 11, 2017 at 2:53 PM, Gianfranco Costamagna <
costamagna.gianfranco@gmail.com> wrote:

> From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
>
> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> ---
>  meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
> b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
> index e06ff7f..7a8ba60 100644
> --- a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
> +++ b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
> @@ -3,10 +3,10 @@ SUMMARY = "Library for IPv6 Neighbor Discovery Protocol"
>  LICENSE = "LGPLv2.1"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
>
> -SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
> +SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
>             file://0001-include-sys-select.h-for-fd_-definitions.patch \
>             "
> -SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
> -SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f
> 72cfaf14f4ff77a77425e52edc33ffac0e"
> +
> +S = "${WORKDIR}/git"
>
>  inherit autotools
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2107 bytes --]

On Wed, May 17, 2017 at 08:35:23AM +0200, Anders Darander wrote:
> Hi,
> 
> * Gianfranco Costamagna <costamagna.gianfranco@gmail.com> [170516 13:15]:
> 
> First, the subject should have included [PATCH v2 1/2] instead of just
> [PATCH 1/2], as this really is the 2nd version. (This applies to the
> whole series).
> 
> > From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> 
> > Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> > ---
> 
> Down here, a changelog for the changes between v1 and v2. (At least if
> they'r not covered by a cover letter).
> 
> >  meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> > -SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
> > +SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
> 
> Pleasen, remove tag=v${PV} from the SRC_URI. Instead, add a SRVREV= the
> SHA1. If you use a tag, bitbake will reach out the git server upon each
> build to verify the SHA1 of the tag. That'll break off-line builds etc.

This is actually 6th version of this change I've seen on ML and one of
them (the one I've cherry-picked to master-next) already sets SRCREV
correctly (I made the same comment earlier).

https://patchwork.openembedded.org/project/oe/patches/?submitter=&state=*&q=libndp&archive=both&delegate=

> 
> Cheers,
> Anders
> 
> >             file://0001-include-sys-select.h-for-fd_-definitions.patch \
> >             "
> > -SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
> > -SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
> > +
> > +S = "${WORKDIR}/git"
> > +
> 
> >  inherit autotools
> -- 
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Anders Darander]

Hi,

* Gianfranco Costamagna <costamagna.gianfranco@gmail.com> [170516 13:15]:

First, the subject should have included [PATCH v2 1/2] instead of just
[PATCH 1/2], as this really is the 2nd version. (This applies to the
whole series).

> From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> ---

Down here, a changelog for the changes between v1 and v2. (At least if
they'r not covered by a cover letter).

>  meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

> -SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
> +SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \

Pleasen, remove tag=v${PV} from the SRC_URI. Instead, add a SRVREV= the
SHA1. If you use a tag, bitbake will reach out the git server upon each
build to verify the SHA1 of the tag. That'll break off-line builds etc.

Cheers,
Anders

>             file://0001-include-sys-select.h-for-fd_-definitions.patch \
>             "
> -SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
> -SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
> +
> +S = "${WORKDIR}/git"
> +

>  inherit autotools
-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB

[PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Gianfranco Costamagna]

From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
---
 meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
index e06ff7f..7cfdd4c 100644
--- a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
+++ b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
@@ -3,10 +3,11 @@ SUMMARY = "Library for IPv6 Neighbor Discovery Protocol"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
-SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
+SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
            file://0001-include-sys-select.h-for-fd_-definitions.patch \
            "
-SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
-SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
+
+S = "${WORKDIR}/git"
+
 
 inherit autotools
-- 
2.7.4

[PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Gianfranco Costamagna]

From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
---
 meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
index e06ff7f..7cfdd4c 100644
--- a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
+++ b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
@@ -3,10 +3,13 @@ SUMMARY = "Library for IPv6 Neighbor Discovery Protocol"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
-SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
+SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
            file://0001-include-sys-select.h-for-fd_-definitions.patch \
            "
-SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
-SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
+
+S = "${WORKDIR}/git"
+
+SRC_URI[md5sum] = "de58352aaee0e8edb744f1aef852cdce"
+SRC_URI[sha256sum] = "565d6c4167f83ec697c762ea002f23e8f0b00828d0749b1ce928f068543e5aad"
 
 inherit autotools
-- 
2.7.4

[PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Gianfranco Costamagna]

From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
---
 meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
index e06ff7f..2cc345a 100644
--- a/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
+++ b/meta-oe/recipes-connectivity/libndp/libndp_1.6.bb
@@ -3,10 +3,11 @@ SUMMARY = "Library for IPv6 Neighbor Discovery Protocol"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
-SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
+SRC_URI = "git://github.com/jpirko/libndp \
            file://0001-include-sys-select.h-for-fd_-definitions.patch \
            "
-SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
-SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
+# tag for v1.6
+SRCREV = "2f721c4ff519f38f46695a60d9f9d88f35bf3c1d"
+S = "${WORKDIR}/git"
 
 inherit autotools
-- 
2.7.4