All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Marco Elver <elver@google.com>
Cc: yee.lee@mediatek.com, LKML <linux-kernel@vger.kernel.org>,
	nicholas.tang@mediatek.com,
	Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
	chinwen.chang@mediatek.com,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"open list:KASAN" <kasan-dev@googlegroups.com>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG
Date: Mon, 5 Jul 2021 13:23:17 +0200	[thread overview]
Message-ID: <CA+fCnZfKAZuy9oyDpTgNUTcNz5gnfHpJK5WN-yBNDV5VF8cq0g@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNNXbszUL4M+-swi7k28h=zuY-KTfw+6W90hk2mgxr8hRQ@mail.gmail.com>

On Mon, Jul 5, 2021 at 1:18 PM Marco Elver <elver@google.com> wrote:
>
> On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@gmail.com> wrote:
> [...]
> > > +       /*
> > > +        * Explicitly initialize the memory with the precise object size to
> > > +        * avoid overwriting the SLAB redzone. This disables initialization in
> > > +        * the arch code and may thus lead to performance penalty. The penalty
> > > +        * is accepted since SLAB redzones aren't enabled in production builds.
> > > +        */
> > > +       if (__slub_debug_enabled() &&
> >
> > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I
> > didn't receive patch #1 of v6 (nor of v5).
>
> Somebody had the same idea with the helper:
> https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com
> and Matthew didn't like the _unlikely() prefix.
>
> Which meant we should just move the existing helper introduced in the
> merge window.
>
> Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com

Got it. Thank you, Marco!

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Marco Elver <elver@google.com>
Cc: yee.lee@mediatek.com, LKML <linux-kernel@vger.kernel.org>,
	 nicholas.tang@mediatek.com,
	Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
	 chinwen.chang@mediatek.com,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	 Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	 "open list:KASAN" <kasan-dev@googlegroups.com>,
	 "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG
Date: Mon, 5 Jul 2021 13:23:17 +0200	[thread overview]
Message-ID: <CA+fCnZfKAZuy9oyDpTgNUTcNz5gnfHpJK5WN-yBNDV5VF8cq0g@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNNXbszUL4M+-swi7k28h=zuY-KTfw+6W90hk2mgxr8hRQ@mail.gmail.com>

On Mon, Jul 5, 2021 at 1:18 PM Marco Elver <elver@google.com> wrote:
>
> On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@gmail.com> wrote:
> [...]
> > > +       /*
> > > +        * Explicitly initialize the memory with the precise object size to
> > > +        * avoid overwriting the SLAB redzone. This disables initialization in
> > > +        * the arch code and may thus lead to performance penalty. The penalty
> > > +        * is accepted since SLAB redzones aren't enabled in production builds.
> > > +        */
> > > +       if (__slub_debug_enabled() &&
> >
> > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I
> > didn't receive patch #1 of v6 (nor of v5).
>
> Somebody had the same idea with the helper:
> https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com
> and Matthew didn't like the _unlikely() prefix.
>
> Which meant we should just move the existing helper introduced in the
> merge window.
>
> Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com

Got it. Thank you, Marco!

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Marco Elver <elver@google.com>
Cc: yee.lee@mediatek.com, LKML <linux-kernel@vger.kernel.org>,
	 nicholas.tang@mediatek.com,
	Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
	 chinwen.chang@mediatek.com,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	 Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	 "open list:KASAN" <kasan-dev@googlegroups.com>,
	 "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG
Date: Mon, 5 Jul 2021 13:23:17 +0200	[thread overview]
Message-ID: <CA+fCnZfKAZuy9oyDpTgNUTcNz5gnfHpJK5WN-yBNDV5VF8cq0g@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNNXbszUL4M+-swi7k28h=zuY-KTfw+6W90hk2mgxr8hRQ@mail.gmail.com>

On Mon, Jul 5, 2021 at 1:18 PM Marco Elver <elver@google.com> wrote:
>
> On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@gmail.com> wrote:
> [...]
> > > +       /*
> > > +        * Explicitly initialize the memory with the precise object size to
> > > +        * avoid overwriting the SLAB redzone. This disables initialization in
> > > +        * the arch code and may thus lead to performance penalty. The penalty
> > > +        * is accepted since SLAB redzones aren't enabled in production builds.
> > > +        */
> > > +       if (__slub_debug_enabled() &&
> >
> > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I
> > didn't receive patch #1 of v6 (nor of v5).
>
> Somebody had the same idea with the helper:
> https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com
> and Matthew didn't like the _unlikely() prefix.
>
> Which meant we should just move the existing helper introduced in the
> merge window.
>
> Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com

Got it. Thank you, Marco!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-05 11:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 10:32 [PATCH v6 0/2] kasan: solve redzone overwritten issue at debug yee.lee
2021-07-05 10:32 ` yee.lee
2021-07-05 10:32 ` yee.lee
2021-07-05 10:32 ` [PATCH v6 1/2] mm: move helper to check slub_debug_enabled yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:32 ` [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:32   ` yee.lee
2021-07-05 10:45   ` Marco Elver
2021-07-05 10:45     ` Marco Elver
2021-07-05 10:45     ` Marco Elver
2021-07-05 10:45     ` Marco Elver
2021-07-05 11:12   ` Andrey Konovalov
2021-07-05 11:12     ` Andrey Konovalov
2021-07-05 11:12     ` Andrey Konovalov
2021-07-05 11:12     ` Andrey Konovalov
2021-07-05 11:18     ` Marco Elver
2021-07-05 11:18       ` Marco Elver
2021-07-05 11:18       ` Marco Elver
2021-07-05 11:18       ` Marco Elver
2021-07-05 11:23       ` Andrey Konovalov [this message]
2021-07-05 11:23         ` Andrey Konovalov
2021-07-05 11:23         ` Andrey Konovalov
2021-07-05 11:23         ` Andrey Konovalov
2021-07-05 13:53         ` Yee Lee
2021-07-05 13:53           ` Yee Lee
2021-07-05 13:53           ` Yee Lee
2021-07-05 13:53           ` Yee Lee
2021-07-05 11:23   ` Andrey Konovalov
2021-07-05 11:23     ` Andrey Konovalov
2021-07-05 11:23     ` Andrey Konovalov
2021-07-05 11:23     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+fCnZfKAZuy9oyDpTgNUTcNz5gnfHpJK5WN-yBNDV5VF8cq0g@mail.gmail.com \
    --to=andreyknvl@gmail.com \
    --cc=Kuan-Ying.Lee@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=chinwen.chang@mediatek.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nicholas.tang@mediatek.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=yee.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.