[U-Boot] DCache in designware.c brakes bf609-ezkit board build

[U-Boot] DCache in designware.c brakes bf609-ezkit board build

[Vasili Galka]

Hi Alexey,

Your commit 50b0df814b0f75c08a3d45a017016a75af3edb5d caused
drivers/net/designware.c to be dependent on dcache functionality, e.g.
invalidate_dcache_range(). This brakes build for configurations that don't
have this implemented. For example the blackfin based "bf609-ezkit" board
does
not build now since it uses designware.c but there is no dcache related
stuff
for the blackfin arch.

What do you see as the right solution for this? Implement some stub
functions
for dcache on blackfin? #ifdef the dcache calls in designware.c? If the
later, what CONFIG conditions are the best to use?

Looking forward for your opinion.

Best,
Vasili

[U-Boot] DCache in designware.c brakes bf609-ezkit board build

[Alexey Brodkin]

Hi Vasili,

On Wed, 2014-06-25 at 15:38 +0300, Vasili Galka wrote:
> Hi Alexey,
> 
> Your commit 50b0df814b0f75c08a3d45a017016a75af3edb5d caused
> drivers/net/designware.c to be dependent on dcache functionality, e.g.
> invalidate_dcache_range(). This brakes build for configurations that
> don't
> have this implemented. For example the blackfin based "bf609-ezkit"
> board does
> not build now since it uses designware.c but there is no dcache
> related stuff
> for the blackfin arch.
> 
> What do you see as the right solution for this? Implement some stub
> functions
> for dcache on blackfin? #ifdef the dcache calls in designware.c? If
> the
> later, what CONFIG conditions are the best to use?

When I added dcache invalidation/flush functions in DW GMAC driver I
expected that all arches have real or stub functions for cache
operations.

So IMHO the simplest solution is to implement stub functions for
blackfin.

But then maybe it's time to look a bit broader and implement generic
stub functions for cache operations and declare them "weak". This will
immediately obsolete requirement of per-arch stubs... well and hopefully
all existing stubs for arches will be removed  - this would also benefit
entire U-Boot project making sources a bit more tiny.

Let me know if either option above works for you and if you need any
help from my side.

-Alexey