* [U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
` (8 subsequent siblings)
9 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
The point of this patch is to eliminate the use of the locally-defined
"reg" variable (which interferes with next patch) and simplify the
fallback to the default CONFIG_SYS_TBIPA_VALUE in case "tbi-handle" is
missing.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 06a9b4fb03ce..53eb5470f4c8 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -798,6 +798,7 @@ int tsec_probe(struct udevice *dev)
struct eth_pdata *pdata = dev_get_platdata(dev);
struct fsl_pq_mdio_info mdio_info;
struct ofnode_phandle_args phandle_args;
+ u32 tbiaddr = CONFIG_SYS_TBIPA_VALUE;
ofnode parent;
const char *phy_mode;
int ret;
@@ -825,14 +826,12 @@ int tsec_probe(struct udevice *dev)
return -ENOENT;
}
- if (dev_read_phandle_with_args(dev, "tbi-handle", NULL, 0, 0,
- &phandle_args)) {
- priv->tbiaddr = CONFIG_SYS_TBIPA_VALUE;
- } else {
- int reg = ofnode_read_u32_default(phandle_args.node, "reg",
- CONFIG_SYS_TBIPA_VALUE);
- priv->tbiaddr = reg;
- }
+ ret = dev_read_phandle_with_args(dev, "tbi-handle", NULL, 0, 0,
+ &phandle_args);
+ if (ret == 0)
+ ofnode_read_u32(phandle_args.node, "reg", &tbiaddr);
+
+ priv->tbiaddr = tbiaddr;
phy_mode = dev_read_prop(dev, "phy-connection-type", NULL);
if (phy_mode)
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
2019-07-18 21:29 ` [U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-23 6:23 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation Vladimir Oltean
` (7 subsequent siblings)
9 siblings, 2 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
By convention, the eTSEC MDIO controller nodes are defined in DT at
0x2d24000 and 0x2d50000, but actually U-Boot does not touch the
interrupt portion of the register map (MDIO_IEVENTM, MDIO_IMASKM,
MDIO_EMAPM).
That leaves only the MDIO bus registers (MDIO_MIIMCFG, MDIO_MIIMCOM,
MDIO_MIIMADD, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at
the 0x520 offset.
So shift the DT-defined register map by the offset of MDIO_MIIMCFG when
mapping the MDIO bus registers.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 13 +++++++------
include/tsec.h | 4 +++-
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 53eb5470f4c8..576398676af7 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -801,6 +801,7 @@ int tsec_probe(struct udevice *dev)
u32 tbiaddr = CONFIG_SYS_TBIPA_VALUE;
ofnode parent;
const char *phy_mode;
+ fdt_addr_t reg;
int ret;
pdata->iobase = (phys_addr_t)dev_read_addr(dev);
@@ -817,15 +818,15 @@ int tsec_probe(struct udevice *dev)
}
parent = ofnode_get_parent(phandle_args.node);
- if (ofnode_valid(parent)) {
- int reg = ofnode_get_addr_index(parent, 0);
-
- priv->phyregs_sgmii = (struct tsec_mii_mng *)reg;
- } else {
- debug("No parent node for PHY?\n");
+ if (!ofnode_valid(parent)) {
+ printf("No parent node for PHY?\n");
return -ENOENT;
}
+ reg = ofnode_get_addr_index(parent, 0);
+ priv->phyregs_sgmii = (struct tsec_mii_mng *)
+ (reg + TSEC_MDIO_REGS_OFFSET);
+
ret = dev_read_phandle_with_args(dev, "tbi-handle", NULL, 0, 0,
&phandle_args);
if (ret == 0)
diff --git a/include/tsec.h b/include/tsec.h
index e90095121bdd..b17fa957df5b 100644
--- a/include/tsec.h
+++ b/include/tsec.h
@@ -17,6 +17,8 @@
#include <config.h>
#include <phy.h>
+#define TSEC_MDIO_REGS_OFFSET 0x520
+
#ifndef CONFIG_DM_ETH
#ifdef CONFIG_ARCH_LS1021A
@@ -27,7 +29,7 @@
#define TSEC_MDIO_OFFSET 0x01000
#endif
-#define CONFIG_SYS_MDIO_BASE_ADDR (MDIO_BASE_ADDR + 0x520)
+#define CONFIG_SYS_MDIO_BASE_ADDR (MDIO_BASE_ADDR + TSEC_MDIO_REGS_OFFSET)
#define TSEC_GET_REGS(num, offset) \
(struct tsec __iomem *)\
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
@ 2019-07-23 6:23 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
1 sibling, 0 replies; 33+ messages in thread
From: Bin Meng @ 2019-07-23 6:23 UTC (permalink / raw)
To: u-boot
On Fri, Jul 19, 2019 at 5:32 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> By convention, the eTSEC MDIO controller nodes are defined in DT at
> 0x2d24000 and 0x2d50000, but actually U-Boot does not touch the
> interrupt portion of the register map (MDIO_IEVENTM, MDIO_IMASKM,
> MDIO_EMAPM).
>
> That leaves only the MDIO bus registers (MDIO_MIIMCFG, MDIO_MIIMCOM,
> MDIO_MIIMADD, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at
> the 0x520 offset.
>
> So shift the DT-defined register map by the offset of MDIO_MIIMCFG when
> mapping the MDIO bus registers.
>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
> Changes from v2:
>
> None.
>
> Changes from v1:
>
> None.
>
> drivers/net/tsec.c | 13 +++++++------
> include/tsec.h | 4 +++-
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] net: tsec: Fix offset of MDIO registers for DM_ETH
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
2019-07-23 6:23 ` Bin Meng
@ 2019-07-25 18:42 ` Joe Hershberger
1 sibling, 0 replies; 33+ messages in thread
From: Joe Hershberger @ 2019-07-25 18:42 UTC (permalink / raw)
To: u-boot
Hi Vladimir,
https://patchwork.ozlabs.org/patch/1133860/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks!
-Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
2019-07-18 21:29 ` [U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property Vladimir Oltean
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible Vladimir Oltean
` (6 subsequent siblings)
9 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
This is a cosmetic patch that reorders variable definitions in the
inverse order of their line length, where possible.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 576398676af7..ce19ff9228fd 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -259,8 +259,8 @@ static int tsec_send(struct udevice *dev, void *packet, int length)
{
struct tsec_private *priv = (struct tsec_private *)dev->priv;
struct tsec __iomem *regs = priv->regs;
- u16 status;
int result = 0;
+ u16 status;
int i;
/* Find an empty buffer descriptor */
@@ -708,9 +708,9 @@ static int init_phy(struct tsec_private *priv)
*/
static int tsec_initialize(bd_t *bis, struct tsec_info_struct *tsec_info)
{
+ struct tsec_private *priv;
struct eth_device *dev;
int i;
- struct tsec_private *priv;
dev = (struct eth_device *)malloc(sizeof(*dev));
@@ -794,14 +794,14 @@ int tsec_standard_init(bd_t *bis)
#else /* CONFIG_DM_ETH */
int tsec_probe(struct udevice *dev)
{
- struct tsec_private *priv = dev_get_priv(dev);
struct eth_pdata *pdata = dev_get_platdata(dev);
- struct fsl_pq_mdio_info mdio_info;
+ struct tsec_private *priv = dev_get_priv(dev);
struct ofnode_phandle_args phandle_args;
u32 tbiaddr = CONFIG_SYS_TBIPA_VALUE;
- ofnode parent;
+ struct fsl_pq_mdio_info mdio_info;
const char *phy_mode;
fdt_addr_t reg;
+ ofnode parent;
int ret;
pdata->iobase = (phys_addr_t)dev_read_addr(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (2 preceding siblings ...)
2019-07-18 21:29 ` [U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH Vladimir Oltean
` (5 subsequent siblings)
9 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
This replaces debug() calls with printf() so that it is immediately
obvious from the console that something is wrong.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index ce19ff9228fd..1e20fe4cd246 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -268,7 +268,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length)
in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY;
i++) {
if (i >= TOUT_LOOP) {
- debug("%s: tsec: tx buffers full\n", dev->name);
+ printf("%s: tsec: tx buffers full\n", dev->name);
return result;
}
}
@@ -287,7 +287,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length)
in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY;
i++) {
if (i >= TOUT_LOOP) {
- debug("%s: tsec: tx error\n", dev->name);
+ printf("%s: tsec: tx error\n", dev->name);
return result;
}
}
@@ -809,7 +809,7 @@ int tsec_probe(struct udevice *dev)
if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
&phandle_args)) {
- debug("phy-handle does not exist under tsec %s\n", dev->name);
+ printf("phy-handle does not exist under tsec %s\n", dev->name);
return -ENOENT;
} else {
int reg = ofnode_read_u32_default(phandle_args.node, "reg", 0);
@@ -838,7 +838,7 @@ int tsec_probe(struct udevice *dev)
if (phy_mode)
pdata->phy_interface = phy_get_interface_by_name(phy_mode);
if (pdata->phy_interface == -1) {
- debug("Invalid PHY interface '%s'\n", phy_mode);
+ printf("Invalid PHY interface '%s'\n", phy_mode);
return -EINVAL;
}
priv->interface = pdata->phy_interface;
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (3 preceding siblings ...)
2019-07-18 21:29 ` [U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
` (4 subsequent siblings)
9 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
In tsec_init, the MAC address is retrieved from 2 different structures
depending on whether DM_ETH is enabled or not.
But since the field name is the same inside both structures, we can
conditionally define the structure of the correct type and simplify the
assignments.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 1e20fe4cd246..f6278817330d 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -560,6 +560,8 @@ static int tsec_init(struct udevice *dev)
struct tsec_private *priv = (struct tsec_private *)dev->priv;
#ifdef CONFIG_DM_ETH
struct eth_pdata *pdata = dev_get_platdata(dev);
+#else
+ struct eth_device *pdata = dev;
#endif
struct tsec __iomem *regs = priv->regs;
u32 tempval;
@@ -580,21 +582,12 @@ static int tsec_init(struct udevice *dev)
* order (BE), MACnADDR1 is set to 0xCDAB7856 and
* MACnADDR2 is set to 0x34120000.
*/
-#ifndef CONFIG_DM_ETH
- tempval = (dev->enetaddr[5] << 24) | (dev->enetaddr[4] << 16) |
- (dev->enetaddr[3] << 8) | dev->enetaddr[2];
-#else
tempval = (pdata->enetaddr[5] << 24) | (pdata->enetaddr[4] << 16) |
(pdata->enetaddr[3] << 8) | pdata->enetaddr[2];
-#endif
out_be32(®s->macstnaddr1, tempval);
-#ifndef CONFIG_DM_ETH
- tempval = (dev->enetaddr[1] << 24) | (dev->enetaddr[0] << 16);
-#else
tempval = (pdata->enetaddr[1] << 24) | (pdata->enetaddr[0] << 16);
-#endif
out_be32(®s->macstnaddr2, tempval);
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (4 preceding siblings ...)
2019-07-18 21:29 ` [U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-23 3:30 ` Joe Hershberger
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver Vladimir Oltean
` (3 subsequent siblings)
9 siblings, 2 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
In the case of the tsec network driver, so far there has been no
mainline user of DM_ETH where the DT bindings get used.
In the case of the mdio bus, it looks like the "fsl,tsec-mdio" string
was made up for the documentation, but there is no mainline code that
parses the "compatible" property anyway.
In both cases, there are no DT blobs that contain the old strings.
So change the documentation to "fsl,etsec2" for the Ethernet ports and
"fsl,etsec2-mdio" for the MDIO buses, which are strings that Linux also
uses, at least for LS1021A. More compatible strings can be added once
other (PowerPC) SoCs are migrated to DM_ETH.
The current ls1021a.dtsi doesn't match what was documented for the MDIO
buses anyway (the "compatible" is "gianfar" currently). This will be
fixed in the next patch.
Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
Patch is new.
doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++--
drivers/net/tsec.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt b/doc/device-tree-bindings/net/fsl-tsec-phy.txt
index c5bf48c3cb51..59989e3b09d6 100644
--- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt
+++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt
@@ -28,13 +28,13 @@ device that exists on this bus, a PHY node should be created.
Required properties:
- compatible : Should define the compatible device type for the
- mdio. Currently supported string/device is "fsl,tsec-mdio".
+ mdio. Currently supported string/device is "fsl,etsec2-mdio".
- reg : Offset and length of the register set for the device
Example:
mdio at 24520 {
- compatible = "fsl,tsec-mdio";
+ compatible = "fsl,etsec2-mdio";
reg = <0x24520 0x20>;
ethernet-phy at 0 {
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index f6278817330d..f85cdcb97ebf 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -880,7 +880,7 @@ static const struct eth_ops tsec_ops = {
};
static const struct udevice_id tsec_ids[] = {
- { .compatible = "fsl,tsec" },
+ { .compatible = "fsl,etsec2" },
{ }
};
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux
2019-07-18 21:29 ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
@ 2019-07-23 3:30 ` Joe Hershberger
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
1 sibling, 0 replies; 33+ messages in thread
From: Joe Hershberger @ 2019-07-23 3:30 UTC (permalink / raw)
To: u-boot
On Thu, Jul 18, 2019 at 4:36 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> In the case of the tsec network driver, so far there has been no
> mainline user of DM_ETH where the DT bindings get used.
>
> In the case of the mdio bus, it looks like the "fsl,tsec-mdio" string
> was made up for the documentation, but there is no mainline code that
> parses the "compatible" property anyway.
>
> In both cases, there are no DT blobs that contain the old strings.
>
> So change the documentation to "fsl,etsec2" for the Ethernet ports and
> "fsl,etsec2-mdio" for the MDIO buses, which are strings that Linux also
> uses, at least for LS1021A. More compatible strings can be added once
> other (PowerPC) SoCs are migrated to DM_ETH.
>
> The current ls1021a.dtsi doesn't match what was documented for the MDIO
> buses anyway (the "compatible" is "gianfar" currently). This will be
> fixed in the next patch.
>
> Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller")
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 33+ messages in thread* [U-Boot] net: tsec: Change compatible strings to match Linux
2019-07-18 21:29 ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
2019-07-23 3:30 ` Joe Hershberger
@ 2019-07-25 18:42 ` Joe Hershberger
1 sibling, 0 replies; 33+ messages in thread
From: Joe Hershberger @ 2019-07-25 18:42 UTC (permalink / raw)
To: u-boot
Hi Vladimir,
https://patchwork.ozlabs.org/patch/1133865/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks!
-Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (5 preceding siblings ...)
2019-07-18 21:29 ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
@ 2019-07-18 21:29 ` Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot Vladimir Oltean
` (2 subsequent siblings)
9 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:29 UTC (permalink / raw)
To: u-boot
From: Bin Meng <bmeng.cn@gmail.com>
Now that we have added driver model support to the TSEC driver,
convert ls1021atwr board to use it.
This depends on previous DM series for ls1021atwr:
http://patchwork.ozlabs.org/patch/561855/
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
[Vladimir] Made the following changes:
- Added 'status = "disabled";' for all Ethernet ports in ls1021a.dtsi
- Fixed the confusion between the SGMII/TBI PCS for enet0 and enet1 -
a mistake ported over from Linux. Each SGMII PCS lies on the private
MDIO bus of the interface (and the RGMII enet2 has no SGMII PCS).
- Added CONFIG_DM_ETH to all ls1021atwr_* defconfigs
- Completely removed non-DM_ETH support from ls1021atwr
- Changed "compatible" string from "fsl,tsec-mdio" to "fsl,etsec2-mdio"
and from "fsl,tsec" to "fsl,etsec2" to match Linux
---
Changes from v2:
None.
Changes from v1:
Applied non-reverse #ifdef logic where possible.
Removed the non-DM_ETH code from board/freescale/ls1021atwr/ and
include/configs/ls1021atwr.h.
Aligned compatible strings to Linux.
arch/arm/cpu/armv7/ls102xa/cpu.c | 2 +-
arch/arm/cpu/armv7/ls102xa/fdt.c | 10 +++++
arch/arm/dts/ls1021a-twr.dtsi | 32 ++++++++++++++++
arch/arm/dts/ls1021a.dtsi | 30 +++++++++++++--
board/freescale/ls1021atwr/ls1021atwr.c | 38 -------------------
configs/ls1021atwr_nor_SECURE_BOOT_defconfig | 2 +
configs/ls1021atwr_nor_defconfig | 2 +
configs/ls1021atwr_nor_lpuart_defconfig | 2 +
configs/ls1021atwr_qspi_defconfig | 2 +
...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 2 +
configs/ls1021atwr_sdcard_ifc_defconfig | 2 +
configs/ls1021atwr_sdcard_qspi_defconfig | 2 +
include/configs/ls1021atwr.h | 28 +-------------
13 files changed, 85 insertions(+), 69 deletions(-)
diff --git a/arch/arm/cpu/armv7/ls102xa/cpu.c b/arch/arm/cpu/armv7/ls102xa/cpu.c
index ecf9e869855e..9ccfe1042ce5 100644
--- a/arch/arm/cpu/armv7/ls102xa/cpu.c
+++ b/arch/arm/cpu/armv7/ls102xa/cpu.c
@@ -296,7 +296,7 @@ int cpu_mmc_init(bd_t *bis)
int cpu_eth_init(bd_t *bis)
{
-#ifdef CONFIG_TSEC_ENET
+#if defined(CONFIG_TSEC_ENET) && !defined(CONFIG_DM_ETH)
tsec_standard_init(bis);
#endif
diff --git a/arch/arm/cpu/armv7/ls102xa/fdt.c b/arch/arm/cpu/armv7/ls102xa/fdt.c
index 8bf9c42b2260..1aadffff5991 100644
--- a/arch/arm/cpu/armv7/ls102xa/fdt.c
+++ b/arch/arm/cpu/armv7/ls102xa/fdt.c
@@ -16,12 +16,17 @@
#include <tsec.h>
#include <asm/arch/immap_ls102xa.h>
#include <fsl_sec.h>
+#include <dm.h>
DECLARE_GLOBAL_DATA_PTR;
void ft_fixup_enet_phy_connect_type(void *fdt)
{
+#ifdef CONFIG_DM_ETH
+ struct udevice *dev;
+#else
struct eth_device *dev;
+#endif
struct tsec_private *priv;
const char *enet_path, *phy_path;
char enet[16];
@@ -29,7 +34,12 @@ void ft_fixup_enet_phy_connect_type(void *fdt)
int phy_node;
int i = 0;
uint32_t ph;
+#ifdef CONFIG_DM_ETH
+ char *name[3] = { "ethernet at 2d10000", "ethernet at 2d50000",
+ "ethernet at 2d90000" };
+#else
char *name[3] = { "eTSEC1", "eTSEC2", "eTSEC3" };
+#endif
for (; i < ARRAY_SIZE(name); i++) {
dev = eth_get_dev_by_name(name[i]);
diff --git a/arch/arm/dts/ls1021a-twr.dtsi b/arch/arm/dts/ls1021a-twr.dtsi
index 5d3275ced913..27c96f95400a 100644
--- a/arch/arm/dts/ls1021a-twr.dtsi
+++ b/arch/arm/dts/ls1021a-twr.dtsi
@@ -51,6 +51,26 @@
};
};
+&enet0 {
+ tbi-handle = <&tbi0>;
+ phy-handle = <&sgmii_phy2>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&enet1 {
+ tbi-handle = <&tbi1>;
+ phy-handle = <&sgmii_phy0>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&enet2 {
+ phy-handle = <&rgmii_phy1>;
+ phy-connection-type = "rgmii-id";
+ status = "okay";
+};
+
&i2c0 {
status = "okay";
};
@@ -84,12 +104,24 @@
sgmii_phy0: ethernet-phy at 0 {
reg = <0x0>;
};
+
rgmii_phy1: ethernet-phy at 1 {
reg = <0x1>;
};
+
sgmii_phy2: ethernet-phy at 2 {
reg = <0x2>;
};
+
+ /* SGMII PCS for enet0 */
+ tbi0: tbi-phy at 1f {
+ reg = <0x1f>;
+ device_type = "tbi-phy";
+ };
+};
+
+&mdio1 {
+ /* SGMII PCS for enet1 */
tbi1: tbi-phy at 1f {
reg = <0x1f>;
device_type = "tbi-phy";
diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi
index 7fb24ab68787..e419d9c44fcb 100644
--- a/arch/arm/dts/ls1021a.dtsi
+++ b/arch/arm/dts/ls1021a.dtsi
@@ -350,12 +350,36 @@
<&platform_clk 1>;
};
+ enet0: ethernet at 2d10000 {
+ compatible = "fsl,etsec2";
+ reg = <0x2d10000 0x1000>;
+ status = "disabled";
+ };
+
+ enet1: ethernet at 2d50000 {
+ compatible = "fsl,etsec2";
+ reg = <0x2d50000 0x1000>;
+ status = "disabled";
+ };
+
+ enet2: ethernet at 2d90000 {
+ compatible = "fsl,etsec2";
+ reg = <0x2d90000 0x1000>;
+ status = "disabled";
+ };
+
mdio0: mdio at 2d24000 {
- compatible = "gianfar";
- device_type = "mdio";
+ compatible = "fsl,etsec2-mdio";
+ reg = <0x2d24000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ mdio1: mdio at 2d64000 {
+ compatible = "fsl,etsec2-mdio";
+ reg = <0x2d64000 0x4000>;
#address-cells = <1>;
#size-cells = <0>;
- reg = <0x2d24000 0x4000>;
};
usb at 8600000 {
diff --git a/board/freescale/ls1021atwr/ls1021atwr.c b/board/freescale/ls1021atwr/ls1021atwr.c
index 01ba1bc96213..fcf2ec97889d 100644
--- a/board/freescale/ls1021atwr/ls1021atwr.c
+++ b/board/freescale/ls1021atwr/ls1021atwr.c
@@ -248,44 +248,6 @@ int board_mmc_init(bd_t *bis)
int board_eth_init(bd_t *bis)
{
-#ifdef CONFIG_TSEC_ENET
- struct fsl_pq_mdio_info mdio_info;
- struct tsec_info_struct tsec_info[4];
- int num = 0;
-
-#ifdef CONFIG_TSEC1
- SET_STD_TSEC_INFO(tsec_info[num], 1);
- if (is_serdes_configured(SGMII_TSEC1)) {
- puts("eTSEC1 is in sgmii mode.\n");
- tsec_info[num].flags |= TSEC_SGMII;
- }
- num++;
-#endif
-#ifdef CONFIG_TSEC2
- SET_STD_TSEC_INFO(tsec_info[num], 2);
- if (is_serdes_configured(SGMII_TSEC2)) {
- puts("eTSEC2 is in sgmii mode.\n");
- tsec_info[num].flags |= TSEC_SGMII;
- }
- num++;
-#endif
-#ifdef CONFIG_TSEC3
- SET_STD_TSEC_INFO(tsec_info[num], 3);
- tsec_info[num].interface = PHY_INTERFACE_MODE_RGMII_ID;
- num++;
-#endif
- if (!num) {
- printf("No TSECs initialized\n");
- return 0;
- }
-
- mdio_info.regs = (struct tsec_mii_mng *)CONFIG_SYS_MDIO_BASE_ADDR;
- mdio_info.name = DEFAULT_MII_NAME;
- fsl_pq_mdio_init(bis, &mdio_info);
-
- tsec_eth_init(bis, tsec_info, num);
-#endif
-
return pci_eth_init(bis);
}
diff --git a/configs/ls1021atwr_nor_SECURE_BOOT_defconfig b/configs/ls1021atwr_nor_SECURE_BOOT_defconfig
index 6c4bb9aaf665..830affc925b5 100644
--- a/configs/ls1021atwr_nor_SECURE_BOOT_defconfig
+++ b/configs/ls1021atwr_nor_SECURE_BOOT_defconfig
@@ -40,7 +40,9 @@ CONFIG_SYS_FLASH_CFI=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_nor_defconfig b/configs/ls1021atwr_nor_defconfig
index 9d8c2024c04e..c4d18c6f6907 100644
--- a/configs/ls1021atwr_nor_defconfig
+++ b/configs/ls1021atwr_nor_defconfig
@@ -40,7 +40,9 @@ CONFIG_SYS_FLASH_CFI=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_nor_lpuart_defconfig b/configs/ls1021atwr_nor_lpuart_defconfig
index b9cfdb6fd69e..b74d58a3487c 100644
--- a/configs/ls1021atwr_nor_lpuart_defconfig
+++ b/configs/ls1021atwr_nor_lpuart_defconfig
@@ -42,7 +42,9 @@ CONFIG_SYS_FLASH_CFI=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_qspi_defconfig b/configs/ls1021atwr_qspi_defconfig
index 8c27c5908cb5..911061a37881 100644
--- a/configs/ls1021atwr_qspi_defconfig
+++ b/configs/ls1021atwr_qspi_defconfig
@@ -42,7 +42,9 @@ CONFIG_SPI_FLASH_STMICRO=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig b/configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig
index 979878d560f4..d8c26393cead 100644
--- a/configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig
+++ b/configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig
@@ -53,7 +53,9 @@ CONFIG_SYS_FLASH_CFI=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_sdcard_ifc_defconfig b/configs/ls1021atwr_sdcard_ifc_defconfig
index 59af172cb8a1..d23c87504c9b 100644
--- a/configs/ls1021atwr_sdcard_ifc_defconfig
+++ b/configs/ls1021atwr_sdcard_ifc_defconfig
@@ -54,7 +54,9 @@ CONFIG_SYS_FLASH_CFI=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1021atwr_sdcard_qspi_defconfig b/configs/ls1021atwr_sdcard_qspi_defconfig
index d7fec5e365eb..7b2c2900a060 100644
--- a/configs/ls1021atwr_sdcard_qspi_defconfig
+++ b/configs/ls1021atwr_sdcard_qspi_defconfig
@@ -53,7 +53,9 @@ CONFIG_SPI_FLASH_STMICRO=y
CONFIG_PHY_GIGE=y
CONFIG_E1000=y
CONFIG_MII=y
+CONFIG_DM_ETH=y
CONFIG_TSEC_ENET=y
+CONFIG_PHY_ATHEROS=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_DM_PCI_COMPAT=y
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index de0c9c7f26af..cbf7a496a564 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -260,33 +260,7 @@
*/
#ifdef CONFIG_TSEC_ENET
-#define CONFIG_MII_DEFAULT_TSEC 1
-#define CONFIG_TSEC1 1
-#define CONFIG_TSEC1_NAME "eTSEC1"
-#define CONFIG_TSEC2 1
-#define CONFIG_TSEC2_NAME "eTSEC2"
-#define CONFIG_TSEC3 1
-#define CONFIG_TSEC3_NAME "eTSEC3"
-
-#define TSEC1_PHY_ADDR 2
-#define TSEC2_PHY_ADDR 0
-#define TSEC3_PHY_ADDR 1
-
-#define TSEC1_FLAGS (TSEC_GIGABIT | TSEC_REDUCED)
-#define TSEC2_FLAGS (TSEC_GIGABIT | TSEC_REDUCED)
-#define TSEC3_FLAGS (TSEC_GIGABIT | TSEC_REDUCED)
-
-#define TSEC1_PHYIDX 0
-#define TSEC2_PHYIDX 0
-#define TSEC3_PHYIDX 0
-
-#define CONFIG_ETHPRIME "eTSEC1"
-
-#define CONFIG_PHY_ATHEROS
-
-#define CONFIG_HAS_ETH0
-#define CONFIG_HAS_ETH1
-#define CONFIG_HAS_ETH2
+#define CONFIG_ETHPRIME "ethernet at 2d10000"
#endif
/* PCIe */
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (6 preceding siblings ...)
2019-07-18 21:29 ` [U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver Vladimir Oltean
@ 2019-07-18 21:30 ` Vladimir Oltean
2019-07-23 3:31 ` Joe Hershberger
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-23 0:15 ` [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Joe Hershberger
9 siblings, 2 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:30 UTC (permalink / raw)
To: u-boot
Due to a typo, "run qspi_bootcmd" and "env exists secureboot" got
concatenated instead of being separated by a semicolon.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
include/configs/ls1021atwr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index cbf7a496a564..31abee81edd2 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -418,7 +418,7 @@
#undef CONFIG_BOOTCOMMAND
#if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI)
-#define CONFIG_BOOTCOMMAND "run distro_bootcmd; run qspi_bootcmd" \
+#define CONFIG_BOOTCOMMAND "run distro_bootcmd; run qspi_bootcmd; " \
"env exists secureboot && esbc_halt"
#elif defined(CONFIG_SD_BOOT)
#define CONFIG_BOOTCOMMAND "run distro_bootcmd; run sd_bootcmd; " \
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (7 preceding siblings ...)
2019-07-18 21:30 ` [U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot Vladimir Oltean
@ 2019-07-18 21:30 ` Vladimir Oltean
2019-07-23 3:35 ` Joe Hershberger
` (2 more replies)
2019-07-23 0:15 ` [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Joe Hershberger
9 siblings, 3 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-18 21:30 UTC (permalink / raw)
To: u-boot
From: Jianchao Wang <jianchao.wang@nxp.com>
The LS1021A-TSN is a development board built by VVDN/Argonboards in
partnership with NXP.
It features the LS1021A SoC and the first-generation SJA1105T Ethernet
switch for prototyping implementations of a subset of IEEE 802.1 TSN
standards.
Supported boot media: microSD card (via SPL), QSPI flash.
Rev. A of the board uses a Spansion S25FL512S_256K serial flash, which
is 64 MB in size and has an erase sector size of 256KB (therefore,
flashing the RCW would erase part of U-Boot).
Rev. B and C of the board use a Spansion S25FL256S1 serial flash, which
is only 32 MB in size but has an erase sector size of 64KB (therefore
the RCW image can be flashed without erasing U-Boot).
To avoid the problems above, the U-Boot base address has been selected
at 0x100000 (the start of the 5th 256KB erase sector), which works for
all board revisions. Actually 0x40000 would have been enough, but
0x100000 is common for all Layerscape devices.
eTSEC3 is connecting directly to SJA1105 via an RGMII fixed-link, but
SJA1105 is currently not supported by uboot. Therefore, eTSEC3 is
disabled.
Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Signed-off-by: Mingkai Hu <mingkai.hu@nxp.com>
Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
Signed-off-by: Changming Huang <jerry.huang@nxp.com>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
[Vladimir] Code taken from https://github.com/openil/u-boot (which
itself is mostly copied from ls1021a-iot) and adapted with the following
changes:
- Add a008850 errata workaround
- Converted eTSEC, MMC to DM to avoid all build warnings
- Plugged in distro boot feature, including support for extlinux.conf
- Added defconfig for QSPI boot
- Added the board/freescale/ls1021atsn/README.rst for initial setup
- Increased CONFIG_SYS_MONITOR_LEN so that the SPL malloc pool does not
get overwritten during copying of the u-boot.bin payload from MMC to
DDR.
---
Changes from v2:
Cosmetic refactoring of comments in board/freescale/ls1021atsn/ls1021atsn.c
and include/configs/ls1021atsn.h.
Removed a few useless defines in include/configs/ls1021atsn.h.
Changes from v1:
Increased CONFIG_SYS_MONITOR_LEN so that the SPL malloc pool does not
get overwritten during copying of the u-boot.bin payload from MMC to
DDR.
Completely removed all traces of IFC support (for CPLD control), which
has no chance of working on this board.
Made ddrmc_init a static function.
arch/arm/Kconfig | 14 +
arch/arm/dts/Makefile | 2 +-
arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
board/freescale/ls1021atsn/Kconfig | 18 ++
board/freescale/ls1021atsn/MAINTAINERS | 8 +
board/freescale/ls1021atsn/Makefile | 3 +
board/freescale/ls1021atsn/README.rst | 97 +++++++
board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
configs/ls1021atsn_qspi_defconfig | 79 ++++++
configs/ls1021atsn_sdcard_defconfig | 91 ++++++
include/configs/ls1021atsn.h | 250 +++++++++++++++++
13 files changed, 921 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/dts/ls1021a-tsn.dts
create mode 100644 board/freescale/ls1021atsn/Kconfig
create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
create mode 100644 board/freescale/ls1021atsn/Makefile
create mode 100644 board/freescale/ls1021atsn/README.rst
create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
create mode 100644 configs/ls1021atsn_qspi_defconfig
create mode 100644 configs/ls1021atsn_sdcard_defconfig
create mode 100644 include/configs/ls1021atsn.h
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 05606d9722e8..ecaa1fe6796b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1338,6 +1338,19 @@ config TARGET_LS1021ATWR
select SUPPORT_SPL
imply SCSI
+config TARGET_LS1021ATSN
+ bool "Support ls1021atsn"
+ select ARCH_LS1021A
+ select ARCH_SUPPORT_PSCI
+ select BOARD_EARLY_INIT_F
+ select BOARD_LATE_INIT
+ select CPU_V7A
+ select CPU_V7_HAS_NONSEC
+ select CPU_V7_HAS_VIRT
+ select LS1_DEEP_SLEEP
+ select SUPPORT_SPL
+ imply SCSI
+
config TARGET_LS1021AIOT
bool "Support ls1021aiot"
select ARCH_LS1021A
@@ -1715,6 +1728,7 @@ source "board/freescale/ls1028a/Kconfig"
source "board/freescale/ls1021aqds/Kconfig"
source "board/freescale/ls1043aqds/Kconfig"
source "board/freescale/ls1021atwr/Kconfig"
+source "board/freescale/ls1021atsn/Kconfig"
source "board/freescale/ls1021aiot/Kconfig"
source "board/freescale/ls1046aqds/Kconfig"
source "board/freescale/ls1043ardb/Kconfig"
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index f5535078c720..e985884d9ac6 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -328,7 +328,7 @@ dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
dtb-$(CONFIG_ARCH_LS1021A) += ls1021a-qds-duart.dtb \
ls1021a-qds-lpuart.dtb \
ls1021a-twr-duart.dtb ls1021a-twr-lpuart.dtb \
- ls1021a-iot-duart.dtb
+ ls1021a-iot-duart.dtb ls1021a-tsn.dtb
dtb-$(CONFIG_FSL_LSCH3) += fsl-ls2080a-qds.dtb \
fsl-ls2080a-rdb.dtb \
fsl-ls2081a-rdb.dtb \
diff --git a/arch/arm/dts/ls1021a-tsn.dts b/arch/arm/dts/ls1021a-tsn.dts
new file mode 100644
index 000000000000..f633074099dc
--- /dev/null
+++ b/arch/arm/dts/ls1021a-tsn.dts
@@ -0,0 +1,77 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright 2016-2018 NXP Semiconductors
+ * Copyright 2019 Vladimir Oltean <olteanv@gmail.com>
+ */
+
+/dts-v1/;
+#include "ls1021a.dtsi"
+
+/ {
+ model = "NXP LS1021A-TSN Board";
+
+ aliases {
+ enet0-sgmii-phy = &sgmii_phy2;
+ enet1-sgmii-phy = &sgmii_phy1;
+ spi0 = &qspi;
+ spi1 = &dspi1;
+ };
+};
+
+&enet0 {
+ tbi-handle = <&tbi0>;
+ phy-handle = <&sgmii_phy2>;
+ phy-mode = "sgmii";
+ status = "okay";
+};
+
+&enet1 {
+ tbi-handle = <&tbi1>;
+ phy-handle = <&sgmii_phy1>;
+ phy-mode = "sgmii";
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&mdio0 {
+ /* AR8031 */
+ sgmii_phy1: ethernet-phy at 1 {
+ reg = <0x1>;
+ };
+
+ /* AR8031 */
+ sgmii_phy2: ethernet-phy at 2 {
+ reg = <0x2>;
+ };
+
+ /* SGMII PCS for enet0 */
+ tbi0: tbi-phy at 1f {
+ reg = <0x1f>;
+ device_type = "tbi-phy";
+ };
+};
+
+&mdio1 {
+ /* SGMII PCS for enet1 */
+ tbi1: tbi-phy at 1f {
+ reg = <0x1f>;
+ device_type = "tbi-phy";
+ };
+};
+
+&qspi {
+ bus-num = <0>;
+ status = "okay";
+
+ flash at 0 {
+ compatible = "spi-flash";
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
diff --git a/board/freescale/ls1021atsn/Kconfig b/board/freescale/ls1021atsn/Kconfig
new file mode 100644
index 000000000000..d999fa469002
--- /dev/null
+++ b/board/freescale/ls1021atsn/Kconfig
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+if TARGET_LS1021ATSN
+
+config SYS_BOARD
+ default "ls1021atsn"
+
+config SYS_VENDOR
+ default "freescale"
+
+config SYS_SOC
+ default "ls102xa"
+
+config SYS_CONFIG_NAME
+ default "ls1021atsn"
+
+source "board/freescale/common/Kconfig"
+
+endif
diff --git a/board/freescale/ls1021atsn/MAINTAINERS b/board/freescale/ls1021atsn/MAINTAINERS
new file mode 100644
index 000000000000..560bb615d2fe
--- /dev/null
+++ b/board/freescale/ls1021atsn/MAINTAINERS
@@ -0,0 +1,8 @@
+NXP LS1021A-TSN Board
+M: Vladimir Oltean <olteanv@gmail.com>
+S: Maintained
+F: arch/arm/dts/ls1021a-tsn.dts
+F: board/freescale/ls1021atsn/
+F: include/configs/ls1021atsn.h
+F: configs/ls1021atsn_qspi_defconfig
+F: configs/ls1021atsn_sdcard_defconfig
diff --git a/board/freescale/ls1021atsn/Makefile b/board/freescale/ls1021atsn/Makefile
new file mode 100644
index 000000000000..b4808f05e8e0
--- /dev/null
+++ b/board/freescale/ls1021atsn/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-y += ls1021atsn.o
+obj-$(CONFIG_ARMV7_PSCI) += ../ls1021atwr/psci.o
diff --git a/board/freescale/ls1021atsn/README.rst b/board/freescale/ls1021atsn/README.rst
new file mode 100644
index 000000000000..cdec02f1a357
--- /dev/null
+++ b/board/freescale/ls1021atsn/README.rst
@@ -0,0 +1,97 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+LS1021A-TSN Board Overview
+==========================
+
+ - 1GB DDR3 at 800 MHz
+ - Spansion/Cypress 64 MB (Rev. A) / 32 MB (Rev. B and C) QSPI NOR flash
+ - Ethernet
+ - 2 SGMII 10/100/1G Ethernet ports (Atheros AR8031)
+ - One SJA1105T switch with 4 Ethernet ports (Broadcom BCM5464R)
+ - One internal RGMII port connected to the switch
+ - SDHC
+ - microSDHC/SDXC connector
+ - Other I/O
+ - One Serial port
+ - Arduino and expansion headers
+ - mPCIE slot
+ - SATA port
+ - USB3.0 port
+
+LS1021A Memory map
+==================
+
+The addresses in brackets are physical addresses.
+
+============== ============== ============================== =======
+Start Address End Address Description Size
+============== ============== ============================== =======
+0x00_0000_0000 0x00_000F_FFFF Secure Boot ROM 1MB
+0x00_0100_0000 0x00_0FFF_FFFF CCSRBAR 240MB
+0x00_1000_0000 0x00_1000_FFFF OCRAM0 64KB
+0x00_1001_0000 0x00_1001_FFFF OCRAM1 64KB
+0x00_2000_0000 0x00_20FF_FFFF DCSR 16MB
+0x00_4000_0000 0x00_5FFF_FFFF QSPI 512MB
+0x00_6000_0000 0x00_67FF_FFFF IFC - NOR Flash 128MB
+0x00_8000_0000 0x00_FFFF_FFFF DRAM1 2GB
+============== ============== ============================== =======
+
+Compiling and flashing
+======================
+
+The LS1021A-TSN board comes along with a microSD card with OpenIL U-Boot that
+can be used to update its internal QSPI flash (which is empty out of the
+factory).
+
+To compile and flash an SD card image::
+
+ make ls1021atsn_sdcard_defconfig && make -j 8 && sudo cp u-boot-with-spl-pbl.bin /srv/tftpboot/
+ => tftp 0x82000000 u-boot-with-spl-pbl.bin && mmc rescan && mmc erase 8 0x1100 && mmc write 0x82000000 8 0x1100
+
+For the QSPI flash, first obtain the Reset Configuration Word binary for
+bootimg from the QSPI flash from the rcw project
+(https://source.codeaurora.org/external/qoriq/qoriq-components/rcw)::
+
+ make -j 8 && sudo cp ls1021atsn/SSR_PNS_30/rcw_1200_qspiboot.bin.swapped /srv/tftpboot/
+
+The above RCW binary takes care of swapping the QSPI AMBA memory, so that the
+U-Boot binary does not need to be swapped when flashing it.
+
+To compile and flash a U-Boot image for QSPI::
+
+ make ls1021atsn_qspi_defconfig && make -j 8 && sudo cp u-boot.bin /srv/tftpboot/
+
+Then optionally create a custom uboot-env.txt file (although the default
+environment already supports distro boot) and convert it to binary format::
+
+ mkenvimage -s 2M -o /srv/tftpboot/uboot-env.bin uboot-env.txt
+
+To program the QSPI flash with the images::
+
+ => tftp 0x82000000 rcw_1200_qspiboot.bin.swapped && sf probe && sf erase 0x0 +${filesize} && sf write 0x82000000 0x0 ${filesize}
+ => tftp 0x82000000 u-boot.bin && sf probe && sf erase 0x100000 +${filesize} && sf write 0x82000000 0x100000 ${filesize}
+ => tftp 0x82000000 uboot-env.bin && sf probe && sf erase 0x400000 +${filesize} && sf write 0x82000000 0x400000 ${filesize}
+
+The boards contain an AT24 I2C EEPROM that is supposed to hold the MAC
+addresses of the Ethernet interfaces, however the EEPROM comes blank out of
+the factory, and the MAC addresses are printed on a label on the bottom of
+the boards.
+
+To write the MAC addresses to the EEPROM, the following needs to be done once::
+
+ => mac id
+ => mac 0 00:1F:7B:xx:xx:xx
+ => mac 1 00:1F:7B:xx:xx:xx
+ => mac 2 00:1F:7B:xx:xx:xx
+ => mac save
+
+The switch ports do not have their own MAC address - they inherit it from the
+master enet2 port.
+
+Known issues and limitations
+============================
+
+- The 4 SJA1105 switch ports are not functional in U-Boot for now.
+- Since the IFC pins are multiplexed with QSPI on LS1021A, currently there is
+ no way to talk to the CPLD for e.g. running the "qixis_reset" command, or
+ turning the fan on, etc.
diff --git a/board/freescale/ls1021atsn/ls1021atsn.c b/board/freescale/ls1021atsn/ls1021atsn.c
new file mode 100644
index 000000000000..39e825ca4967
--- /dev/null
+++ b/board/freescale/ls1021atsn/ls1021atsn.c
@@ -0,0 +1,260 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright 2016-2019 NXP Semiconductors
+ */
+#include <common.h>
+#include <asm/arch-ls102xa/ls102xa_soc.h>
+#include <asm/arch/ls102xa_devdis.h>
+#include <asm/arch/immap_ls102xa.h>
+#include <asm/arch/ls102xa_soc.h>
+#include <asm/arch/fsl_serdes.h>
+#include "../common/sleep.h"
+#include <fsl_validate.h>
+#include <fsl_immap.h>
+#include <fsl_csu.h>
+#include <netdev.h>
+#include <spl.h>
+#ifdef CONFIG_U_QE
+#include <fsl_qe.h>
+#endif
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static void ddrmc_init(void)
+{
+#if (!defined(CONFIG_SPL) || defined(CONFIG_SPL_BUILD))
+ struct ccsr_ddr *ddr = (struct ccsr_ddr *)CONFIG_SYS_FSL_DDR_ADDR;
+ u32 temp_sdram_cfg, tmp;
+
+ out_be32(&ddr->sdram_cfg, DDR_SDRAM_CFG);
+
+ out_be32(&ddr->cs0_bnds, DDR_CS0_BNDS);
+ out_be32(&ddr->cs0_config, DDR_CS0_CONFIG);
+
+ out_be32(&ddr->timing_cfg_0, DDR_TIMING_CFG_0);
+ out_be32(&ddr->timing_cfg_1, DDR_TIMING_CFG_1);
+ out_be32(&ddr->timing_cfg_2, DDR_TIMING_CFG_2);
+ out_be32(&ddr->timing_cfg_3, DDR_TIMING_CFG_3);
+ out_be32(&ddr->timing_cfg_4, DDR_TIMING_CFG_4);
+ out_be32(&ddr->timing_cfg_5, DDR_TIMING_CFG_5);
+
+#ifdef CONFIG_DEEP_SLEEP
+ if (is_warm_boot()) {
+ out_be32(&ddr->sdram_cfg_2,
+ DDR_SDRAM_CFG_2 & ~SDRAM_CFG2_D_INIT);
+ out_be32(&ddr->init_addr, CONFIG_SYS_SDRAM_BASE);
+ out_be32(&ddr->init_ext_addr, (1 << 31));
+
+ /* DRAM VRef will not be trained */
+ out_be32(&ddr->ddr_cdr2,
+ DDR_DDR_CDR2 & ~DDR_CDR2_VREF_TRAIN_EN);
+ } else
+#endif
+ {
+ out_be32(&ddr->sdram_cfg_2, DDR_SDRAM_CFG_2);
+ out_be32(&ddr->ddr_cdr2, DDR_DDR_CDR2);
+ }
+
+ out_be32(&ddr->sdram_mode, DDR_SDRAM_MODE);
+ out_be32(&ddr->sdram_mode_2, DDR_SDRAM_MODE_2);
+
+ out_be32(&ddr->sdram_interval, DDR_SDRAM_INTERVAL);
+
+ out_be32(&ddr->ddr_wrlvl_cntl, DDR_DDR_WRLVL_CNTL);
+
+ out_be32(&ddr->ddr_wrlvl_cntl_2, DDR_DDR_WRLVL_CNTL_2);
+ out_be32(&ddr->ddr_wrlvl_cntl_3, DDR_DDR_WRLVL_CNTL_3);
+
+ out_be32(&ddr->ddr_cdr1, DDR_DDR_CDR1);
+
+ out_be32(&ddr->sdram_clk_cntl, DDR_SDRAM_CLK_CNTL);
+ out_be32(&ddr->ddr_zq_cntl, DDR_DDR_ZQ_CNTL);
+
+ out_be32(&ddr->cs0_config_2, DDR_CS0_CONFIG_2);
+
+ /* DDR erratum A-009942 */
+ tmp = in_be32(&ddr->debug[28]);
+ out_be32(&ddr->debug[28], tmp | 0x0070006f);
+
+ udelay(1);
+
+#ifdef CONFIG_DEEP_SLEEP
+ if (is_warm_boot()) {
+ /* enter self-refresh */
+ temp_sdram_cfg = in_be32(&ddr->sdram_cfg_2);
+ temp_sdram_cfg |= SDRAM_CFG2_FRC_SR;
+ out_be32(&ddr->sdram_cfg_2, temp_sdram_cfg);
+
+ temp_sdram_cfg = (DDR_SDRAM_CFG_MEM_EN | SDRAM_CFG_BI);
+ } else
+#endif
+ temp_sdram_cfg = (DDR_SDRAM_CFG_MEM_EN & ~SDRAM_CFG_BI);
+
+ out_be32(&ddr->sdram_cfg, DDR_SDRAM_CFG | temp_sdram_cfg);
+
+#ifdef CONFIG_DEEP_SLEEP
+ if (is_warm_boot()) {
+ /* exit self-refresh */
+ temp_sdram_cfg = in_be32(&ddr->sdram_cfg_2);
+ temp_sdram_cfg &= ~SDRAM_CFG2_FRC_SR;
+ out_be32(&ddr->sdram_cfg_2, temp_sdram_cfg);
+ }
+#endif
+#endif /* !defined(CONFIG_SPL) || defined(CONFIG_SPL_BUILD) */
+}
+
+int dram_init(void)
+{
+ ddrmc_init();
+
+ erratum_a008850_post();
+
+ gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
+
+#if defined(CONFIG_DEEP_SLEEP) && !defined(CONFIG_SPL_BUILD)
+ fsl_dp_resume();
+#endif
+
+ return 0;
+}
+
+int board_eth_init(bd_t *bis)
+{
+ return pci_eth_init(bis);
+}
+
+int board_early_init_f(void)
+{
+ struct ccsr_scfg *scfg = (struct ccsr_scfg *)CONFIG_SYS_FSL_SCFG_ADDR;
+
+#ifdef CONFIG_TSEC_ENET
+ /*
+ * Clear BD & FR bits for big endian BD's and frame data (aka set
+ * correct eTSEC endianness). This is crucial in ensuring that it does
+ * not report Data Parity Errors in its RX/TX FIFOs when attempting to
+ * send traffic.
+ */
+ clrbits_be32(&scfg->etsecdmamcr, SCFG_ETSECDMAMCR_LE_BD_FR);
+ /* EC3_GTX_CLK125 (of enet2) used for all RGMII interfaces */
+ out_be32(&scfg->etsecmcr, SCFG_ETSECCMCR_GE2_CLK125);
+#endif
+
+ arch_soc_init();
+
+#if defined(CONFIG_DEEP_SLEEP)
+ if (is_warm_boot()) {
+ timer_init();
+ dram_init();
+ }
+#endif
+
+ return 0;
+}
+
+#ifdef CONFIG_SPL_BUILD
+void board_init_f(ulong dummy)
+{
+ void (*second_uboot)(void);
+
+ /* Clear the BSS */
+ memset(__bss_start, 0, __bss_end - __bss_start);
+
+ get_clocks();
+
+#if defined(CONFIG_DEEP_SLEEP)
+ if (is_warm_boot())
+ fsl_dp_disable_console();
+#endif
+
+ preloader_console_init();
+
+ dram_init();
+
+ /* Allow OCRAM access permission as R/W */
+#ifdef CONFIG_LAYERSCAPE_NS_ACCESS
+ enable_layerscape_ns_access();
+ enable_layerscape_ns_access();
+#endif
+
+ /*
+ * if it is woken up from deep sleep, then jump to second
+ * stage U-Boot and continue executing without recopying
+ * it from SD since it has already been reserved in memory
+ * in last boot.
+ */
+ if (is_warm_boot()) {
+ second_uboot = (void (*)(void))CONFIG_SYS_TEXT_BASE;
+ second_uboot();
+ }
+
+ board_init_r(NULL, 0);
+}
+#endif
+
+int board_init(void)
+{
+#ifndef CONFIG_SYS_FSL_NO_SERDES
+ fsl_serdes_init();
+#endif
+ ls102xa_smmu_stream_id_init();
+
+#ifdef CONFIG_LAYERSCAPE_NS_ACCESS
+ enable_layerscape_ns_access();
+#endif
+
+#ifdef CONFIG_U_QE
+ u_qe_init();
+#endif
+
+ return 0;
+}
+
+#if defined(CONFIG_SPL_BUILD)
+void spl_board_init(void)
+{
+ ls102xa_smmu_stream_id_init();
+}
+#endif
+
+#ifdef CONFIG_BOARD_LATE_INIT
+int board_late_init(void)
+{
+#ifdef CONFIG_CHAIN_OF_TRUST
+ fsl_setenv_chain_of_trust();
+#endif
+
+ return 0;
+}
+#endif
+
+#if defined(CONFIG_MISC_INIT_R)
+int misc_init_r(void)
+{
+#ifdef CONFIG_FSL_DEVICE_DISABLE
+ device_disable(devdis_tbl, ARRAY_SIZE(devdis_tbl));
+#endif
+
+#ifdef CONFIG_FSL_CAAM
+ return sec_init();
+#endif
+}
+#endif
+
+#if defined(CONFIG_DEEP_SLEEP)
+void board_sleep_prepare(void)
+{
+#ifdef CONFIG_LAYERSCAPE_NS_ACCESS
+ enable_layerscape_ns_access();
+#endif
+}
+#endif
+
+int ft_board_setup(void *blob, bd_t *bd)
+{
+ ft_cpu_setup(blob, bd);
+
+#ifdef CONFIG_PCI
+ ft_pci_setup(blob, bd);
+#endif
+
+ return 0;
+}
diff --git a/board/freescale/ls1021atsn/ls102xa_pbi.cfg b/board/freescale/ls1021atsn/ls102xa_pbi.cfg
new file mode 100644
index 000000000000..ba1499b26440
--- /dev/null
+++ b/board/freescale/ls1021atsn/ls102xa_pbi.cfg
@@ -0,0 +1,15 @@
+# PBI commands
+
+09570200 ffffffff
+09570158 00000300
+8940007c 21f47300
+
+# Configure Scratch register
+09ee0200 10000000
+# Configure alternate space
+09570158 00001000
+# Flush PBL data
+096100c0 000FFFFF
+
+09ea085c 00502880
+09ea0560 80800000
diff --git a/board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg b/board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
new file mode 100644
index 000000000000..a6fc91436f25
--- /dev/null
+++ b/board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
@@ -0,0 +1,8 @@
+# PBL preamble and RCW header
+aa55aa55 01ee0100
+
+# Disable IFC, enable QSPI and DSPI
+0608000c 00000000 00000000 00000000
+30000000 08007900 40105a00 21046000
+00000000 00000000 00000000 10002000
+20124801 8804b340 00000000 00000000
diff --git a/configs/ls1021atsn_qspi_defconfig b/configs/ls1021atsn_qspi_defconfig
new file mode 100644
index 000000000000..d1a6dad2d79d
--- /dev/null
+++ b/configs/ls1021atsn_qspi_defconfig
@@ -0,0 +1,79 @@
+CONFIG_ARM=y
+CONFIG_TARGET_LS1021ATSN=y
+CONFIG_SYS_TEXT_BASE=0x40100000
+CONFIG_DEFAULT_DEVICE_TREE="ls1021a-tsn"
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_MISC_INIT_R=y
+CONFIG_SYS_EXTRA_OPTIONS="QSPI_BOOT"
+CONFIG_QSPI_BOOT=y
+CONFIG_BOOTDELAY=3
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_FAT=y
+CONFIG_FSL_ESDHC=y
+CONFIG_CMD_SF=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_DM=y
+CONFIG_FSL_CAAM=y
+CONFIG_SPI=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_ATMEL=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_NETDEVICES=y
+CONFIG_DM_ETH=y
+CONFIG_TSEC_ENET=y
+CONFIG_MII=y
+CONFIG_SYS_NS16550=y
+CONFIG_DM_SPI=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH_DATAFLASH=y
+CONFIG_FSL_DSPI=y
+CONFIG_FSL_QSPI=y
+CONFIG_PCI=y
+CONFIG_CMD_PCI=y
+CONFIG_DM_PCI=y
+CONFIG_DM_PCI_COMPAT=y
+CONFIG_CMD_MMC=y
+CONFIG_DM_MMC=y
+CONFIG_FSL_SPI_ALIGNED_TXFIFO=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_CMD_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_FSL=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_HAS_FSL_XHCI_USB=y
+CONFIG_USB_STORAGE=y
+CONFIG_CMD_EXT2=y
+CONFIG_PCIE_LAYERSCAPE=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_GIGE=y
+CONFIG_PHY_ATHEROS=y
+CONFIG_PHY_BROADCOM=y
+CONFIG_PHY_FIXED=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMDLINE_TAG=y
+CONFIG_CMDLINE_EDITING=y
+CONFIG_AUTO_COMPLETE=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_CMD_BOOTZ=y
+CONFIG_SYS_LONGHELP=y
+CONFIG_FIT=y
+CONFIG_CMD_DM=y
+CONFIG_AHCI=y
+CONFIG_CMD_I2C=y
+CONFIG_BLK=y
+CONFIG_CMD_PART=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_FS_UUID=y
+CONFIG_SILENT_CONSOLE=y
+CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/ls1021atsn_sdcard_defconfig b/configs/ls1021atsn_sdcard_defconfig
new file mode 100644
index 000000000000..299b30037069
--- /dev/null
+++ b/configs/ls1021atsn_sdcard_defconfig
@@ -0,0 +1,91 @@
+CONFIG_ARM=y
+CONFIG_TARGET_LS1021ATSN=y
+CONFIG_SPL_TEXT_BASE=0x10000000
+CONFIG_SYS_TEXT_BASE=0x82000000
+CONFIG_DEFAULT_DEVICE_TREE="ls1021a-tsn"
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_MISC_INIT_R=y
+CONFIG_SPL=y
+CONFIG_SPL_FRAMEWORK=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SPL_WATCHDOG_SUPPORT=y
+CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT=y
+CONFIG_SYS_EXTRA_OPTIONS="RAMBOOT_PBL,SPL_FSL_PBL,SD_BOOT,SD_BOOT_QSPI"
+CONFIG_SD_BOOT=y
+CONFIG_BOOTDELAY=3
+CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
+CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0xe8
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_MMC=y
+CONFIG_FSL_ESDHC=y
+CONFIG_CMD_SF=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_DM=y
+CONFIG_FSL_CAAM=y
+CONFIG_SPI=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_ATMEL=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_NETDEVICES=y
+CONFIG_DM_ETH=y
+CONFIG_TSEC_ENET=y
+CONFIG_MII=y
+CONFIG_SYS_NS16550=y
+CONFIG_DM_SPI=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH_DATAFLASH=y
+CONFIG_FSL_DSPI=y
+CONFIG_FSL_QSPI=y
+CONFIG_PCI=y
+CONFIG_CMD_PCI=y
+CONFIG_DM_PCI=y
+CONFIG_DM_PCI_COMPAT=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_CMD_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_FSL=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_HAS_FSL_XHCI_USB=y
+CONFIG_USB_STORAGE=y
+CONFIG_CMD_EXT2=y
+CONFIG_PCIE_LAYERSCAPE=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_GIGE=y
+CONFIG_PHY_ATHEROS=y
+CONFIG_PHY_BROADCOM=y
+CONFIG_PHY_FIXED=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMDLINE_TAG=y
+CONFIG_CMDLINE_EDITING=y
+CONFIG_AUTO_COMPLETE=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_CMD_BOOTZ=y
+CONFIG_SYS_LONGHELP=y
+CONFIG_FIT=y
+CONFIG_SPL_MMC_SUPPORT=y
+CONFIG_SPL_SERIAL_SUPPORT=y
+CONFIG_SPL_I2C_SUPPORT=y
+CONFIG_SPL_ENV_SUPPORT=y
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_CMD_DM=y
+CONFIG_AHCI=y
+CONFIG_CMD_I2C=y
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_CMD_PART=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_FS_UUID=y
+CONFIG_SILENT_CONSOLE=y
+CONFIG_DISTRO_DEFAULTS=y
diff --git a/include/configs/ls1021atsn.h b/include/configs/ls1021atsn.h
new file mode 100644
index 000000000000..b011cb2a8414
--- /dev/null
+++ b/include/configs/ls1021atsn.h
@@ -0,0 +1,250 @@
+/* SPDX-License-Identifier: GPL-2.0
+ * Copyright 2016-2018 NXP Semiconductors
+ * Copyright 2019 Vladimir Oltean <olteanv@gmail.com>
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CONFIG_ARMV7_SECURE_BASE OCRAM_BASE_S_ADDR
+
+#define CONFIG_SYS_FSL_CLK
+
+#define CONFIG_DEEP_SLEEP
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 16 * 1024 * 1024)
+
+#define CONFIG_SYS_INIT_RAM_ADDR OCRAM_BASE_ADDR
+#define CONFIG_SYS_INIT_RAM_SIZE OCRAM_SIZE
+
+/* XHCI Support - enabled by default */
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
+
+#define CONFIG_SYS_CLK_FREQ 100000000
+#define CONFIG_DDR_CLK_FREQ 100000000
+
+#define DDR_SDRAM_CFG 0x470c0008
+#define DDR_CS0_BNDS 0x008000bf
+#define DDR_CS0_CONFIG 0x80014302
+#define DDR_TIMING_CFG_0 0x50550004
+#define DDR_TIMING_CFG_1 0xbcb38c56
+#define DDR_TIMING_CFG_2 0x0040d120
+#define DDR_TIMING_CFG_3 0x010e1000
+#define DDR_TIMING_CFG_4 0x00000001
+#define DDR_TIMING_CFG_5 0x03401400
+#define DDR_SDRAM_CFG_2 0x00401010
+#define DDR_SDRAM_MODE 0x00061c60
+#define DDR_SDRAM_MODE_2 0x00180000
+#define DDR_SDRAM_INTERVAL 0x18600618
+#define DDR_DDR_WRLVL_CNTL 0x8655f605
+#define DDR_DDR_WRLVL_CNTL_2 0x05060607
+#define DDR_DDR_WRLVL_CNTL_3 0x05050505
+#define DDR_DDR_CDR1 0x80040000
+#define DDR_DDR_CDR2 0x00000001
+#define DDR_SDRAM_CLK_CNTL 0x02000000
+#define DDR_DDR_ZQ_CNTL 0x89080600
+#define DDR_CS0_CONFIG_2 0
+#define DDR_SDRAM_CFG_MEM_EN 0x80000000
+#define SDRAM_CFG2_D_INIT 0x00000010
+#define DDR_CDR2_VREF_TRAIN_EN 0x00000080
+#define SDRAM_CFG2_FRC_SR 0x80000000
+#define SDRAM_CFG_BI 0x00000001
+
+#ifdef CONFIG_RAMBOOT_PBL
+#define CONFIG_SYS_FSL_PBL_PBI \
+ "board/freescale/ls1021atsn/ls102xa_pbi.cfg"
+#endif
+
+#ifdef CONFIG_SD_BOOT
+#define CONFIG_SYS_FSL_PBL_RCW \
+ "board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg"
+
+#ifdef CONFIG_SECURE_BOOT
+#define CONFIG_U_BOOT_HDR_SIZE (16 << 10)
+#endif /* ifdef CONFIG_SECURE_BOOT */
+
+#define CONFIG_SPL_MAX_SIZE 0x1a000
+#define CONFIG_SPL_STACK 0x1001d000
+#define CONFIG_SPL_PAD_TO 0x1c000
+
+#define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_TEXT_BASE + \
+ CONFIG_SYS_MONITOR_LEN)
+#define CONFIG_SYS_SPL_MALLOC_SIZE 0x100000
+#define CONFIG_SPL_BSS_START_ADDR 0x80100000
+#define CONFIG_SPL_BSS_MAX_SIZE 0x80000
+
+#ifdef CONFIG_U_BOOT_HDR_SIZE
+/*
+ * HDR would be appended@end of image and copied to DDR along
+ * with U-Boot image. Here u-boot max. size is 512K. So if binary
+ * size increases then increase this size in case of secure boot as
+ * it uses raw U-Boot image instead of FIT image.
+ */
+#define CONFIG_SYS_MONITOR_LEN (0x100000 + CONFIG_U_BOOT_HDR_SIZE)
+#else
+#define CONFIG_SYS_MONITOR_LEN 0x100000
+#endif /* ifdef CONFIG_U_BOOT_HDR_SIZE */
+#endif
+
+#define CONFIG_NR_DRAM_BANKS 1
+#define PHYS_SDRAM 0x80000000
+#define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024)
+
+#define CONFIG_SYS_DDR_SDRAM_BASE 0x80000000UL
+#define CONFIG_SYS_SDRAM_BASE CONFIG_SYS_DDR_SDRAM_BASE
+
+#define CONFIG_CHIP_SELECTS_PER_CTRL 4
+
+/* Serial Port */
+#define CONFIG_CONS_INDEX 1
+#define CONFIG_SYS_NS16550_SERIAL
+#ifndef CONFIG_DM_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE 1
+#endif
+#define CONFIG_SYS_NS16550_CLK get_serial_clock()
+
+#define CONFIG_BAUDRATE 115200
+
+/* I2C */
+#define CONFIG_SYS_I2C
+#define CONFIG_SYS_I2C_MXC
+#define CONFIG_SYS_I2C_MXC_I2C1 /* enable I2C bus 1 */
+#define CONFIG_SYS_I2C_MXC_I2C2 /* enable I2C bus 2 */
+#define CONFIG_SYS_I2C_MXC_I2C3 /* enable I2C bus 3 */
+
+/* EEPROM */
+#define CONFIG_ID_EEPROM
+#define CONFIG_SYS_I2C_EEPROM_NXID
+#define CONFIG_SYS_EEPROM_BUS_NUM 0
+#define CONFIG_SYS_I2C_EEPROM_ADDR 0x51
+#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 2
+
+/* QSPI */
+#define FSL_QSPI_FLASH_SIZE (1 << 24)
+#define FSL_QSPI_FLASH_NUM 2
+
+/* PCIe */
+#define CONFIG_PCIE1 /* PCIE controller 1 */
+#define CONFIG_PCIE2 /* PCIE controller 2 */
+#define FSL_PCIE_COMPAT "fsl,ls1021a-pcie"
+#ifdef CONFIG_PCI
+#define CONFIG_PCI_SCAN_SHOW
+#endif
+
+#define CONFIG_LAYERSCAPE_NS_ACCESS
+#define COUNTER_FREQUENCY 12500000
+
+#define CONFIG_HWCONFIG
+#define HWCONFIG_BUFFER_SIZE 256
+
+#define CONFIG_FSL_DEVICE_DISABLE
+
+#define BOOT_TARGET_DEVICES(func) \
+ func(MMC, mmc, 0) \
+ func(USB, usb, 0) \
+ func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ "bootargs=root=/dev/ram0 rw console=ttyS0,115200\0" \
+ "initrd_high=0xffffffff\0" \
+ "fdt_high=0xffffffff\0" \
+ "fdt_addr=0x64f00000\0" \
+ "kernel_addr=0x61000000\0" \
+ "kernelheader_addr=0x60800000\0" \
+ "scriptaddr=0x80000000\0" \
+ "scripthdraddr=0x80080000\0" \
+ "fdtheader_addr_r=0x80100000\0" \
+ "kernelheader_addr_r=0x80200000\0" \
+ "kernel_addr_r=0x80008000\0" \
+ "kernelheader_size=0x40000\0" \
+ "fdt_addr_r=0x8f000000\0" \
+ "ramdisk_addr_r=0xa0000000\0" \
+ "load_addr=0x80008000\0" \
+ "kernel_size=0x2800000\0" \
+ "kernel_addr_sd=0x8000\0" \
+ "kernel_size_sd=0x14000\0" \
+ "kernelhdr_addr_sd=0x4000\0" \
+ "kernelhdr_size_sd=0x10\0" \
+ BOOTENV \
+ "boot_scripts=ls1021atsn_boot.scr\0" \
+ "boot_script_hdr=hdr_ls1021atsn_bs.out\0" \
+ "scan_dev_for_boot_part=" \
+ "part list ${devtype} ${devnum} devplist; " \
+ "env exists devplist || setenv devplist 1; " \
+ "for distro_bootpart in ${devplist}; do " \
+ "if fstype ${devtype} " \
+ "${devnum}:${distro_bootpart} " \
+ "bootfstype; then " \
+ "run scan_dev_for_boot; " \
+ "fi; " \
+ "done\0" \
+ "scan_dev_for_boot=" \
+ "echo Scanning ${devtype} " \
+ "${devnum}:${distro_bootpart}...; " \
+ "for prefix in ${boot_prefixes}; do " \
+ "run scan_dev_for_scripts; " \
+ "run scan_dev_for_extlinux; " \
+ "done;" \
+ "\0" \
+ "boot_a_script=" \
+ "load ${devtype} ${devnum}:${distro_bootpart} " \
+ "${scriptaddr} ${prefix}${script}; " \
+ "env exists secureboot && load ${devtype} " \
+ "${devnum}:${distro_bootpart} " \
+ "${scripthdraddr} ${prefix}${boot_script_hdr} " \
+ "&& esbc_validate ${scripthdraddr};" \
+ "source ${scriptaddr}\0" \
+ "qspi_bootcmd=echo Trying load from qspi..;" \
+ "sf probe && sf read $load_addr " \
+ "$kernel_addr $kernel_size; env exists secureboot " \
+ "&& sf read $kernelheader_addr_r $kernelheader_addr " \
+ "$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
+ "bootm $load_addr#$board\0" \
+ "sd_bootcmd=echo Trying load from SD ..;" \
+ "mmcinfo && mmc read $load_addr " \
+ "$kernel_addr_sd $kernel_size_sd && " \
+ "env exists secureboot && mmc read $kernelheader_addr_r " \
+ "$kernelhdr_addr_sd $kernelhdr_size_sd " \
+ " && esbc_validate ${kernelheader_addr_r};" \
+ "bootm $load_addr#$board\0"
+
+/* Miscellaneous configurable options */
+#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */
+#define CONFIG_SYS_PBSIZE \
+ (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_MAXARGS 16 /* max number of command args */
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+
+#define CONFIG_SYS_LOAD_ADDR 0x82000000
+
+#define CONFIG_LS102XA_STREAM_ID
+
+#define CONFIG_SYS_INIT_SP_OFFSET \
+ (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR \
+ (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+
+#ifdef CONFIG_SPL_BUILD
+#define CONFIG_SYS_MONITOR_BASE CONFIG_SPL_TEXT_BASE
+#else
+#define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_TEXT_BASE /* start of monitor */
+#endif
+
+/* Environment */
+#define CONFIG_ENV_OVERWRITE
+
+#if defined(CONFIG_SD_BOOT)
+#define CONFIG_ENV_OFFSET 0x300000
+#define CONFIG_SYS_MMC_ENV_DEV 0
+#define CONFIG_ENV_SIZE 0x20000
+#elif defined(CONFIG_QSPI_BOOT)
+#define CONFIG_ENV_SIZE 0x2000
+#define CONFIG_ENV_OFFSET 0x300000
+#define CONFIG_ENV_SECT_SIZE 0x40000
+#endif
+
+#define CONFIG_SYS_BOOTM_LEN 0x8000000 /* 128 MB */
+
+#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
@ 2019-07-23 3:35 ` Joe Hershberger
2019-07-23 6:25 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2 siblings, 0 replies; 33+ messages in thread
From: Joe Hershberger @ 2019-07-23 3:35 UTC (permalink / raw)
To: u-boot
On Thu, Jul 18, 2019 at 4:36 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> From: Jianchao Wang <jianchao.wang@nxp.com>
>
> The LS1021A-TSN is a development board built by VVDN/Argonboards in
> partnership with NXP.
>
> It features the LS1021A SoC and the first-generation SJA1105T Ethernet
> switch for prototyping implementations of a subset of IEEE 802.1 TSN
> standards.
>
> Supported boot media: microSD card (via SPL), QSPI flash.
>
> Rev. A of the board uses a Spansion S25FL512S_256K serial flash, which
> is 64 MB in size and has an erase sector size of 256KB (therefore,
> flashing the RCW would erase part of U-Boot).
>
> Rev. B and C of the board use a Spansion S25FL256S1 serial flash, which
> is only 32 MB in size but has an erase sector size of 64KB (therefore
> the RCW image can be flashed without erasing U-Boot).
>
> To avoid the problems above, the U-Boot base address has been selected
> at 0x100000 (the start of the 5th 256KB erase sector), which works for
> all board revisions. Actually 0x40000 would have been enough, but
> 0x100000 is common for all Layerscape devices.
>
> eTSEC3 is connecting directly to SJA1105 via an RGMII fixed-link, but
> SJA1105 is currently not supported by uboot. Therefore, eTSEC3 is
> disabled.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> Signed-off-by: Mingkai Hu <mingkai.hu@nxp.com>
> Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
>
> [Vladimir] Code taken from https://github.com/openil/u-boot (which
> itself is mostly copied from ls1021a-iot) and adapted with the following
> changes:
>
> - Add a008850 errata workaround
> - Converted eTSEC, MMC to DM to avoid all build warnings
> - Plugged in distro boot feature, including support for extlinux.conf
> - Added defconfig for QSPI boot
> - Added the board/freescale/ls1021atsn/README.rst for initial setup
> - Increased CONFIG_SYS_MONITOR_LEN so that the SPL malloc pool does not
> get overwritten during copying of the u-boot.bin payload from MMC to
> DDR.
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-23 3:35 ` Joe Hershberger
@ 2019-07-23 6:25 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2 siblings, 0 replies; 33+ messages in thread
From: Bin Meng @ 2019-07-23 6:25 UTC (permalink / raw)
To: u-boot
On Fri, Jul 19, 2019 at 5:33 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> From: Jianchao Wang <jianchao.wang@nxp.com>
>
> The LS1021A-TSN is a development board built by VVDN/Argonboards in
> partnership with NXP.
>
> It features the LS1021A SoC and the first-generation SJA1105T Ethernet
> switch for prototyping implementations of a subset of IEEE 802.1 TSN
> standards.
>
> Supported boot media: microSD card (via SPL), QSPI flash.
>
> Rev. A of the board uses a Spansion S25FL512S_256K serial flash, which
> is 64 MB in size and has an erase sector size of 256KB (therefore,
> flashing the RCW would erase part of U-Boot).
>
> Rev. B and C of the board use a Spansion S25FL256S1 serial flash, which
> is only 32 MB in size but has an erase sector size of 64KB (therefore
> the RCW image can be flashed without erasing U-Boot).
>
> To avoid the problems above, the U-Boot base address has been selected
> at 0x100000 (the start of the 5th 256KB erase sector), which works for
> all board revisions. Actually 0x40000 would have been enough, but
> 0x100000 is common for all Layerscape devices.
>
> eTSEC3 is connecting directly to SJA1105 via an RGMII fixed-link, but
> SJA1105 is currently not supported by uboot. Therefore, eTSEC3 is
> disabled.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> Signed-off-by: Mingkai Hu <mingkai.hu@nxp.com>
> Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
>
> [Vladimir] Code taken from https://github.com/openil/u-boot (which
> itself is mostly copied from ls1021a-iot) and adapted with the following
> changes:
>
> - Add a008850 errata workaround
> - Converted eTSEC, MMC to DM to avoid all build warnings
> - Plugged in distro boot feature, including support for extlinux.conf
> - Added defconfig for QSPI boot
> - Added the board/freescale/ls1021atsn/README.rst for initial setup
> - Increased CONFIG_SYS_MONITOR_LEN so that the SPL malloc pool does not
> get overwritten during copying of the u-boot.bin payload from MMC to
> DDR.
> ---
> Changes from v2:
>
> Cosmetic refactoring of comments in board/freescale/ls1021atsn/ls1021atsn.c
> and include/configs/ls1021atsn.h.
> Removed a few useless defines in include/configs/ls1021atsn.h.
>
> Changes from v1:
>
> Increased CONFIG_SYS_MONITOR_LEN so that the SPL malloc pool does not
> get overwritten during copying of the u-boot.bin payload from MMC to
> DDR.
> Completely removed all traces of IFC support (for CPLD control), which
> has no chance of working on this board.
> Made ddrmc_init a static function.
>
> arch/arm/Kconfig | 14 +
> arch/arm/dts/Makefile | 2 +-
> arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
> board/freescale/ls1021atsn/Kconfig | 18 ++
> board/freescale/ls1021atsn/MAINTAINERS | 8 +
> board/freescale/ls1021atsn/Makefile | 3 +
> board/freescale/ls1021atsn/README.rst | 97 +++++++
> board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
> board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
> board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
> configs/ls1021atsn_qspi_defconfig | 79 ++++++
> configs/ls1021atsn_sdcard_defconfig | 91 ++++++
> include/configs/ls1021atsn.h | 250 +++++++++++++++++
> 13 files changed, 921 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/dts/ls1021a-tsn.dts
> create mode 100644 board/freescale/ls1021atsn/Kconfig
> create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
> create mode 100644 board/freescale/ls1021atsn/Makefile
> create mode 100644 board/freescale/ls1021atsn/README.rst
> create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
> create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
> create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
> create mode 100644 configs/ls1021atsn_qspi_defconfig
> create mode 100644 configs/ls1021atsn_sdcard_defconfig
> create mode 100644 include/configs/ls1021atsn.h
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] Add support for the NXP LS1021A-TSN board
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-23 3:35 ` Joe Hershberger
2019-07-23 6:25 ` Bin Meng
@ 2019-07-25 18:42 ` Joe Hershberger
2019-07-25 20:30 ` Vladimir Oltean
2 siblings, 1 reply; 33+ messages in thread
From: Joe Hershberger @ 2019-07-25 18:42 UTC (permalink / raw)
To: u-boot
Hi Vladimir,
https://patchwork.ozlabs.org/patch/1133867/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks!
-Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
` (8 preceding siblings ...)
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
@ 2019-07-23 0:15 ` Joe Hershberger
2019-07-23 6:07 ` Vladimir Oltean
9 siblings, 1 reply; 33+ messages in thread
From: Joe Hershberger @ 2019-07-23 0:15 UTC (permalink / raw)
To: u-boot
On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> This patchset adds initial support for the NXP LS1021A-TSN board,
> an evaluation platform built in partnership with VVDN/Argonboards
> for some IEEE 802.1 TSN features.
>
> It features a cleaned-up U-Boot board support taken from OpenIL,
> as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> patch that converts the LS1021A-TWR (different board, same SoC):
> https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> verified it on the LS1021A-TSN board I am submitting, and made a
> few adjustments where necessary.
>
> TODO items:
> - Make the eTSEC driver support fixed-link interfaces (necessary
> for the enet2 <-> sja1105 internal port)
> - Add driver for SJA1105 switch
> - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> expose the TBI PHY to mdio commands (useful for debugging),
> once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> is merged.
This series is merged at this point... are you wanting to do that
migration now or do it sometime later?
>
> Bin Meng (1):
> arm: ls1021atwr: Convert to use driver model TSEC driver
>
> Jianchao Wang (1):
> Add support for the NXP LS1021A-TSN board
>
> Vladimir Oltean (7):
> net: tsec: Refactor the readout of the tbi-handle property
> net: tsec: Fix offset of MDIO registers for DM_ETH
> net: tsec: Reverse Christmas tree notation
> net: tsec: Make errors visible
> net: tsec: Common handling of MAC station address for DM_ETH
> net: tsec: Change compatible strings to match Linux
> configs: ls1021atwr: Fix distro_bootcmd for QSPI boot
>
> arch/arm/Kconfig | 14 +
> arch/arm/cpu/armv7/ls102xa/cpu.c | 2 +-
> arch/arm/cpu/armv7/ls102xa/fdt.c | 10 +
> arch/arm/dts/Makefile | 2 +-
> arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
> arch/arm/dts/ls1021a-twr.dtsi | 32 +++
> arch/arm/dts/ls1021a.dtsi | 30 +-
> board/freescale/ls1021atsn/Kconfig | 18 ++
> board/freescale/ls1021atsn/MAINTAINERS | 8 +
> board/freescale/ls1021atsn/Makefile | 3 +
> board/freescale/ls1021atsn/README.rst | 97 +++++++
> board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
> board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
> board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
> board/freescale/ls1021atwr/ls1021atwr.c | 38 ---
> configs/ls1021atsn_qspi_defconfig | 79 ++++++
> configs/ls1021atsn_sdcard_defconfig | 91 ++++++
> configs/ls1021atwr_nor_SECURE_BOOT_defconfig | 2 +
> configs/ls1021atwr_nor_defconfig | 2 +
> configs/ls1021atwr_nor_lpuart_defconfig | 2 +
> configs/ls1021atwr_qspi_defconfig | 2 +
> ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 2 +
> configs/ls1021atwr_sdcard_ifc_defconfig | 2 +
> configs/ls1021atwr_sdcard_qspi_defconfig | 2 +
> doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 +-
> drivers/net/tsec.c | 59 ++--
> include/configs/ls1021atsn.h | 250 +++++++++++++++++
> include/configs/ls1021atwr.h | 30 +-
> include/tsec.h | 4 +-
> 29 files changed, 1038 insertions(+), 107 deletions(-)
> create mode 100644 arch/arm/dts/ls1021a-tsn.dts
> create mode 100644 board/freescale/ls1021atsn/Kconfig
> create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
> create mode 100644 board/freescale/ls1021atsn/Makefile
> create mode 100644 board/freescale/ls1021atsn/README.rst
> create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
> create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
> create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
> create mode 100644 configs/ls1021atsn_qspi_defconfig
> create mode 100644 configs/ls1021atsn_sdcard_defconfig
> create mode 100644 include/configs/ls1021atsn.h
>
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 33+ messages in thread* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-23 0:15 ` [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Joe Hershberger
@ 2019-07-23 6:07 ` Vladimir Oltean
2019-07-23 7:37 ` Joe Hershberger
0 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-23 6:07 UTC (permalink / raw)
To: u-boot
Hi Joe,
On Tue, 23 Jul 2019 at 03:15, Joe Hershberger <joe.hershberger@ni.com> wrote:
>
> On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > This patchset adds initial support for the NXP LS1021A-TSN board,
> > an evaluation platform built in partnership with VVDN/Argonboards
> > for some IEEE 802.1 TSN features.
> >
> > It features a cleaned-up U-Boot board support taken from OpenIL,
> > as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> > patch that converts the LS1021A-TWR (different board, same SoC):
> > https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> > verified it on the LS1021A-TSN board I am submitting, and made a
> > few adjustments where necessary.
> >
> > TODO items:
> > - Make the eTSEC driver support fixed-link interfaces (necessary
> > for the enet2 <-> sja1105 internal port)
> > - Add driver for SJA1105 switch
> > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > expose the TBI PHY to mdio commands (useful for debugging),
> > once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> > is merged.
>
> This series is merged at this point... are you wanting to do that
> migration now or do it sometime later?
>
I think I would rather have these 9 patches merged first, now that
they got reviewed, instead of reworking them again.
> >
> > Bin Meng (1):
> > arm: ls1021atwr: Convert to use driver model TSEC driver
> >
> > Jianchao Wang (1):
> > Add support for the NXP LS1021A-TSN board
> >
> > Vladimir Oltean (7):
> > net: tsec: Refactor the readout of the tbi-handle property
> > net: tsec: Fix offset of MDIO registers for DM_ETH
> > net: tsec: Reverse Christmas tree notation
> > net: tsec: Make errors visible
> > net: tsec: Common handling of MAC station address for DM_ETH
> > net: tsec: Change compatible strings to match Linux
> > configs: ls1021atwr: Fix distro_bootcmd for QSPI boot
> >
> > arch/arm/Kconfig | 14 +
> > arch/arm/cpu/armv7/ls102xa/cpu.c | 2 +-
> > arch/arm/cpu/armv7/ls102xa/fdt.c | 10 +
> > arch/arm/dts/Makefile | 2 +-
> > arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
> > arch/arm/dts/ls1021a-twr.dtsi | 32 +++
> > arch/arm/dts/ls1021a.dtsi | 30 +-
> > board/freescale/ls1021atsn/Kconfig | 18 ++
> > board/freescale/ls1021atsn/MAINTAINERS | 8 +
> > board/freescale/ls1021atsn/Makefile | 3 +
> > board/freescale/ls1021atsn/README.rst | 97 +++++++
> > board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
> > board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
> > board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
> > board/freescale/ls1021atwr/ls1021atwr.c | 38 ---
> > configs/ls1021atsn_qspi_defconfig | 79 ++++++
> > configs/ls1021atsn_sdcard_defconfig | 91 ++++++
> > configs/ls1021atwr_nor_SECURE_BOOT_defconfig | 2 +
> > configs/ls1021atwr_nor_defconfig | 2 +
> > configs/ls1021atwr_nor_lpuart_defconfig | 2 +
> > configs/ls1021atwr_qspi_defconfig | 2 +
> > ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 2 +
> > configs/ls1021atwr_sdcard_ifc_defconfig | 2 +
> > configs/ls1021atwr_sdcard_qspi_defconfig | 2 +
> > doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 +-
> > drivers/net/tsec.c | 59 ++--
> > include/configs/ls1021atsn.h | 250 +++++++++++++++++
> > include/configs/ls1021atwr.h | 30 +-
> > include/tsec.h | 4 +-
> > 29 files changed, 1038 insertions(+), 107 deletions(-)
> > create mode 100644 arch/arm/dts/ls1021a-tsn.dts
> > create mode 100644 board/freescale/ls1021atsn/Kconfig
> > create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
> > create mode 100644 board/freescale/ls1021atsn/Makefile
> > create mode 100644 board/freescale/ls1021atsn/README.rst
> > create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
> > create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
> > create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
> > create mode 100644 configs/ls1021atsn_qspi_defconfig
> > create mode 100644 configs/ls1021atsn_sdcard_defconfig
> > create mode 100644 include/configs/ls1021atsn.h
> >
> > --
> > 2.17.1
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
Regards,
-Vladimir
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-23 6:07 ` Vladimir Oltean
@ 2019-07-23 7:37 ` Joe Hershberger
2019-07-24 15:37 ` Vladimir Oltean
0 siblings, 1 reply; 33+ messages in thread
From: Joe Hershberger @ 2019-07-23 7:37 UTC (permalink / raw)
To: u-boot
On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> Hi Joe,
>
> On Tue, 23 Jul 2019 at 03:15, Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
> > >
> > > This patchset adds initial support for the NXP LS1021A-TSN board,
> > > an evaluation platform built in partnership with VVDN/Argonboards
> > > for some IEEE 802.1 TSN features.
> > >
> > > It features a cleaned-up U-Boot board support taken from OpenIL,
> > > as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> > > patch that converts the LS1021A-TWR (different board, same SoC):
> > > https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> > > verified it on the LS1021A-TSN board I am submitting, and made a
> > > few adjustments where necessary.
> > >
> > > TODO items:
> > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > for the enet2 <-> sja1105 internal port)
> > > - Add driver for SJA1105 switch
> > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > expose the TBI PHY to mdio commands (useful for debugging),
> > > once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> > > is merged.
> >
> > This series is merged at this point... are you wanting to do that
> > migration now or do it sometime later?
> >
>
> I think I would rather have these 9 patches merged first, now that
> they got reviewed, instead of reworking them again.
Sounds good.
Thanks,
-Joe
>
> > >
> > > Bin Meng (1):
> > > arm: ls1021atwr: Convert to use driver model TSEC driver
> > >
> > > Jianchao Wang (1):
> > > Add support for the NXP LS1021A-TSN board
> > >
> > > Vladimir Oltean (7):
> > > net: tsec: Refactor the readout of the tbi-handle property
> > > net: tsec: Fix offset of MDIO registers for DM_ETH
> > > net: tsec: Reverse Christmas tree notation
> > > net: tsec: Make errors visible
> > > net: tsec: Common handling of MAC station address for DM_ETH
> > > net: tsec: Change compatible strings to match Linux
> > > configs: ls1021atwr: Fix distro_bootcmd for QSPI boot
> > >
> > > arch/arm/Kconfig | 14 +
> > > arch/arm/cpu/armv7/ls102xa/cpu.c | 2 +-
> > > arch/arm/cpu/armv7/ls102xa/fdt.c | 10 +
> > > arch/arm/dts/Makefile | 2 +-
> > > arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
> > > arch/arm/dts/ls1021a-twr.dtsi | 32 +++
> > > arch/arm/dts/ls1021a.dtsi | 30 +-
> > > board/freescale/ls1021atsn/Kconfig | 18 ++
> > > board/freescale/ls1021atsn/MAINTAINERS | 8 +
> > > board/freescale/ls1021atsn/Makefile | 3 +
> > > board/freescale/ls1021atsn/README.rst | 97 +++++++
> > > board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
> > > board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
> > > board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
> > > board/freescale/ls1021atwr/ls1021atwr.c | 38 ---
> > > configs/ls1021atsn_qspi_defconfig | 79 ++++++
> > > configs/ls1021atsn_sdcard_defconfig | 91 ++++++
> > > configs/ls1021atwr_nor_SECURE_BOOT_defconfig | 2 +
> > > configs/ls1021atwr_nor_defconfig | 2 +
> > > configs/ls1021atwr_nor_lpuart_defconfig | 2 +
> > > configs/ls1021atwr_qspi_defconfig | 2 +
> > > ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 2 +
> > > configs/ls1021atwr_sdcard_ifc_defconfig | 2 +
> > > configs/ls1021atwr_sdcard_qspi_defconfig | 2 +
> > > doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 +-
> > > drivers/net/tsec.c | 59 ++--
> > > include/configs/ls1021atsn.h | 250 +++++++++++++++++
> > > include/configs/ls1021atwr.h | 30 +-
> > > include/tsec.h | 4 +-
> > > 29 files changed, 1038 insertions(+), 107 deletions(-)
> > > create mode 100644 arch/arm/dts/ls1021a-tsn.dts
> > > create mode 100644 board/freescale/ls1021atsn/Kconfig
> > > create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
> > > create mode 100644 board/freescale/ls1021atsn/Makefile
> > > create mode 100644 board/freescale/ls1021atsn/README.rst
> > > create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
> > > create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
> > > create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
> > > create mode 100644 configs/ls1021atsn_qspi_defconfig
> > > create mode 100644 configs/ls1021atsn_sdcard_defconfig
> > > create mode 100644 include/configs/ls1021atsn.h
> > >
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot at lists.denx.de
> > > https://lists.denx.de/listinfo/u-boot
>
> Regards,
> -Vladimir
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-23 7:37 ` Joe Hershberger
@ 2019-07-24 15:37 ` Vladimir Oltean
2019-07-24 18:56 ` Joe Hershberger
0 siblings, 1 reply; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-24 15:37 UTC (permalink / raw)
To: u-boot
On Tue, 23 Jul 2019 at 10:38, Joe Hershberger <joe.hershberger@ni.com> wrote:
>
> On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > Hi Joe,
> >
> > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger <joe.hershberger@ni.com> wrote:
> > >
> > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
> > > >
> > > > This patchset adds initial support for the NXP LS1021A-TSN board,
> > > > an evaluation platform built in partnership with VVDN/Argonboards
> > > > for some IEEE 802.1 TSN features.
> > > >
> > > > It features a cleaned-up U-Boot board support taken from OpenIL,
> > > > as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> > > > patch that converts the LS1021A-TWR (different board, same SoC):
> > > > https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> > > > verified it on the LS1021A-TSN board I am submitting, and made a
> > > > few adjustments where necessary.
> > > >
> > > > TODO items:
> > > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > > for the enet2 <-> sja1105 internal port)
> > > > - Add driver for SJA1105 switch
> > > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > > expose the TBI PHY to mdio commands (useful for debugging),
> > > > once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> > > > is merged.
> > >
> > > This series is merged at this point... are you wanting to do that
> > > migration now or do it sometime later?
> > >
> >
> > I think I would rather have these 9 patches merged first, now that
> > they got reviewed, instead of reworking them again.
>
> Sounds good.
> Thanks,
> -Joe
>
What does this mean, that we are waiting for Prabhakar's OK? Is the
patchset going to get in through a single tree? Whose is it going to
be?
Thanks,
-Vladimir
> >
> > > >
> > > > Bin Meng (1):
> > > > arm: ls1021atwr: Convert to use driver model TSEC driver
> > > >
> > > > Jianchao Wang (1):
> > > > Add support for the NXP LS1021A-TSN board
> > > >
> > > > Vladimir Oltean (7):
> > > > net: tsec: Refactor the readout of the tbi-handle property
> > > > net: tsec: Fix offset of MDIO registers for DM_ETH
> > > > net: tsec: Reverse Christmas tree notation
> > > > net: tsec: Make errors visible
> > > > net: tsec: Common handling of MAC station address for DM_ETH
> > > > net: tsec: Change compatible strings to match Linux
> > > > configs: ls1021atwr: Fix distro_bootcmd for QSPI boot
> > > >
> > > > arch/arm/Kconfig | 14 +
> > > > arch/arm/cpu/armv7/ls102xa/cpu.c | 2 +-
> > > > arch/arm/cpu/armv7/ls102xa/fdt.c | 10 +
> > > > arch/arm/dts/Makefile | 2 +-
> > > > arch/arm/dts/ls1021a-tsn.dts | 77 ++++++
> > > > arch/arm/dts/ls1021a-twr.dtsi | 32 +++
> > > > arch/arm/dts/ls1021a.dtsi | 30 +-
> > > > board/freescale/ls1021atsn/Kconfig | 18 ++
> > > > board/freescale/ls1021atsn/MAINTAINERS | 8 +
> > > > board/freescale/ls1021atsn/Makefile | 3 +
> > > > board/freescale/ls1021atsn/README.rst | 97 +++++++
> > > > board/freescale/ls1021atsn/ls1021atsn.c | 260 ++++++++++++++++++
> > > > board/freescale/ls1021atsn/ls102xa_pbi.cfg | 15 +
> > > > board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg | 8 +
> > > > board/freescale/ls1021atwr/ls1021atwr.c | 38 ---
> > > > configs/ls1021atsn_qspi_defconfig | 79 ++++++
> > > > configs/ls1021atsn_sdcard_defconfig | 91 ++++++
> > > > configs/ls1021atwr_nor_SECURE_BOOT_defconfig | 2 +
> > > > configs/ls1021atwr_nor_defconfig | 2 +
> > > > configs/ls1021atwr_nor_lpuart_defconfig | 2 +
> > > > configs/ls1021atwr_qspi_defconfig | 2 +
> > > > ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 2 +
> > > > configs/ls1021atwr_sdcard_ifc_defconfig | 2 +
> > > > configs/ls1021atwr_sdcard_qspi_defconfig | 2 +
> > > > doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 +-
> > > > drivers/net/tsec.c | 59 ++--
> > > > include/configs/ls1021atsn.h | 250 +++++++++++++++++
> > > > include/configs/ls1021atwr.h | 30 +-
> > > > include/tsec.h | 4 +-
> > > > 29 files changed, 1038 insertions(+), 107 deletions(-)
> > > > create mode 100644 arch/arm/dts/ls1021a-tsn.dts
> > > > create mode 100644 board/freescale/ls1021atsn/Kconfig
> > > > create mode 100644 board/freescale/ls1021atsn/MAINTAINERS
> > > > create mode 100644 board/freescale/ls1021atsn/Makefile
> > > > create mode 100644 board/freescale/ls1021atsn/README.rst
> > > > create mode 100644 board/freescale/ls1021atsn/ls1021atsn.c
> > > > create mode 100644 board/freescale/ls1021atsn/ls102xa_pbi.cfg
> > > > create mode 100644 board/freescale/ls1021atsn/ls102xa_rcw_sd.cfg
> > > > create mode 100644 configs/ls1021atsn_qspi_defconfig
> > > > create mode 100644 configs/ls1021atsn_sdcard_defconfig
> > > > create mode 100644 include/configs/ls1021atsn.h
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > > _______________________________________________
> > > > U-Boot mailing list
> > > > U-Boot at lists.denx.de
> > > > https://lists.denx.de/listinfo/u-boot
> >
> > Regards,
> > -Vladimir
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-24 15:37 ` Vladimir Oltean
@ 2019-07-24 18:56 ` Joe Hershberger
2019-07-24 20:54 ` Vladimir Oltean
2019-08-14 9:37 ` Prabhakar Kushwaha
0 siblings, 2 replies; 33+ messages in thread
From: Joe Hershberger @ 2019-07-24 18:56 UTC (permalink / raw)
To: u-boot
On Wed, Jul 24, 2019 at 10:38 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> On Tue, 23 Jul 2019 at 10:38, Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> > >
> > > Hi Joe,
> > >
> > > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger <joe.hershberger@ni.com> wrote:
> > > >
> > > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
> > > > >
> > > > > This patchset adds initial support for the NXP LS1021A-TSN board,
> > > > > an evaluation platform built in partnership with VVDN/Argonboards
> > > > > for some IEEE 802.1 TSN features.
> > > > >
> > > > > It features a cleaned-up U-Boot board support taken from OpenIL,
> > > > > as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> > > > > patch that converts the LS1021A-TWR (different board, same SoC):
> > > > > https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> > > > > verified it on the LS1021A-TSN board I am submitting, and made a
> > > > > few adjustments where necessary.
> > > > >
> > > > > TODO items:
> > > > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > > > for the enet2 <-> sja1105 internal port)
> > > > > - Add driver for SJA1105 switch
> > > > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > > > expose the TBI PHY to mdio commands (useful for debugging),
> > > > > once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> > > > > is merged.
> > > >
> > > > This series is merged at this point... are you wanting to do that
> > > > migration now or do it sometime later?
> > > >
> > >
> > > I think I would rather have these 9 patches merged first, now that
> > > they got reviewed, instead of reworking them again.
> >
> > Sounds good.
> > Thanks,
> > -Joe
> >
>
> What does this mean, that we are waiting for Prabhakar's OK? Is the
> patchset going to get in through a single tree? Whose is it going to
> be?
Since the vast majority of the series is the Ethernet changes, I was
planning to take it.
Thanks,
-Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-24 18:56 ` Joe Hershberger
@ 2019-07-24 20:54 ` Vladimir Oltean
2019-08-14 9:37 ` Prabhakar Kushwaha
1 sibling, 0 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-07-24 20:54 UTC (permalink / raw)
To: u-boot
On Wed, 24 Jul 2019 at 21:56, Joe Hershberger <joe.hershberger@ni.com> wrote:
>
> On Wed, Jul 24, 2019 at 10:38 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > On Tue, 23 Jul 2019 at 10:38, Joe Hershberger <joe.hershberger@ni.com> wrote:
> > >
> > > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> > > >
> > > > Hi Joe,
> > > >
> > > > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger <joe.hershberger@ni.com> wrote:
> > > > >
> > > > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com> wrote:
> > > > > >
> > > > > > This patchset adds initial support for the NXP LS1021A-TSN board,
> > > > > > an evaluation platform built in partnership with VVDN/Argonboards
> > > > > > for some IEEE 802.1 TSN features.
> > > > > >
> > > > > > It features a cleaned-up U-Boot board support taken from OpenIL,
> > > > > > as well as an eTSEC migration to DM_ETH. I picked up Bin Meng's
> > > > > > patch that converts the LS1021A-TWR (different board, same SoC):
> > > > > > https://lists.denx.de/pipermail/u-boot/2018-May/330096.html
> > > > > > verified it on the LS1021A-TSN board I am submitting, and made a
> > > > > > few adjustments where necessary.
> > > > > >
> > > > > > TODO items:
> > > > > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > > > > for the enet2 <-> sja1105 internal port)
> > > > > > - Add driver for SJA1105 switch
> > > > > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > > > > expose the TBI PHY to mdio commands (useful for debugging),
> > > > > > once https://lists.denx.de/pipermail/u-boot/2019-June/371563.html
> > > > > > is merged.
> > > > >
> > > > > This series is merged at this point... are you wanting to do that
> > > > > migration now or do it sometime later?
> > > > >
> > > >
> > > > I think I would rather have these 9 patches merged first, now that
> > > > they got reviewed, instead of reworking them again.
> > >
> > > Sounds good.
> > > Thanks,
> > > -Joe
> > >
> >
> > What does this mean, that we are waiting for Prabhakar's OK? Is the
> > patchset going to get in through a single tree? Whose is it going to
> > be?
>
> Since the vast majority of the series is the Ethernet changes, I was
> planning to take it.
>
Sounds reasonable to me.
> Thanks,
> -Joe
Regards,
-Vladimir
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-07-24 18:56 ` Joe Hershberger
2019-07-24 20:54 ` Vladimir Oltean
@ 2019-08-14 9:37 ` Prabhakar Kushwaha
2019-08-14 9:52 ` Vladimir Oltean
1 sibling, 1 reply; 33+ messages in thread
From: Prabhakar Kushwaha @ 2019-08-14 9:37 UTC (permalink / raw)
To: u-boot
Dear Joe,
> -----Original Message-----
> From: Joe Hershberger <joe.hershberger@ni.com>
> Sent: Thursday, July 25, 2019 12:26 AM
> To: Vladimir Oltean <olteanv@gmail.com>
> Cc: Joseph Hershberger <joseph.hershberger@ni.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>; u-boot <u-
> boot at lists.denx.de>; Joseph Hershberger <joseph.hershberger@ni.com>
> Subject: Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
>
> On Wed, Jul 24, 2019 at 10:38 AM Vladimir Oltean <olteanv@gmail.com>
> wrote:
> >
> > On Tue, 23 Jul 2019 at 10:38, Joe Hershberger <joe.hershberger@ni.com>
> wrote:
> > >
> > > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com>
> wrote:
> > > >
> > > > Hi Joe,
> > > >
> > > > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger
> <joe.hershberger@ni.com> wrote:
> > > > >
> > > > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com>
> wrote:
> > > > > >
> > > > > > This patchset adds initial support for the NXP LS1021A-TSN
> > > > > > board, an evaluation platform built in partnership with
> > > > > > VVDN/Argonboards for some IEEE 802.1 TSN features.
> > > > > >
> > > > > > It features a cleaned-up U-Boot board support taken from
> > > > > > OpenIL, as well as an eTSEC migration to DM_ETH. I picked up
> > > > > > Bin Meng's patch that converts the LS1021A-TWR (different board,
> same SoC):
> > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2
> > > > > > F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2018-
> May%2F330096.htm
> > > > > >
> l&data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Cb56d806fd1
> > > > > >
> d34b1e9f6e08d710689b30%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> > > > > >
> 7C0%7C636995913790933089&sdata=p3knnJglauV7ddeHwXZqFHJTTVk
> > > > > > vgIPINUzuVkH6e%2Fw%3D&reserved=0
> > > > > > verified it on the LS1021A-TSN board I am submitting, and made
> > > > > > a few adjustments where necessary.
> > > > > >
> > > > > > TODO items:
> > > > > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > > > > for the enet2 <-> sja1105 internal port)
> > > > > > - Add driver for SJA1105 switch
> > > > > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > > > > expose the TBI PHY to mdio commands (useful for debugging),
> > > > > > once
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> enx.de%2Fpipermail%2Fu-boot%2F2019-
> June%2F371563.html&data=02%7C01%7Cprabhakar.kushwaha%40nxp.c
> om%7Cb56d806fd1d34b1e9f6e08d710689b30%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C636995913790933089&sdata=dRUz6o%2FbaaRV
> Fy%2FTn4Qxx%2B%2Bbng2YmxMVWtUyknP2qHY%3D&reserved=0
> > > > > > is merged.
> > > > >
> > > > > This series is merged at this point... are you wanting to do
> > > > > that migration now or do it sometime later?
> > > > >
> > > >
> > > > I think I would rather have these 9 patches merged first, now that
> > > > they got reviewed, instead of reworking them again.
> > >
> > > Sounds good.
> > > Thanks,
> > > -Joe
> > >
> >
> > What does this mean, that we are waiting for Prabhakar's OK? Is the
> > patchset going to get in through a single tree? Whose is it going to
> > be?
>
> Since the vast majority of the series is the Ethernet changes, I was planning
> to take it.
>
I hope you have taken this patch-set
--pk
^ permalink raw reply [flat|nested] 33+ messages in thread
* [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
2019-08-14 9:37 ` Prabhakar Kushwaha
@ 2019-08-14 9:52 ` Vladimir Oltean
0 siblings, 0 replies; 33+ messages in thread
From: Vladimir Oltean @ 2019-08-14 9:52 UTC (permalink / raw)
To: u-boot
Hi Prabhakar,
On Wed, 14 Aug 2019 at 12:37, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> Dear Joe,
>
> > -----Original Message-----
> > From: Joe Hershberger <joe.hershberger@ni.com>
> > Sent: Thursday, July 25, 2019 12:26 AM
> > To: Vladimir Oltean <olteanv@gmail.com>
> > Cc: Joseph Hershberger <joseph.hershberger@ni.com>; Prabhakar
> > Kushwaha <prabhakar.kushwaha@nxp.com>; u-boot <u-
> > boot at lists.denx.de>; Joseph Hershberger <joseph.hershberger@ni.com>
> > Subject: Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board
> >
> > On Wed, Jul 24, 2019 at 10:38 AM Vladimir Oltean <olteanv@gmail.com>
> > wrote:
> > >
> > > On Tue, 23 Jul 2019 at 10:38, Joe Hershberger <joe.hershberger@ni.com>
> > wrote:
> > > >
> > > > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean <olteanv@gmail.com>
> > wrote:
> > > > >
> > > > > Hi Joe,
> > > > >
> > > > > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger
> > <joe.hershberger@ni.com> wrote:
> > > > > >
> > > > > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean <olteanv@gmail.com>
> > wrote:
> > > > > > >
> > > > > > > This patchset adds initial support for the NXP LS1021A-TSN
> > > > > > > board, an evaluation platform built in partnership with
> > > > > > > VVDN/Argonboards for some IEEE 802.1 TSN features.
> > > > > > >
> > > > > > > It features a cleaned-up U-Boot board support taken from
> > > > > > > OpenIL, as well as an eTSEC migration to DM_ETH. I picked up
> > > > > > > Bin Meng's patch that converts the LS1021A-TWR (different board,
> > same SoC):
> > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2
> > > > > > > F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2018-
> > May%2F330096.htm
> > > > > > >
> > l&data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Cb56d806fd1
> > > > > > >
> > d34b1e9f6e08d710689b30%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> > > > > > >
> > 7C0%7C636995913790933089&sdata=p3knnJglauV7ddeHwXZqFHJTTVk
> > > > > > > vgIPINUzuVkH6e%2Fw%3D&reserved=0
> > > > > > > verified it on the LS1021A-TSN board I am submitting, and made
> > > > > > > a few adjustments where necessary.
> > > > > > >
> > > > > > > TODO items:
> > > > > > > - Make the eTSEC driver support fixed-link interfaces (necessary
> > > > > > > for the enet2 <-> sja1105 internal port)
> > > > > > > - Add driver for SJA1105 switch
> > > > > > > - Potentially migrate the eTSEC MDIO bus driver to DM_MDIO and
> > > > > > > expose the TBI PHY to mdio commands (useful for debugging),
> > > > > > > once
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> > enx.de%2Fpipermail%2Fu-boot%2F2019-
> > June%2F371563.html&data=02%7C01%7Cprabhakar.kushwaha%40nxp.c
> > om%7Cb56d806fd1d34b1e9f6e08d710689b30%7C686ea1d3bc2b4c6fa92cd99c
> > 5c301635%7C0%7C0%7C636995913790933089&sdata=dRUz6o%2FbaaRV
> > Fy%2FTn4Qxx%2B%2Bbng2YmxMVWtUyknP2qHY%3D&reserved=0
> > > > > > > is merged.
> > > > > >
> > > > > > This series is merged at this point... are you wanting to do
> > > > > > that migration now or do it sometime later?
> > > > > >
> > > > >
> > > > > I think I would rather have these 9 patches merged first, now that
> > > > > they got reviewed, instead of reworking them again.
> > > >
> > > > Sounds good.
> > > > Thanks,
> > > > -Joe
> > > >
> > >
> > > What does this mean, that we are waiting for Prabhakar's OK? Is the
> > > patchset going to get in through a single tree? Whose is it going to
> > > be?
> >
> > Since the vast majority of the series is the Ethernet changes, I was planning
> > to take it.
> >
>
> I hope you have taken this patch-set
Yes, they are now applied to the u-boot-net tree:
https://gitlab.denx.de/u-boot/custodians/u-boot-net/commits/master
>
> --pk
>
>
Thanks!
-Vladimir
^ permalink raw reply [flat|nested] 33+ messages in thread