From: Vladimir Oltean <olteanv@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Felix Fietkau <nbd@nbd.name>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jakub Kicinski <kuba@kernel.org>, John Crispin <john@phrozen.org>,
Jonathan Corbet <corbet@lwn.net>,
Jose Abreu <joabreu@synopsys.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-stm32@st-md-mailman.stormreply.com,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
netdev <netdev@vger.kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
Sean Wang <sean.wang@mediatek.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up()
Date: Tue, 25 Feb 2020 23:09:35 +0200 [thread overview]
Message-ID: <CA+h21hp8KCqhCasOAGz17k0eRteHVVYK-eANQmn4h443qv=2JQ@mail.gmail.com> (raw)
In-Reply-To: <E1j6Wg0-0000Ss-W7@rmk-PC.armlinux.org.uk>
Hi Russell,
On Tue, 25 Feb 2020 at 11:39, Russell King <rmk+kernel@armlinux.org.uk> wrote:
>
> Propagate the resolved link configuration down via DSA's
> phylink_mac_link_up() operation to allow split PCS/MAC to work.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/b53/b53_common.c | 4 +++-
> drivers/net/dsa/b53/b53_priv.h | 4 +++-
> drivers/net/dsa/bcm_sf2.c | 4 +++-
> drivers/net/dsa/lantiq_gswip.c | 4 +++-
> drivers/net/dsa/mt7530.c | 4 +++-
> drivers/net/dsa/mv88e6xxx/chip.c | 4 +++-
> drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
> include/net/dsa.h | 4 +++-
> net/dsa/port.c | 3 ++-
> 9 files changed, 26 insertions(+), 9 deletions(-)
>
It looks like you missed the felix_phylink_mac_link_up() conversion in
this patch? (which also makes it fail to build, by the way, I'm
supposed the Kbuild robot didn't already jump)
Nonetheless, I've manually added the missing speed, duplex, tx_pause
and rx_pause parameters, and it appears to work as before.
Same for sja1105.
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Regards,
-Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-stm32@st-md-mailman.stormreply.com,
Florian Fainelli <f.fainelli@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Michal Simek <michal.simek@xilinx.com>,
Jose Abreu <joabreu@synopsys.com>,
Jakub Kicinski <kuba@kernel.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Felix Fietkau <nbd@nbd.name>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up()
Date: Tue, 25 Feb 2020 23:09:35 +0200 [thread overview]
Message-ID: <CA+h21hp8KCqhCasOAGz17k0eRteHVVYK-eANQmn4h443qv=2JQ@mail.gmail.com> (raw)
In-Reply-To: <E1j6Wg0-0000Ss-W7@rmk-PC.armlinux.org.uk>
Hi Russell,
On Tue, 25 Feb 2020 at 11:39, Russell King <rmk+kernel@armlinux.org.uk> wrote:
>
> Propagate the resolved link configuration down via DSA's
> phylink_mac_link_up() operation to allow split PCS/MAC to work.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/b53/b53_common.c | 4 +++-
> drivers/net/dsa/b53/b53_priv.h | 4 +++-
> drivers/net/dsa/bcm_sf2.c | 4 +++-
> drivers/net/dsa/lantiq_gswip.c | 4 +++-
> drivers/net/dsa/mt7530.c | 4 +++-
> drivers/net/dsa/mv88e6xxx/chip.c | 4 +++-
> drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
> include/net/dsa.h | 4 +++-
> net/dsa/port.c | 3 ++-
> 9 files changed, 26 insertions(+), 9 deletions(-)
>
It looks like you missed the felix_phylink_mac_link_up() conversion in
this patch? (which also makes it fail to build, by the way, I'm
supposed the Kbuild robot didn't already jump)
Nonetheless, I've manually added the missing speed, duplex, tx_pause
and rx_pause parameters, and it appears to work as before.
Same for sja1105.
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Regards,
-Vladimir
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-stm32@st-md-mailman.stormreply.com,
Florian Fainelli <f.fainelli@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Michal Simek <michal.simek@xilinx.com>,
Jose Abreu <joabreu@synopsys.com>,
Jakub Kicinski <kuba@kernel.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Felix Fietkau <nbd@nbd.name>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up()
Date: Tue, 25 Feb 2020 23:09:35 +0200 [thread overview]
Message-ID: <CA+h21hp8KCqhCasOAGz17k0eRteHVVYK-eANQmn4h443qv=2JQ@mail.gmail.com> (raw)
In-Reply-To: <E1j6Wg0-0000Ss-W7@rmk-PC.armlinux.org.uk>
Hi Russell,
On Tue, 25 Feb 2020 at 11:39, Russell King <rmk+kernel@armlinux.org.uk> wrote:
>
> Propagate the resolved link configuration down via DSA's
> phylink_mac_link_up() operation to allow split PCS/MAC to work.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/b53/b53_common.c | 4 +++-
> drivers/net/dsa/b53/b53_priv.h | 4 +++-
> drivers/net/dsa/bcm_sf2.c | 4 +++-
> drivers/net/dsa/lantiq_gswip.c | 4 +++-
> drivers/net/dsa/mt7530.c | 4 +++-
> drivers/net/dsa/mv88e6xxx/chip.c | 4 +++-
> drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
> include/net/dsa.h | 4 +++-
> net/dsa/port.c | 3 ++-
> 9 files changed, 26 insertions(+), 9 deletions(-)
>
It looks like you missed the felix_phylink_mac_link_up() conversion in
this patch? (which also makes it fail to build, by the way, I'm
supposed the Kbuild robot didn't already jump)
Nonetheless, I've manually added the missing speed, duplex, tx_pause
and rx_pause parameters, and it appears to work as before.
Same for sja1105.
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Regards,
-Vladimir
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-25 21:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 9:37 [PATCH net-next 0/8] rework phylink interface for split MAC/PCS support Russell King - ARM Linux admin
2020-02-25 9:37 ` Russell King - ARM Linux admin
2020-02-25 9:37 ` Russell King - ARM Linux admin
2020-02-25 9:38 ` [PATCH net-next 1/8] net: phylink: propagate resolved link config via mac_link_up() Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 9:38 ` [PATCH net-next 2/8] net: dsa: " Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 21:09 ` Vladimir Oltean [this message]
2020-02-25 21:09 ` Vladimir Oltean
2020-02-25 21:09 ` Vladimir Oltean
2020-02-25 23:23 ` Russell King - ARM Linux admin
2020-02-25 23:23 ` Russell King - ARM Linux admin
2020-02-25 23:23 ` Russell King - ARM Linux admin
2020-02-26 10:39 ` Russell King - ARM Linux admin
2020-02-26 10:39 ` Russell King - ARM Linux admin
2020-02-26 10:39 ` Russell King - ARM Linux admin
2020-02-25 9:38 ` [PATCH net-next 3/8] net: mv88e6xxx: use resolved link config in mac_link_up() Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 9:38 ` Russell King
2020-02-25 9:39 ` [PATCH net-next 4/8] net: axienet: " Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` [PATCH net-next 5/8] net: dpaa2-mac: " Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 16:36 ` Ioana Ciornei
2020-02-25 16:36 ` Ioana Ciornei
2020-02-25 16:36 ` Ioana Ciornei
2020-02-26 10:12 ` Russell King - ARM Linux admin
2020-02-26 10:12 ` Russell King - ARM Linux admin
2020-02-26 10:12 ` Russell King - ARM Linux admin
2020-02-26 15:07 ` Ioana Ciornei
2020-02-26 15:07 ` Ioana Ciornei
2020-02-26 15:07 ` Ioana Ciornei
2020-02-25 9:39 ` [PATCH net-next 6/8] net: macb: " Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` [PATCH net-next 7/8] net: mvneta: " Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` [PATCH net-next 8/8] net: mvpp2: " Russell King
2020-02-25 9:39 ` Russell King
2020-02-25 9:39 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hp8KCqhCasOAGz17k0eRteHVVYK-eANQmn4h443qv=2JQ@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peppe.cavallaro@st.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.