[PATCH net] net: dsa: dsa_bridge_mtu_normalization() can be static

[PATCH net] net: dsa: dsa_bridge_mtu_normalization() can be static

[Vladimir Oltean]

From: kbuild test robot <lkp@intel.com>

This function is not called from any other C file.

Fixes: bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 5390ff541658..e94eb1aac602 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1338,7 +1338,7 @@ static void dsa_hw_port_list_free(struct list_head *hw_port_list)
 }
 
 /* Make the hardware datapath to/from @dev limited to a common MTU */
-void dsa_bridge_mtu_normalization(struct dsa_port *dp)
+static void dsa_bridge_mtu_normalization(struct dsa_port *dp)
 {
 	struct list_head hw_port_list;
 	struct dsa_switch_tree *dst;
-- 
2.17.1

Re: [PATCH net] net: dsa: dsa_bridge_mtu_normalization() can be static

[Vivien Didelot]

On Thu,  2 Apr 2020 13:28:19 +0300, Vladimir Oltean <olteanv@gmail.com> wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> This function is not called from any other C file.
> 
> Fixes: bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")
> Signed-off-by: kbuild test robot <lkp@intel.com>

Did you mean Reported-by? I don't think kbuild test robot signed that.

> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Jason sent a patch already.

Thanks,
Vivien

Re: [PATCH net] net: dsa: dsa_bridge_mtu_normalization() can be static

[Vladimir Oltean]

On Thu, 2 Apr 2020 at 18:47, Vivien Didelot <vivien.didelot@gmail.com> wrote:
>
> On Thu,  2 Apr 2020 13:28:19 +0300, Vladimir Oltean <olteanv@gmail.com> wrote:
> > From: kbuild test robot <lkp@intel.com>
> >
> > This function is not called from any other C file.
> >
> > Fixes: bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")
> > Signed-off-by: kbuild test robot <lkp@intel.com>
>
> Did you mean Reported-by? I don't think kbuild test robot signed that.
>

Yes it did?
https://patchwork.ozlabs.org/patch/1265415/
But the sha1sum of the commit is wrong.

> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Jason sent a patch already.

Yes, I saw too late.
But it looks like even Jason was too late, David already picked up the
kbuild robot's RFC. I wasn't sure he was going to do that since it was
an RFC.

>
> Thanks,
> Vivien

-Vladimir