[Buildroot] [PATCH 1/1] package/crun: needs gcc >= 4.9

[Buildroot] [PATCH 1/1] package/crun: needs gcc >= 4.9

[Fabrice Fontaine]

crun unconditionally uses atomic_bool when libgcrypt is found since
version 1.7.1 and
https://github.com/containers/crun/commit/40f66c0a74b8d918ecc7ae9228dca32a4fd71084
resulting in the following build failure with gcc 4.8 since commit
6987b92da510a8c8b9534a22506850c163d0f035:

src/libcrun/seccomp.c: In function 'calculate_seccomp_checksum':
src/libcrun/seccomp.c:374:3: error: unknown type name 'atomic_bool'
   static atomic_bool initialized = false;
   ^

Fixes:
 - http://autobuild.buildroot.org/results/924806ffd6d83cd6d8226577c3877b0b8ca2722d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/crun/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/crun/Config.in b/package/crun/Config.in
index fa0894e126..45c86f0655 100644
--- a/package/crun/Config.in
+++ b/package/crun/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_CRUN
 	bool "crun"
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
 	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_YAJL # libocispec
 	help
@@ -8,5 +9,6 @@ config BR2_PACKAGE_CRUN
 
 	  https://github.com/containers/crun
 
-comment "crun needs a glibc or musl toolchain"
-	depends on BR2_TOOLCHAIN_USES_UCLIBC
+comment "crun needs a glibc or musl toolchain, gcc >= 4.9"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/crun: needs gcc >= 4.9

[Christian Stewart via buildroot]

Hi Fabrice,

On Sun, Jan 8, 2023 at 11:15 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> crun unconditionally uses atomic_bool when libgcrypt is found since
> version 1.7.1 and
> https://github.com/containers/crun/commit/40f66c0a74b8d918ecc7ae9228dca32a4fd71084
> resulting in the following build failure with gcc 4.8 since commit
> 6987b92da510a8c8b9534a22506850c163d0f035:
>
> src/libcrun/seccomp.c: In function 'calculate_seccomp_checksum':
> src/libcrun/seccomp.c:374:3: error: unknown type name 'atomic_bool'
>    static atomic_bool initialized = false;
>    ^
>
> Fixes:
>  - http://autobuild.buildroot.org/results/924806ffd6d83cd6d8226577c3877b0b8ca2722d

Reviewed-by: Christian Stewart <christian@paral.in>

Thanks!
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/crun: needs gcc >= 4.9

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > crun unconditionally uses atomic_bool when libgcrypt is found since
 > version 1.7.1 and
 > https://github.com/containers/crun/commit/40f66c0a74b8d918ecc7ae9228dca32a4fd71084
 > resulting in the following build failure with gcc 4.8 since commit
 > 6987b92da510a8c8b9534a22506850c163d0f035:

 > src/libcrun/seccomp.c: In function 'calculate_seccomp_checksum':
 > src/libcrun/seccomp.c:374:3: error: unknown type name 'atomic_bool'
 >    static atomic_bool initialized = false;
 >    ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/924806ffd6d83cd6d8226577c3877b0b8ca2722d

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot