All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sna: Fix comment on GCC version check
@ 2013-02-26 14:27 Sedat Dilek
  2013-02-26 14:35 ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Sedat Dilek @ 2013-02-26 14:27 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: Sedat Dilek

The comment was introduced with...

commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
"sna: Fix build on older GCC for cpuid()"

...and is a bit misleading.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 src/sna/sna_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sna/sna_cpu.c b/src/sna/sna_cpu.c
index 9110456..1097ea5 100644
--- a/src/sna/sna_cpu.c
+++ b/src/sna/sna_cpu.c
@@ -31,7 +31,7 @@
 
 #include "sna.h"
 
-#if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */
+#if defined(__GNUC__) && (__GNUC__ >= 4) /* gcc >= v4 */
 
 #include <cpuid.h>
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-26 14:27 [PATCH] sna: Fix comment on GCC version check Sedat Dilek
@ 2013-02-26 14:35 ` Chris Wilson
  2013-02-26 14:44   ` Sedat Dilek
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2013-02-26 14:35 UTC (permalink / raw)
  To: Sedat Dilek; +Cc: intel-gfx

On Tue, Feb 26, 2013 at 03:27:52PM +0100, Sedat Dilek wrote:
> The comment was introduced with...
> 
> commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
> "sna: Fix build on older GCC for cpuid()"
> 
> ...and is a bit misleading.

The comment was a reminder to me as to whether I needed to check
__gnuc_minor__ for 4.4; not duplicating what was already expressed in
the code.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-26 14:35 ` Chris Wilson
@ 2013-02-26 14:44   ` Sedat Dilek
  2013-02-27 17:37     ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Sedat Dilek @ 2013-02-26 14:44 UTC (permalink / raw)
  To: Chris Wilson, Sedat Dilek, intel-gfx

On Tue, Feb 26, 2013 at 3:35 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Feb 26, 2013 at 03:27:52PM +0100, Sedat Dilek wrote:
>> The comment was introduced with...
>>
>> commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
>> "sna: Fix build on older GCC for cpuid()"
>>
>> ...and is a bit misleading.
>
> The comment was a reminder to me as to whether I needed to check
> __gnuc_minor__ for 4.4; not duplicating what was already expressed in
> the code.


#if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */

I wanted to know what the above line means?
Check for gcc-4.4 or check for gcc-v4-compatibility?

- Sedat -

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-26 14:44   ` Sedat Dilek
@ 2013-02-27 17:37     ` Chris Wilson
  2013-02-27 17:43       ` Sedat Dilek
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2013-02-27 17:37 UTC (permalink / raw)
  To: Sedat Dilek; +Cc: intel-gfx

On Tue, Feb 26, 2013 at 03:44:13PM +0100, Sedat Dilek wrote:
> On Tue, Feb 26, 2013 at 3:35 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Tue, Feb 26, 2013 at 03:27:52PM +0100, Sedat Dilek wrote:
> >> The comment was introduced with...
> >>
> >> commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
> >> "sna: Fix build on older GCC for cpuid()"
> >>
> >> ...and is a bit misleading.
> >
> > The comment was a reminder to me as to whether I needed to check
> > __gnuc_minor__ for 4.4; not duplicating what was already expressed in
> > the code.
> 
> 
> #if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */
> 
> I wanted to know what the above line means?
> Check for gcc-4.4 or check for gcc-v4-compatibility?

Finally, found the information I was looking for - took ages to checkout
gcc.git. cpuid.h was first introduced in gcc-4.4

And I'll recant and fixup __cpuid to use __get_cpuid() instead.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-27 17:37     ` Chris Wilson
@ 2013-02-27 17:43       ` Sedat Dilek
  2013-02-27 17:59         ` Sedat Dilek
  0 siblings, 1 reply; 9+ messages in thread
From: Sedat Dilek @ 2013-02-27 17:43 UTC (permalink / raw)
  To: Chris Wilson, Sedat Dilek, intel-gfx

On Wed, Feb 27, 2013 at 6:37 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Feb 26, 2013 at 03:44:13PM +0100, Sedat Dilek wrote:
>> On Tue, Feb 26, 2013 at 3:35 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > On Tue, Feb 26, 2013 at 03:27:52PM +0100, Sedat Dilek wrote:
>> >> The comment was introduced with...
>> >>
>> >> commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
>> >> "sna: Fix build on older GCC for cpuid()"
>> >>
>> >> ...and is a bit misleading.
>> >
>> > The comment was a reminder to me as to whether I needed to check
>> > __gnuc_minor__ for 4.4; not duplicating what was already expressed in
>> > the code.
>>
>>
>> #if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */
>>
>> I wanted to know what the above line means?
>> Check for gcc-4.4 or check for gcc-v4-compatibility?
>
> Finally, found the information I was looking for - took ages to checkout
> gcc.git. cpuid.h was first introduced in gcc-4.4
>
> And I'll recant and fixup __cpuid to use __get_cpuid() instead.

Thanks for taking a look into gcc sources.

Be glad the GNU folk uses Git besides CVS... The subject-line and
changelog from binutils/gcc/etc, is still strange to me.
Cloning is slow, unfortunately. I keep tarballs of all my cloned local
GIT repositories.

- Sedat -

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-27 17:43       ` Sedat Dilek
@ 2013-02-27 17:59         ` Sedat Dilek
  2013-02-27 22:27           ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Sedat Dilek @ 2013-02-27 17:59 UTC (permalink / raw)
  To: Chris Wilson, Sedat Dilek, intel-gfx

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

On Wed, Feb 27, 2013 at 6:43 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Wed, Feb 27, 2013 at 6:37 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> On Tue, Feb 26, 2013 at 03:44:13PM +0100, Sedat Dilek wrote:
>>> On Tue, Feb 26, 2013 at 3:35 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> > On Tue, Feb 26, 2013 at 03:27:52PM +0100, Sedat Dilek wrote:
>>> >> The comment was introduced with...
>>> >>
>>> >> commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
>>> >> "sna: Fix build on older GCC for cpuid()"
>>> >>
>>> >> ...and is a bit misleading.
>>> >
>>> > The comment was a reminder to me as to whether I needed to check
>>> > __gnuc_minor__ for 4.4; not duplicating what was already expressed in
>>> > the code.
>>>
>>>
>>> #if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */
>>>
>>> I wanted to know what the above line means?
>>> Check for gcc-4.4 or check for gcc-v4-compatibility?
>>
>> Finally, found the information I was looking for - took ages to checkout
>> gcc.git. cpuid.h was first introduced in gcc-4.4
>>
>> And I'll recant and fixup __cpuid to use __get_cpuid() instead.
>
> Thanks for taking a look into gcc sources.
>
> Be glad the GNU folk uses Git besides CVS... The subject-line and
> changelog from binutils/gcc/etc, is still strange to me.
> Cloning is slow, unfortunately. I keep tarballs of all my cloned local
> GIT repositories.
>
> - Sedat -
>
>> -Chris
>>
>> --
>> Chris Wilson, Intel Open Source Technology Centre

/o\ ... Latest GIT is like ice-cream.

How can I compare a gcc-4.6 and clang-3.2 compiled binaries?
Thinking of miscompiling and/or benchmarking.

- Sedat -

[-- Attachment #2: build-and-install-log_XF86-Video-Intel-v2-21-3+git20130227-f08ad3f.txt --]
[-- Type: text/plain, Size: 43817 bytes --]

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal ${ACLOCAL_FLAGS}
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --install --copy
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `.'.
libtoolize: copying file `./config.guess'
libtoolize: copying file `./config.sub'
libtoolize: copying file `./install-sh'
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: running: /usr/bin/autoconf
autoreconf: running: /usr/bin/autoheader
autoreconf: running: automake --add-missing --copy --no-force
configure.ac:34: installing `./missing'
src/Makefile.am: installing `./depcomp'
autoreconf: Leaving directory `.'
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking dependency style of clang... gcc3
checking for clang option to accept ISO C99... none needed
checking how to run the C preprocessor... clang-cpp
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking whether __clang__ is declared... yes
checking whether __INTEL_COMPILER is declared... no
checking whether __SUNPRO_C is declared... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for a sed that does not truncate output... /bin/sed
checking if clang supports -Werror=unknown-warning-option... yes
checking if clang supports -Werror=unused-command-line-argument... yes
checking if clang supports-Wall... yes
checking if clang supports-Wpointer-arith... yes
checking if clang supports-Wmissing-declarations... yes
checking if clang supports-Wformat=2... yes
checking if clang supports-Wstrict-prototypes... yes
checking if clang supports-Wmissing-prototypes... yes
checking if clang supports-Wnested-externs... yes
checking if clang supports-Wbad-function-cast... yes
checking if clang supports-Wold-style-definition... yes
checking if clang supports-Wdeclaration-after-statement... yes
checking if clang supports-Wunused... yes
checking if clang supports-Wuninitialized... yes
checking if clang supports-Wshadow... yes
checking if clang supports-Wcast-qual... yes
checking if clang supports-Wmissing-noreturn... yes
checking if clang supports-Wmissing-format-attribute... yes
checking if clang supports-Wredundant-decls... yes
checking if clang supports-Werror=implicit... yes
checking if clang supports-Werror=nonnull... yes
checking if clang supports-Werror=init-self... yes
checking if clang supports-Werror=main... yes
checking if clang supports-Werror=missing-braces... yes
checking if clang supports-Werror=sequence-point... yes
checking if clang supports-Werror=return-type... yes
checking if clang supports-Werror=trigraphs... yes
checking if clang supports-Werror=array-bounds... yes
checking if clang supports-Werror=write-strings... yes
checking if clang supports-Werror=address... yes
checking if clang supports-Werror=int-to-pointer-cast... yes
checking if clang supports-Werror=pointer-to-int-cast... yes
checking if clang supports-pedantic... yes
checking if clang supports-Werror... yes
checking if clang supports-Werror=attributes... yes
checking whether make supports nested variables... yes
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /bin/sed
checking for fgrep... /bin/grep -F
checking for ld used by clang... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from clang object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if clang supports -fno-rtti -fno-exceptions... yes
checking for clang option to produce PIC... -fPIC -DPIC
checking if clang PIC flag -fPIC -DPIC works... yes
checking if clang static flag -static works... yes
checking if clang supports -c -o file.o... yes
checking if clang supports -c -o file.o... (cached) yes
checking whether the clang linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for native atomic primitives... Intel
checking for UDEV... yes
checking for X11... yes
checking sys/sysinfo.h usability... yes
checking sys/sysinfo.h presence... yes
checking for sys/sysinfo.h... yes
checking whether to include SNA support... yes
checking whether to include UXA support... checking for DRMINTEL... yes
yes
checking whether to include GLAMOR support... no
checking for XORG... yes
checking xaa.h usability... yes
checking xaa.h presence... no
configure: WARNING: xaa.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: xaa.h: proceeding with the compiler's result
checking for xaa.h... yes
checking whether to include XAA support... yes
checking for dgaproc.h... yes
checking whether to include DGA support... yes
checking which acceleration method to use by default... uxa
checking if RANDR is defined... yes
checking if RENDER is defined... yes
checking if XF86DRI is defined... yes
checking if DPMSExtension is defined... yes
checking for DRM... yes
checking for DRI... no
checking for DRI2... yes
checking for PCIACCESS... yes
checking for dri.h... no
checking for sarea.h... yes
checking for dristruct.h... no
checking whether to include DRI support... no
checking for dri2.h... yes
checking whether to include DRI2 support... yes
checking for XVMCLIB... no
checking for XCB... no
checking whether to include XvMC support... no
configure: creating ./config.status
config.status: creating Makefile
config.status: creating uxa/Makefile
config.status: creating src/Makefile
config.status: creating src/xvmc/Makefile
config.status: creating src/xvmc/shader/Makefile
config.status: creating src/xvmc/shader/mc/Makefile
config.status: creating src/xvmc/shader/vld/Makefile
config.status: creating src/legacy/Makefile
config.status: creating src/legacy/i810/Makefile
config.status: creating src/legacy/i810/xvmc/Makefile
config.status: creating src/sna/Makefile
config.status: creating src/sna/brw/Makefile
config.status: creating src/sna/fb/Makefile
config.status: creating man/Makefile
config.status: creating src/render_program/Makefile
config.status: creating test/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
make  all-recursive
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
Making all in man
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
  GEN    intel.4
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
Making all in uxa
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
  CC     uxa.lo
  CC     uxa-render.lo
  CC     uxa-glyphs.lo
  CC     uxa-accel.lo
uxa-render.c:930:9: warning: implicit conversion from enumeration type 'enum _PictFormatShort' to different enumeration type 'pixman_format_code_t' [-Wenum-conversion]
                                    PICT_a8r8g8b8,
                                    ^~~~~~~~~~~~~
uxa-render.c:944:9: warning: implicit conversion from enumeration type 'enum _PictFormatShort' to different enumeration type 'pixman_format_code_t' [-Wenum-conversion]
                                    PICT_a8,
                                    ^~~~~~~
uxa-accel.c:959:10: warning: variable 'region' is uninitialized when used here [-Wuninitialized]
                return region;
                       ^~~~~~
uxa-accel.c:947:19: note: initialize the variable 'region' to silence this warning
                RegionPtr region;
                                ^
                                 = NULL
  CC     uxa-unaccel.lo
1 warning generated.
2 warnings generated.
  CCLD   libuxa.la
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
Making all in src
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
Making all in xvmc
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
Making all in shader
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
Making all in mc
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make  all-am
make[6]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[6]: Nothing to be done for `all-am'.
make[6]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
Making all in vld
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make  all-am
make[6]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[6]: Nothing to be done for `all-am'.
make[6]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[5]: Nothing to be done for `all-am'.
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
Making all in render_program
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make  all-am
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
Making all in legacy
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
Making all in i810
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
Making all in xvmc
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
make[5]: Nothing to be done for `all'.
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
  CC     i810_accel.lo
  CC     i810_cursor.lo
  CC     i810_driver.lo
  CC     i810_memory.lo
  CC     i810_video.lo
  CC     i810_wmark.lo
  CC     i810_xaa.lo
  CC     i810_dga.lo
  CCLD   liblegacy-i810.la
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
  CCLD   liblegacy.la
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
Making all in sna
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
Making all in brw
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
  CC     brw_disasm.lo
  CC     brw_eu_emit.lo
  CC     brw_eu.lo
  CC     brw_sf.lo
  CC     brw_wm.lo
  CC     brw_test.o
  CC     brw_test_gen4.o
  CC     brw_test_gen5.o
  CC     brw_test_gen6.o
  CC     brw_test_gen7.o
  CCLD   libbrw.la
  CCLD   brw_test
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
Making all in fb
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
  CC     libfb_la-fbarc.lo
  CC     libfb_la-fbbitmap.lo
  CC     libfb_la-fbblt.lo
  CC     libfb_la-fbbltone.lo
  CC     libfb_la-fbclip.lo
  CC     libfb_la-fbcopy.lo
  CC     libfb_la-fbfill.lo
  CC     libfb_la-fbgc.lo
  CC     libfb_la-fbglyph.lo
  CC     libfb_la-fbimage.lo
  CC     libfb_la-fbline.lo
  CC     libfb_la-fbpict.lo
  CC     libfb_la-fbpoint.lo
  CC     libfb_la-fbpush.lo
  CC     libfb_la-fbseg.lo
  CC     libfb_la-fbspan.lo
  CC     libfb_la-fbstipple.lo
  CC     libfb_la-fbtile.lo
  CC     libfb_la-fbutil.lo
  CCLD   libfb.la
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
  CC     blt.lo
  CC     kgem.lo
  CC     sna_accel.lo
  CC     sna_blt.lo
  CC     sna_composite.lo
  CC     sna_cpu.lo
kgem.c:1676:22: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(bo, &kgem->snoop, list) {
                            ^~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:1661:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo, *first = NULL;
                          ^
                           = NULL
kgem.c:1866:27: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry_safe(bo, next, &kgem->flushing, request) {
                                 ^~
/usr/include/xorg/list.h:309:45: note: expanded from macro 'list_for_each_entry_safe'
    for (pos = __container_of((head)->next, pos, member),               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:1863:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo, *next;
                          ^
                           = NULL
kgem.c:2070:27: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry_safe(bo, next, &rq->buffers, request) {
                                 ^~
/usr/include/xorg/list.h:309:45: note: expanded from macro 'list_for_each_entry_safe'
    for (pos = __container_of((head)->next, pos, member),               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:2068:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo, *next;
                          ^
                           = NULL
kgem.c:2151:27: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry_safe(bo, next, &kgem->batch_buffers, base.list) {
                                 ^~
/usr/include/xorg/list.h:309:45: note: expanded from macro 'list_for_each_entry_safe'
    for (pos = __container_of((head)->next, pos, member),               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:2149:24: note: initialize the variable 'bo' to silence this warning
        struct kgem_buffer *bo, *next;
                              ^
                               = NULL
kgem.c:3048:23: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
                list_for_each_entry(bo, cache, vma) {
                                    ^~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:2958:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo, *first = NULL;
                          ^
                           = NULL
kgem.c:3542:31: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
                list_for_each_entry_reverse(bo, &kgem->scanout, list) {
                                            ^~
../../src/intel_list.h:396:45: note: expanded from macro 'list_for_each_entry_reverse'
    for (pos = __container_of((head)->prev, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:3516:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo;
                          ^
                           = NULL
kgem.c:4831:22: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(bo, buffers, request) {
                            ^~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:4829:20: note: initialize the variable 'bo' to silence this warning
        struct kgem_bo *bo;
                          ^
                           = NULL
kgem.c:5081:22: warning: variable 'bo' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(bo, &kgem->batch_buffers, base.list) {
                            ^~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
kgem.c:5067:24: note: initialize the variable 'bo' to silence this warning
        struct kgem_buffer *bo;
                              ^
                               = NULL
  CC     sna_damage.lo
8 warnings generated.
  CC     sna_display.lo
Recording git-tree used for compilation: 2.21.3-45-gf08ad3f
  CC     sna_glyphs.lo
sna_damage.c:421:22: warning: variable 'iter' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(iter, &damage->embedded_box.list, list)
                            ^~~~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
sna_damage.c:413:29: note: initialize the variable 'iter' to silence this warning
        struct sna_damage_box *iter;
                                   ^
                                    = NULL
sna_damage.c:1681:22: warning: variable 'iter' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(iter, &damage->embedded_box.list, list)
                            ^~~~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
sna_damage.c:1674:29: note: initialize the variable 'iter' to silence this warning
        struct sna_damage_box *iter;
                                   ^
                                    = NULL
2 warnings generated.
  CC     sna_gradient.lo
  CC     sna_io.lo
  CC     sna_render.lo
  CC     sna_stream.lo
  CC     sna_trapezoids.lo
sna_render.c:1603:43: warning: implicit conversion from enumeration type 'PictFormatShort' (aka 'enum _PictFormatShort') to different enumeration type 'pixman_format_code_t' [-Wenum-conversion]
                dst = pixman_image_create_bits(picture->format, w, h, NULL, 0);
                      ~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~^~~~~~
sna_render.c:1790:43: warning: implicit conversion from enumeration type 'PictFormatShort' (aka 'enum _PictFormatShort') to different enumeration type 'pixman_format_code_t' [-Wenum-conversion]
                src = pixman_image_create_bits(picture->format,
                      ~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~^~~~~~
  CC     sna_tiling.lo
  CC     sna_transform.lo
2 warnings generated.
  CC     sna_threads.lo
sna_trapezoids.c:6877:44: warning: implicit conversion from enumeration type 'PictFormatShort' (aka 'enum _PictFormatShort') to different enumeration type 'pixman_format_code_t' [-Wenum-conversion]
        image = pixman_image_create_bits(picture->format, width, height,
                ~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~^~~~~~
  CC     sna_vertex.lo
  CC     sna_video.lo
  CC     sna_video_overlay.lo
1 warning generated.
  CC     sna_video_sprite.lo
  CC     sna_video_textured.lo
  CC     gen2_render.lo
  CC     gen3_render.lo
  CC     gen4_source.lo
  CC     gen4_render.lo
  CC     gen4_vertex.lo
  CC     gen5_render.lo
  CC     gen6_render.lo
  CC     gen7_render.lo
  CC     sna_dri.lo
  CC     sna_driver.lo
sna_dri.c:2018:6: warning: variable 'pipe' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (get_private(front)->pixmap != get_drawable_pixmap(draw))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sna_dri.c:2150:42: note: uninitialized use occurs here
        DRI2SwapComplete(client, draw, 0, 0, 0, pipe, func, data);
                                                ^~~~
sna_dri.c:2018:2: note: remove the 'if' if its condition is always false
        if (get_private(front)->pixmap != get_drawable_pixmap(draw))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sna_dri.c:1992:10: note: initialize the variable 'pipe' to silence this warning
        int pipe;
                ^
                 = 0
1 warning generated.
  CCLD   libsna.la
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
  CC     intel_options.lo
  CC     intel_module.lo
  CC     intel_batchbuffer.lo
  CC     intel_display.lo
  CC     intel_driver.lo
intel_module.c:350:16: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types]
        scrn->chipset = name;
                      ^ ~~~~
intel_module.c:363:6: warning: passing 'const SymTabRec [86]' to parameter of type 'SymTabPtr' (aka 'struct _SymTabRec *') discards qualifiers [-Wincompatible-pointer-types]
                          intel_chipsets);
                          ^~~~~~~~~~~~~~
/usr/include/xorg/xf86.h:240:20: note: passing argument to parameter 'chips' here
                       SymTabPtr chips);
                                 ^
2 warnings generated.
  CC     intel_memory.lo
intel_batchbuffer.c:146:22: warning: variable 'priv' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(priv, &intel->batch_pixmaps, batch)
                            ^~~~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
intel_batchbuffer.c:144:27: note: initialize the variable 'priv' to silence this warning
        struct intel_pixmap *priv;
                                 ^
                                  = NULL
1 warning generated.
  CC     intel_uxa.lo
intel_display.c:1698:22: warning: variable 'iterator' is uninitialized when used here [-Wuninitialized]
        list_for_each_entry(iterator, &mode->outputs, link)
                            ^~~~~~~~
/usr/include/xorg/list.h:297:45: note: expanded from macro 'list_for_each_entry'
    for (pos = __container_of((head)->next, pos, member);               \
                                            ^
/usr/include/xorg/list.h:278:20: note: expanded from macro '__container_of'
             - ((char *)&(sample)->member - (char *)(sample)))
                          ^
intel_display.c:1695:31: note: initialize the variable 'iterator' to silence this warning
        struct intel_output *iterator;
                                     ^
                                      = NULL
1 warning generated.
  CC     intel_video.lo
  CC     i830_3d.lo
  CC     i830_render.lo
  CC     i915_3d.lo
  CC     i915_render.lo
  CC     i915_video.lo
  CC     i965_3d.lo
  CC     i965_video.lo
  CC     i965_render.lo
  CC     intel_dri.lo
intel_dri.c:865:28: warning: declaration shadows a local variable [-Wshadow]
                I830DRI2BufferPrivatePtr priv;
                                         ^
intel_dri.c:843:27: note: previous declaration is here
        I830DRI2BufferPrivatePtr priv = info->back->driverPrivate;
                                 ^
intel_dri.c:1532:6: warning: declaration shadows a variable in the global scope [-Wshadow]
        int dri2_major = 1;
            ^
/usr/include/xorg/dri2.h:49:14: note: previous declaration is here
extern CARD8 dri2_major; /* version of DRI2 supported by DDX */
             ^
intel_dri.c:1533:6: warning: declaration shadows a variable in the global scope [-Wshadow]
        int dri2_minor = 0;
            ^
/usr/include/xorg/dri2.h:50:14: note: previous declaration is here
extern CARD8 dri2_minor;
             ^
3 warnings generated.
  CCLD   intel_drv.la
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
Making all in test
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
  CC     test_display.lo
  CC     test_image.lo
  CC     test_render.lo
  CC     test_log.lo
test_log.c:12:19: warning: format string is not a string literal [-Wformat-nonliteral]
        vfprintf(stderr, fmt, va);
                         ^~~
test_log.c:8:1: warning: function 'die' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
{
^
2 warnings generated.
  CC     dri2.lo
  CC     lowlevel-blt-bench.o
  CCLD   libtest.la
  CCLD   lowlevel-blt-bench
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
Making install in man
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
make[2]: Nothing to be done for `install-exec-am'.
test -z "/opt/xorg/share/man/man4" || /bin/mkdir -p "/opt/xorg/share/man/man4"
 /usr/bin/install -c -m 644 intel.4 '/opt/xorg/share/man/man4'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/man'
Making install in uxa
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/uxa'
Making install in src
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
Making install in xvmc
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
Making install in shader
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
Making install in mc
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make  install-am
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[6]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[6]: Nothing to be done for `install-exec-am'.
make[6]: Nothing to be done for `install-data-am'.
make[6]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/mc'
Making install in vld
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make  install-am
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[6]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[6]: Nothing to be done for `install-exec-am'.
make[6]: Nothing to be done for `install-data-am'.
make[6]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader/vld'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[5]: Nothing to be done for `install-exec-am'.
make[5]: Nothing to be done for `install-data-am'.
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc/shader'
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
test -z "/opt/xorg/lib" || /bin/mkdir -p "/opt/xorg/lib"
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/xvmc'
Making install in render_program
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make  install-am
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/render_program'
Making install in legacy
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
Making install in i810
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
Making install in xvmc
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
test -z "/opt/xorg/lib" || /bin/mkdir -p "/opt/xorg/lib"
make[5]: Nothing to be done for `install-data-am'.
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810/xvmc'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[5]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[5]: Nothing to be done for `install-exec-am'.
make[5]: Nothing to be done for `install-data-am'.
make[5]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy/i810'
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/legacy'
Making install in sna
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
Making install in brw
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/brw'
Making install in fb
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna/fb'
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[4]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src/sna'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
make[3]: Nothing to be done for `install-exec-am'.
test -z "/opt/xorg/lib/xorg/modules/drivers" || /bin/mkdir -p "/opt/xorg/lib/xorg/modules/drivers"
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   intel_drv.la '/opt/xorg/lib/xorg/modules/drivers'
libtool: install: /usr/bin/install -c .libs/intel_drv.so /opt/xorg/lib/xorg/modules/drivers/intel_drv.so
libtool: install: /usr/bin/install -c .libs/intel_drv.lai /opt/xorg/lib/xorg/modules/drivers/intel_drv.la
libtool: finish: PATH="/opt/llvm/bin:/opt/llvm/bin:/opt/xorg/bin:/opt/llvm/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/sbin" ldconfig -n /opt/xorg/lib/xorg/modules/drivers
----------------------------------------------------------------------
Libraries have been installed in:
   /opt/xorg/lib/xorg/modules/drivers

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
     during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
     during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
make[3]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src'
Making install in test
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/test'
make[1]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
make[2]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
make[1]: Leaving directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git'
	libdrm_intel.so.1 => /opt/xorg/lib/libdrm_intel.so.1 (0x00007fca1d3a3000)
	libdrm.so.2 => /opt/xorg/lib/libdrm.so.2 (0x00007fca1d192000)

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-27 17:59         ` Sedat Dilek
@ 2013-02-27 22:27           ` Chris Wilson
  2013-02-27 23:33             ` Sedat Dilek
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2013-02-27 22:27 UTC (permalink / raw)
  To: Sedat Dilek; +Cc: intel-gfx

On Wed, Feb 27, 2013 at 06:59:58PM +0100, Sedat Dilek wrote:
> How can I compare a gcc-4.6 and clang-3.2 compiled binaries?
> Thinking of miscompiling and/or benchmarking.

The real test is whether you can measure a difference in a benchmark
like cairo-perf-trace. There are a few traces that are sensitive to CPU
optimisations.

To maximise the likelihood of spotting a difference though you will want
to use microbenchmarks like x11perf, x11perf -aa10text would be a prime
candidate.

The last set of errors reported when compiled with Clang were during
trapezoid rasterisation triggered whilst using normal Gtk+ and Qt apps.
They have a tendency to hit all the corner cases.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] sna: Fix comment on GCC version check
  2013-02-27 22:27           ` Chris Wilson
@ 2013-02-27 23:33             ` Sedat Dilek
  0 siblings, 0 replies; 9+ messages in thread
From: Sedat Dilek @ 2013-02-27 23:33 UTC (permalink / raw)
  To: Chris Wilson, Sedat Dilek, intel-gfx

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Wed, Feb 27, 2013 at 11:27 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Feb 27, 2013 at 06:59:58PM +0100, Sedat Dilek wrote:
>> How can I compare a gcc-4.6 and clang-3.2 compiled binaries?
>> Thinking of miscompiling and/or benchmarking.
>
> The real test is whether you can measure a difference in a benchmark
> like cairo-perf-trace. There are a few traces that are sensitive to CPU
> optimisations.
>
> To maximise the likelihood of spotting a difference though you will want
> to use microbenchmarks like x11perf, x11perf -aa10text would be a prime
> candidate.
>
> The last set of errors reported when compiled with Clang were during
> trapezoid rasterisation triggered whilst using normal Gtk+ and Qt apps.
> They have a tendency to hit all the corner cases.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

Attached 'x11perf -aa10text' with clang-3.2 and gcc-4.6.

- Sedat .

[-- Attachment #2: x11perf-aa10text_clang-3-2.txt --]
[-- Type: text/plain, Size: 719 bytes --]

$ x11perf -aa10text
x11perf - X11 performance program, version 1.2
The X.Org Foundation server version 11103000 on :0
from fambox
Thu Feb 28 00:25:23 2013

Sync time adjustment is 0.0446 msecs.

6400000 reps @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)
6400000 reps @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)
6400000 reps @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)
6400000 reps @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)
6400000 reps @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)
32000000 trep @   0.0008 msec (1240000.0/sec): Char in 80-char aa line (Charter 10)


-dileks // 28-Feb-2013

[-- Attachment #3: x11perf-aa10text_gcc-4-6.txt --]
[-- Type: text/plain, Size: 724 bytes --]

$ x11perf -aa10text
x11perf - X11 performance program, version 1.2
The X.Org Foundation server version 11103000 on :1
from fambox
Thu Feb 28 00:29:02 2013

Sync time adjustment is 0.0390 msecs.

16000000 reps @   0.0005 msec (2110000.0/sec): Char in 80-char aa line (Charter 10)
16000000 reps @   0.0005 msec (2120000.0/sec): Char in 80-char aa line (Charter 10)
16000000 reps @   0.0005 msec (2110000.0/sec): Char in 80-char aa line (Charter 10)
16000000 reps @   0.0005 msec (2010000.0/sec): Char in 80-char aa line (Charter 10)
16000000 reps @   0.0005 msec (2050000.0/sec): Char in 80-char aa line (Charter 10)
80000000 trep @   0.0005 msec (2080000.0/sec): Char in 80-char aa line (Charter 10)


-dileks // 28-Feb-2013

[-- Attachment #4: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] sna: Fix comment on GCC version check
@ 2013-02-26 14:33 Sedat Dilek
  0 siblings, 0 replies; 9+ messages in thread
From: Sedat Dilek @ 2013-02-26 14:33 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: Sedat Dilek

The comment was introduced with...

commit 528dbf9ebb2688f476ef283be59d0f2232159dcb
"sna: Fix build on older GCC for cpuid()"

...and is a bit misleading.

[ v2: Point to compatibility with gcc-v4 (e.g. clang) ]

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 src/sna/sna_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sna/sna_cpu.c b/src/sna/sna_cpu.c
index 9110456..3ee4be0 100644
--- a/src/sna/sna_cpu.c
+++ b/src/sna/sna_cpu.c
@@ -31,7 +31,7 @@
 
 #include "sna.h"
 
-#if defined(__GNUC__) && (__GNUC__ >= 4) /* 4.4 */
+#if defined(__GNUC__) && (__GNUC__ >= 4) /* compiler compatible with gcc-v4 */
 
 #include <cpuid.h>
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-02-27 23:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 14:27 [PATCH] sna: Fix comment on GCC version check Sedat Dilek
2013-02-26 14:35 ` Chris Wilson
2013-02-26 14:44   ` Sedat Dilek
2013-02-27 17:37     ` Chris Wilson
2013-02-27 17:43       ` Sedat Dilek
2013-02-27 17:59         ` Sedat Dilek
2013-02-27 22:27           ` Chris Wilson
2013-02-27 23:33             ` Sedat Dilek
2013-02-26 14:33 Sedat Dilek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.