Re: [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default

Re: [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default

[Jérémie Galarneau]

[-- Attachment #1.1: Type: text/plain, Size: 1147 bytes --]

Merged in master, 2.6 and 2.5.

Thanks!
Jérémie

On Tue, Apr 28, 2015 at 10:16 AM, Mathieu Desnoyers <
mathieu.desnoyers@efficios.com> wrote:

> On busy systems, it's possible to spuriously hit the default 3 seconds
> timeout for UST registration to sessiond, thus causing tests to be flaky
> on those systems.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
>  tests/utils/utils.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh
> index c3d8bd4..5f86ece 100644
> --- a/tests/utils/utils.sh
> +++ b/tests/utils/utils.sh
> @@ -27,6 +27,11 @@ KERNEL_MAJOR_VERSION=2
>  KERNEL_MINOR_VERSION=6
>  KERNEL_PATCHLEVEL_VERSION=27
>
> +# We set the default UST register timeout to "wait forever", so that
> +# basic tests don't have to worry about hitting timeouts on busy
> +# systems. Specialized tests should test those corner-cases.
> +export LTTNG_UST_REGISTER_TIMEOUT=-1
> +
>  source $TESTDIR/utils/tap/tap.sh
>
>  function print_ok ()
> --
> 2.1.4
>
>


-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

[-- Attachment #1.2: Type: text/html, Size: 1796 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[PATCH lttng-tools] Fix: set UST register timeout to -1 as test default

[Mathieu Desnoyers]

On busy systems, it's possible to spuriously hit the default 3 seconds
timeout for UST registration to sessiond, thus causing tests to be flaky
on those systems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 tests/utils/utils.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh
index c3d8bd4..5f86ece 100644
--- a/tests/utils/utils.sh
+++ b/tests/utils/utils.sh
@@ -27,6 +27,11 @@ KERNEL_MAJOR_VERSION=2
 KERNEL_MINOR_VERSION=6
 KERNEL_PATCHLEVEL_VERSION=27
 
+# We set the default UST register timeout to "wait forever", so that
+# basic tests don't have to worry about hitting timeouts on busy
+# systems. Specialized tests should test those corner-cases.
+export LTTNG_UST_REGISTER_TIMEOUT=-1
+
 source $TESTDIR/utils/tap/tap.sh
 
 function print_ok ()
-- 
2.1.4